- 16 Oct, 2018 40 commits
-
-
Hector Carmona authored
Bug: 889222 Change-Id: I666bb92178d2e5236143656f9b96180df8fd133c Reviewed-on: https://chromium-review.googlesource.com/c/1266202 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#599834}
-
Ted Meyer authored
Simply return an empty buffer and log an error. Bug: 894941 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I02a70afb3f326c1a9a8b845f7bc8d1aa84cb5dad Reviewed-on: https://chromium-review.googlesource.com/c/1281692 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#599833}
-
Fredrik Söderquist authored
The children/leaves (LayoutSVGShape et al) will handle this. Cf. LayoutBox::HitTestChildren. Move the code to SVGLayoutSupport::HitTestChildren, and share that between the two users. Change-Id: Ibad76d35d90b2738cc3b840e0762147ef5098b4d Reviewed-on: https://chromium-review.googlesource.com/c/1278401Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#599832}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c064d0b121db..be7450b6c635 git log c064d0b121db..be7450b6c635 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 brianosman@google.com Revert "Preserve pixel config in makeColorSpace of GPU backed images" 2018-10-15 brianosman@google.com Revert "Fix bug with makeColorSpace of GPU images with non-renderable configs" 2018-10-15 ethannicholas@google.com Revert "converted AARectEffect to new FP system" 2018-10-15 brianosman@google.com Add documentation to SkRGBA4f 2018-10-15 brianosman@google.com Fix bug with makeColorSpace of GPU images with non-renderable configs 2018-10-15 reed@google.com remove unused isABitmap code 2018-10-15 brianosman@google.com Revert "Revert "Use SkImage to manage mip map cache purging, not Bitmap/PixelRef"" 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms bdafec6a06cd..33ca7b4f7334 (1 commits) 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 bsalomon@google.com Make GrTextureOp disable filtering/aa in more cases. 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms d27291c0eba6..bdafec6a06cd (1 commits) 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 71e256cae02a..767b41b1a841 (1 commits) 2018-10-15 mtklein@google.com another NVPR-only op 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms d26444f2999e..d27291c0eba6 (1 commits) 2018-10-15 ethannicholas@google.com fixed Metal release build 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 79b914075cc5..bbd532d164f0 (1 commits) 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 herb@google.com Change 0 extraSize allocation behavior for SkArenaAlloc 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b655b88172fa..d26444f2999e (1 commits) 2018-10-15 brianosman@google.com Preserve pixel config in makeColorSpace of GPU backed images 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 9369e44523c7..b655b88172fa (1 commits) Created with: gclient setdep -r src/third_party/skia@be7450b6c635 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: Id0e8723f9035a363c68aaa431f3920ab12095da2 Reviewed-on: https://chromium-review.googlesource.com/c/1281866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599831}
-
Christian Biesinger authored
This is required before (re)landing a Flexbox change (bug 596743 / https://chromium-review.googlesource.com/c/chromium/src/+/1269235) This fixes the previously found issues in the wallpaper manager and the OOBE UI. This changes more than necessary, but this is easier and should not be harmful. Bug: 890100, 891988, 892757 Change-Id: I745a22fadabd182d06d6b4c67b428d495c48bae4 Reviewed-on: https://chromium-review.googlesource.com/c/1281726Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#599830}
-
John Z Wu authored
imports should come after the header guards. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2644a6978cdaf2019e2ad78f990c6c2e0d455f1a Reviewed-on: https://chromium-review.googlesource.com/c/1282387 Commit-Queue: John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#599829}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I70c6f29a95265d3554dd938c00a69a54d1dd5729 Reviewed-on: https://chromium-review.googlesource.com/c/1272420Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599828}
-
Patrick Monette authored
This is meant to make the code easier to read by making ownership more obvious and standardize a little bit the different functions that implement the various dialog types. Also will facilitate a possible transition to the IFileDialog interface This CL should not change the behavior of the dialogs. Bug: 73098,884075 Change-Id: I0d2f5cc02e1d08ab3f54385fb166bc34ae1f5b53 Reviewed-on: https://chromium-review.googlesource.com/c/1249911Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#599827}
-
Weidong Guo authored
Background: After switching to another account, the item list for folder gets destructed, but |items_grid_view_| still has stale pointer to the object. When opening a folder, AppsGridView::SetItemList() will try to remove observer from the stale object, thus causing the crash. Changes: Notify observers when the folder item will be deleted. Bug: 891430 Change-Id: Id2957b594022321feaf6ee3cf402af318ddf169a Reviewed-on: https://chromium-review.googlesource.com/c/1282033Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#599826}
-
Noel Gordon authored
CL:1237801 removed this start-up message, but it was being used in the ui/views/select_file_dialog_extension_browsertest.cc tests. These file extension dialog browser tests didn't complain about the message being removed because the they're DISABLED on Chrome OS ¯\(ツ)/¯ We should get those test running again, which will be the subject of a of a new testing bug. For now, recover the 'ready' start-up message. Bug: 453634, 887792 Change-Id: I69b5118f9ebab6d7ee2ac2285ac714b223a437a4 Reviewed-on: https://chromium-review.googlesource.com/c/1282482Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599825}
-
Hirokazu Honda authored
This reverts commit eb0d6e13. Reason for revert: This CL causes a crash on AMD device, b/117398307 Original change's description: > Use ARGB8888 for a dummy buffer for protected content playbkack on ARC++ > > We have specified R8 format for a dummy buffer for protected content playback > on ARC++. > R8 format is not supported on exynos device. It leads crash on the devices. > ARGB8888 should be used instead, which is widely supported on all Chrome OS > device. > > BUG=chromium:787660, chromium:887658 > TEST=No crash on peach_pit and Protected content playback on veyron_minnie and eve > > Change-Id: Ia550277ad30a0e0fd814106a1610b59a1a86bb03 > Reviewed-on: https://chromium-review.googlesource.com/1242564 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Pawel Osciak <posciak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593842} TBR=posciak@chromium.org,gurchetansingh@chromium.org,hiroh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:787660, chromium:887658 Change-Id: I7cc4e8607b0dd267f73a2f32879abae74f9fa24e Reviewed-on: https://chromium-review.googlesource.com/c/1282505Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599824}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2f727917ac25..7d7bbc3b530f git log 2f727917ac25..7d7bbc3b530f --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl upload: delete no longer supported flags. Created with: gclient setdep -r src/third_party/depot_tools@7d7bbc3b530f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408 TBR=agable@chromium.org Change-Id: If4f421e036ff5a4a81d8b95ecbaab9df5e016a16 Reviewed-on: https://chromium-review.googlesource.com/c/1281842Reviewed-by:
-
Tetsui Ohkubo authored
This CL implements TopCornerBorder hack for NewMessageListView. For the detail of the hack, please refer https://crrev.com/c/1161710 . NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: I24ad795fe118c21ef40be6b4ecc2f8e4a5f85101 Reviewed-on: https://chromium-review.googlesource.com/c/1278068 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#599822}
-
Andrew Grieve authored
The non-full reports capture about the same info and load much faster. We can always switch them back, but thought it's worth trying them for a while to see if there are any drawbacks. Also adds a note about opening the viewer directly for uploading files. Results of this commit are already pushed to https://storage.googleapis.com/chrome-supersize/index.html Bug: 880671 Change-Id: I79f1b2298658cde0564c5976f47382e930f7196a Reviewed-on: https://chromium-review.googlesource.com/c/1281174 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599821}
-
Jun Mukai authored
This is the final phase of tab-dragging with touch on Mash. This makes several changes to use the result of the previous phases and achieve tab-dragging with touch on Mash. BUG=867074 TEST=manually Change-Id: I53239efbdf567754d3e9322b334d0a4e6751fa52 Reviewed-on: https://chromium-review.googlesource.com/c/1247034 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Currently to use GetState we have to create a RunLoop, call GetState with a callback that saves the result in a class variable, run the loop and then access the class variable to get the result. This CL attemps to simplify this by wrapping GetState into a function that waits for the call to respond and returns the result directly. Bug: 870192 Change-Id: I9d8d2dfb654443f99d56fe6e676efe9bfb8d0717 Reviewed-on: https://chromium-review.googlesource.com/c/1278464 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599819}
-
Andrew Grieve authored
This file does not actually exist for stable & beta channels. Change-Id: I0885a565933b7457c77c5c43eaf218175cbb04ad Reviewed-on: https://chromium-review.googlesource.com/c/1281282Reviewed-by:
-
Khushal authored
Currently repaint only reports smoothness metrics so the data for thread time measurements is missed. Switch it to use rendering measurements, already used by rendering_ct, which includes both smoothness and thread times numbers. R=rmistry@chromium.org Change-Id: Ia39077827d9cda9a8840b0f85584f956edbcd649 Reviewed-on: https://chromium-review.googlesource.com/c/1281283Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#599817}
-
Tsuyoshi Horo authored
After crrev.com/c/1272419, all unittests which trigers navigation requires MockRenderProcessHost::url_loader_factory_ when ServiceWorkerServicification is enabled. This is causing many crashes in content_unittests. To fix this, this CL introduces NotImplementedNetworkURLLoaderFactory and use it as default of MockRenderProcessHost's url_loader_factory_. Bug: 895187 Change-Id: I8119845cf73d0a97297efc473db87b84021cf71d Reviewed-on: https://chromium-review.googlesource.com/c/1280072Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599816}
-
Tsuyoshi Horo authored
Currently when both service-worker-servicification and network-service are not enabled, the internally redirected request doesn't go to the service worker. But when service-worker-servicification or network-service is enabled, the internally redirected request goes to the service worker. We may support service worker integration, like FetchEvent's preloadResponse in future. But we don't have plan to support service worker integration without service-worker-servicification. To make this behavior consistent, this CL makes NavigationURLLoaderImpl::URLLoaderRequestController skip sending the redirected request of signed exchange to the service worker. Bug: 894755 Change-Id: I6f22819655169b4d3c30de0aa269911111c45586 Reviewed-on: https://chromium-review.googlesource.com/c/1278433Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#599815}
-
Morten Stenshorne authored
It produces the same output as in legacy, except for space differences. Some syntax error is apparently expected these days, as of https://chromium-review.googlesource.com/c/1215512 TBR=kojii@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5938cd5d53154f6b51ddd515144d8a0b727a0a0a Reviewed-on: https://chromium-review.googlesource.com/c/1281327 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599814}
-
Moe Ahmadi authored
Bug: 881364 Change-Id: I89310a03a7afdcb4e1c38b1b22f0a1ca49722210 Reviewed-on: https://chromium-review.googlesource.com/c/1277575Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#599813}
-
Nasko Oskov authored
KURL parsing uses known_ports.cc for supporting known ports for standard schemes. GURL uses its own version, which leads to mismatch in behavior. This CL adds gopher's default port to known_ports.cc, however a follow up patch should just remove gopher support in general. Bug: 894426 Change-Id: I9cde04bef34be39337cdb9f2a584de576d0b15ea Reviewed-on: https://chromium-review.googlesource.com/c/1279408Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599812}
-
Collin Baker authored
The triggering conditions for our in-product help include closing a tab that has been active for at least some length of time. This adds a class that tracks when tabs are activated and notifies its client when an active tab is closed. Bug: 887991 Change-Id: I7b3ca7a8f069d24c1751df9e301854ca99b2ff17 Reviewed-on: https://chromium-review.googlesource.com/c/1277819 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#599811}
-
Alan Cutter authored
This CL turns a NOTIMPLEMENTED into a TODO to reduce console spam on Mac. Bug: 415024 Change-Id: I6da61e2e942e5c8014aec2c412705ffeb2d1c9d9 Reviewed-on: https://chromium-review.googlesource.com/c/1280062Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#599810}
-
David Staessens authored
The QueueInputBuffer function tries to print the queued buffer's data size. The data_size function contains a "DCHECK(!end_of_stream());" however, so when a EOS buffer is queued this check fails. TEST=ran VDA tests on eve BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I278f87461d221d2638984abe3fe0241f9da71eac Reviewed-on: https://chromium-review.googlesource.com/c/1272755Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#599809}
-
John Budorick authored
Bug: 878082 Change-Id: I4172f46931e09c5ba8bf85f0113e5f31df53e9c5 Reviewed-on: https://chromium-review.googlesource.com/c/1279409Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599808}
-
Noel Gordon authored
In tablet mode, the extensions dialog has a fixed sized, and cannot be resized. However, non-client hit testing in Ash calls canResize(), and the current dialog code returns true: that causes Ash to show a resize cursor on the non-client window edges of the dialog for mouse users. Prevent that: when the dialog is active in Chrome OS tablet mode, deny canResize() requests to stop the resize cursor appearing at the dialog window edges. Bug: 453634 Change-Id: I551e145c169c9844d3ac090a4e99d9eb826e6e5a Reviewed-on: https://chromium-review.googlesource.com/c/1280383Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599807}
-
Annie Sullivan authored
This is deprecated and will be replaced by load:tools:stackoverflow:2018 story. Disabling now because we are hitting CQ capacity. Bug: 893615 Change-Id: I29b839a0d8bfd007f36a1d09ca1e52a4620735cf TBR: nednguyen@google.com Reviewed-on: https://chromium-review.googlesource.com/c/1280617 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599806}
-
Albert J. Wong authored
This CL moves the final 4 messages that are sent to the RenderWidgetHost's routing ID, but which were handled by RenderViewHost or an object within RVH's delegate/subdelegate tangle. Specifically, WidgetHostMsg_Close, ViewHostMsg_RouteCloseEvent, WidgetHostMsg_DidFirstVisuallyNonEmptyPaint, and WidgetHostMsg_DidCommitAndDrawCompositorFrame now terminate in the RenderWidgetHost and are sent down via explicit methods on the delegates interfaces. After this CL, any messages sent to RenderWidgetHost no longer pass into the RenderViewHost. RenderWidgetHostView*::OnMessageReceived...I'm coming for ya next. You're a marked object and ima gonna sweep your methods clean. Bug: 419087 Change-Id: Ic104aaf785983159ae4a7f1a65781d89b98dfabe Reviewed-on: https://chromium-review.googlesource.com/c/1278285Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#599805}
-
Justin Cohen authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie5bdc140b82f49151ca891b39f65112bf6210eac Reviewed-on: https://chromium-review.googlesource.com/c/1278332Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599804}
-
John Budorick authored
Revert "[testing/scripts] Add base adapter class that enables more code reuse for all isolated script test" This reverts commit 18e40bdc. Reason for revert: Spec revert for https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%281%29/84707 etc Original change's description: > [testing/scripts] Add base adapter class that enables more code reuse for all isolated script test > > BUG: 894261 > Change-Id: Id707ba8a8782a23a41a7dc4680cbc2538e1d3df1 > Reviewed-on: https://chromium-review.googlesource.com/c/1278156 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#599669} TBR=nyquist@chromium.org,dpranke@chromium.org,kbr@chromium.org,dtrainor@chromium.org,nednguyen@google.com,martiniss@chromium.org Change-Id: Ib67b3565568dec728a78fd7d95342d4762a8ecbb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1282215Reviewed-by:
-
Tommy C. Li authored
After deduplicating 100 filenames, i.e. foo.jpg, foo (1).jpg, ... foo (100).jpg, Chrome will stop trying. On Desktop this is acceptable, as the user gets a prompt to choose a filename. On Android, this is really bad, because there is no prompt to choose an alternate filename, and the download just silently fails. This CL starts using a timestamp after 100, and creates filenames in the ISO 8601 format, like: foo - 2018-10-11T21:55:47.392Z.jpg Bug: 135428 Change-Id: I13748110171f799f58c8ddf27f22eebc97149c09 Reviewed-on: https://chromium-review.googlesource.com/c/1278137Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#599802}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/482b936f1be1..b4ed4fd40624 Created with: gclient setdep -r src-internal@b4ed4fd40624 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6933c47aec925a0a34504be2e50b457d94239765 Reviewed-on: https://chromium-review.googlesource.com/c/1281267Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599801}
-
Nick Harper authored
Bug: 875053 Change-Id: I10e419f9e15d004d8da115ed9b18734d47b0a442 Reviewed-on: https://chromium-review.googlesource.com/c/1279294 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#599800}
-
Abhishek Bhardwaj authored
This change adds AddWakeOnWifiPacketTypes and RemoveWakeOnWifiPacketTypes to the shill D-Bus API. These APIs program what type of packets the NIC should wake the system on. BUG=891143 TEST=chromeos_unittests. Change-Id: I21d779ed450ae8f682d2dd5d9f90aef0ee0a2360 Reviewed-on: https://chromium-review.googlesource.com/c/1269114Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599799}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5aac72d05c7e..2be20fdd2d70 git log 5aac72d05c7e..2be20fdd2d70 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 nednguyen@google.com Remove --exact-test-filter flag Created with: gclient setdep -r src/third_party/catapult@2be20fdd2d70 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894261 TBR=sullivan@chromium.org Change-Id: I618e12507c58e9a214232aa3866780f6b13ef8bf Reviewed-on: https://chromium-review.googlesource.com/c/1281264Reviewed-by:
-
Ken Rockot authored
This pulls EmbeddedInstanceManager, EmbeddedServiceRunner, and EmbeddedServiceInfo out of the //services/service_manager/embedder target and into the client library, where they belong. These types are used only by client code to facilitate embedding services within other services and they require no linkage to the Service Manager implementation. Bug: 895022 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I180d9eff440c2b3a06e62b8784bdd2747822842d Reviewed-on: https://chromium-review.googlesource.com/c/1279327Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599797}
-
Tom Anderson authored
BUG=881371 R=pkasting Change-Id: I7a351ed115da2a265e74bfd8557c845b7faa3a60 Reviewed-on: https://chromium-review.googlesource.com/c/1281325 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#599796}
-
Collin Baker authored
This allows tabs to be reached by the keyboard. Only tabs are made focusable, not the tab close buttons since tabs can be easily closed from the context menu. This also makes the tabstrip as an accessible pane so it can be reached by F6 and SHIFT+F6. Follow-up changes: - Look into having CTRL+W close the focused tab rather than the active tab when in keyboard accessibility mode. - Make keyboard focus advance to the next tab when closing the focused tab (rather than disappearing as it does now). Bug: 702414 Change-Id: I052ac56a6adfbc317a67c00314fd9259ab83fc2e Reviewed-on: https://chromium-review.googlesource.com/c/1241845 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
