- 24 Jan, 2020 40 commits
-
-
Wez authored
These tests all make use of either base::test::TaskEnvironment or content::BrowserTestBase (via the WebEngineBrowserTest helper), which already set default ScopedRunTimeouts. Bug: 1021777 Change-Id: Ifbc5c29fb7dc1380c1d97bf6a49ff71c02b7e7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020642 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735101}
-
François Doray authored
This reverts commit b4d501e3. Reason for revert: This CL is on the blame list of the first failures observed for PortalBrowserTest.FocusTransfersAcrossActivation on Mac, and it is related to focus. Original change's description: > Focus tab contents in BeginNavigation case of NTP-initiated navigations. > > Tab contents may get focused during some renderer-initiated navigations > (e.g. navigations from an NTP-replacement extension - see the regression > test added in r723022). This CL ensures that the focus decision is > applied not only to navigations that go through OpenURL, but also to > navigations that go through (more freqeuent, usual) BeginNavigation. > This change helps ensure that we retain the right focus behavior after > more navigations switch to the BeginNavigation code path (e.g. after > relanding ShouldFork removal in https://crrev.com/c/1949448). > > The CL covers both the OpenURL and BeginNavigation code paths by > handling the focus decisions in a newly added TabContentFocusingHelper > class (replicating/moving the focus decisions from OpenURL-only > Browser::UpdateUIForNavigationInTab). Adding a new tab-helper class is > useful, because the existing, OpenURL/BeginNavigation-shared navigation > notifications handlers (e.g. Browser::ScheduleUIUpdate) cannot > distinguish between replaceState and new navigations (see also new steps > in the OmniboxFocusInteractiveTest.NtpReplacementExtension test). > > While this CL changes how focus behavior is implemented, it should have > no effect on end-to-end/high-level expectations of focus behavior (as > observed by end users or browser tests). > > browser_tests do not guarantee window activation and/or focus, but before this > CL navigation in browser_tests would focus WebContents. This is not happening > after this CL, and requires moving a handful of focus-dependent tests from > browser_tests to interactive_ui_tests. > > Bug: 1029161 > Change-Id: Ib57c260b2f85f276ff1dad3aabedd59d1d864c8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970834 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735048} TBR=pkasting@chromium.org,bbudge@chromium.org,creis@chromium.org,rouslan@chromium.org,lukasza@chromium.org,karandeepb@chromium.org,bsheedy@chromium.org Change-Id: I43362d7689548761154b80b72a0734ca02569794 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1029161, 1045594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020862Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735100}
-
Maksym Onufriienko authored
Current update prevent creating/deleting simulators if test runs on real devices. Some bots don't have preinstalled sim-runtimes that match version of connected real devices, it was a reason of failure like https://chrome-swarming.appspot.com/task?id=49c31b4eab008710 To determine whether device with UDID is simulator used `xcrun simctl` command because `idevice_id` is not installed properly on some bots without real devices, e.g. https://chromium-swarm.appspot.com/task?id=49c9a229b161d210 Bug: 1042380 Change-Id: I3771af295dadf32068343bdc2691bedf0a5f72a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002895Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#735099}
-
Matthew Mourgos authored
This is a reland which has fixed msan failures by initializing |target_color_| in hotseat_widget.cc. In this change, the hotseat background will change color for different shelf states and will animate between colors when changing. When in-app shelf is shown the hotseat color should have an alpha value of 90%. When the home shelf is shown the hotseat color should have an alpha value of 60%. Bug: 1041132 Change-Id: I74c1fc9de07d7db1e39400a963d6a5c7c8149320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017913Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735098}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfca5c67f1a7..a7e557f3e353 git log cfca5c67f1a7..a7e557f3e353 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 michaelludwig@google.com Reland "Increase precision of some quad AA calculations" Created with: gclient setdep -r src/third_party/skia@a7e557f3e353 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:10141204 Tbr: benjaminwagner@google.com Change-Id: I012f8db2f3ffbb1c57356940b328a47404e3ab9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#735097}
-
Samuel Huang authored
Previously DevUI DFM Java files have locations that are inconsistent with convention: * Java files under .../modules/dev_ui/ should be in package org.chromium.chrome.features.dev_ui, but were instead placed in org.chromium.chrome.modules.dev_ui. * /chrome/android/features/dev_ui/java should be /chrome/android/features/dev_ui/internal/java. This CL fixes the above. Change-Id: I523d040b0e1a2a041c2faa589d7606a04491ab1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018248Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#735096}
-
Richard Knoll authored
This adds the host implementation of the WebRtc service in the browser process. It implements a new SendMessageDelegate that can send Unido messages via the WebRtc service running in a sandboxed process. - The service is launched in SharingServiceHost::BindService with SandboxType::kUtility - SharingWebRtcConnectionHost handles sending / receiving data in plaintext as of now, with a follow-up CL adding encryption: https://crrev.com/c/2011925 - Signaling of WebRTC is done via FCM messages and passed through WebRtcSignallingHostFCM to and from the service Bug: 1031144 Change-Id: I44884b5debdf3001b82c32e467b07bc0de87c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995660 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#735095}
-
Tomasz Wiszkowski authored
This change replaces inheritance with generics and, in turn, flips relation between Base- and Specialized ViewBinder classes. While more verbose, this gives us a better control and protection over how views and view binders are created and used. With this change we get: - better control over what individual viewbinders see, - better compile-time diagnostics for accidental typos and copy-paste errors, - better support for selective view substitution (enabling us to further optimize suggestions mechanism while staying safe). For the most part this ensures Compiler will catch and report an error early. In the extreme case where an error is repeated everywhere the error will be caught and thrown at runtime upon view creation. This change aligns with the original design proposal for suggestions refactor. More details: https://crrev.com/c/2007943 Doc: http://doc/1aL_UcW1gdeSLqNzuJZlQPBqMG0XAwVaoa05UTyVulp8 Bug: 982818 Change-Id: Ic8425512f3904cc29ea410723a9b7a717492e191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017980 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#735094}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/300b9ced..516ed977 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I32fcf61627f8cc1f3584efcf397a10f45948a1d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019824Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735093}
-
Joe Downing authored
It looks like this was disabled here: https://chromium-review.googlesource.com/c/chromium/src/+/2006353 However the test is still being run. I looked at the original CL and I suspect there is a missing comma so the last two tests in the blacklist array aren't separated correctly. I'm going to try adding the comma in and see if the flaky failure goes away. TBR: mythria@chromium.org Bug: 1043048 Change-Id: I8db21e2fb569193e2653bcc5b28cd2f5ddd32eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019587 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735092}
-
Bettina authored
Enable by default the SafeBrowsingPasswordProtectionForSavedPasswords and SafeBrowsingPasswordProtectionForSignedInUsers experiments on desktop only. Bug: 1026006,914410 Change-Id: If0052bf62af127e94adc24cfdab701559c2293e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017675 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735091}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I919a40da757400537a10fea0259e4672f542daa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020242Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#735090}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5337c2c3980c..829bdae45d24 Created with: gclient setdep -r src-internal@829bdae45d24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1028270,chromium:1039877,chromium:1042208,chromium:702834 Tbr: jbudorick@google.com Change-Id: I37c965744a09f16982a174ad888af23c0978861c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019934Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735089}
-
Toni Barzic authored
Scrollable shelf view was mirroring available_space_ bounds even though they already were in the right coordinates as calculated in UpdateAvailableSpace(). What has to be mirrored is the layout offset passed to shelf view, whose coordinates are flipped (compared to scrollable shelf view) in rtl. Also fixes drag from apps grid view - the screen coordinates passed to the drag and drop host (i.e. shelf) by converting location returned by ExtractDragLocation() to screen coordinates, but which was flipped for rtl (to correctly match the drag handling inside apps grid view). Instead, calculate the screen coordinates from the event root location, to avoid dependency on the ExtractDragLocation() details. BUG=1039758 Change-Id: I5c74f02d72e5f8e0b13e0c9076bd12361387d5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020330Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#735088}
-
Megan Jablonski authored
The snackbar cancel rate is very high. Using a higher threshold does not reduce the cancel rate, however it reduces the number of times this snackbar is shown resulting is less users accidentantlly getting into a never translate state that they don't know how to get out of. Bug: 1044815 Change-Id: Ibee9c9cb3e0068a3d57b35adfc66b821299332a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016184Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#735087}
-
kylechar authored
The only remaining usage is in tests. Convert the test to ContextLossObserver instead and delete ContextFactoryObserver. Bug: 947279 Change-Id: I0ec87d11a011ea315dc1a4cea3b8bf66f1f30f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546269Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735086}
-
evliu authored
This CL defines Speech On-Device API (SODA)-related file path constants in //components/soda that will be used by the component updater in //chrome/browser/component_updater, the SODA sandbox hook in //content/utility, and the SODA service in //chrome/services. Bug: 1039824 Change-Id: Ic96c7eb5ec6d458beb4f0bf90982bf4dccc6dc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015483Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#735085}
-
Albert Chaulk authored
Bug: None Test: None Change-Id: Ie720aa5c16971f0105504cb089e0b27a46c5d32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953670Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735084}
-
Aaron Leventhal authored
When a generated live region event occurs, we currently fire IA2_EVENT_TEXT_INSERTED. However, as recently discovered via https://chromium-review.googlesource.com/c/chromium/src/+/2015429 we are not firing IA2_EVENT_TEXT_REMOVED in the generated event case. This currently adds a todo rather than attempting to correct the logic for which events fire, as it is not known to cause any actual screen reader issues. Bug: None Change-Id: I4d74acdf47c5909d3efe0dbf2acb9d20ffb98528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019410Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#735083}
-
Alex Newcomer authored
When the drag completes in ScrollableShelfView, there are two possibilities: 1. The drag was Shelf -> Shelf 2. The drag was AppList -> Shelf For scenario 1: - ScrollableShelfView owns a DragIconProxy |drag_icon_| - ShelfView treats ScrollableShelfView as the ApplicationDragAndDropHost. - ShelfView makes its DragImageView |drag_image_| invisible. When scenario 1's drag completes, there is no issue, ScrollableShelfView successfully animates |drag_icon_| to the proper bounds. For scenario 2: - AppsGridView treats ShelfView as the ApplicationDragAndDropHost - ShelfView creates a DragIconProxy, |drag_image_|. - ScrollableShelfView does not create a DragIconProxy. - Animation for the scrollable shelf, implemented in ScrollableShelfView fails. To fix scenario 2, pass ShelfView's DragIconProxy (ShelfView::drag_image_|) and use it within ScrollableShelfView. This change is not intended to be a full fix, just a change that we can successfully land without refactoring. I am avoiding refactoring because: - Branch is soon. - Kukui is coming out with this milestone - This code is already prone to bugs, I am worried there will be negative effects to a refactor I created a follow up bug for this refactoring: https://bugs.chromium.org/p/chromium/issues/detail?id=1045186 Also in this change: - Use a transform instead of a bounds animation. - Simplify DragIconDropAnimationDelegate Bug: 1041999 Change-Id: I63a428f103a888ef019da919407a60533da68c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017923 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Robert Ogden authored
This isn't hooked up to anything yet. Also this starts on params and features headers which I'll move the existing stuff into later to avoid merge conflicts. Bug: 1042829 Change-Id: I59139788243e076432789f8b5ff9c581cf276f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004956 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735081}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py efb130fc93059bdf02d3a83950ddabc5d119f9de`. This increases the clang version from 10 to 11. It also disables the use of vector instructions in zlib to work around new false positives in msan (see crbug.com/1045291). Bug: 1030664 Change-Id: I5417d3063f0d67a61cdf31141b05a51a56e84482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014904Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#735080}
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: Ie482ce1a2c48badb57b761fe30cc5e58551eefb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019884Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735079}
-
Manu Cornet authored
Some tools are a bit thrown off by this occurrence of a test class that doesn't end in "Test" like all the others. Just making this a bit more consistent. Change-Id: I75885202e804d4d632ca4fe92f5f482e03051c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020402 Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735078}
-
Dale Curtis authored
For 1x1 YUV images the sample size will be larger than the height, so upon dividing the integer height by the sample size we get a result of zero chunks for processing. Additionally, since the code wasn't accounting for the last row of odd height frames, it would do nothing on a 1x1 frame. The fix is to ensure we always process an extra row in the last task when we've got an odd height frame. R=thomasanderson Fixed: 1034955 Change-Id: Ic6733ffb31bd2040769d7bc63e9096aea756cbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016359 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735077}
-
Weiliang Chen authored
The creation of OverlayProcessorOnGpu is not synchronous, and we might try to use it before the task is run on the gpu thread. Make sure to wait for the creation if we try to use it. R=rjkroege Bug: 1044671 Change-Id: I9c9f02368ab36b3e328a525612f4fbd481e6df97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015345 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#735076}
-
Avi Drissman authored
This changes expectations based on the macOS SDK used to build Chromium. MAC_OS_X_VERSION_10_12 is true if we use at least the macOS 10.12 SDK, which has been the case for years. MAC_OS_VERSION_10_13 is a typo and thus is never defined. Therefore, this always evaluates to true on the Mac. Bug: 1044838 Change-Id: I3a56d37e7ea9d1acb65d6b8e07996de47da37794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020163Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#735075}
-
Andrew Xu authored
This CL is a part of the effort to ensure that the target bounds of the window scaling animation are the shelf icon's final bounds. See https://crrev.com/c/1996268 for more details. This CL fixes the case 2 by accomplishing the following things: (1) Updating the visibility state before starting the window scaling animation. It assures that when the window scaling animation starts, the target hotseat bounds are already set. (2) Locking the shelf auto hide state when the back drop widget updates since the change in back drop widget should not affect the shelf. This CL should be landed after https://crrev.com/c/2004009 which fixes the tests broken by this CL. Bug: 1030819 Change-Id: Iff97f7f1731e7dec6cea36ec99cc3abbee2caa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004052 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735074}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93d8e2cd12d0..53faba1c7d1d git log 93d8e2cd12d0..53faba1c7d1d --date=short --first-parent --format='%ad %ae %s' 2020-01-24 brgoddar@microsoft.com Reland "Add script that checks license headers of JavaScript files" Created with: gclient setdep -r src/third_party/devtools-frontend/src@53faba1c7d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a45a577efeb8b138e685d03b5fb50ec922703a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019931Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Following discussion in crrev.com/c/1991710 about using dark mode PNGs, the preferred approach is using color_utils::IsDark() instead of GetNativeTheme()->ShouldUseDarkColors(). Change-Id: I50dceb05c8c902d148827b37914addf4e213c4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019802 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#735072}
-
yilkal authored
This cl makes sure that the navigation throttle for iframe is created even if the main frame url has been whitelisted. Bug: 1045157 Change-Id: I966a59f3a856e8d34609b013e94d6dd87bc9dc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018095Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#735071}
-
Joshua Bell authored
A sub-test modifies Object.prototype and leaves the modifications in place longer than needed. In an async test, this can have bad side-effects across tests and interfere with the test harness itself. Modify the sub-test to behave like the others, scoping how long the Object.prototype modifications are left in place. Bug: 1045260 Change-Id: I74c1789f5f804b6f050944e5257d7a9fb3a273e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019928Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735070}
-
Francois Doray authored
TBR=dvadym@chromium.org R=dvadym@chromium.org Bug: 1045545 Change-Id: Iaa0b63e95748d488dc97b07087c4852e981b5d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019886Reviewed-by:
-
Allen Bauer authored
Bug: 648382 Change-Id: I0e97983c8a5509e99bb7d33f7dab7e43be74d95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017667 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4e98dfeaf092..453926f51ebd git log 4e98dfeaf092..453926f51ebd --date=short --first-parent --format='%ad %ae %s' 2020-01-24 syoussefi@chromium.org Vulkan: Remove inactive shader inputs in the translator 2020-01-24 syoussefi@chromium.org Fix image linking not verifying same format Created with: gclient setdep -r src/third_party/angle@453926f51ebd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Ia03f439e790664fc7bd490fb160bc38b62986e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019848Reviewed-by:
-
Francois Doray authored
R=eseckler@chromium.org TBR=eseckler@chromium.org Bug: 1045519, 1041392 Change-Id: Ia4ef9f7d54ad603c8a9f11cd582440c07e2777c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019788 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f368925e49f4..214a08493a82 git log f368925e49f4..214a08493a82 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 taylori@google.com Merge "perfetto-ui: Fix record page" Created with: gclient setdep -r src/third_party/perfetto@214a08493a82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I11165256600ca480c009fe472ca37cd3398a4c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019849Reviewed-by:
-
Joe Downing authored
TBR: vmpstr@chromium.org Bug: 1045521 Change-Id: I81284ed75302d4dd8d144b73b6f3c936100f70c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019332Reviewed-by:
-
Ana Salazar authored
We have rounded corners on the shelf to clip the ink-drop effect, this causes an additional renderpass. We added an InkDropObserver to listen for the ink drop animation starting and ending and toggle the rounded corners as needed. Bug: 1021772 Change-Id: Icf4aafa6ddb1d917ec8ae07b68fb4063b0b6c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001745Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e37f2ef6bd6e..748ad200897b git log e37f2ef6bd6e..748ad200897b --date=short --first-parent --format='%ad %ae %s' 2020-01-24 capn@google.com Don't override vkQueuePresentKHR() failure codes with VK_SUBOPTIMAL_KHR 2020-01-24 capn@google.com Discern between per-swapchain and vkQueuePresent command results 2020-01-24 amaiorano@google.com Subzero: replace globals with external memory for constant vectors 2020-01-24 amaiorano@google.com SubzeroReactor: implement missing atomic ops Created with: gclient setdep -r src/third_party/swiftshader@748ad200897b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If866dd5f6a6e58c6f0098a6710bbaff90395aa05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019856Reviewed-by:
-
