- 11 Oct, 2018 40 commits
-
-
Yuki Yamada authored
This is a clean-up for previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1215512 After submitted the previous CL, these old classes are not used from anywhere: blink::V8AbstractEventHandler blink::V8EventListenerOrEventHandler blink::V8ErrorHandler blink::V8LazyEventListener Therefore, this CL removes them. Bug: 872138 Change-Id: I44e9026148e6db24f44b52c138523cce55eacd7d Reviewed-on: https://chromium-review.googlesource.com/c/1273355Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#598707}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: If15934c66bb2ea3350d02b7953618083e34ba706 Reviewed-on: https://chromium-review.googlesource.com/c/1264642 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#598706}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2dc719bfb1eb..fbc78231d058 Created with: gclient setdep -r src-internal@fbc78231d058 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibc8743b3b54a74fe36e2fd6282037b28328d3705 Reviewed-on: https://chromium-review.googlesource.com/c/1275867Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#598705}
-
Yuichiro Hanada authored
Android IMEs can call CommitText() with control characters, but InputMethodEngine::CommitText expects only text characters. This CL adds IsControlChar() and SendControlKeyEvent() to send those control characters as a KeyEvent. Bug: 845079 Test: Omnibox works with Gboard. Change-Id: I6d3dadb3879ada22993b9b5a330e08c634521380 Reviewed-on: https://chromium-review.googlesource.com/c/1275465 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#598704}
-
Yuta Kitamura authored
The class is no longer exposed to //content and others. This CL rewrites all the occurrences of the old name in the entire code base, and removes the temoprary aliases. Bug: 826203 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I98ef06a8cd87e168216257eb76ac8bad1c662ceb Reviewed-on: https://chromium-review.googlesource.com/c/1261455 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Arthur Sonzogni authored
A FrameTreeNode hosts several RenderFrameHost like: * The current RenderFrameHost. * The future one that is loading but hasn't committed yet. * The ones pending deletion. On its turn a RenderFrameHost contains several children frames, represented by FrameTreeNode. This CL replace FTN::IsDescendantOf by RFH::IsDescendantOf. * The new form of IsDescendantOf is used in follow up CLs. * In the case of one RenderFrameHost being pending deletion, the meaning is a bit different. For instance during a navigation from A(B) to C. Both RenderFrameHost A and C are on the same FrameTreeNode. The FrameTreeNode of B is a child of the FrameTreeNode of C, but B is not a child of C, only a child of A. Add a content/public API so that embedders won't have to manually iterate on RenderFrameHost::GetParent() themselves to get this information. This will be used in a follow-up CL. Bug: 609963 Change-Id: Iedb4a7acf17c7782cd9e91dd529a2736c1fd51d4 Reviewed-on: https://chromium-review.googlesource.com/c/1269874 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#598702}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ic2facf850ac74d8087cc599ce0a9a7351b330ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1275868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#598701}
-
Andreas Haas authored
On Windows we use crashpad and not breakpad. Moreover, in these files we setup crashpad and not breakpad. Change-Id: Id50c1b1ba9b2dc962dfd4c2eac913e8c1ce30060 Reviewed-on: https://chromium-review.googlesource.com/c/1269865Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#598700}
-
Mikel Astiz authored
Follow-up patch that cleans up the Java counterpart of the experimental feature, which is effectively dead. Bug: 649880 Change-Id: I0cefac07822934d5103145abbeb6bf988dcc7ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1273058Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#598699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1d9fb538547..2dc719bfb1eb Created with: gclient setdep -r src-internal@2dc719bfb1eb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia0a99de33e13f66e3cf33960007515e40cdbfb86 Reviewed-on: https://chromium-review.googlesource.com/c/1275865Reviewed-by:
-
Ramin Halavati authored
Ephemeral Flash permissions are going to live until M87. The expiration milestone of its metrics is increased until then. Bug: 884865 Change-Id: I8edec5c107fb5f47126bf90d9ad4b6a8c6e54a66 Reviewed-on: https://chromium-review.googlesource.com/c/1272817Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#598697}
-
Olivier Robin authored
Bug: 892033 Change-Id: Ie7476fd26b0085cdc405e4e942e69765c6149254 Reviewed-on: https://chromium-review.googlesource.com/c/1273747Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#598696}
-
Alexandre Courbot authored
We can send pictures to clients from two situations: when dequeuing a capture buffer if the image processor is not used, or when the image processor is done with a frame. The code for these two cases is identical, so factorize it. BUG=792790 TEST=Checked that VDA was passing on hana. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I18aee0e2ea98c80da98e3e507c018bb8960572b1 Reviewed-on: https://chromium-review.googlesource.com/c/1264340 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#598695}
-
François Beaufort authored
This reverts commit 7bf7db36. Reason for revert: https://chromium-review.googlesource.com/c/1273515 has landed. Original change's description: > Disable TabIconUpdated test on ChromeOS (is flaky). > > TBR=alph@chromium.org > > Bug: 892310 > Change-Id: I6cefa7018520128cdf81d79a1ee467d5ef5859fe > Reviewed-on: https://chromium-review.googlesource.com/c/1269339 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597679} TBR=alph@chromium.org,waffles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892310 Change-Id: Ibb6d9ffdfe2372e165eb0abb7db9a2f4a0d57a2f Reviewed-on: https://chromium-review.googlesource.com/c/1275665Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
-
Heng-Ruey Hsu authored
In original step, app launcher will open Chrome Camera App first to do media migration. Second time will launch Google Camera App. It confuses user to open two kinds of apps in the same icon. Since there is no image in the device after first login, set the parameter to true to avoid unnecessary migration step to open GCA directly. BUG=b:115691249 TEST=first login and device will launch GCA directly. Change-Id: Icfff7df2989c0f333b8455ea7194d1cfc9fd2e95 Reviewed-on: https://chromium-review.googlesource.com/c/1245301 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#598693}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9942ffb490bf..d1d9fb538547 Created with: gclient setdep -r src-internal@d1d9fb538547 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I324fe95fc9ab80f3cc177d5d6d702f8285db99e3 Reviewed-on: https://chromium-review.googlesource.com/c/1275428Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 5292ab62. Reason for revert: This is failing compilation on Google Chrome Linux x64: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/36667 Original change's description: > Won't build yasm with sanitizer option for release build. > > In addition to debug build, let me disable the sanitizer for release > build. To remove sanitizer option at link time, > //build/config/sanitizers:link_executable is added in BUILDCONFIG.gn > instead of build/config/BUILD.gn. > > Bug: 887234 > Change-Id: I5a13d0d6cc63b454f75cedc71870f157de80ad0c > Reviewed-on: https://chromium-review.googlesource.com/c/1264196 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > Cr-Commit-Position: refs/heads/master@{#598688} TBR=dalecurtis@chromium.org,gab@chromium.org,yyanagisawa@google.com,dpranke@chromium.org Change-Id: Iab498aec22f86382727ce00236528083f9daf51f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887234 Reviewed-on: https://chromium-review.googlesource.com/c/1275825Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/40be505a7023..265886b2befa git log 40be505a7023..265886b2befa --date=short --no-merges --format='%ad %ae %s' 2018-10-11 thestig@chromium.org Update build rules for CFX_CodecMemory. 2018-10-11 thestig@chromium.org Fix double V8 initialization with fuzzers. Created with: gclient setdep -r src/third_party/pdfium@265886b2befa The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:894325,chromium:894053 TBR=dsinclair@chromium.org Change-Id: I6f07a4f8cd803a88ab825f30d07e8659e7fd8d4c Reviewed-on: https://chromium-review.googlesource.com/c/1275450Reviewed-by:
-
Bailey Berro authored
- Adds a histrogram and metric collection for the authenticaion method that a user uses. Bug: chromium:891902 Change-Id: I6f3a9e81ec3983750d006c93fa79b147c83fc98b Reviewed-on: https://chromium-review.googlesource.com/c/1262971 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#598689}
-
Yoshisato Yanagisawa authored
In addition to debug build, let me disable the sanitizer for release build. To remove sanitizer option at link time, //build/config/sanitizers:link_executable is added in BUILDCONFIG.gn instead of build/config/BUILD.gn. Bug: 887234 Change-Id: I5a13d0d6cc63b454f75cedc71870f157de80ad0c Reviewed-on: https://chromium-review.googlesource.com/c/1264196Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#598688}
-
Ivan Sandrk authored
Recently there was a serious problem where a lot of TPMs ended up in a locked state due to unforeseen interactions of several components. In order to get a better understanding of the scope of the problem we want to have accurate reporting on TPM status of the devices. Bug: 893245 Change-Id: I41de153ac6887d6d48a106f64211fba0f104cac1 Reviewed-on: https://chromium-review.googlesource.com/c/1269040Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#598687}
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray has slightly different battery icon shape. TEST=manual BUG=876217 Change-Id: Ifdbccd66f238bb909e67fcca69ee0e72a881e3aa Reviewed-on: https://chromium-review.googlesource.com/c/1273196Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#598686}
-
Sky Malice authored
Bug: 866123 Change-Id: I89153c2871010027fc39a47b990f70d91b400f04 Reviewed-on: https://chromium-review.googlesource.com/c/1272658 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#598685}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88c509620d12..9942ffb490bf Created with: gclient setdep -r src-internal@9942ffb490bf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8638e3e81c8d038a16ee3c1c4c371fac70c125a3 Reviewed-on: https://chromium-review.googlesource.com/c/1275427Reviewed-by:
-
Adam Rice authored
Layout test http/tests/fetch/chromium/release-handle-crash.html crashes around 2% of the time in DCHECK-enabled builds. Add a crash expectation to TestExpectations. BUG=893015 Change-Id: I7b3b208ab76027eb52e80facfb1c7d1a6b41023b Reviewed-on: https://chromium-review.googlesource.com/c/1273175Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#598683}
-
Chris Hall authored
This change adds an aria-label to the "undo" button of the form "press Control plus Z to undo". It will appropriately insert either "Control" or "Command" depending on platform. BUG=856209 Change-Id: I95f917b8d6722ad8362dea2295bfc4aaf82f6259 Reviewed-on: https://chromium-review.googlesource.com/c/1229737 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#598682}
-
Ernest Galbrun authored
finishing a script on an error. Before this patch, clean_contextual_ui was ignored. This patch makes the executor aware of the clean_contextual_ui field. At the end of the script, the cleanup is triggered if the field was set on the last action, or if the script ended with an error. After this patch, clean_contextual_ui field triggers the ui cleanup on finish. Bug: 806868 Change-Id: Ief65183066a2ca1dedfda5c93ec0a2c75639f8ba Reviewed-on: https://chromium-review.googlesource.com/c/1273949 Commit-Queue: Ernest Galbrun <galbrun@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#598681}
-
Jinsuk Kim authored
This CL moves the remaining SadTab-related method to SadTab. |TabObserver.onCrash| is updated not to pass the parameter |sadTabShown| since it can be obtained directly from Sadtab by the observers. Bug: 877878 Change-Id: Ib2dd8a1e98b8780a9d4be30c3a4bb8d667d3c53e Reviewed-on: https://chromium-review.googlesource.com/c/1267455 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#598680}
-
Justin DeWitt authored
On ESP they were completely circular. Change-Id: Ie2341230526435990629073925d2d656807a0a3d Reviewed-on: https://chromium-review.googlesource.com/c/1274830 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#598679}
-
Sergei Datsenko authored
First launch will take more than regular one, so we put it under different metric to keep the numbers more relevant. BUG=chromium:892524 TBR=slangley@chromium.org Change-Id: Ic39f869f7b1a70744193b0c42c80812219c727c9 Reviewed-on: https://chromium-review.googlesource.com/c/1272778Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#598678}
-
Tetsui Ohkubo authored
This CL implements custom scrolling/resizing behavior to NewUnifiedMessageListView. In Unified, the latest notification is placed at the bottom, so notification list should be scrolled to the bottom when it's opened. NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: Ia817e7f07a2bdf161195d298771dbc641e627a23 Reviewed-on: https://chromium-review.googlesource.com/c/1270420 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Daniel Cheng authored
Change-Id: Ie6a0b83982857fb12b9c8a85d617484e0ce71189 Reviewed-on: https://chromium-review.googlesource.com/c/1273998Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Bailey Berro authored
- Passes use_kerberos to SmbService::Mount so that it can be used to determine if kerberos authentication should be performed with a users login credential (for chromad users). Bug: chromium:887113 Change-Id: I4326f37df0522b80dccce9535f9e71e823114cd0 Reviewed-on: https://chromium-review.googlesource.com/c/1260213Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
We will use it for PendingWebAppManager testing. Bug: 875698 Change-Id: I7a433a3d1427edcb71efd4356a74d391cfdffa5d Reviewed-on: https://chromium-review.googlesource.com/c/1272916 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#598674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab02c4853c54..88c509620d12 Created with: gclient setdep -r src-internal@88c509620d12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2f548c62e85883e6cb3b375ee9fae11c96f15681 Reviewed-on: https://chromium-review.googlesource.com/c/1275447Reviewed-by:
-
David Black authored
Previously Assistant UI would hide when navigating to the browser. This kept the Assistant session alive so the stage would be populated when the user returned. In the case of auto navigation (e.g. navigation as a result of the server response and not as a result of the user clicking a card/chip), this caused user confusion because the stage had results upon returning that were redundant to what they saw in the browser. Now, per change in product requirement, we will still hide Assistant UI when going to the browser as a result of user interaction, but will close the UI when auto navigating due to the response from the server. In such cases, the user will start a fresh session with clean state UI upon returning to Assistant. Bug: b:117520060 Change-Id: I0b9bd7c06cf10717dcc13f73f3c2b1bfcbb54b85 Reviewed-on: https://chromium-review.googlesource.com/c/1272716Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#598672}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4eb809a..80d8889e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: Ibd6774d0460ccbba7e5eee294389bbc602a90dad Reviewed-on: https://chromium-review.googlesource.com/c/1275288Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#598671}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f7dd9df7e12d..e8d2b1be1a7c git log f7dd9df7e12d..e8d2b1be1a7c --date=short --no-merges --format='%ad %ae %s' 2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8afdf167..24992897 (598496:598606) Created with: gclient setdep -r src/third_party/webrtc@e8d2b1be1a7c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I380b8b5300e504e7485a183af19acdc7fa521761 Reviewed-on: https://chromium-review.googlesource.com/c/1275449Reviewed-by:
-
Bailey Berro authored
- Passes the authMethod string to smbMount. - This string will be used to determine whether chromad kerberos should be used by SmbService to authenticate to a share. Bug: chromium:853803 Change-Id: Ib6a329529904902dc26982346e0130640795778f Reviewed-on: https://chromium-review.googlesource.com/c/1258973Reviewed-by:
-
rajendrant authored
This CL adds a LazyImage previews bit, which is used to draw just a transparent rectangle as placeholder. Bug: 887665 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I47a230aa7c6210fd65eb05ed4916186830f1909f Reviewed-on: https://chromium-review.googlesource.com/c/1260926 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#598668}
-
