- 21 Jun, 2018 40 commits
-
-
Deepanjan Roy authored
Allows specifying cache temperature with --cache-temperature. Values are as defined in telemetry/page/cache_temperature.py. For example: --cache-temperature=warm. Also, changes the default cache temperature for loading_ct to COLD. Change-Id: Ib0210bf2a72d28902bfe653cc01646aae4ccbcff Reviewed-on: https://chromium-review.googlesource.com/1106643 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#569260}
-
Danyao Wang authored
WKBasedNavigationManager needs to create a web view to restore session. The current order causes an CHECK in CRWWebController that prevents the creation of new web view when |_webUsageEnabled| is false. This fixes failure in NavigationTestCase and crashes observed in the wild. Bug: 852847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6a7800ca6ec985a2080d0e0acc3a743c8c62c5f Reviewed-on: https://chromium-review.googlesource.com/1108575Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569259}
-
Martin Šrámek authored
Bug: 854538 Change-Id: I1e33574edf070dc93cf897faab75a0e53df39dd8 TBR: mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1109959Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#569258}
-
Mustaq Ahmed authored
Bug: 805015 Change-Id: I9b9c8ee0071707220ec9ad1f7966816b055cf655 Reviewed-on: https://chromium-review.googlesource.com/1108438Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#569257}
-
Stuart Langley authored
Rename to --disable-team-drives for disabling. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1103986. sashab@ is on vacation so I am landing her changes in this CL, with fixes for failing unit tests. Bug: 849772 Change-Id: I37260458a60f69d2e95d87afbf87213456131c29 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1108241Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#569256}
-
Kai Ninomiya authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1098558 but with the bug fixed. TBR=piman@chromium.org, geofflang@chromium.org Bug: 828135 Change-Id: I8c2b899e911277f9ad0d86363a54d187aad64843 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1105564Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#569255}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b67614b..653887dd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3ef6bab11c902b33ea07e7d7a68c367136a6f28d Reviewed-on: https://chromium-review.googlesource.com/1109741Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569254}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5b8dd4d75ec3..8b23dba0e50f git log 5b8dd4d75ec3..8b23dba0e50f --date=short --no-merges --format='%ad %ae %s' 2018-06-21 philipel@webrtc.org Add RTPVideoHeader const accessor. 2018-06-21 danilchap@webrtc.org Replace rtc::Optional with absl::optional 2018-06-21 ouj@fb.com Create a peer connection factory builder 2018-06-21 phensman@webrtc.org Add OnLogMessage(msg, sev, tag) to logsinks 2018-06-21 saza@webrtc.org Remove nonlinear beamformer API from APM 2018-06-21 philipel@webrtc.org Add RTPVideoHeader accessor. 2018-06-21 buildbot@webrtc.org Roll chromium_revision e1ef7d4b..b47e7752 (568794:569173) Created with: gclient setdep -r src/third_party/webrtc@8b23dba0e50f The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I971128efa0de663e8c5c768eb373e7672768a096 Reviewed-on: https://chromium-review.googlesource.com/1109860Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569253}
-
Quan Nguyen authored
This reverts commit 8db5d9a3. Reason for revert: This CL was identified as introducing flakiness to LoginCursorTest.CursorHidden (in interactive_ui_tests) Original change's description: > Enable powerwash shortcut in views-based login screen. > > Bug: 837501 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Ia55c5e302d70c1a65409fd7268ae135e0ee7c5ca > Reviewed-on: https://chromium-review.googlesource.com/1102904 > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569043} TBR=xiyuan@chromium.org,dcheng@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org Change-Id: I2cf2fcc2d8a0f8c491b16e4bca4387e07cabb69c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837501 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1109617 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569252}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I3b0380e69b94665b8687757939c11c8427c52015 Reviewed-on: https://chromium-review.googlesource.com/1110137Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569251}
-
Rune Lillesveen authored
Bug: 836126 Change-Id: Ifd1705c3d72af1c9250f97279a03f439ee08d478 Reviewed-on: https://chromium-review.googlesource.com/1109824 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#569250}
-
Philip Jägenstedt authored
This is because add_cleanup will begin accepting thenable return values, and returning any other value will cause a harness error: https://github.com/web-platform-tests/wpt/pull/8748#issuecomment-398954260 Change-Id: I700233ef706328c09e67c6d262f206b8f0d06da7 Reviewed-on: https://chromium-review.googlesource.com/1109513 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#569249}
-
Philip Jägenstedt authored
Roll in the most recent version of: testharness.js, testdriver.js, idlharness.js and webidl2.js Change-Id: I90d19fcca8d4cd5ef616534da61937f185913085 Reviewed-on: https://chromium-review.googlesource.com/1109514 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
-
chrome://dinoEdward Jung authored
Bug happens on the rare occasion that bdayFlashTimer == 0, the dino keeps on flashing and bday mode never gets set. Bug: 846473 Change-Id: Iddbe3f9fdba49c540930aac1721cb76a2b137af6 Reviewed-on: https://chromium-review.googlesource.com/1109501Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#569247}
-
Peter Beverloo authored
This removes all permission-related code from the Web Notifications implementation beyond the NotificationPermissionContext. The //content-level code has been amended to use the PermissionManager directly now that all permission checks happen on the UI thread. Web Notifications inherit the "notifications" extension permission. This was implemented in the PlatformNotificationServiceImpl, which meant that not all ways of checking for granted permission (notably the Permission API, as well as internal checks) reached the same conclusion. This led to bugs. In order to unify all of that, these checks are now also done by the NotificationPermissionContext. The key difference there from the previous implementation is that we no longer check whether the extension is indeed running in a particular process. That's OK because the Mojo service, BlinkNotificationServiceImpl, decisively knows which origin it's owned by. (Which could be the extension Id that this code is dealing with.) Various new tests have been added to cover this behaviour, including a NotificationPermissionContextApiTest suite that verifies that our Web exposed behaviour is consistent among the various APIs that are able to request and/or use notification permission status. Bug: 845514 Change-Id: I4b8b306858a69ed93b6b1ab553985f4c90b7b2d1 Reviewed-on: https://chromium-review.googlesource.com/1085568 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#569246}
-
Marc Treib authored
This reorders and renames some members, extracts logic into helpers, removes an unnecessary ForTest method, etc. No functional changes. While we're here, also switch from ThreadTaskRunnerHandle to SequencedTaskRunnerHandle - nothing here requires thread affinity. Bug: 846238, 854978 Change-Id: Iaeaf7664ec78a23acbc0dfaf84122dea9ca4ef38 Reviewed-on: https://chromium-review.googlesource.com/1109897Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569245}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/393d20a8e911..e0b24e08909e Created with: gclient setdep -r src-internal@e0b24e08909e The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide530129c2e76ad999d991b5af5b3febf27dadda Reviewed-on: https://chromium-review.googlesource.com/1109862Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569244}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd70aa422ce6..3237f75953c1 git log cd70aa422ce6..3237f75953c1 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 lucferron@chromium.org Vulkan: Fix issue when a sampler2D was not used in FS or VS Created with: gclient setdep -r src/third_party/angle@3237f75953c1 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ibaf3dc15aea352302bfd07c8ee88bdb487848c5f Reviewed-on: https://chromium-review.googlesource.com/1109857Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569243}
-
Justin Cohen authored
It seems with Xcode 10 items behind the keyboard are appearing as visible. This is likely an EG bug. Bug: 854847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I905d4e7809afe6d5d35e240b8e6c815f70cd41df Reviewed-on: https://chromium-review.googlesource.com/1109307Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569242}
-
Ned Nguyen authored
This CL improve the sharding algorithm by adjusting the policy of picking a story at the boundary a benchmark shard. Before this, we will keep adding story to a benchmark shard until the total time assigned is greater than expected total time (assuming assignment is perfect). This CL changes it to keep adding story until the absolute value of the difference between total time assigned and expeted total time is minimal. The effectiveness of this change can be shown by looking at the predict stats ("extra_info" field) in the 3 shards: linux_perf_shard_map, mac_1012_low_end_26_shard_map, mac_1013_high_end_26_shard_map. Change-Id: I3ace373fb1393658cc21aca1a61a66d865a8c059 NOTRY=true # tests covered by PRESUBMIT Change-Id: I3ace373fb1393658cc21aca1a61a66d865a8c059 Reviewed-on: https://chromium-review.googlesource.com/1108374 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569241}
-
jonross authored
Locally the SitePerProcessBrowserTests were working with surface sync on Android. This updates the filter to only block SitePerProcessHitTests instead. Also updates the Viz filter to remove the Mac only failures. TBR=fsamuel@chromium.org TEST=surface_sync_content_browsertests, viz_content_browsertests Bug: 849746 Change-Id: Id6fca3c0ff2ad31a2ee0051b2b889fb80d0c51e3 Reviewed-on: https://chromium-review.googlesource.com/1110038Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#569240}
-
Martin Šrámek authored
This reverts commit 8f2591ae. Reason for revert: Likely broke DesktopMediaPickerViewsTest. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33273 Original change's description: > [ozone/wayland] Manually handle fullscreen states. > > In order to ensure media files can enter fullscreen mode, manually > handle fullscreen states. Basically, a compositor sends configuration > events on each request for state changes from clients asynchronously, > which is unefficient for media files when they enter a fullscreen mode. > > For example, when a youtube video file is being set to fullscreen, a > WaylandWindow is also set to a fullscreen mode, but the return value from > the WaylandWindow::GetPlatformWindowState still contains an old value until > the compositor calls with a configuration event. This short race is > enough for a media content to be placed in a forever "entering fullscreen" > state, which never results in a fullscreen state for media files. > > Bug: 843018 > TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0 > XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0 > > Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17 > Reviewed-on: https://chromium-review.googlesource.com/1107636 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#569172} TBR=rjkroege@chromium.org,msisov@igalia.com Change-Id: I9920185d61395a70663fa184e834592f02176da3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843018 Reviewed-on: https://chromium-review.googlesource.com/1110057Reviewed-by:
-
Yuvanesh Natarajan authored
Moving static variables and functions to anonymous namespace. Bug: None Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I91789dd354da254dd13410425792321a2608f19c Reviewed-on: https://chromium-review.googlesource.com/1049587 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#569238}
-
Takuto Ikuta authored
This is mainly for compile step time improve for android-kitkat-arm-rel builder having symbol_level=1 I measured peak memory usage when link some large targets with android-kitkat-arm-rel builder's config. libchrome.so: 4776232 KB lib_unit_tests__library.so: 5308156 KB lib_components_unittests__library.so: 5383500 KB So 6GB will be sufficient for such builder. This also increase parallelism of proguard steps too. Bug: 804251 Change-Id: I7e8785ae3f14d8ba1f45da532585d7c61875d321 Reviewed-on: https://chromium-review.googlesource.com/1104280Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#569237}
-
Olivier Robin authored
For compatibility, make all callbacks return false when is_main_frame is false (current behavior). Bug: 823285 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0bd4c7d1561df87f80c88b37e2342e4589a1fd24 Reviewed-on: https://chromium-review.googlesource.com/1105989Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch adapts accessibility module to LayoutNG by: * Make |AbstractInlineTextBox| as an interface like class and implements legacy version |LegacyAbstractInlineTextBox| using InlineTextBox and LayoutNG version |NGAbstractInlineTextBox| using NGPaintFragment. * Make |AXLayoutObject| to handle |LayoutNGListMarker| - |LayoutListMarker| has no children. - |LayoutNGListMarker| is a container of list marker. * Make |AXLayoutObject::ComputeAccessibilityIsIgnored()| to handle LayoutNG block flow to check empty block flow. * Make |NGPaintFragment::FragmentRange::iterator| to work with |std::next()| * Intrdouce LayoutText::GetFirstLetterPart() for ease of getting layout object for first-letter part from layout object for remaining part. Following patch will implements NGAbstractInlineTextBox::CharacterWidths() The doc,https://bit.ly/2kUEFZy, contains study and change details. TBR=dmazzoni@chromium.org Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iae25e8a7d7e6be0c7478470c690e081084476e85 Reviewed-on: https://chromium-review.googlesource.com/1104082 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569235}
-
Mathias Bynens authored
Per the HTML Standard, the recommended JavaScript MIME type is `text/javascript` and not `application/javascript`. We should use the former in all examples by default. This patch updates the CORB explainer accordingly. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8435745806eb04fdde9d44a9cb0133986d165ef8 Reviewed-on: https://chromium-review.googlesource.com/1109687Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#569234}
-
Colin Blundell authored
This CL just extracts some commonly-used logic into helper functions in preparation for introducing several more unittests that use this logic extremely heavily. There is more such extraction that could be performed for different pieces of code; this CL just focuses on the pieces that are relevant for the upcoming unittests. Change-Id: I83f86faa4679dc0639cc1abff561b640baff5816 Reviewed-on: https://chromium-review.googlesource.com/1101687 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569233}
-
Han Leon authored
As Service Worker IPCs are all in Mojo now, we no longer use ServiceWorkerDispatcherHost to handle any legacy IPCs, its only usage is to implement mojom::ServiceWorkerDispatcherHost interface, so, it no longer needs to be a BrowserMessageFilter. This CL makes ServiceWorkerDispatcherHost not a BrowserMessageFilter any more, but still keeps its Mojo interface being associated with the legacy IPC channel. In future once we make clear of those potential races with some legacy IPCs like navigation IPCs, we can consider putting mojom::ServiceWorkerDispatcherHost on a dedicated Mojo message pipe, or we'd remove mojom::ServiceWorkerDispatcherHost completely if we can find an alternative/clear way to achieve the same goal. BUG=845341 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9f764017832a5e2f9ff15aff9b49b4c2a6834b78 Reviewed-on: https://chromium-review.googlesource.com/1105623Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#569232}
-
Vasilii Sukhanov authored
The profile avatar opens the Chrome profile menu. This change adds 3 new menu items there. - Passwords -> chrome://settings/passwords - Payment methods -> chrome://settings/autofill - Addresses -> chrome://settings/autofill It's expected for M69 that Payment methods and Addresses link to the same page. The icon for addresses is just temporary. Bug: 854562 Change-Id: I7f5b62914e49b8e3ae9d882a7d6eaaf05a532100 Reviewed-on: https://chromium-review.googlesource.com/1108097 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569231}
-
Ned Nguyen authored
This reverts commit 3948b2b2. Reason for revert: root cause was fixed Original change's description: > Disable failing brows:news:cnn on webview system_health.common > > Bug: 854683 > Change-Id: I6cd308c8eadf151051916262c1d17530e85be0c1 > TBR: charliea@chromium.org > NOTRY: true > Reviewed-on: https://chromium-review.googlesource.com/1108396 > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568918} TBR=sullivan@chromium.org Change-Id: Id6aa4dd0526a4b6fea26d825cbca8e1639eebabe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854683 Reviewed-on: https://chromium-review.googlesource.com/1109997Reviewed-by:
-
Martin Šrámek authored
Bug: 854778 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9cfb73cb5a33085a89a127591d86c70da11171b4 TBR: penghuang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1109919Reviewed-by:
-
Sylvain Defresne authored
Those tests trigger code path that access the toolbar if there is an active WebState in the WebStateList. This requires that the WebState returns non-null BrowserState and NavigationManager so set the corresponding property on the TestWebState. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic950a706b31ac153cdfb71b510681c09886c3da0 Reviewed-on: https://chromium-review.googlesource.com/1106176Reviewed-by:
-
Mikel Astiz authored
In particular, remove any notion of 'bridge' and hence stop using ModelTypeChangeProcessor altogether, since it's irrelevant for testing ModelTypeController. Bug: 791939 Change-Id: I76abc5e3ff48fb73ecb943e17fd114b11ec5aed6 Reviewed-on: https://chromium-review.googlesource.com/1109822 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#569227}
-
Marc Treib authored
Previously, we cleared Sync data on most, but not all types of unrecoverable errors: Engine initialization failure was treated specially. Per the TODO removed in this CL, there was no reason for the special treatment anymore. Bug: 839834 Change-Id: I3b473c65b837c810e6fe8456defffe6ebe6e53a2 Reviewed-on: https://chromium-review.googlesource.com/1107991Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569226}
-
Mikel Astiz authored
They are motivated by an ongoing investigation for test flakiness on iOS, with the suspicion that some of the codepaths (namely, where calls to OnSyncStopping() could be dropped) can cause issues (e.g. sync metadata being leaked). Bug: 854446 Change-Id: I6fe7da40c36d00e01afa176334f59f9dc66a74e1 Reviewed-on: https://chromium-review.googlesource.com/1108200Reviewed-by:
-
Vasilii Sukhanov authored
The UI needs the new password value. Thus, the method is needed in ChromePasswordManagerClient. Also it doesn't seem right to scatter all the generation events across two interfaces while autofill::mojom::PasswordManagerClient solely concentrates on generation. Bug: 851021 Change-Id: I6a6dcc59a934202bb0e2e336ff1324da131c6dfd Reviewed-on: https://chromium-review.googlesource.com/1104339Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569224}
-
Morten Stenshorne authored
And that's how it's supposed to work, apparently. We're just supposed to mark such lines dirty when the objects get deleted, and the dangling pointers will be cleaned up "soon enough". When removing a FloatingObject, we need to mark the RootInlineBox object that points to it as dirty. The case we were missing was the one where we remove ALL floating objects. When removing just one, on the other hand, we use LayoutBlockFlow::RemoveFloatingObject(), which already takes care of this. Bug: 835613 Change-Id: I2b978f1bb4c9a496a5dad4b097ef598630059a9d Reviewed-on: https://chromium-review.googlesource.com/1108936 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#569223}
-
Philip Jägenstedt authored
SpeechGrammarList's addFromURI because it doesn't match the spec: https://github.com/w3c/speech-api/issues/26 SpeechRecognitionEvent's interpretation and emma attributes because they actually always return null and might be better to remove: https://chromium.googlesource.com/chromium/src/+/7ad6ea7c2583942e86017bdd6fd5df991f6a05af/third_party/blink/renderer/modules/speech/speech_recognition_event.h#55 SpeechSynthesis#speak() to measure real SpeechSynthesis usage, like the existing counter for SpeechRecognition#start(). Bug: 755287 Change-Id: I4f7fdcc5630887aaa051ac8ab13f72dab52c8dfb Reviewed-on: https://chromium-review.googlesource.com/1109510Reviewed-by:
-
Gyuyoung Kim authored
Although there have been the thresholds of cache usage limitations for the Android in /gpu/config/gpu_preferences.h, it would be good if we can give embedders the power to set the cache size for the ShaderDiskCache. Because there are many various embedded devices which have different sizes of disk. Bug: 854494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie1ecb903a79e52ee79503df30fe1ae15b95739ea Reviewed-on: https://chromium-review.googlesource.com/1107517 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569221}
-
