- 26 Mar, 2020 40 commits
-
-
Peng Huang authored
This is a reland of 838eb034 Original change's description: > VulkanImage: support create from GpuMemoryBufferHandle on Android > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > Bug: None > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753394} TBR=rjkroege@chromium.org,vasilyt@chromium.org Cq-Include-Trybots: luci.chromium.try:android_archive_rel_ng Bug: None Change-Id: Ie6132474ef4a386ed661116aa8f580fd8460901d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121442Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753501}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e1d6f39d..3714932e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30d3fc19f46e39f3c209e67c372d857c59127b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753500}
-
Marijn Kruisselbrink authored
Bug: 1064795 Change-Id: Ib9999b6b2366872a92c508a292e8268936d54109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121416 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753499}
-
Eriko Kurimoto authored
This CL removes the test expectation for shared worker parse error failure wpt which is exported from external Github. The timeout is fixed for module shared worker in the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2100058 Bug: 1058259 Change-Id: Ifb5e4ccdb352d13cb3b4e9d42889ef3574c2e7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121114Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#753498}
-
Ted Choc authored
This loosens the requirement that the activity is destroyed and allow a single SearchActivity to be in the finishing() state to determine success. BUG=1064092 Change-Id: I8149b1676d7dad21c508ae45464a1b12f2195f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121457Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753497}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I773f7e364ccc9e46095bed6a21447c977c1cdcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121656Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753496}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71cb6fda55ac..c2d325c1d67a git log 71cb6fda55ac..c2d325c1d67a --date=short --first-parent --format='%ad %ae %s' 2020-03-26 reed@google.com emptyshader should fail onProgram Created with: gclient setdep -r src/third_party/skia@c2d325c1d67a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I2f9b3c40c41a9b2bb7b6a345e839c858c2e724f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753495}
-
Hayato Ito authored
Bug: 1064839 TBR: davve@opera.com Change-Id: Ia74ae7cff46dba3e1ed01fad9b1deac02bfa41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121635Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#753494}
-
Brandon Wylie authored
This logic is unnecessary because tablets always have the status view visible. Bug: 1059898 Change-Id: I37fcf536c71945ec844b346216495048315b44c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121088 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753493}
-
Emily Andrews authored
This change removes the //mojo copy of zip.py and updates mojom.gni to use the one from //build/android Bug: 582594 Change-Id: I8e739c112696c47ce3afb68baf61b139359c5e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119636 Commit-Queue: Emily Andrews <emiled@microsoft.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#753492}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/34f71abca1a1..de6c45646618 git log 34f71abca1a1..de6c45646618 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 sokcevic@google.com Fix max value for git_common threading 2020-03-25 adrexler@google.com Use console url for recursive gsutil operations. Created with: gclient setdep -r src/third_party/depot_tools@de6c45646618 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ibb7e60517b4ce481b0226ad672266a5a5377bda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121546Reviewed-by:
-
Bo Liu authored
There are two options to implement a callback for title changes. * Implement callback for when the active nav entry changes, and a callback for when the title of the nav entry changes * A callback for when the title of a tab changes, ignoring details about things like navigations. This CL takes the second option, since it's both simpler to implement and simpler to use. Bug: 1060997 Change-Id: I5ed1a3e41abcf5f7d7cf3c65cbd94533e8d9c36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115695 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753490}
-
David Tseng authored
TBR=dtseng@chromium.org Fixed: 1033649 Change-Id: I57b0ec7feaff6d07d0be16f626bfc6c46446699c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119767Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753489}
-
Julie Jeongeun Kim authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs, a test assertion describing its purpose, and a ref link. Bug: 1063749 Change-Id: I0d0850d82caaf1ac3bdfb55e28179592ea5bdf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120080Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#753488}
-
Rohit Rao authored
BUG=1024115 Change-Id: I78dd1f2c79467f22cf8917d95be395f52c5343d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119750 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#753487}
-
Joshua Bell authored
The tests have moved to have a '.https' infix, so these expectations (files and entries) are unused/obsolete. Change-Id: I8c305115f3277e63510b1d3fb06ac8061b9f1b62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121356 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#753486}
-
rbpotter authored
Bug: 1026426 Change-Id: I54d838a9832a2540b2603aab936d4cd44f31eb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119870 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#753485}
-
Lukasz Anforowicz authored
NetworkService was incorrectly using "bad_message_reason" crash key name when reporting a bad mojo message. This CL switches to using the correct "mojo-message-error" name (one that is recognized by the crash analysis services). This CL also moves the crash key definition to the //mojo layer, so that it can be reused both from //content and from //services/network. Bug: 987986 Change-Id: I772ae563df2f62ea430235524397b8492455de23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118690Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#753484}
-
Christopher Cameron authored
This access was previously living in apps/platform_apps, and using extension mechanisms. In a previous patch, I had moved AppShimRegistry into apps/app_shim. This was a mistake -- AppShimRegistry is only for web apps (not for all app shims). Move it to be in web_applications/components, and update it in web_app::AppShortcutManager. R=loyso TBR=avi (chrome/) Bug: 1057195 Change-Id: I284a56b472fde55f33f30a84c5959a68e4f0a04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116564 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#753483}
-
Kenichi Ishibashi authored
ServiceWorkerUtils::CreateResourceResponseHeadAndMetadata() assumes that |http_info->headers| is always set. We plan to use the function in crrev.com/c/2108260 to convert HttpResponseInfo to URLResponseHead. This CL is a preparation for the conversion so that we don't need to add a check in the function. See [1] for more detailed context. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2108260/3/content/browser/service_worker/service_worker_cache_writer_unittest.cc#b33 Bug: 1060076 Change-Id: I2a34b78ba47b3ff67a4659975b09151b5f03bec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120993Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753482}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/046389926f10..d5db214564bd git log 046389926f10..d5db214564bd --date=short --first-parent --format='%ad %ae %s' 2020-03-26 jiawei.shao@intel.com Collect if a storage texture is declared as multisampled in shader Created with: gclient setdep -r src/third_party/dawn@d5db214564bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibc7e548525838506ca6f0aaee5301c12a5998d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121544Reviewed-by:
-
Julie Jeongeun Kim authored
Migrate this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ia91dac770baad6695673f54c776b053d3851ead7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119294Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0090b85f. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 39f5c78d "Reland test for lost pointercapture in disconnected node in shadow dom" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dtapuska@chromium.org: external/wpt/uievents NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I462da7ed6bf0c533e523082d32d47555d5717153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121276Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753479}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3ca8bc5a4a86..d5a3755f19aa git log 3ca8bc5a4a86..d5a3755f19aa --date=short --first-parent --format='%ad %ae %s' 2020-03-26 changhaohan@chromium.org Adds check to ensure style pane update Created with: gclient setdep -r src/third_party/devtools-frontend/src@d5a3755f19aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060267 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iab6e656094b2ee4a49f6311f5a67182b8571f2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121545Reviewed-by:
-
Ian Wells authored
Bug: 1044139 Change-Id: I01a0d041b67e2923d67a5cded6b92f784efd3a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121049Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#753477}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7510f0675df..b69c4e14c5e2 git log a7510f0675df..b69c4e14c5e2 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 cnorthrop@google.com Capture/Replay: Update CaptureReplay sample for compression 2020-03-25 cnorthrop@google.com Perf: Add a single Manhattan trace Created with: gclient setdep -r src/third_party/angle@b69c4e14c5e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I7524d3c01d111f0e6733a649c7b305087f3d0c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121231Reviewed-by:
-
Theresa Wellington authored
Add a suite of tests verifying Android NMR1+ launcher shorcut behavior. BUG=632541 Change-Id: I4603610989fe145bbe410ad51c0900036bcb468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121083 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Lei Zhang authored
Verify the PDF plugin can successfully report metrics. Currently, the plugin reports metrics using the PPAPI interface, but that will change in the future. Make sure metrics continue to work, and help prevent issues like https://crbug.com/1043019 from happening. Change-Id: I0306247a320040231b8f47a4981a45fcff689ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119204 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#753474}
-
dpapad authored
Bug: 1026426 Change-Id: I35b0fd47a1662d600779a904a18f99f163087c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119583 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753473}
-
Daniel Hosseinian authored
crrev.com/752905 moved the definition of PrinterStatus out of cups_jobs.h, and named the new file with the assumption that it will only be built on ChromeOS. Given that CUPS IPP will be supported on macOS in the near future, this naming was not appropriate. Do the same thing with PrinterQueryResult. Bug: 226176 Change-Id: I54e99b63f40221a832ab95196c8c9c14ba7f2011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121081 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753472}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ba92999..e1d6f39d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d150dcc479b41f86d8eefd5f6e4450c96d09755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121277Reviewed-by:
-
David Tseng authored
General strategy: - perform all actions (sm_.Call) - gather pending utterances - mix in Expect* calls between all Call actions (incrementally from the top) - keep the tests mostly simple (limit UI interactions) to prevent flakes - do use the async SpeechMonitor api which should be less flakey - deleted one test who's behavior is still in flux (empty panel menu behavior) Some tests were still failing but due to external factors. Comments left. Change-Id: I7689880dbeeac3b31fe22a8029fae5078d975f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119382 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#753470}
-
Noel Gordon authored
Block hover rules for inactive toolbar <cr-button>. Add focus rings to these toolbar <cr-button> only if the keyboard is active. And add TODO note about these rules applying in files-ng and not. Bug: 1062902, 992824 Change-Id: Ib4d670abc38aca455d03c4c01c1017bfec666937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120553Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753469}
-
Danan S authored
This refactor was motivated by revert 71f516df. Background: There was an ASAN error that occurred in certain test cases where the ParentPermissionDialog was deleted from beneath itself before it was able to set its dialog_closed_callback_ member, causing a use-after-free. The use-after-free was caused by the way this feature was originally implemented: 2 objects with distinct lifetimes separately managing the view and workflow of the ParentPermissionDialog. The 2 objects spanned sections of the codebase (ui and views) which have dependency restrictions that made it very challenging to coordinate the lifetime of objects across them. Furthermore, the flows in this code are full of asynchronous sections that necessitated an extra callback-based message passing interface between the 2 objects. This CL consolidates all the existing to a single object: ParentPermissionDialogView, thereby removing most of the aforementioned dependency and object lifetime management complexity. The API for creating the dialog remains in parent_permission_dialog.h, however it is now in a much simplified form, consisting of a simple control interface and Show() functions. Original change's description: > Revert "Changes to Webstore Private API to support child extension installation" > > This reverts commit 99ffda8e. > > Reason for revert: browser_tests failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37129 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18174 > > Original change's description: > > Changes to Webstore Private API to support child extension installation > > > > These changes are required in order to prompt a child user to get > > parent permission when they attempt to install an extension in the > > Chrome Webstore. > > > > This CL also enables the feature by default. > > > > Bug: 957832 > > Change-Id: I3a2011b418e31dd491fd35e37d976b492eef197b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079620 > > Commit-Queue: Dan S <danan@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#749436} > > TBR=karandeepb@chromium.org,danan@chromium.org > > Change-Id: If262ccd3dad279dc60e849f9780e340b18d7384c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 957832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100891 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749726} Change-Id: Ia217f68502a6fe8719614b1322af74aeb02f3319 No-Presubmit: false No-Tree-Checks: false No-Try: false Bug: 957832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100548 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
-
Maria Villarreal authored
Per guidance, this changes the color used in message_view to kColorId_UnfocusedBorderColor. Bug: 1056950 Change-Id: Ibe265a94c5552e01f7d5cbd330e42a940854f164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117291Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753467}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6f84edeb857..8351d2182b54 git log d6f84edeb857..8351d2182b54 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 crouleau@chromium.org [Catapult] Remove myself from OWNERS. Created with: gclient setdep -r src/third_party/catapult@8351d2182b54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1059913 Tbr: skyostil@google.com Change-Id: Ib8a956bcc35b324182c146e736ad3b6c6605ad40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121537Reviewed-by:
-
Anatoliy Potapchuk authored
This part of Web kiosk launch was lacking test coverage. Now it does not. Also, we add window name to the created window so it does not fail on DCHECKS. Bug: 1046364 Change-Id: I569ad66061515bd18fef38e7e150a2c21be0ef3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116081Reviewed-by:
Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753465}
-
Zain Afzal authored
At the moment media-app receives a file list with only 1 item in it. This CL updates the launch code to send over all files in the current directory if the app was launched via the files app. This is part of a larger set of CLs to expose more directory methods and data to the guest frame. Bug: 996088 Change-Id: I485bbe143fcc953c8cd189ded30d0cf23f337fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108453Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#753464}
-
Gyuyoung Kim authored
This CL moves auto-height-column-with-border-and-padding.html test from css/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs and a ref test link. Bug: 1063749 Change-Id: I6751269ba56911615f236d57216e792b64410cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117555Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Yoichi Osato authored
First, I broke the calculation by change initialization order: https://chromium-review.googlesource.com/c/chromium/src/+/1948393 That caused apparent memory improvement. Then another my CL fixed the order: https://chromium-review.googlesource.com/c/chromium/src/+/2099668 Now bots computes memory size appropriately as same as before. This CL adds a test so that no such false regression. Bug: 1062837 Change-Id: If76707cae97f0037664facd901bfea45241c66f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114479Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#753462}
-
