- 26 Feb, 2018 40 commits
-
-
Guido Urdaneta authored
Bug: 816323 Change-Id: I5345d13037105374ad8ca062e8c55a4dec13d9e4 Reviewed-on: https://chromium-review.googlesource.com/937222 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#539120}
-
https://chromium.googlesource.com/catapult.git/+log/8a42ad3cb185..38ba657f018a $ git log 8a42ad3cb..38ba657f0 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 perezju Revert "[Telemetry] Simplify code for --browser=exact on Android" 2018-02-24 nednguyen Add logging of when tracing metrics computation started 2018-02-23 dtu [pinpoint] Ignore CIPD packages in DEPS. 2018-02-23 dtu [pinpoint] Fail Job if all Attempts fail. 2018-02-23 eakuefner [Dashboard] Filter stats using REs 2018-02-23 eakuefner Add a couple AUTHORS 2018-02-23 eakuefner [Dashboard] Suffix histogram names rather than test paths 2018-02-23 perezju [Telemetry] Fix usage of last_modification_time in possible browsers 2018-02-23 kraynov Group rendering in AsyncSliceGroupTrack. 2018-02-23 perezju [Telemetry] A bit of cleanup on Android browser backend settings 2018-02-22 perezju [Telemetry] Simplify code for --browser=exact on Android Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I133002d56cbcd0b9149ea7dbac1e98be26233285 Reviewed-on: https://chromium-review.googlesource.com/936791 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539119}
-
Darren Shen authored
This patch adds tests for properties taking an <image>. There are some failing tests due to keywords not implemented in Blink yet. Bug: 774887 Change-Id: Ie5fa1fa15a16440273517afdd62b078449e615e4 Reviewed-on: https://chromium-review.googlesource.com/928056 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#539118}
-
Darren Shen authored
font-weight is clamped to [0, 1000], so we have to change the out of range code to handle upperbounds too. Test failure because we seem to be rounding the font weight, but the spec doesn't say we should. Bug: 774887 Change-Id: I75d283dc32d37e04633133fe420817d02953d4e3 Reviewed-on: https://chromium-review.googlesource.com/936722Reviewed-by:
-
Raphael Kubo da Costa authored
--allow-local-commits was removed in 4a301c5f ("Remove the --allow-local-commits flag from wpt-import") so stop recommending its usage. Additionally, given the amount of export commits we have in web-platform-tests it is likely that unauthenticated runs will fail, so explain how to use the --credentials-json option in both wpt-export and wpt-import. Bug: 816390 Change-Id: I72d7bc6dcb80d0db372e9dac1176f68d1b812bcb Reviewed-on: https://chromium-review.googlesource.com/937241Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#539116}
-
Elad Alon authored
Make sure that ToString() would produce distinct strings for distinct tokens. Bug: 815217 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I38ea5bfad061610e95945eb31187cb3c02f737cf Reviewed-on: https://chromium-review.googlesource.com/934824Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#539115}
-
Gyuyoung Kim authored
Although r525634 updated the URL type of registerProtocolHandler from DOMString to USVString, it didn't add a test case because it was a bit complex. Though it's still hard to add a test case for it, this CL adds a rough test case for now. Bug: 790860 Change-Id: Ia688494293274ab2c0aa62f9e33a588ca80d2a82 Reviewed-on: https://chromium-review.googlesource.com/933668Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#539114}
-
Rakina Zata Amni authored
This change is the continuation of crrev.com/c/898762. With this change, a list of constructed stylesheets can be assigned to TreeScope's moreStyleSheets andthe TreeScope will update its style (lazily). This change also adds handling of disabled and alternate stylesheets. Spec draft: https://wicg.github.io/construct-stylesheets/#dom-cssstylesheet-cssstylesheet Bug: 807560 Change-Id: If6bc583d9923b193d6b308f48900e4979ff5bf4e Reviewed-on: https://chromium-review.googlesource.com/925763Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#539113}
-
Alexander Timin authored
Introduce a WorkerSchedulerProxy to allow WebFrameSchedulerImpl and WorkerSchedulerImpl to communicate, in particular allow to notify WorkerScheduler about page visibility changes. WorkerSchedulerProxy will be owned by DedicatedWorkerThread all will be guaranteed to outlive WorkerScheduler. R=skyostil@chromium.org,alexclarke@chromium.org,haraken@chromium.org,nhiroki@chromium.org BUG=776416 Change-Id: I40e1431990e2d114cdb7fe918e1db83d91583a8a Reviewed-on: https://chromium-review.googlesource.com/886364Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539112}
-
Vikas Soni authored
In linux and android, we are seeing an issue where texture data from one tab overwrites the texture data of another tab. This is happening for apps which are using webgl2 texture of type TEXTURE_2D_ARRAY/TEXTURE_3D. Due to a bug in virtual context save/restore code for above texture formats, the texture data is not properly restored while switching tabs. Hence texture data from one tab overwrites other. This CL has fix for that issue, an update for existing test expectations and a new unit test for this bug. Bug: 788448 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie933984cdd2d1381f42eb4638f730c8245207a28 Reviewed-on: https://chromium-review.googlesource.com/930327Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#539111}
-
Ivan Afanasyev authored
Facebook.com may perform |SameDocumentNavigation| on login form submit. User password will be saved even if it is wrong. The changeset disables trigger on action changes. Change-Id: I4103661fb9649280862229248f329da23dcc8912 Bug: 808917 Reviewed-on: https://chromium-review.googlesource.com/897638Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Иван Афанасьев <ivafanas@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#539110}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a60e311..89d5d57b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I442adcb63453fef7daadc124855d22dc40661fa2 Reviewed-on: https://chromium-review.googlesource.com/936672Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539109}
-
Pavol Marko authored
Write out explicitly that these policies are intended to match the user policy values, and that if they don't match, a chrome process restart will be performed on user session start, leading to a delay. BUG=800117 TEST=none Change-Id: Ic458ac006d8ffe80460d3f021d0a8fb99837b63f Reviewed-on: https://chromium-review.googlesource.com/926129Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#539108}
-
https://skia.googlesource.com/skia.git/+log/a58cd1ba9fe8..904b08cf1fc0 $ git log a58cd1ba9..904b08cf1 --date=short --no-merges --format='%ad %ae %s' 2018-02-26 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 81aa15f10..3582c0e2c (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ib92ecf5c43835ac872913e7eb67c14b0a98b4d27 Reviewed-on: https://chromium-review.googlesource.com/937062 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539107}
-
François Beaufort authored
This CLs makes sure fullscreen videos don't enter automatically Picture-in-Picture if the disablePictureInPicture attribute is set on the video element. Test page: https://beaufortfrancois.github.io/sandbox/media/disable-pip.html Bug: 806249 Change-Id: I3621ef58c8f1778d54865eca6cc30a736994d493 Reviewed-on: https://chromium-review.googlesource.com/918421 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This CL is just relanding https://chromium-review.googlesource.com/c/chromium/src/+/597482, after confirming that there are no statistical significant regressions in the real world by Finch experiments (crbug.com/755489). Note that this might still cause Telemetry regressions reported at crbug.com/753071 before, but this is expected. A document is leaked because AutofillAgent hold a lastly used element even after navigation happens, and the document of the element remains until a new (input) element is focused. This CL fixes this issue by resetting the element in AutofillAgent when navigation happens. Bug: 734427, 755489 Change-Id: Ie3ee7f202abf56e22102e3d7f68cf2778f85ca87 Reviewed-on: https://chromium-review.googlesource.com/908371 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#539105}
-
Piotr Tworek authored
Right now the file used to pass command line parameters to test- processes is not removed after the test finished. In cases where tests are run in repeat mode those flag files just keep accumulating until the system runs out of space in it's $TMPDIR. To solve this, the patch makes sure the path to the file containing the flags is stored in UnitTestProcessLifetimeObserver and removed once the OnCompleted method is called. Bug: 814687 Change-Id: Ifb0ba6dba860d9297fbc2c939e0cc10f620907fa Reviewed-on: https://chromium-review.googlesource.com/931341 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539104}
-
Piotr Tworek authored
When building the code with clang the compilation fails due to the following error: "invalid use of a cast in a inline asm context requiring an l-value: remove the cast or build with -fheinous-gnu-extensions" Doing the cast outside of __asm__ block fixes the problem. R=jar@chromium.org Bug: 794147 Change-Id: I49bcdbd3d4177cbdafa37ffc2d12983db1fe7621 Reviewed-on: https://chromium-review.googlesource.com/822411Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#539103}
-
vasilii authored
Bug: 782287 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I534f2b892efe8d2af08bbea6ee724c38509a55c9 Reviewed-on: https://chromium-review.googlesource.com/926581Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#539102}
-
Christian Dullweber authored
When only a single Tab is left after deleting tabs from a Window in TabRestoreService, the Window should be converted to a Tab. Fix another case where tabstrip_index was used incorrectly as it might not be valid. Bug: 407074 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86f49969ea83a0771634be554541aab92334a967 Reviewed-on: https://chromium-review.googlesource.com/931706Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#539101}
-
https://chromium.googlesource.com/angle/angle.git/+log/81aa15f10682..3582c0e2c3c1 $ git log 81aa15f10..3582c0e2c --date=short --no-merges --format='%ad %ae %s' 2018-02-22 oetuaho Add a test for redefining an unavailable built-in Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic4ac0d13123092c525e0a56f34e1f890512f8a19 Reviewed-on: https://chromium-review.googlesource.com/936436Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539100}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8d963dab. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/12960 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: I37166a58ef4e1372355858bb8f15a213bac5470e Reviewed-on: https://chromium-review.googlesource.com/937082 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#539099}
-
Zhuoyu Qian authored
Move FindEventTargetFrom() out of |Editor| to make class simpler for improving code health. BUG=672405 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ib8ed084702ffbb58eb438eb83d59ed0c43f71233 Reviewed-on: https://chromium-review.googlesource.com/933684Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#539098}
-
Jochen Eisinger authored
BUG=812293 Change-Id: I1375ecbdef13ea43ac350cdae6e550267166fadc Reviewed-on: https://chromium-review.googlesource.com/934204Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539097}
-
Gyuyoung Kim authored
The latest spec changed DOMString type of Document.origin with USVString. - https://dom.spec.whatwg.org/#document This CL applies USVString type into the Document.origin in order to meet the change. Bug: 790860 Change-Id: Ibd1fafa28a6e999f7d3085aa7bb4cca0f92d8b2b Reviewed-on: https://chromium-review.googlesource.com/928005 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#539096}
-
Gabriel Charette authored
SchedulerWorker can touch SchedulerWorkerPoolImpl through SchedulerWorker::delegate_->outer_. This could cause use-after-free in tests (not a problem in prod because we never join workers nor destroy the scheduler/pools) because SchedulerWorkerPoolImpl no longer accounts for a SchedulerWorker after invoking SchedulerWorker::Cleanup and hence will not join it in JoinForTesting() before it is itself destroyed. Before this CL: a SchedulerWorker could access SchedulerWorkerPoolImpl after Cleanup() and hence potentially use after free if the pool is destroyed before the detached thread completes execution. This CL reinforces JoinForTesting() to wait for all workers that ever had a reference to |this| (i.e. its |workers_| + any recently reclaimed workers). Added TaskSchedulerWorkerPoolTest.RacyCleanup as regression test although it passes in most scenarios without the fix because this race is hard to exercise... And added a DCHECK on start that the requested pool size isn't greater than kMaxNumberOfWorkers (as I tried to add 1000 worker in my new test and had to debug why it hung until I rediscovered this intentional behavior). Bug: 810464 Change-Id: Ibaefb5446d462c325e4ddfd34a54ad3c448c1417 Reviewed-on: https://chromium-review.googlesource.com/931547 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#539095}
-
Yuki Shiino authored
Applies the same fix as https://crrev.com/c/924104 to IntersectionObserver, too. Unfortunately, I cannot reproduce the crash for IntersectionObserver, and I'm not sure if this fix is actually effective or not. However, seeing the same fix worked (at least partially) for ResizeObserver, I'd like to apply the same fix to IntersectionObserver, too. Bug: 815058 Change-Id: I0e89cd56ab4915457178b38623daadc0be20c927 Reviewed-on: https://chromium-review.googlesource.com/934483 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#539094}
-
Rune Lillesveen authored
We used OriginalStyleForLayoutObject which doesn't update animations or stacking context. Hopefully a better fix for 813348. Bug: 813348, 813439, 813836 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I93584261a935c4813f618a9291d384a5b1203ec7 Reviewed-on: https://chromium-review.googlesource.com/924705Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#539093}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6198dc41..4a60e311 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I08c0d9e6075b924bca01a3fa37ac7f3a4f6716a6 Reviewed-on: https://chromium-review.googlesource.com/937081Reviewed-by:
-
Ricky Liang authored
Some application (e.g. Hangouts) closes the camera explicitly on system suspend. As the Chrome OS VCD also closes the camera on system suspend without going through the full destruction of the VideoCaptureDevice, this results in StopAndDeAllocate being called back-to-back. The second call to StopAndDeAllocate should simply return if the device context is already destroyed. BUG=b:73436939 TEST=unit tests TEST=Verify that Hangouts call works correctly on Soraka when system suspends Change-Id: Id6127b751ccc5bc71538d622bc0905bf03951e0d Reviewed-on: https://chromium-review.googlesource.com/930605Reviewed-by:Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#539091}
-
Zhuoyu Qian authored
Editor::PasteAsPlainText() is only called by PasteAsPlainTextWithPasteboard() in EditorCommand.cpp. Move it to make |Editor| class simpler for improving code health. Bug: 672405 Signed-off-by:
-
Takashi Toyoshima authored
This patch introduces cors::PreflightController that will handle URLLoader interfaces to make CORS-preflight request and response for CORS-preflight enabled request from CORSURLLoader in the near future. This will also own a unified CORS-preflight cache. The first patch implements a function that takes an original ResourceRequest and creates a ResourceRequest for a CORS-preflight request. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iad50a2d297e445bacca8c3fdb364b942d237b5aa Reviewed-on: https://chromium-review.googlesource.com/923907 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces |getSelectionInFlatTree()| in |window.internals| and utilize it into |selection_test()| to write tests for selection in shadow DOM tree, e.g. selection in INPUT[1]. The return value of |getSelectionInFlatTree()| is |StaticSelection|, which is introduced by this patch. Changes in "assert_selection.js" and "assert_selection.html" shows how to use |getSelectionInFlatTree()| and |StaticSelection|. Expectation of "fast/dom/shadow/selection-in-nested-shadow.html" is updated to show actual selection position instead of adjusted to document scope selection, e.g. selection in shadow root is adjusted to selection before shadow host in document scope. [1] http://crrev.com/c/930841 Sanitize computed start and end positions Change-Id: Ib871c77dd16834459297b68b6664a93d6dce57c7 Reviewed-on: https://chromium-review.googlesource.com/934062Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539088}
-
Hitoshi Yoshida authored
Web IDL has no definition of bool/int. We should use boolean and long instead. Bug: 816352 Change-Id: Icf55c6adda4898e0490b51a46e2755dd432f4552 Reviewed-on: https://chromium-review.googlesource.com/936347Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
tzik authored
This CL replaces a legacy Closure in OpenFileCallback with OnceClosure as a preparation of the full migration of fileapi to OnceCallback. As it's in a function signature, it had blocked the incremental migration. Change-Id: I53471c0a178687fcb9ab97365e0421a124fc3575 Reviewed-on: https://chromium-review.googlesource.com/933883Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#539086}
-
Francois Beaufort authored
This CL exposes a new internal setting that determines whether Picture-in-Picture is enabled and if the user has disabled Picture-in-Picture for Chrome using the system's per-application settings. This setting is used in document.pictureInPictureEnabled and video.requestPictureInPicture(). Test page: https://beaufortfrancois.github.io/sandbox/media/picture-in-picture-enabled Screenshots: https://i.imgur.com/nLL3l0U.png Recording: https://drive.google.com/file/d/1DgIH8XPPGr7giPvaFQ8bvDd_WM-1lzSj/view Bug: 806249 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a4a8ca69c8b53a4bce3d8375c16725b3e545d52 Reviewed-on: https://chromium-review.googlesource.com/922081Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#539085}
-
Hajime Hoshi authored
MatchesPattern can be called from multiple threads on single process mode, and this caused crash on ASAN-built Chromium. This CL fixes this issue by making MatchesPattern thread-safe. Bug: 812182 Change-Id: Ibbb3df96264e28fffd0b8e0581f36c6294e02036 Reviewed-on: https://chromium-review.googlesource.com/921302 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
This reverts commit 588d8a94. Reason for revert: Some CTS/GTS tests has failed due to the CL. Original change's description: > v4l2: Remove GLImage from OutputRecord > > When GLImages were introduced to v4l2 in crrev.com/c/517883 to replace > EGLImages, a scoped ref to a GLImage was added to OutputRecord in place of > the EGLImage. > > This was not necessary since when we bind the GLImage in GLES2 cmd decoder, > the decoder increases the ref count and keeps the GLImage alive. > > Additionally, copying the scoped_refptr<GLImage> in a different > thread than it was created, when we associate GLImage to OutputRecords, > causes a DCHECK to go off. > > This CL removes GLImage scoped_refptr from > V4L2SliceVideoDecodeAccelerator::OutputRecord. > > > Test: Youtube video on scarlet. Tried to close and open new tabs with videos. > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Idd2625996b177be35b7a67eab3d9ac8b3f8206d7 > Reviewed-on: https://chromium-review.googlesource.com/911841 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536139} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iafc4e43b6d99de251d18c45ec1efcb901d8a2e79 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/936882Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#539083}
-
Ramin Halavati authored
QuicChromiumClientSession::CreateOutgoingDynamicStream() implementation is replaced with NOTREACHED, and moved to a new function for testing purposes only. Bug: 656607 Change-Id: Idfcf2f96de59fd57d61395c142f6e60dec677e26 Reviewed-on: https://chromium-review.googlesource.com/934285Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#539082}
-
Zhuoyu Qian authored
Editor::DeleteWithDirection() is only called in EditorCommand.cpp. Move it to make |Editor| class simpler for improving code health. BUG=672405 Signed-off-by:
-
