GitLab

BUG=388560

Review URL: https://codereview.chromium.org/1093153003

Cr-Commit-Position: refs/heads/master@{#327247}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/80927b2..1fa112a

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1110893002

Cr-Commit-Position: refs/heads/master@{#327246}

Fixing two errors:
 - ERROR Unresolved dependencies.
   //:gn_only(//build/toolchain/linux:mipsel)
   needs //third_party/libjpeg_turbo:simd_asm(//build/toolchain/linux:mipsel)
 by including //third_party/libjpeg_turbo:simd_asm target
 only for x86 and x64, where it exists
 - incompatible pointer types in usrsctp
 by ignoring warnings for this module

TEST=gn gen out/mips-linux --args="is_debug=false target_os=\"linux\" target_cpu=\"mipsel\" is_clang=false"
     ninja -C out/mips-linux/ chrome

Review URL: https://codereview.chromium.org/1094793004

Cr-Commit-Position: refs/heads/master@{#327245}

I introduced this change in http://crrev.com/324246 but I now
think it's incorrect based on the fact that the UI thread
should already have COM initialized.

BUG=422522
TEST=audio plays

Review URL: https://codereview.chromium.org/1103383003

Cr-Commit-Position: refs/heads/master@{#327244}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef7cfd7..80927b2

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1103403003

Cr-Commit-Position: refs/heads/master@{#327243}

Original: https://codereview.chromium.org/1101733005/

CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship
and the indirection is no longer necessary. As a first step of merge, this CL
moves message handlers for CacheStorage API from the listener to the dispatcher.

BUG=474233
TEST=content_unittests --gtest_filter=CacheStorage*
TEST=run-webkit-tests http/tests/cachestorage/

Review URL: https://codereview.chromium.org/1111713002

Cr-Commit-Position: refs/heads/master@{#327242}

Bescause base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/1093823005

Cr-Commit-Position: refs/heads/master@{#327241}

Bescause base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/1062803009

Cr-Commit-Position: refs/heads/master@{#327240}

This CL turns const by value return values into const by ref

BUG=393155

Review URL: https://codereview.chromium.org/1105093002

Cr-Commit-Position: refs/heads/master@{#327239}

This would be useful in cases when on the same platform due to different version, AX tree may vary.
Please check below mentioned bug id for such kind of example.

BUG=423675

Review URL: https://codereview.chromium.org/844273002

Cr-Commit-Position: refs/heads/master@{#327238}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1107013002

Cr-Commit-Position: refs/heads/master@{#327237}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f4e0a33..ef7cfd7

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1111613003

Cr-Commit-Position: refs/heads/master@{#327236}

Some sites, notably techcrunch, in top25 were failing to reach readyState
complete or quiesence due to continual requests (possibly an artifact of
the wpr). As this benchmark normalizes/categories results, it shouldn't
be necessary to reach the same state on every run.

Also switches to a tighter tracing category which allows the reference build
to be re-enabled, since the metrics will not appear there until they are
valid to be consumed by the blink_style measurement.

BUG=479048

Review URL: https://codereview.chromium.org/1100853003

Cr-Commit-Position: refs/heads/master@{#327235}

When binding the data string to a callback, the existing code copies the data which can be 1MB+ sometimes.
Use scoped_ptr to avoid unnecessary data copy.

BUG=None

Review URL: https://codereview.chromium.org/1079943002

Cr-Commit-Position: refs/heads/master@{#327234}

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/media_galleries , metrics and nacl_host modules

BUG=466848

Review URL: https://codereview.chromium.org/1102233002

Cr-Commit-Position: refs/heads/master@{#327233}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6486c8e..f4e0a33

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1107283002

Cr-Commit-Position: refs/heads/master@{#327232}

Deleting ShortcutsDatabase on the UI thread results in destructing sql::Connection.
This results in disk IO and slows down shutdown.

BUG=480822

Review URL: https://codereview.chromium.org/1105843002

Cr-Commit-Position: refs/heads/master@{#327231}

BUG=469061
TEST=run newly added test

Review URL: https://codereview.chromium.org/1092573002

Cr-Commit-Position: refs/heads/master@{#327230}

Revert of CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1) (patchset #2 id:140001 of https://codereview.chromium.org/1101733005/)

Reason for revert:
I think this patch caused layouttest failures on the Blink tree, see crbug.com/481784 for details.

Original issue's description:
> CacheStorage: Merge CacheStorageListener into CacheStorageDispatcherHost (1)
>
> CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship
> and the indirection is no longer necessary. As a first step of merge, this CL
> moves message handlers for CacheStorage API from the listener to the dispatcher.
>
> BUG=474233
> TEST=content_unittests --gtest_filter=CacheStorage*
>
> Committed: https://crrev.com/34cbfce4cae255c11fb19059ea4a31166768cdcf
> Cr-Commit-Position: refs/heads/master@{#327199}

TBR=jsbell@chromium.org,nhiroki@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=474233, 481784

Review URL: https://codereview.chromium.org/1111703002

Cr-Commit-Position: refs/heads/master@{#327229}

(caused by 423d45cb)

BUG=481754

Review URL: https://codereview.chromium.org/1108173003

Cr-Commit-Position: refs/heads/master@{#327228}

1/2 chromium: this cl
2/2 blink: https://codereview.chromium.org/1100403004/

screen shot: https://code.google.com/p/chromium/issues/detail?id=466871#c61

BUG=466871

Review URL: https://codereview.chromium.org/1102263002

Cr-Commit-Position: refs/heads/master@{#327227}

BUG=429053

Review URL: https://codereview.chromium.org/1088563003

Cr-Commit-Position: refs/heads/master@{#327226}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/df4cf97d..c541d594

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1103273003

Cr-Commit-Position: refs/heads/master@{#327225}

* Adds cr-network-list and cr-expand-button
* Adds network-summary-item containing expandable network list
* Implements 'connect' functionality for selected networks

BUG=475667

Review URL: https://codereview.chromium.org/1100993002

Cr-Commit-Position: refs/heads/master@{#327224}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/95cc012..f4219dd

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1102273007

Cr-Commit-Position: refs/heads/master@{#327223}

In https://chromium-review.googlesource.com/#/c/267554/ we added a new
error code to ChromeOS update engine. This adds FilesystemVerifierError
to histograms.xml.

BUG=None
TEST=unit tests, pretty_print.py.
R=deymo@chromium.org

Review URL: https://codereview.chromium.org/1108843005

Cr-Commit-Position: refs/heads/master@{#327222}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/649b7e8b..6486c8e

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1104423004

Cr-Commit-Position: refs/heads/master@{#327221}

BookmarkModel::RemoveNodeAndGetRemovedUrls() does not require AsMutable
as sunction itself suggest RemoveNode and get its url, and parent() can
return non const pointer. So AsMutable() is not required in this case.

BUG=481500

Review URL: https://codereview.chromium.org/1104093002

Cr-Commit-Position: refs/heads/master@{#327220}

BUG=471928

Review URL: https://codereview.chromium.org/1104383002

Cr-Commit-Position: refs/heads/master@{#327219}

Server side logs indicate that device_id passed in refresh token
annotation request differs from device_id recorded on LST. Scenario is
not clear how device_id changes between minting LST and sending
annotation request.

It is possible that some programs/tools restore preferences to some
early state therefore removing devic_id from preferences and causing
generation of new device_id. This change adds histogram to see how often
this happens.

R=stanisc@chromium.org
BUG=481596

Review URL: https://codereview.chromium.org/1082853007

Cr-Commit-Position: refs/heads/master@{#327218}

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/611/steps/compile/logs/stdio

This fixes the following kind or warnings:

warning(clang): [chromium-style] Complex constructor has an inline body.
warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor.

BUG=467287
R=thakis@chromium.org,grt@chromium.org

Review URL: https://codereview.chromium.org/1111613002

Cr-Commit-Position: refs/heads/master@{#327217}

The reason of Trap.SigSysAction failure under TSAN was identified,
which was;
TSAN intercepts sigaction(), similar to MSAN. So, direct syscall
breaks its assumption. Fallback to sigaction() on TSAN.

TEST=Ran bots with tsan. Ran the failure test case with tsan=1 locally.
BUG=481297

Review URL: https://codereview.chromium.org/1103263003

Cr-Commit-Position: refs/heads/master@{#327216}

Limit form-less Autofilling to pages that look like checkout pages.

This should hopefully stem the tide of false positives on non-checkout pages, while preserving desired behavior on Best Buy and Apple checkout.

Fixing FormStructureBrowserTests: I went back and added <form>s that were present in the source pages but not in the local copies. I also added the original <title> tags, except for ones that did /not/ include any of the checkout keywords. For these, I added the checkout keywords to the title, so that the test still had some value (instead of passing trivially because the title was "Google Calendar" and not something like "Payment information").

BUG=471090, 477466
original review: https://codereview.chromium.org/1081803003/
TBR=brettw@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/1111583002

Cr-Commit-Position: refs/heads/master@{#327215}

For now, this only happens in debug builds.

BUG=369661
TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
TEST=Every other test on the planet.

Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
Cr-Commit-Position: refs/heads/master@{#327122}

Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc
Cr-Revert-Position: refs/heads/master@{#327152}

Review URL: https://codereview.chromium.org/1002803002

Cr-Commit-Position: refs/heads/master@{#327214}

In libevent, socketpair() is used. However, it will be prohibited
by seccomp-bpf in nacl_helper_nonsfi. As its preparation, this CL
stubs out signal.c, which is the only module calling socketpair().

TEST=Ran bots.
BUG=358417
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/1093113002

Cr-Commit-Position: refs/heads/master@{#327213}

These three binaries still don't quite build.

TBR=phajdan.jr@chromium.org
BUG=463528

Review URL: https://codereview.chromium.org/1106403002

Cr-Commit-Position: refs/heads/master@{#327212}

Previously, Display would read the device scale factor from the command
line in its ctor, but then screen would clobber it.  This meant that
the force device scale factor command line flag was silently ignored.

R=oshima@chromium.org,ccameron@chromium.org

Review URL: https://codereview.chromium.org/1111543003

Cr-Commit-Position: refs/heads/master@{#327211}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/12c2339..649b7e8b

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1108983003

Cr-Commit-Position: refs/heads/master@{#327210}

Make sure that we always include the dashboard reset link in any passphrase
prompt. Also ensure we use the term "sync passphrase" rather than "google
password". Lastly, use the passphrase time if its available.

BUG=481224

Review URL: https://codereview.chromium.org/1101373002

Cr-Commit-Position: refs/heads/master@{#327209}

Looks like it was there on the initial commit.

Review URL: https://codereview.chromium.org/1102673004

Cr-Commit-Position: refs/heads/master@{#327208}