- 06 Jun, 2020 40 commits
-
-
Daniel Cheng authored
Bug: 1059157 Change-Id: I03b2e9b1b6eaad6d8e24e54eb0f2287ec2953b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233603Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#775846}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591286362-902781b12ab9dd448871f9768174868838c7d326.profdata to chrome-win64-master-1591399286-b39212858debc8dd3bf1b48362b37180826018ff.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I75c7ed00ab134ffd0f001e2e7aed226b84c51196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775845}
-
Yuheng Huang authored
In <settings-subpage>, if preserve-search-term boolean is set, settings-subpage will save the subpage input term to the URL, similar to what settings page does to the settings search input. When user hits the back button, it will preserve the search input from the URL. At this moment only chrome://settings/siteData and chrome://settings/content/all have this flag turned on since they are the only places of search results link to another subpage. Bug: 1049887 Change-Id: I92782876f2e0ac3167fce6c4980914b4dab9b249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210731 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#775844}
-
Jeremy Roman authored
We don't want portals to be an avenue for download spam, and we aren't presently aware of uses that require downloads in portals. This is largely straightforward, but the non-chrome DownloadManagerDelegate was unfortunately left as a stub that never calls WebContentsDelegate::CanDownload (like the chrome/ one does). Accordingly, this CL expands it to a simplified version of what the chrome/ one does. The post-task was left because the TODO comment there insinuates that not doing so is risky. It would be straightforward to inline the posted task in the future if one wished to. This strategy is used instead of a NavigationThrottle, because NavigationThrottle only covers downloads that are initiated by navigation, but <a download> and other renderer-initiated downloads do not fire navigation throttles. AwWebContentsDelegate::CanDownload is removed because it was previously unreachable but is now reachable (because AwDownloadManagerDelegate does not override CheckDownloadAllowed), but behavior is otherwise preserved. Android WebView relies on AwDownloadManagerDelegate::InterceptDownloadIfApplicable for its download interception features. Bug: 967202 Change-Id: Ic019688aab81ebc92728bfd715bb10a5de3f36d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229463Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775843}
-
Clark DuVall authored
This will allow the policy to be shared with WebLayer. Bug: 1058364 Change-Id: Icd1f84983651a0f9ad37d518e9d6d3ea0fd0b09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233719 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#775842}
-
Tao Bai authored
- Add the optional dedicated preference for the unsent log info. - Save the unsent log info at each time the unsent log persisted. - Read the unsent log info at next browser startup. - Define the record method in UnsentLogStoreMetrics to record the count of the unsent samples, the count of the sent samples the percentage of unsent samples and the persisted logs size. Bug: 1076564 Change-Id: I1ba3018ae819ff6f350fbf6a1fe8d7dbf0d17e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224314 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#775841}
-
Jeremy Roman authored
Bug: 1051639 Change-Id: I69acc44899be204b720a66d3f420cf165addf7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227511Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ia8b5f7389132c6083ade9ac1b9ca517023ed57c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233693Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775839}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5a8e856b7e3347f09f0f339ec619eeb2919a1f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232817Reviewed-by:
-
Bo Liu authored
In an attempt to debug deserialization crashes, add a crash key for failures cases for deserializing CompositorFrame. Only add crash key for extra sanity checks during deserialization, not failures from data errors. Bug: 1072407 Change-Id: Icf26eef3d802605be4e9e3df60481ea7c6edc7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225594 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#775837}
-
Owen Min authored
It should be "allow PH to *do* something." Change-Id: Ibfae10fdb08e311dd30e387e44e1a1e0d9cdca6a Tbr: pastarmovj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233686Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775836}
-
Daniel Rubery authored
This CL adds code to the PhishingClassifier to extract a screenshot of the current page. It also sends this screenshot to the Scorer to determine if the visual model matches the given screenshot. Bug: 1068617 Change-Id: I9e4cb1ba8888fa76b116405611bf64280a87def0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226974Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#775835}
-
David Schinazi authored
We found an issue during interop with other R=renjietang@chromium.org our server by sending a packet that is larger than our receive buffer. That was because we were incorrectly shutting down the server on any read failure. The fix is to whitelist errors that we know do not cause the socket to become unusable. implementations: anyone can cause us to shutdown Change-Id: I32a20109aa345654ae225f64170f97274c9c36a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233823 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775834}
-
Alex Turner authored
While AdTracker::Will() already checks if |resource_name| is empty, in rare situations, the subsequent call to ToString() can still return an empty result. This is the cause of a rare crash. To fix this, we check whether the result is empty; if it is, we treat it in the same was as an empty |resource_name|. Bug: 1086832 Change-Id: Ie9d3a865c5a588a34f94034d55bba1ae67e6895e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225282Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#775833}
-
Brian Sheedy authored
This reverts commit 9c14eacb. Reason for revert: crbug.com/1091658 Original change's description: > Don't use @media with feature expressions in UA style. > > We don't support MediaValues based feature evaluation in UA stylesheet, > only matching media types. There was an instance of > (-webkit-min-device-pixel-ratio: 2) in mediaControls.css which would > always evaluate to true in the UA sheet, but not in the context of the > evaluator in the StyleEngine for dpr=1. That caused us to constantly > update active stylesheets for frame resizes because we thought the media > result would change. > > This also contributed to hide a bug on tweetdeck.twitter.com before we > optimized the ruleset invalidation for media query changes. > > This should not be a behavior change for the mediaControls stylesheet > since the removed query would always evaluate to true so that we would > always use the high resolution image. > > Bug: 1088340 > Change-Id: I23f582893b21db6f14903836d58608caa82e5577 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228848 > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775144} TBR=steimel@chromium.org,futhark@chromium.org,andruud@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1088340 Change-Id: I795bac8fd60b1e6892cb28f1247fae1e9ec822ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233708Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#775832}
-
Kevin McNee authored
This comment appears to have been duplicated from the caller (see the end of Portal::Activate). Bug: None Change-Id: I25b4cda9b7145c4caf39b2769c6af815855a4459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233614 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f7485b4bbeb..bb5b2a17c28a 2020-06-05 mtklein@google.com Revert "Split out coretext fontmgr factory." 2020-06-05 bungeman@google.com Split out coretext fontmgr factory. 2020-06-05 johnstiles@google.com Revert "Move JavaInputStreamAdaptor into third_party and add a LICENSE file." 2020-06-05 senorblanco@chromium.org Revert my recent change to WritePixelsNonTexture_Gpu. 2020-06-05 kjlubick@google.com [canvaskit] Roll 0.16.2 2020-06-05 mtklein@google.com port skx opts to old style 2020-06-05 bungeman@google.com Revert "Split out coretext fontmgr factory." 2020-06-05 johnstiles@google.com Move JavaInputStreamAdaptor into third_party and add a LICENSE file. 2020-06-05 kjlubick@google.com [canvaskit] Fix freeing of memory in computeTonalColors 2020-06-05 michaelludwig@google.com Initial clipShader implementation for SkClipStack and GPU 2020-06-05 johnstiles@google.com Fix constant output for Clamp FP when child processor is present. 2020-06-05 johnstiles@google.com Update HSL/RGB and color matrix conversion processors to use a child FP. 2020-06-05 bungeman@google.com Split out coretext fontmgr factory. 2020-06-05 bungeman@google.com Remove 'public' from disabled optional target. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I8798279522710365c1e2fbe8c20f2502571e9297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233096Reviewed-by:
-
Zach Trudo authored
Adds the ReportingClient, which allows for a unified method of creating ReportQueues. Bug: chromium:1078512 Change-Id: I8200272782322fe186ed8234d73a617426af7964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231739 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#775829}
-
Christian Biesinger authored
Bug: 1045668 Change-Id: Ic341735ddb1c014bdce7a16b5fe4bc5ea2f7b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233758 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#775828}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23313e21..9b08c186 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaba126d0e0794084821a56ae11263148d830ca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233170Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775827}
-
danakj authored
The test seems to not be flaky any more with improvements made to the web test harness for site isolation. If wrong.. we can revert and investigate. Local run of 20 runs had 0 failures and TestExpectations claims it was very flaky. R=vmpstr@chromium.org Bug: 891427 Change-Id: Ic36c6685c5f87f8d1a678a9f88b021f641f18d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232767 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Adrienne Walker authored
This patch supported WebView for the browser-side: https://chromium-review.googlesource.com/c/chromium/src/+/2190220 However, there was nothing to tell the renderer to also enable AppCache like ChromeContentBrowserClient::AppendExtraCommandLineSwitches does. This patch adds that same code for AwContentBrowserClient. This fixes webview tests when kAppCacheRequireOriginTrial is enabled. Bug: 582750 Change-Id: Iadc572e8a825225ffc4879ffedbd1bf14e8115af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233709 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775825}
-
Khushal Sagar authored
We currently rely both on the timing history and whether the main thread responded within the frame deadline to decide whether to prioritize impl side invalidations. The latter had a bug where we incorrectly assumed the main thread is missing deadlines when impl thread is high latency/swap throttled. Update the logic to account for the second case. R=sunnyps@chromium.org Bug:1086790 Change-Id: I0b163e99c2a2081518ba89b0743c9de9836ba8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217062 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#775824}
-
Henrique Nakashima authored
ChromeActivity uses EmptyTabModel, so this cannot be internal for now. Bug: 1090033 Change-Id: I3b95713a877113d23ea19c22f426029782cda4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228358 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#775823}
-
file:///Edward Trist authored
Currently, the permission prompt says "file:/// wants to show notifications" for file URLs, which isn't meaningful. This change replaces "file:///" with "This file". It: 1) Adds a new string for "This file" 2) Adds logic to PermissionPromptBubbleView to return the string for file scheme origins 4) Adds unit tests for PermissionPromptBubbleView to test this replacement in the accessible title Bug: 1078920 Change-Id: I57f3a7b61786e02ae1f2132dd1c81e4b4de652d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223933 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#775822}
-
Sammie Quon authored
Update the tooltip to say restore/maximize when the icon updates. Test: manual Change-Id: I62c8c186972c70e0689414bc65c1c137bd23485a Fixed: 1091183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232773 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#775821}
-
Andres Calderon Jaramillo authored
This CL makes the V4L2VideoEncodeAccelerator reject flush requests when using the image processor. This is because flush requests are only expected to come from Android clients and such clients don't need an image processor. Thus, instead of adding special code to handle flushes, we simply reject them. Test coverage is added to exercise the image processor path. This is done by introducing another parameter, 'scale', in the unit tests. If this parameter is true and the input mode is native (i.e., zero-copy path), we request that the VideoEncodeAccelerator scales the input frames to 75% prior to encoding which triggers the image processor. Unfortunately, platform_video_frame_utils.cc and video_frame_helpers.cc had to be fixed to correctly propagate a video frame's natural size which is necessary to convey the desired scaling. Note that it is not necessary to reject flushes in the VaapiVideoEncodeAccelerator because it does not yet use an ImageProcessor. Bug: 1090220 Test: video.EncodeAccel.* on scarlet, veyron_tiger, eve, and kukui. Change-Id: I3b3fee03cb7d35c0bc027cf9686e4a0535457dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226086 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#775820}
-
Yi Gu authored
Previously the test was marked as Timeout but it also fails sometime. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=snap-to-target-on-layout-change.html Bug: 1034789 Change-Id: I3c68dd9769f745389abba624cdd603cd1cba7fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233611Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775819}
-
Finnur Thorarinsson authored
Videos that are playing should pause while the user is interacting with the SeekBar. The best way to do this is via touch tracking. Trying to use OnSeekCompleteListener inside onProgressChanged is unreliable, because it won't fire if and while the thumb is moving too quickly (pausing would then happen only when seeking is slowing down, and it looks jerky). Bug: 895776, 656015 Change-Id: Ie044b5cac30741bba0f5ee4a59650ef514ae8a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231359 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#775818}
-
sczs authored
Bug: 1054024 Change-Id: Ib20d303f75d06f3bb0c78132c7031fc54ff0da49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233617Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#775817}
-
Charlene Yan authored
Bug: 1018230 Change-Id: Iae567776524a5850171c91ded1afa4e11b58d77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232798Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775816}
-
Gabriel Charette authored
PreventMessagePumpHangs will be used for further tweaks in followup CLs. In this CL, the first tweak avoids looking at sent-messages from ProcessPumpReplacementMessage as MPForUI's kMsgHaveWork message can never have taken precedence over a sent message. Processing them in PreventMessagePumpHangs only adds two more checks to that queue and a potential for hangs deeper in the stack since the PeekMessage that found kMsgHaveWork will already process sent-messages (twice) : https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-peekmessagea#remarks Example stack of this happening in the wild: https://pastebin.com/EKVqg2SN Also add a trace event for ::PeekMessage from ProcessPumpReplacementMessage and bump the work id as the docs claim it can still "process internal events". R=fdoray@chromium.org Bug: 1074019, 1075960 Change-Id: I110d314f6682a97748c62be16e8b5f3551a48a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228579Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#775815}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bd37d6813a23..9a30664a3fdd 2020-06-05 jalyn@microsoft.com Add missing platform attributes to shortcuts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11a95e34e20354fa5b36645ef842aa5e3b8357c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233226Reviewed-by:
-
Nate Chapin authored
Bug: 1091577 Test: html/semantics/scripting-1/the-template-element/template-element/template-construction-in-inactive-document-crash.html Change-Id: I226aec64092784834be3197bf7a78c99e0120949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232746 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#775813}
-
Adrienne Walker authored
This is a preliminary fix for this patch to require tokens: https://chromium-review.googlesource.com/c/chromium/src/+/2225477 That patch will require origin trial tokens for any use of appcache. This fixes up browsertests to include the tokens so that they keep running when that ptach lands. Bug: 582750 Change-Id: Idf686b0c6423e9a4458e72b608dfdfad311f049c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229642 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
-
Ethan Jimenez authored
1. Creating virtual test suite to run all the `css-grid` web tests from `fast/css-grid-layout` and `external/wpt/css/css-grid` using the new LayoutNG implementation. Test suite is individually disabled in order to progressively re-enable tests fixed by new changes. Bug: 1045599 Change-Id: Ia28d40e8ab75c3668910e66330658f52ffcf2595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227306 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#775811}
-
Yann Dago authored
Browsers installed under "C:\Program Files (x86)" remain in that directory and will continue to be updated. They must be uninstalled first to be reinstalled under "C:\Program Files". Bug: 380177 Change-Id: I45b8898ddf39dd7a5fe7e6e0ce258da313ea880f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204420 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#775810}
-
Sam Sebree authored
This change uses the calendar_picker_refresh.css to set correct dark mode styling for date time local native controls. Bug: 929098 Change-Id: I6daa542ed1148c782815eb392d6f65d58c3d1366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209406Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#775809}
-
Devlin Cronin authored
base::Version is interesting. It is treated as (up to) four dot- separated integers. However, because these are parsed individually, leading zeros in each component are ignored. This leads to some interesting (potentially unexpected) behavior: - v1.01 is equivalent to v1.1 - v1.01's string representation is "1.1" - v1.02 is greater than v1.1 Additionally, leading zeros are not allowed in the first component, though they are allowed in subsequent components. That is, v01.1 is invalid. Add unittests to cover these cases, and make them more explicit. Bug: None Change-Id: Ia8cc6ec988fdef7f6c2b41c93e7468781a458591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233495Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775808}
-
Gyuyoung Kim authored
This CL applies mojo::PendingRemote to all uses of mojom::MidisClientPtr. Bug: 955171 Change-Id: Iade30d5473c8d812812dce9e6a105d668cccb3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228746Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#775807}
-
