- 14 May, 2020 40 commits
-
-
danakj authored
R=pdr@chromium.org Bug: 866140 Change-Id: Ibdc39aa65b7048916fb8a209e6abcfdba777bc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201409Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#768815}
-
Charlie Harrison authored
This CL adds an initial limit of 1024 impressions / conversions per site to prevent excessive disk usage. In a follow-up we will consider migrating this logic to call out to the quota manager. This CL also deletes the MockStorageDelegate in favor of using the one in conversion_test_utils. Bug: 1075564 Change-Id: I4097432b39f1751cf96c6c75cf3830fbd75a2900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167533 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768814}
-
Sylvain Defresne authored
When doing a fat builds, some template needs to have different expansion (as some things are only done for the primary architecture like creating the fat binary, ...). This mean that some variables are not used for the second architectures, resulting in warning from gn about unused variables. Fix this by using `not_needed` when appropriate (and convert the old code that used `assert`). Also add some forwarding targets (like +bundle). Bug: none Change-Id: I46474826c8c28778fc9fa27e5992d193ec32f827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201758Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#768813}
-
Asanka Herath authored
Previously it required too many conversions at callsites. Bug: 973801 Change-Id: Ic65d28fb594b48a719d6306cb742b49a3cf5bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181310Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#768812}
-
Jeff Yoon authored
Expose the mac,win,win64 beta/stable trybots upstream for the autorollers to invoke. Bug: 1081356 Change-Id: If9d9641d91dab186d977d14ff6910e7c9ef4427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199688Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#768811}
-
Majid Valipour authored
TEST: external/wpt/scroll-animations/element-based-offset-clamp.html Bug: 1023375 Change-Id: I9d32332e04c6f8efedc55cc24bb18d2792904c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194662Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#768810}
-
Vladimir Levin authored
This patch updates the scroll anchoring selection to consider - focused element - find-in-page active match results If an anchor is selected out of those candidates, then it is used. Otherwise, we proceed with the DOM traversal. This is updated due to changes in the spec: https://github.com/w3c/csswg-drafts/commit/396d0cf9dc9585bd77a611f18124770ac8ce704b Fixed: 1066924, 1066982 R=chrishtr@chromium.org, flackr@chromium.org Change-Id: I1af88dfdeea374c17161b86981b10fbdcecc3a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199603 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#768809}
-
Stephen White authored
Dawn doesn't currently report its maximum texture size, which causes Canvas to think the max is zero. So canvas backing store allocation always fails, and we end up with a software canvas. The easiest thing for now is to avoid the maximum size test for Dawn. Bug: 1076141 Change-Id: I73df1aeb9af7ad438889f9e0f7792c870d1b9201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199693 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#768808}
-
Greg Thompson authored
The handle verifier is intended to be enabled in 32-bit dev and canary builds, and in 32-bit debug builds (see chrome_main_delegate.cc's UseHooks). By accident, it has been enabled in all builds of setup.exe. This CL disables it for all but 32-bit debug builds. BUG=1082263 R=wfh@chromium.org Change-Id: I0442f25ab2beb07ee819693b24756562f6ce1796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199466 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#768807}
-
Alice Wang authored
This CL replaces the AccountPickerMediator.start()/stop() methods to its constructor and destroy(). Bug: 1075880 Change-Id: I9dc3bf4b7af74813889e33e798165ffaa802e30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193683 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#768806}
-
Nohemi Fernandez authored
As a part of various projects including the Sign-in architecture migration, account list management, and exploratory prototypes of MICe these reviewers have become very familiar with the Settings codebase and would like to take additional responsibility in its upkeep and future changes. Bug: 971989 Change-Id: I423c6f1ca6f5df50297054e71c40f5e2a5b96e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198967Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#768805}
-
Josh Simmons authored
Adds recursive delete support to SmbfsAsyncFileUtil. This optimizes the deletion of directories by sending a single request to smbfs over Mojo rather than making many local (FUSE) filesystem calls to enumerate and delete the directory contents. Bug: 1064471 Test: Manually tested by creating a directory with nested directories and files and then deleting that directory via Files.app Change-Id: Ieb1ea068b582899dab573548309024d6a4e8eb46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162485Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Auto-Submit: Josh Simmons <simmonsjosh@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#768804}
-
Dave Tapuska authored
Mojo structs can be used directly avoiding the code for typemapping them. No functional code changes intended. BUG=1073560 Change-Id: I5942bd3308e7c439ddd42a3bcc096f8514db8116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199701Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#768803}
-
Matthias Körber authored
The field "identificação do endereço" is wrongly classified as an address ("endereço") field. Change-Id: I0a3eafdddbc16aecc1a321a1eadd23405ead1e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199285 Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#768802}
-
Owen Min authored
C++ code and proto buf will be generated for platforms that policy's future_on tag contains. It also add a new flag in PolicyDetails to indicate that. Bug: 1076560 Tbr: anqing@chromium.org Change-Id: Iacf3f560809dbf8e1e9e4f6f2124a13948f8bd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198364 Commit-Queue: Owen Min <zmin@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768801}
-
Evan Stade authored
On Chrome, this should have no effect. It just moves the URL formatting from bespoke code in //chrome to use of UrlFormatter. On WebLayer, this brings the URL's presentation in line with Chrome (scheme and host are the only things shown). Bug: none Change-Id: I64a6d020230b5e75b0f0bb4327165c0d07026102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194338Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#768800}
-
Francois Doray authored
The FontCache is a 2-level map. The key for the 2nd level is the font size. Therefore, the font size shouldn't be used in the key at the 1st level. This CL adds a feature to clear the font size in the key of the 1st level, to allow measuring impact via an experiment. This should reduce the number of calls to CreateFontPlatformData(). Bug: 1076981 Change-Id: I64001f7652371c5f1db8054d04792aa1488fd7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196421Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#768799}
-
Robbie Gibson authored
Bug: 1071078 Change-Id: I1732b0501b40f9a9017acd3658ce784d9b39182d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201157Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#768798}
-
Michael Moss authored
And add symupload to the default targets for official builds. BUG=801296 Change-Id: I34b493c217bd02348e776f3d70a805b00573ae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191126 Commit-Queue: Michael Moss <mmoss@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#768797}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f8cb70a343a7..46b3bc6c24c2 git log f8cb70a343a7..46b3bc6c24c2 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 tommi@webrtc.org Make sure that "current" rtc::Thread instances are always current for TaskQueueBase. Created with: gclient setdep -r src/third_party/webrtc@46b3bc6c24c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I26899f82bf69cc8255fbcbdf67b21e3f001f21f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768796}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f348b224a38d..bd950196d58a Created with: gclient setdep -r src-internal@bd950196d58a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com,amraboelkher@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rogerta@google.com,amraboelkher@google.com Change-Id: I192c4418f7c289c106e97f867a85937e6061c2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201741Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768795}
-
Jun Mukai authored
When the transform for a view's underlying layer has been changed, it updates the visible location of the view (and indeed accessibility node supports transform). However, currently views don't fire a11y events. This means that potentially a11y client may recognize a stale location. Bug: 1082562 Test: views_unittests Change-Id: Ib605afdd63903abe8ef19543de9d6626457e4786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200093Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#768794}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 435ac43b. With Chromium commits locally applied on WPT: 59c99fcd "Clipboard API Tests: Automate Web Platform Tests" 7a588d8c "[client hints] Match update behavior to the spec." 46619c73 "[client hints] Enforce the top-frame requirement." 3c2baf64 "[Client-Hints] Fix cross-origin redirect leak" c15bc63c "[EventTiming] Test more event types" 6640d9f9 "[EventTiming] Wrap lines better in event-timing-test-utils" 200214d5 "[client-hints] Ensure by-default&legacy hints behave with XO redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I248b1c93988422efce6357ba48e46053f741d0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201457Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768793}
-
Ian Struiksma authored
In http://crrev.com/c/2159707 the autofill_download_manager const kDefaultAutofillServerURL was changed to the new server location. In captured sites tests, the ServerCacheReplayer uses that value to determine which requests to respond with the local cache built from WPR data instead. Thus, these values should match. Bug: 1079488 Change-Id: Ibeb137cb59cea754b346b62a22390b6ef224dea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200628 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
-
Chris Lu authored
Bug: 1071914 Change-Id: I4d59420f237f3747c79d1d92c212625901257bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198969 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#768791}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9ada4599375..09d3485a9556 git log e9ada4599375..09d3485a9556 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 skyostil@google.com Merge "ui: Fix nesting of slice argument table" Created with: gclient setdep -r src/third_party/perfetto@09d3485a9556 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9c2af045342b8c45959746751e089c9e1f6fd14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201744Reviewed-by:
-
Matt Menke authored
This sets it to be based on the URL being fetched. This does not address any cross-site tracking concerns around the cert fetches themselves, but is instead aimed at letting us DCHECK that all URLRequests have a non-empty IsolationInfo, to help us catch any other places that are potentially leaking information across sites. Bug: 1082280 Change-Id: Ie9b29b5f16b8c01dee23975e82d701d8f98e0489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198924Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#768789}
-
Jacques Newman authored
We should not automatically hide the children of links if they are not a single text-only object. AX-Relnotes: n/a Bug: 1054514 Change-Id: I51d26d33b21fe524efef247fd2c25ed52aa40bdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194903Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#768788}
-
Adrienne Walker authored
Rather than passing around a remote, pass around a wrapper that owns the remote. This is a setup patch for a patch that will add watching origins for changes to storage policy. This wrapper is needed to intercept origins that have factories created for them in order to watch them, and to have a place (that's not StoragePartitionImpl) to implement observers of the special storage policy. This is a no-op on its own, but sets up future work. Bug: 1015214 Change-Id: Icd99823cd46faf33a0bf6e4401f27f58b51af708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199914 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#768787}
-
Mohammed Abdon authored
Currently Azure is recorded as Failure as it's certificate looks quiet different and need some special handling. Bug: 1081324 Change-Id: I66b4b9589df9a7fd242ec01e67d2fdba113bc986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197437Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#768786}
-
Mikhail Khokhlov authored
The new macros will allow using the blink.console events in TBMv3 metrics. Bug: 1038710 Change-Id: Icbb039f37f945dcc9c5954d59b2b05852f4ceb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195968Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#768785}
-
Samuel Huang authored
Bundle wrapper test scripts calls such as /out/Debug/bin/monochrome_public_bundle install /out/Debug/bin/trichrome_chrome_google_bundle run use the '-m' flag to include DFMs. In particular, the switch for the DevUI DFM is '-m dev_ui' (and '-f dev_ui' for fake install). However, most developers who use these test scripts don't care about this detail. This CL makes the DevUI DFM installed by default when these build scripts are used, to simplify development. The master list |default_modules_for_testing| is in chrome_bundle_tmpl.gni, and currently on has "dev_ui". To make it still possible to test install flows of DevUI DFM, this CL also adds the new flag '--no-module' to exclude non-base DFMs that are installed by default (currently only {dev_ui}). Fake installs, e.g., '-f dev_ui', also excludes the default install. Bug: 1081812, 987040 Change-Id: Icf87515382cc6d0b3d52fc3fa1914c7a4830b6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197339Reviewed-by:Egor Pasko <pasko@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#768784}
-
Dana Fried authored
This reverts commit 1f434e5c. Reason for revert: Uninitialized variable in phishing_classifier_delegate.h|cc causes many MSan tests to fail. See attached bug and associated builders. Bug: 1082797 Original change's description: > Add UMA metrics to Phishing Delegate. > > The metrics are to help better understanding > what is going on in the phishing delegate, such > as when the phishing detection call is blocked > by page capture or if it's destructed before > the call is finished. > > Bug: 1068621 > Change-Id: I1f7d55fc89f448acbec6afa7e3869de5591503a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181566 > Commit-Queue: Bettina Dea <bdea@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Daniel Rubery <drubery@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768675} TBR=isherman@chromium.org,bdea@chromium.org,drubery@chromium.org Change-Id: I9d9dcef0f6cd56142940c38b431745e5aee81022 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202120Reviewed-by:
Dana Fried <dfried@google.com> Commit-Queue: Dana Fried <dfried@google.com> Cr-Commit-Position: refs/heads/master@{#768783}
-
Andrew Grieve authored
This reverts commit 0b505061. Reason for revert: Trybots are failing with: ../../chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelFilterProvider.java:20: error: could not resolve EmptyTabModelSelectorObserver e.g.: https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/555380 Original change's description: > Replace EmptyTabModelSelectorObserver with default methods. > > Bug: 1082248 > Change-Id: I51b883c8fbefcf391750110b3477ea84c78f7a5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199890 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768767} TBR=dtrainor@chromium.org,hnakashima@chromium.org Change-Id: I220287bc7077ab590c6e9d4272784ef3a958bf6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202118Reviewed-by:
-
Ken Buchanan authored
The Web Authentication feature policy which allows pages to delegate the ability to perform public-key navigator.credentials.get operations is enabled by default. Bug: 993007 Change-Id: I8d9330a8fbc8c9881e0b046db4c06b36de28c866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199702Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Rick Byers <rbyers@chromium.org> Auto-Submit: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#768781}
-
Yutaka Hirano authored
Initial empty documents have a special navigation path, which leads to missing reports for cross-origin embedder policy violations. Fix the issue by creating a CrossOriginEmbedderPolicyReporter in the special navigation path. Bug: 1052764 Change-Id: I5825eb2946dc00f9e042b55e602fd786dc2d1adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097800 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768780}
-
Chris Sharp authored
This new policy allows admins to control what domains AutoOpenFileTypes applies to. BasedOnExtension was removed from a lot of function names since extension isn't the only factor when determining if a file is auto-opened. Bug: 92846 Change-Id: I20cbc254c841a03be3032566ebc2ecd6e91e913c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196245Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#768779}
-
Rayan Kanso authored
Confirmed this is now working by forcing an update via chrome://webapks Bug: 1074351 Change-Id: Ic5b6ccaa725fbf24566473f4ff56c179aa6650d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201818Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#768778}
-
Sahel Sharify authored
This refactoring is needed for addressing review comments on https://chromium-review.googlesource.com/c/chromium/src/+/2168009/8 Change-Id: I49d3a4a8f0d0f5c7640dcb01f66ce3ba4f145951 Bug: 1026667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199889Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#768777}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/493b76784ef1..c7172a2a6808 git log 493b76784ef1..c7172a2a6808 --date=short --first-parent --format='%ad %ae %s' 2020-05-14 pfaffe@chromium.org Disable the flaky Animations Panel test Created with: gclient setdep -r src/third_party/devtools-frontend/src@c7172a2a6808 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1082735 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac0f1f728448de30b22dc9505abbc8c71f6b2774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201739Reviewed-by:
-
