- 08 Jul, 2017 20 commits
-
-
dpapad authored
BUG=739150 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2975553003 Cr-Commit-Position: refs/heads/master@{#485126}
-
Matt Wolenetz authored
If a random access point doesn't have the earliest presentation time of other frames that depend on it (eg, other frames in later decode time up until the next random access point), the MSE spec was not designed to support processing and buffering it well. With the change to managing and reporting buffered ranges by PTS intervals instead of DTS intervals, this could impact interop. This change detects this general case and logs once per track to chrome://media-internals. Later changes might include telemetry collection to assist removing or fixing support for at least SAP Type 2 in the MSE ISOBMFF bytestream spec. To verify the new log is emitted by the new test, this change also upgrades FrameProcessorTest's |media_log_| to a StrictMock<MockMediaLog> and includes new strict verification of logs emitted during FrameProcessorTests. See also related spec issue https://github.com/w3c/media-source/issues/187 BUG=739931,718641 Change-Id: I361177dee6a5c70edf17bdbde2f3ea643977e6ec Reviewed-on: https://chromium-review.googlesource.com/563017 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#485125}
-
eroman authored
This has the advantage of moving the file writing off the main thread. BUG=716570 Review-Url: https://codereview.chromium.org/2973673003 Cr-Commit-Position: refs/heads/master@{#485124}
-
Menglu Huang authored
Bug: Change-Id: I6378477249aecff89035c3c9297ba59ecdd86a4f Reviewed-on: https://chromium-review.googlesource.com/548983 Commit-Queue: Menglu Huang <huangml@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485123}
-
Randall Raymond authored
These two new files are mostly a copy of json_response_fetcher.cc and json_response_fetcher.h from chrome/browser/ui/app_list/search/common/ (https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/search/common/?q=chrome/browser/ui/app_list/search/common&sq=package:chromium&dr). The main differences are that 1) The namespace is changed from app_list to payment_request_util 2) Instead of using SafeJsonParser, a basic parser is used instead since iOS does not currently support SafeJsonParser. Bug: 602666 Change-Id: Ibf619f1c53a32eb53654e00959fbcba61720c8a5 Reviewed-on: https://chromium-review.googlesource.com/562581 Commit-Queue: Randall Raymond <rayraymond@google.com> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485122}
-
garykac authored
Includes basic support for plaintext read/write. See https://w3c.github.io/clipboard-apis/ BUG=677564 Review-Url: https://codereview.chromium.org/2695593006 Cr-Commit-Position: refs/heads/master@{#485121}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9a5b75ed3609..256098db1e09 $ git log 9a5b75ed3..256098db1 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 benjhayden Reland Fix _GetSelectedTestPathsForDict in /list_tests handler. 2017-07-07 erikchen Use json.dumps instead of json.dump in symbolize_trace.py. 2017-07-07 benjhayden Clean up MERGED_FROM in histogram.py. 2017-07-07 mikecase Decrease iter_timeout for logcat_monitor by factor of 10. Created with: roll-dep src/third_party/catapult BUG=740263 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2137321803b52e544fd47074a13225e63faf5e7b Reviewed-on: https://chromium-review.googlesource.com/564066 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485120}
-
sandersd authored
BUG=512916 Review-Url: https://codereview.chromium.org/2966643002 Cr-Commit-Position: refs/heads/master@{#485119}
-
Dave Schuyler authored
This CL updates the options html from the old i18n-content to $i18n{} replacements. TBR=stevenjb@chromium.org Bug: 677338 Change-Id: I7c129d792910a2196cf2701a750258d49fe0b33b Reviewed-on: https://chromium-review.googlesource.com/564137 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#485118}
-
Sean Kau authored
The changes mirror those in the logging system. Additional info in crbug.com/740225 Bug: 725739, 740225 Change-Id: I5426da5065b1de2943ec8130e364769d5853affe Reviewed-on: https://chromium-review.googlesource.com/563607Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#485117}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f6f68c75ce54..b46ce4172ee8 $ git log f6f68c75c..b46ce4172 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 vmiklos core: fix -Wshadow warnings Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: If7d50f672ece222a1792bc0140a9e9f3e1512caa Reviewed-on: https://chromium-review.googlesource.com/564063 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485116}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9b80ffc77b80..8fe24272fa6d $ git log 9b80ffc77..8fe24272f --date=short --no-merges --format='%ad %ae %s' 2017-07-07 bsalomon Add mock config to tools and run through gms and benchs without crashing. 2017-07-07 bsalomon Make AAHairlineOp a non-legacy GrDrawMeshOp Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I1cf67abf171beefb02bc630ed1b8731eaed0cd67 Reviewed-on: https://chromium-review.googlesource.com/563472Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485115}
-
Bret Sepulveda authored
WebRtcCaptureFromElementBrowserTest. VerifyCanvasCaptureOffscreenCanvasCommitFrames was reported as flaky. Looks like it's timing out. TBR=mcasas@chromium.org Bug: 740248 Change-Id: If8ab0a57e5870dfbc8945d0cb8423d6957767e0c Reviewed-on: https://chromium-review.googlesource.com/564179Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485114}
-
luoe authored
BUG=739462 Review-Url: https://codereview.chromium.org/2972273002 Cr-Commit-Position: refs/heads/master@{#485113}
-
Matthew Jones authored
This reverts commit 58394da4 as it causes a crash and undesirable behavior in the existing infractructure. BUG=729575, 729611, 721389 Change-Id: I029fcc2c6d63b849bf511e57bd2737acb0b6325f Reviewed-on: https://chromium-review.googlesource.com/564081Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#485112}
-
Dave Schuyler authored
This CL updates the options/chromeos html from the old i18n-content and values to $i18n{} replacements. TBR=stevenjb@chromium.org Bug: 677338 Change-Id: I24685ac591b8116baa52fe059f5076d7c1674232 Reviewed-on: https://chromium-review.googlesource.com/563608 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#485111}
-
zhaobin authored
NOTE: those extensions header files and extensions::api:: namespace will go away when https://codereview.chromium.org/2913033003/ lands Discover process is similar to DialMediaSinkService: - CastMediaSinkService::Start() registers itself with DnsRegistry - CastMediaSinkService::OnDnsSdEvent() gets invoked when Dns services comes back and starts a 3s timer - Start opening channel for each service on IO thread - CastMediaSinkService::OnChannelOpenedOnIOThread() gets invoked when channel open finishes - Post task back to UI thread via CastMediaSinkService::OnChannelOpenOnUIThread() - Create MediaSinkInternal and store it in CastSinkService's sink map - Invoke MediaSinkBase::FetchCompleted() and send sinks to MRP when timer expires BUG=687377 Review-Url: https://codereview.chromium.org/2927833002 Cr-Original-Commit-Position: refs/heads/master@{#484979} Committed: https://chromium.googlesource.com/chromium/src/+/b9a2a9b60034d3ee2138c4815bc3c66b13cee3b5 Review-Url: https://codereview.chromium.org/2927833002 Cr-Commit-Position: refs/heads/master@{#485110}
-
Tien-Ren Chen authored
This CL reworks PaintChunksToCcLayer to handle effect grouping properly. Prior to this CL each paint chunk applies its property state all the way from the layer state then pop all the way back. This CL implemented an algorithm to lazily pop states so that contiguous paint chunks enclosed by the same effect will apply the effect atomically. As an optimization, clip region is also popped lazily. Note that this doesn't mean AA-clips are applied as a group but still apply to individual draw commands separately. It does improve performance by reusing previously generated clip region when a complex clip region applies to multiple chunks repeatedly. Rounded clip support is also added as a side change. Transforms are always applied on the spot. This is because we can compute the matrix between arbitrary nodes in O(1). Also this automatically handles "transform inversion" cases as we don't even need to detect the relationship between nodes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64657b657fad3e19132b9eb0d64db494955f2139 Reviewed-on: https://chromium-review.googlesource.com/540737 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485109}
-
Jian Li authored
When the user open the downloaded page, a specific offline header is added in the request to mean to load the offline snapshot. In this case, the service worker interceptor should fall back in order for the subsequent offline page interceptor to bring up the offline snapshot. BUG=736917 TEST=new tests added Change-Id: I5e57ed437d7534bd54f6406d4d527c4599bd9a41 Reviewed-on: https://chromium-review.googlesource.com/557479 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485108}
-
weidongg authored
If mouse press/release occurs between search key down and up, avoid toggling app list. This is helpful when user is chromoting from chromeos to other system which uses 'Win+Click' as a gesture. BUG=665897 TEST= ash_unittests --gtest_filter= 'AcceleratorControllerTest.GlobalAcceleratorsToggleAppList' ash_unittests --gtest_filter= 'AcceleratorFilterTest.ToggleAppListInterruptedByMouseEvent' Review-Url: https://codereview.chromium.org/2923723002 Cr-Commit-Position: refs/heads/master@{#485107}
-
- 07 Jul, 2017 20 commits
-
-
Qiang Xu authored
changes: Extracting a private method CalculateTransitionOffset for a view's current page. For new launcher, not only the all apps tiles, but also the new added views (indicators, suggested apps) should have transition offset. Change-Id: I8b65332f06ea7aea107b9b77081d8dbdf54c47d7 Bug: 735702 TEST: no functional/UI change Reviewed-on: https://chromium-review.googlesource.com/562589Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485106}
-
eroman authored
Instead use an internally created sequenced task runer. BUG=689520 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2966283002 Cr-Commit-Position: refs/heads/master@{#485105}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/554098. This shouldn't change the behavior. Bug: 686281 Change-Id: I8f98349b2ecbd8ba972189256f0dbf1c07ad73bd Reviewed-on: https://chromium-review.googlesource.com/557363 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485104}
-
pkotwicz authored
The check is no longer necessary after https://codereview.chromium.org/1354323003 BUG=713655 Review-Url: https://codereview.chromium.org/2973103003 Cr-Commit-Position: refs/heads/master@{#485103}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c2d9d2f7f16e..9a5b75ed3609 $ git log c2d9d2f7f..9a5b75ed3 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 eakuefner [Tracing] Move Python DiagnosticRef into tracing.value.diagnostics 2017-07-07 benjhayden Formalize reserved diagnostic names. 2017-07-07 simonhatch Dashboard - Add tests for api/oauth.py. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ada15db7730b24e7bc88fe04e8adec4c8c651b3 Reviewed-on: https://chromium-review.googlesource.com/564079 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485102}
-
Noel Gordon authored
Test is using two levels of runAfterLayoutAndPaint and is failing on the some bots (see bug 713049). Try using one runAfterLayoutAndPaint since that's all that should be needed after changing the element box-reflection CSS style. Bug: 713049 Change-Id: I448b6908044786cb9da45945b2aed370336c1353 Reviewed-on: https://chromium-review.googlesource.com/558540Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#485101}
-
Hiroshige Hayashizaki authored
According to the spec: Step 8 of "execute a script block": https://html.spec.whatwg.org/#execute-the-script-block This CL stops firing load events for - parser-inserted inline module scripts without async in HTML, i.e. those fall into 1st Clause of Step 23 of "prepare a script" (Issue 715369; This CL and [1] stop firing load events of all inline module scripts) - parser-inserted inline classic scripts that fall into 5th Clause of Step 23 of "prepare a script" (Issue 739514) [1] https://chromium-review.googlesource.com/c/557978/ Bug: 686281, 739514, 715369 Change-Id: Ia1a2e9653bccb99ff47faa1d8b8186c043e83770 Reviewed-on: https://chromium-review.googlesource.com/557972 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485100}
-
Aleksandr Derbenev authored
All build configurations except windows with msvc now output diagnostics with paths relative to the build directory. But msvc build uses absolute paths for diagnostic messages and __FILE__ macro. It also makes test launcher and gtest produce absolute paths to source code locations in the logs and summaries (it looks very weird for swarmed binaries and makes harder to find out where is the real location). I've switched to relative paths and checked that: 1. MSVC can correctly generates relative paths in diagnostics. 2. MSVS can correctly parse relative paths and use them to navigate the code in case of creating solution with gn gen --ide=vs (that was an issue to use absolute paths earlier). Switching to the relative paths makes build more determenistic also ( path to the build directory will not be included to the compiled object files when __FILE__ macro is used). To enable absolute paths back use gn argument: msvc_use_absolute_paths=true Bug: Change-Id: I4599fb4869849d5b9b6550406777a3d1e4476bf1 Reviewed-on: https://chromium-review.googlesource.com/558871 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#485099}
-
edchin authored
TabCollectionTabCell lazily retrieves snapshot images from SnapshotCache. This CL adds this capability and unit tests. This CL does not plumb the cache into the tab cell. This CL does not modify SnapshotCache to handle multiple image sizes. BUG=686770 Review-Url: https://codereview.chromium.org/2967083002 Cr-Commit-Position: refs/heads/master@{#485098}
-
zijiehe authored
DesktopCaptureOptions impacts which underlying DesktopCapturer implementation is used. But there is no guarantee that different DesktopCapturer implementations would eventually return the same SourceList, or a Source in the SourceList represents the same output content on the system. So DesktopCaptureBase and DesktopCaptureDevice should use same DesktopCaptureOptions. BUG=732224 Review-Url: https://codereview.chromium.org/2961193002 Cr-Commit-Position: refs/heads/master@{#485097}
-
chaopeng authored
Currently we don't support using ScopedFeatureList::* in SetUp for InProcessBrowserTest since we clear FeatureList at the beginning of InProcessBrowserTest::SetUp. In this patch, we remove the FeatureList::ClearInstanceForTesting() and move the feature change in InProcessBrowserTest to ScopedFeatureList. So we are able to move all feature list change calls SetUp and use ScopedFeatureList::*. BUG=713390 Review-Url: https://codereview.chromium.org/2876153002 Cr-Commit-Position: refs/heads/master@{#485096}
-
arthursonzogni authored
In every method of ChildProcessSecurityPolicyImpl, this CL makes url.scheme() being called only once. BUG=None Review-Url: https://codereview.chromium.org/2966203002 Cr-Commit-Position: refs/heads/master@{#485095}
-
erikchen authored
BUG=669240 Review-Url: https://codereview.chromium.org/2976533002 Cr-Commit-Position: refs/heads/master@{#485094}
-
chrome://media-internalssandersd authored
Buttons now contain: [player src or ID] [frame title] - [frame url] [resolution, codecs] [last event] Screenshot: http://i.imgur.com/ue2ibQJ.png Also removes the kCreated event from PipelineImpl. After this change, the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED, and we will be able to use that to improve log expiry. BUG=551065 Review-Url: https://codereview.chromium.org/2964713004 Cr-Commit-Position: refs/heads/master@{#485093}
-
kerrnel authored
Calls SetApplicationIsDaemon() to prevent crashing if LaunchServices cannot be connected to. This CL also allows the com.apple.lsdb.mapdb service which exposes the LaunchServices database. BUG=689306 Review-Url: https://codereview.chromium.org/2944623003 Cr-Commit-Position: refs/heads/master@{#485092}
-
sandersd authored
This class wraps a gpu::gles2::GLES2Decoder* to provide utility functions for VDAs. BUG=522298 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2938543005 Cr-Commit-Position: refs/heads/master@{#485091}
-
Adrienne Walker authored
This is pre-refactoring for a future patch where PaintFlags stores PaintShader directly. As PaintFlags is often copy constructed, it doesn't make a ton of sense to have a unique_ptr PaintShader. This makes it an sk_sp ref counted time for similiarities to all of the other paint type refcounting. Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0b4ea8285f375180f8abceb86c984d42491ff41a Reviewed-on: https://chromium-review.googlesource.com/560669Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485090}
-
Fady Samuel authored
This CL moves: cc/resources/resource_format.h => components/viz/common/quads cc/resources/resoure_format_utils.{cc|h} => components/viz/common/resources cc/resources/platform_color* => components/viz/common/resources. This CL also moves out the functions in resource_format to resource_format_utils. The rest of the changes are just updating includes, namespaces and DEPS. TBR=piman@chromium.org, reveman@chromium.org, junov@chromium.org Bug: 722935 Change-Id: I4b861448df64f08733dac254525f1770336f9254 Reviewed-on: https://chromium-review.googlesource.com/563737 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#485089}
-
holte authored
BUG=739971,734091 Review-Url: https://codereview.chromium.org/2976453002 Cr-Commit-Position: refs/heads/master@{#485088}
-
smut authored
Bug: 738255 Change-Id: Ib00bbc4e7ca58868ed29dd72111042b29c74aa56 Reviewed-on: https://chromium-review.googlesource.com/562566Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#485087}
-