- 23 Jul, 2019 40 commits
-
-
Brandon Wylie authored
The suggested removal process as documented in the bug is to: (1) Remove any instrumentation code. (2) Mark the histograms as obsolete in histograms.xml Bug: 975891,975790 Change-Id: If21eb5799c788bf49de3e3f91ba1279ad14f19a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700329Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680099}
-
Min Qin authored
These UMA are no longer used. BUG=969993 Change-Id: Ib2d54586958289240aace62ba12d3b6a6b70ae57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704735 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#680098}
-
Mario Sanchez Prada authored
Convert the implementation and clients in the browser and renderer processes for the blink.mojom.NonPersistentNotificationListener and blink.mojom.NotificationService mojo interfaces, and adapt unit tests. Bug: 955171, 978694 Change-Id: I03aa11addfcc84fa3c16680f31f58cdca69a29db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712573 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#680097}
-
Nicolás Peña Moreno authored
This CL replaces responseEnd with loadTime. Before, responseEnd would be used and would be problematic for memory cached images. We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This time has the advantage of being independent of the memory cache and being after the image has been appended to the DOM, as shown by a test. To implement loadTime, we use a new HashMap. This HashMap populates the timestamps that will be used in ImageRecords. We cannot use the existing data structures because this happens before we know whether the image will be added to the set of visible or invisible images, etc. Bug: 982046, 965505 Change-Id: I50d4f304a35b60409c58c54a5bd912e7d15825e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710682 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680096}
-
Ian Kilpatrick authored
For NG types this isn't needed anymore. The NG types now use: CalculateSizeBasedLayoutCacheStatusWithGeometry Which determines the size of a fragment ahead of time, and applies the same optimization. The only thing that we now miss, is things which are sized shrink-to-fit which use legacy layout. We couldn't apply this optimization to shrink-to-fit tables, as they may have %-based inline-sized children which affect their (final) inline size. Bug: 984642 Change-Id: I0d0b584f31947bb674f4e7e5d88d7af6cf5d9d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662535 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#680095}
-
Asanka Herath authored
This mildly reduces the number of platform specific code in files that are supposed to be cross platform. R=eroman@chromium.org Bug: 927182 Change-Id: I854f452ac95a9dbeca326821d7efd9c2ea4c61b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693565 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680094}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ecadc16190a..59b2d77a1e39 Created with: gclient setdep -r src-internal@59b2d77a1e39 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Bug: chromium:None Change-Id: I7d0b3f34716d0f37fc0d7cff44e24f5f95847c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c80b0e954187..84bcd0c3ae08 git log c80b0e954187..84bcd0c3ae08 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mtklein@google.com skvmtool upgrades 2019-07-23 brianosman@google.com Always include surface origin in keys for program/pipeline state Created with: gclient setdep -r src/third_party/skia@84bcd0c3ae08 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I16bf6c9981d7e55296bb53a29fcb44ffee59cde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715092Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680092}
-
Martin Kreichgauer authored
Tests should use the device's Config and State to influence the authenticatorGetInfo response it replies with, rather than injecting one directly. This change removes the method and changes the single test that depended on it. Also make the |allow_invalid_utf8_in_credential_entities| option in VirtualCtap2Device::Config default to `false`. It was `true` inadvertently. Change-Id: I1f0536b1b52a4d3a561afe57242639be5325a18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709845 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#680091}
-
Brian Sheedy authored
Fixes the Telemetry minidump tests failing on Linux by switching from GetMostRecentMinidumpPath() to GetRcentMinidumpPathWithTimeout(), i.e. blocking until a minidump is actually available instead of assuming one has been written to disk by the time we check for it. This will also hopefully fix similar issues on other platforms, but for now, Linux is the only platform that is being re-enabled. Bug: 634156 Change-Id: I1a4bb9e8710b322e9a30c8b2040d6617bf1fc531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713749 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#680090}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I38901bded441724e46735cdda6eccc867d0c35e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680089}
-
Andrew Xu authored
Learnt from other engineers that map::count at some time gives unexpected results. So replace map::count with map::find in ChromeAppListModelUpdater::FindItem. In addition, it is suspected that ActivateChromeItem may affect |current_model_updater_| in a surprising way. So move ActivateChromeItem to the end of function. Meanwhile, add more checks to help the bug investigation. Bug: 969810 Change-Id: Ic5c7b21efb4746d9761742482d9a697ebe322c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714214Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680088}
-
Josh Nohle authored
Handles the BatchGetFeatureStatuses portion of the CryptAuth v2 DeviceSync protocol. Returns the feature statuses for each input device ID as a map from multidevice::SoftwareFeature to multidevice::SoftwareFeatureState. The implementation handles timeouts internally, so GetFeatureStatuses() is always guaranteed to return. Verified 100% code coverage aside from different flavors of network request errors. Bug: 951969 Change-Id: I829cb1e036c4be4c837e81a9def361be8efb071f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703278 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680087}
-
Vikas Soni authored
Enable 6 pixel video tests on Mac Pro FYI Release (AMD) bot since the test was fixed in CL - https://chromium-review.googlesource.com/c/chromium/src/+/1699401. Bug: 925744,911413 Change-Id: I62bf4f3beb4337d2eb84692c96ac30c3952322a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710881 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#680086}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I65dd09fac56f15df03f4128cff6d51186ac3b96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715746Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680085}
-
Clark DuVall authored
TBR=kinuko@chromium.org Bug: 824840 Change-Id: I6de8c5f6089de7a031b5642fe9d440ea7ddea083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715426Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680084}
-
Aaron Tagliaboschi authored
Bug: 856777, 849483, 868407 Change-Id: I694eeab0d4041b4e521b9d2c47ded5a8d7df6ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643748Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#680083}
-
Peter Boström authored
This doesn't exist when kExtensionsToolbarMenu is on, so add a CHECK to make sure it isn't used or gives reasonable stack traces if it does hit. Bug: chromium:984654, chromium:985834 Change-Id: Ia1fde8b28dc39414cc378bda425a3d2775f0b359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715245 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#680082}
-
Aran Gilman authored
According to the W3, both alert [1] and alertdialog [2] should fire an alert accessibility event when an element with either role appears. The existing code covers alerts, since those are also implicitly live regions. However, alertdialogs are not live regions, so no alert event was fired for them. This change just moves the event generator's check for an element having an alert role before the check for live region status. [1] https://www.w3.org/TR/wai-aria-1.1/#alert [2] https://www.w3.org/TR/wai-aria-1.1/#alertdialog Bug: 983225 Change-Id: I6ecfa3ef0909e37c59bb6a94886dd3b6f3737744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698724 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680081}
-
Robert Ogden authored
Next CL will see this code moved to a new dir under //chrome/browser Bug: 986359 Change-Id: Id6d0a43b684db7aa3bcd751c6d3b7e58702ec208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715105Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#680080}
-
Max Moroz authored
Bug: 539572 Change-Id: I721b224671ead0b1f6852269667f525c7abb08ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715107 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680079}
-
Dominik Laskowski authored
This is a remnant from a reverted feature where DisplayConfigurator managed virtual displays. Bug: 929449 Test: Build Change-Id: I0e8f3849bd50795bdfb467e161d80d5a60fdc393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713123Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#680078}
-
Lily Chen authored
Bug: none Change-Id: I3607d4581f3ac46a6949bb61c89da104346b55c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715307Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#680077}
-
Mason Freed authored
Prior to this CL, a node that contained both opacity and backdrop-filter would sometimes not be properly rendered. The opacity was, in some cases, applied as if there was an opaque black background behind the filter region, rather than compositing the filtered image into the background with the specified opacity. This CL changes the way opacity is applied, moving it to the paint of the final filtered image, which fixes the problem. Bug: 983252 Change-Id: I9fae88c8f7b1c950d5616e1c9eeaaa664bab649a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707457Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#680076}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd369bb8a251..dd3de6f095c1 git log cd369bb8a251..dd3de6f095c1 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 jose.dapena@lge.com Do not assume __has_builtin is available Created with: gclient setdep -r src/third_party/angle@dd3de6f095c1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:819294 Change-Id: Ib731c7d2df4a90029681fefb8b696cd4ccadfa49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680075}
-
Rob Schonberger authored
The details are based off of those in Eve, but with fields updated via examination in evtest. Bug: 982118 Change-Id: Ibf5825ebabc21d4e820fcaf3d05193808d862fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714206 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680074}
-
Jack Steinberg authored
This change adds the toast type attribute and property according to the PR on the toast explainer here: https://github.com/jackbsteinberg/std-toast/pull/49 There is still work TODO on implementing this PR, w.r.t the showToast type option, a11y behavior for warning / error, and default features for those types (Infinity duration, closebutton, etc) Additionally, a follow-up CL will come out to reconfigure the current reflection tests for type and open to use established reflection test methodology (ex: https://cs.chromium.org/chromium/src/third_party/blink/web_tests/wpt_internal/std-switch/tentative/form-associated-basic.js) Bug: 972945 Change-Id: I58c7079dc4f748928eea44103dece835e549986e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708313 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680073}
-
May Lippert authored
With the upcoming plan to split out OS settings, chrome://settings will not have certain settings anymore so those need to be removed from the autocomplete suggestion list. BUG=984744 TEST=wrote unit test, ran code on an Eve device with the flag on and off and verified that the autocomplete suggestions are accurate. Change-Id: I9b055f120e4f3d9c61b676e126bf5bde9feec125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713566 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#680072}
-
Michelle Roxas authored
Bug:973603 Change-Id: Id3472d0797f5e031db027c0daf1a12ac7cd46517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709937 Commit-Queue: Michelle Roxas <michelleroxas@google.com> Auto-Submit: Michelle Roxas <michelleroxas@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#680071}
-
Brandon Wylie authored
* Naming for timing histograms is now more generic. * Add time reporting to NetworkImageFetcher.java. * Add EntitySuggestions to image fetcher client list. Bug: 973682 Change-Id: Ic1b6fe8541e5b36bc359a5ba64fc2064bc260c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657032 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#680070}
-
dalyk authored
In SECURE or AUTOMATIC mode, we should be able to send secure DoH queries via the async resolver regardless of whether the async resolver is enabled for sending insecure queries. The network service will be updated in a follow-up cl to actually set the insecure and secure parts separately; for now support is just being added in HostResolverManager. Bug: 985589 Change-Id: Ife79f70897229aadc4f7111c3ce07de47b47a32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497654 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#680069}
-
Tim Volodine authored
Remove unused AwInterceptedRequestHandler code and add documentation for AwProxyingURLLoaderFactory. This patch: - removes unused AwInterceptedRequestHandler class and related code. - adds documentation for the AwProxyingURLLoaderFactory specifying it's functionality, the logic it contains, handled callbacks and threading considerations. BUG=841556 Change-Id: I1c62b6db3d7c4d4915b72abdb07954f5642ce425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710574 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680068}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2f0a34a..109b30b3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0a46268501a25b41a92c22e769a4a87c107fa32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715404Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680067}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4e3b218e9695..68d97adf88de git log 4e3b218e9695..68d97adf88de --date=short --no-merges --format='%ad %ae %s' 2019-07-23 senorblanco@chromium.org Prefer <cstring> to <string.h>. Created with: gclient setdep -r src/third_party/dawn@68d97adf88de The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I4597f2403819781dbf96662788ad263d248784b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680066}
-
Jun Mukai authored
- The folder-view's expansion / shrink can be fully done through ui::LayerAnimator since it can animate all of the properties. - Item view can update the rounded corner and insets with animation on folder-item. It still has a slide-animation in item_view for the indicator circle of the non-folder items. I believe this can be done through the ui::LayerAnimator though it would need some amount of refactoring while it won't affect the performance so much; so this CL leaves it as-is. Bug: 983308 Test: manually Change-Id: Ib954280e3c72fd7c1add1b863349d4793059e14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710048 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#680065}
-
Piotr Bialecki authored
Change-Id: I474cc8a67e92ad3ebee7dcd97a2d67f5f50c133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709692 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#680064}
-
danakj authored
We are removing the WebLayerTreeView interface as it is redundant with WebWidgetClient now that we always composite web contents. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. The HaveScrollEventHandlers() method is only used in blink_unittests and they can get at the TestWebWidgetClient, so remove it from the public APIs entirely. WebPagePopups don't have scroll event handlers, and even if they did they don't need to tell the compositor. Add a comment and a NOTREACHED() instead of code. R=dcheng@chromium.org Bug: 912193 Change-Id: I5aed86e0773953428aded533df4395c29f3bd451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713746 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680063}
-
Juanmi Huertas authored
Fixing a clusterfuzz bug by ensuring that ExistingDrawingCanvas and DrawingCanvas will fail in the same conditions (the context is lost and there is no canvas to draw to). Bug: 982321 Change-Id: I3ac02f605ed1b41c50a3179e1d69d61d25f528a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708154Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#680062}
-
Dan Harrington authored
This CL hides ClientPolicyController, and makes it a singleton. Access to policy data is now provided through regular functions. ClientPolicyController was already immutable, so making it a proper singleton is just a mechanical change. This has a benefit that we no longer construct multiple copies of ClientPolicyController, and no longer need to thread it through so many interfaces. A potential downside is that injecting fake policies for testing would have been easier before this change. However, there's still several ways to do it, and we haven't yet found a need for this. Bug: 883559 Change-Id: I5b0919f9d91d91c53d9897b8469f9031d45c6996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678780 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#680061}
-
Will Cassella authored
The CL uses the new 'conditional modules' feature to auto-install the VR DFM upon updating Chrome on supported devices. This should provide a much better experience when launching Chrome from the DDH for the first time on devices where the cost of having the VR DFM unused is minimal. This is only used on monochrome_bundle builds. Bug: 961796 Change-Id: I79b095205b5dd947484738034bf50a2a0c4c8ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714144Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#680060}
-