- 25 Sep, 2014 40 commits
-
-
jbudorick authored
I broke the uiautomator tests with my change to instrumentation test running in https://codereview.chromium.org/558883003/. The revised implementation never called _RunTest, which the uiautomator test runner overrides to run its tests. As a result, we were trying to run the uiautomator tests with 'am instrument', which (obviously) doesn't work. This patch revises the implementation of the instrumentation test runner s.t. it does call _RunTest again. BUG=417492 Review URL: https://codereview.chromium.org/607583002 Cr-Commit-Position: refs/heads/master@{#296835}
-
erikcorry authored
BUG= Review URL: https://codereview.chromium.org/606653002 Cr-Commit-Position: refs/heads/master@{#296834}
-
dmazzoni authored
Split off from cl 490443002 because for some reason this test seems to fail with a NaCl error on one of the trybots. Let's try to land it separately. BUG=404470 Review URL: https://codereview.chromium.org/590913002 Cr-Commit-Position: refs/heads/master@{#296833}
-
erikchen authored
- In Canonical Fullscreen, the toolbar/tabstrip now slide over the content when the AppKit menu bar is revealed. This prevents a series of fast resizes of the content view, which is janky. - Adjust the z-ordering of the infobar so that it shows in front of the bookmark bar and toolbar in Canonical Fullscreen. - Removed method -isInFullscreenWithOmniboxSliding, as it has the same behavior as -isInAnyFullscreenMode. BUG=413210 Review URL: https://codereview.chromium.org/607603003 Cr-Commit-Position: refs/heads/master@{#296832}
-
vitalybuka authored
Revert of Restored disable print preview policy. (patchset #8 id:140001 of https://codereview.chromium.org/597933002/) Reason for revert: Noticed a bug in render_view_context_menu.cc change Original issue's description: > Restored disable print preview policy. > Not exact revert of https://codereview.chromium.org/488853002 > > BUG=374321,416396 > > Committed: https://crrev.com/15daa893f50daebf33ccf06ba67d74788700e495 > Cr-Commit-Position: refs/heads/master@{#296751} TBR=thestig@chromium.org,joaodasilva@chromium.org,pastarmovj@chromium.org NOTREECHECKS=true NOTRY=true BUG=374321,416396 Review URL: https://codereview.chromium.org/603253003 Cr-Commit-Position: refs/heads/master@{#296831}
-
gcasto authored
BUG=415166 Review URL: https://codereview.chromium.org/604563003 Cr-Commit-Position: refs/heads/master@{#296830}
-
sammc authored
Review URL: https://codereview.chromium.org/600363002 Cr-Commit-Position: refs/heads/master@{#296829}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/7214955..f1db071 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/610433004 Cr-Commit-Position: refs/heads/master@{#296828}
-
samuong authored
BUG=chromedriver:908 Review URL: https://codereview.chromium.org/605863002 Cr-Commit-Position: refs/heads/master@{#296827}
-
tedchoc authored
The problem is that calling hide/cancel on a popup is async. With two popups, you would get Previously: SHOW A HIDE A SHOW B NOTIFY SELECTION A HIDE B NOTIFY SELECTION B When notifying the selection of A in the above scenario, it was clearing the frame pointer (and actually updating the wrong popup). Then when hiding the second popup, it's reference was actually gone already. Fix this by making the call to hide sync instead of async. BUG=416354 Review URL: https://codereview.chromium.org/603303002 Cr-Commit-Position: refs/heads/master@{#296826}
-
kkimlabs authored
We won't launch this feature for M39, so disable public opt-in flag. BUG=416664 Review URL: https://codereview.chromium.org/610443002 Cr-Commit-Position: refs/heads/master@{#296825}
-
chrome://settingsestade authored
I missed this one when I was reformatting the controlled settings. BUG=417624 Review URL: https://codereview.chromium.org/601283004 Cr-Commit-Position: refs/heads/master@{#296824}
-
mtomasz authored
It is impossible to whitelist an extension which is note a component, when the api is restricted to components. Since we need to whitelist such regular extension, this patch removes the location restriction and whitelists all clients of this API. Along the way, id testing extensions using this api has been changed to a new one, since it was reused with other tests not related to the api. TEST=browser_tests: *FileBrowser*, *FileManager* BUG=None Review URL: https://codereview.chromium.org/601103002 Cr-Commit-Position: refs/heads/master@{#296823}
-
alexmos authored
Move initializeChildFrame from RenderFrameImpl to RenderFrameProxy. Replace RenderFrameImpl::OnSwapOut's call to setIsRemote with WebRemoteFrame::initializeFromFrame that was introduced in part 1 of this change (https://codereview.chromium.org/591413004/) This will be followed by another CL that will remove setIsRemote on the blink side. BUG=416102 Review URL: https://codereview.chromium.org/592263002 Cr-Commit-Position: refs/heads/master@{#296822}
-
Adam Langley authored
The "snionly" tag only applies to preloaded values and only affects people who are forcing SSLv3 on the command line. (We no longer have the option in the preferences to disable TLS and the preference has been renamed so even those who might have set it in the past shouldn't have it now). It also complicates pending work to reduce the size of the preload data. BUG=102779 R=eroman@chromium.org, rsleevi@chromium.org Review URL: https://codereview.chromium.org/578553004 Cr-Commit-Position: refs/heads/master@{#296821}
-
morrita authored
It doesn't work, and it is no longer used. BUG=416208 R=cpu@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/601563002 Cr-Commit-Position: refs/heads/master@{#296820}
-
rvargas authored
BUG=416722 R=gab@chromium.org, robertshield@chromium.org Review URL: https://codereview.chromium.org/603803002 Cr-Commit-Position: refs/heads/master@{#296819}
-
jdonnelly authored
It's possible to get a copy of an answer from previous matches and get the same answer attached to a similar server-provided answer. In the future, we may decide that we want to have different answers attached to multiple suggestions, but the current assumption is that there should only ever be one suggestion with an answer. BUG= Review URL: https://codereview.chromium.org/603683004 Cr-Commit-Position: refs/heads/master@{#296818}
-
aa authored
BUG= Review URL: https://codereview.chromium.org/598223003 Cr-Commit-Position: refs/heads/master@{#296817}
-
reveman authored
BUG=325045 Review URL: https://codereview.chromium.org/604903005 Cr-Commit-Position: refs/heads/master@{#296816}
-
isherman authored
Exclude more targets from openssl build. BUG=none TEST=none R=jamesr@chromium.org Review URL: https://codereview.chromium.org/602433002 Cr-Commit-Position: refs/heads/master@{#296815}
-
Adam Langley authored
Brings in the following changes: commit 87b96db4268293187d7cf741907a6d5d1d8080e0 Author: agl@chromium.org <agl@chromium.org> Date: Thu Sep 25 20:28:09 2014 +0000 Update to NSS 3.16.7. This contains a fix for the RSA signature forgery bug (CVE-2014-1568): https://www.mozilla.org/security/announce/2014/mfsa2014-73.html Chrome and ChromeOS have already released updates containing this fix: http://googlechromereleases.blogspot.com/2014/09/stable-channel-update_24.html http://googlechromereleases.blogspot.com/2014/09/stable-channel-update-for-chrome-os_24.html https://codereview.appspot.com/142600043/ (This the SVN version of the git change, referenced above. It seems that the NSS git is still a mirror from this SVN repo and thus one cannot commit to it directly.) git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/nss@292145 4ff67af0-8c30-449e-8e8b-ad334ec8d88c BUG=414124 Review URL: https://codereview.chromium.org/603153004 Cr-Commit-Position: refs/heads/master@{#296814}
-
Sam Clegg authored
This brings in the following changes to the addin: r1578 Add default compiler include paths to visual studio r1577 Cleanup create_package.py r1576 Fix several issues with debugging PPAPI plugins r1575 Update versions used for testing the addin r1574 Only skip uploading of addin if the file already exists on google storage. BUG= https://code.google.com/p/chromium/issues/detail?id=179121 R=binji@chromium.org Review URL: https://codereview.chromium.org/604083003 Cr-Commit-Position: refs/heads/master@{#296813}
-
John Abd-El-Malek authored
BUG=417892 TBR=fsamuel@chromium.org Review URL: https://codereview.chromium.org/604103004 Cr-Commit-Position: refs/heads/master@{#296812}
-
gunsch authored
Without this, Chromecast apps will not have time to handle window.unload events when user switches to a new app. R=lcwu@chromium.org,byungchul@chromium.org BUG=400876 Review URL: https://codereview.chromium.org/601293002 Cr-Commit-Position: refs/heads/master@{#296811}
-
Shrikant Kelkar authored
This reverts commit 3d148e7d. BUG=417597 TBR=bauerb@chromium.org,dhnishi@chromium.org,cpu@chromium.org Review URL: https://codereview.chromium.org/595213006 Cr-Commit-Position: refs/heads/master@{#296810}
-
grunell authored
Use it at appropriate places. Also add corresponding UMA histogram value. BUG=416233 Review URL: https://codereview.chromium.org/586223002 Cr-Commit-Position: refs/heads/master@{#296809}
-
mad authored
Review URL: https://codereview.chromium.org/599633005 Cr-Commit-Position: refs/heads/master@{#296808}
-
dmichael authored
Blocking renderer->plugin messages can be interrupted by any message from the plugin->renderer (even async ones). So while handline a blocking message, such as HandleInputEvent or HandleBlockingMessage, it's currently possible to re-enter JavaScript. This patch makes that impossible by queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage while any renderer->plugin sync message is on the stack. BUG=384528 Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506 Cr-Commit-Position: refs/heads/master@{#296311} Review URL: https://codereview.chromium.org/589213003 Cr-Commit-Position: refs/heads/master@{#296807}
-
mukai authored
Bunch of includes are actually unnecessary, simply removed them. For the fullscreen state, I believe FullscreenNotificationBlocker can handle it correctly. MessageCenterNotificationManager doesn't have to handle it anymore. BUG=None R=dewittj@chromium.org TEST=manually Review URL: https://codereview.chromium.org/604453002 Cr-Commit-Position: refs/heads/master@{#296806}
-
sergeyu authored
Previously 4096 bytes write buffer was used for XMPP socket. Problem is that ChromeAsyncSocket stops writing when the buffer is full and talk::XmppClient ignores this error, as result random chunks of data may be lost. This CL increses buffer size to 64k - same value that's used in notifier::XmppConnection. This is essentially a temporary workaround until the problem is fixed in jingle::ChromeAsyncSocket or talk::XmppClient BUG=417336 Review URL: https://codereview.chromium.org/608613002 Cr-Commit-Position: refs/heads/master@{#296805}
-
vadimt authored
Adding tracking to verify the theory that jankiness of ExtensionMessageFilter::OnExtensionAddListener is because of the observer invocation. BUG=401560, 417106 Review URL: https://codereview.chromium.org/600213002 Cr-Commit-Position: refs/heads/master@{#296804}
-
Dominic Mazzoni authored
We still need to finish updating the extensions to use these translations. BUG=416983 TBR=plundblad Review URL: https://codereview.chromium.org/610453002 Cr-Commit-Position: refs/heads/master@{#296803}
-
reillyg authored
The common string descriptors: iManufacturer, iProduct and iSerialNumber should be accessible without opening the device. On Linux these can be read out of sysfs without having access to the usbfs device node. This is critical on Chrome OS because otherwise the permission broker needs to be asked for permission to access the device. On other platforms we fall back to opening the device temporarily. This will stop being the case on OS X when libusb is no longer used and on Windows this will be part of the initial enumeration process. BUG= TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/601073002 Cr-Commit-Position: refs/heads/master@{#296802}
-
edwardjung authored
+ Correct the layout and size of the offline icon when getting a DNS_PROBE_FINISHED_NO_INTERNET error + Delay AudioContext initialising until required to reduce CPU usage. BUG=417614 Review URL: https://codereview.chromium.org/601523003 Cr-Commit-Position: refs/heads/master@{#296801}
-
John Abd-El-Malek authored
BUG=414808 R=maruel@chromium.org Review URL: https://codereview.chromium.org/601283005 Cr-Commit-Position: refs/heads/master@{#296800}
-
asargent authored
Normally extensions must specify a concrete list of url patterns. But with this patch, extensions on the whitelist can do: "permissions": ["externally_connectable.all_urls"], "externally_connectable": { "matches": ["<all_urls>"] } and they will be able to be connected to from any url. Also add an entry to the whitelist for the CryptoToken extension. BUG=417062,417494 Review URL: https://codereview.chromium.org/599163003 Cr-Commit-Position: refs/heads/master@{#296799}
-
derat authored
Make DisplayConfigurator save the requested display power state even when it fails to configure CRTCs. This lets the previously-requested state be used for future mode changes. BUG=chrome-os-partner:31571 Review URL: https://codereview.chromium.org/597683004 Cr-Commit-Position: refs/heads/master@{#296798}
-
pkotwicz authored
BUG=416209 TEST=None Review URL: https://codereview.chromium.org/591803002 Cr-Commit-Position: refs/heads/master@{#296797}
-
nyquist authored
This removes the last files regarding guava since http://crbug.com/380688 has now been addressed. TBR=darin@chromium.org BUG=412673 Review URL: https://codereview.chromium.org/602203003 Cr-Commit-Position: refs/heads/master@{#296796}
-