GitLab

        Reviewed by Dimitri Glazkov.

        NULL pointer crash when using :empty and :first-line pseudoclass selectors together
        https://bugs.webkit.org/show_bug.cgi?id=53316

        * fast/css/empty-first-line-crash-expected.txt: Added.
        * fast/css/empty-first-line-crash.html: Added.
2011-03-10  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Dimitri Glazkov.

        NULL pointer crash when using :empty and :first-line pseudoclass selectors together
        https://bugs.webkit.org/show_bug.cgi?id=53316

        :empty is calculated for each element during parsing, but then not
        recalculated after any child elements are attached. Force style
        re-calculation on elements which have :empty in their style when
        their children are changed.

        Test: fast/css/empty-first-line-crash.html

        * dom/Element.cpp:
        (WebCore::checkForEmptyStyleChange): Pull out empty style checking
        logic from checkForSiblingStyleChanges().
        (WebCore::checkForSiblingStyleChanges): Use new checkForEmptyStyleChanges()
        method.
        (WebCore::Element::childrenChanged):  Call checkForEmptyStyleChanges() when
        called with changedByParser = true.

git-svn-id: svn://svn.chromium.org/blink/trunk@80803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix.

        Fix Leopard Release build broken by r80797.

        * html/CollectionCache.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@80802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rubber-stamped by Sam Weinig.

The presence of CFBundleDevelopmentRegion in the application's Info.plist prevents
the default localization that we set during launch from being respected.

* PluginProcess/Info.plist: Remove CFBundleDevelopmentRegion.
* WebProcess/Info.plist: Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

send notifications appropriate times (showing up, resizing)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=56067

Reviewed by Darin Adler.

The general strategy here is to add a HashSet of ScrollableAreas to the page that 
can be accessed when necessary to send notifications to all ScrollableAreas.

Find layers for relevant node and if the layers are in the Page's ScrollableArea 
set, then send the relevant notification.
* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

When the page is set active or not active, iterate through the Page's 
ScrollableAreas to send hide/show notifications. 
* page/FocusController.cpp:
(WebCore::FocusController::setActive):

When a FrameView is created, add it to the ScrollableArea set. When it's 
destroyed, remove it.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):

Iterate through the Page's ScrollableAreas to send the paint notification.
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
* page/FrameView.h:

Add the new ScrollableArea set.
* page/Page.cpp:
(WebCore::Page::addScrollableArea):
(WebCore::Page::removeScrollableArea):
(WebCore::Page::pageContainsScrollableArea):
* page/Page.h:
(WebCore::Page::scrollableAreaSet):

notifyPageThatContentAreaWillPaint() is a dummy function implemented in FrameView.
* platform/ScrollView.cpp:
(WebCore::ScrollView::notifyPageThatContentAreaWillPaint):

Call notifyPageThatContentAreaWillPaint() instead of calling 
contentAreaWillPaint() just for the ScrollView.
(WebCore::ScrollView::paint):
* platform/ScrollView.h:

Add/remove ScrollableAreas to the set.
* rendering/RenderDataGrid.cpp:
(WebCore::RenderDataGrid::RenderDataGrid):
(WebCore::RenderDataGrid::~RenderDataGrid):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):

Should have implemented this ScrollableArea-interface function a while ago.
(WebCore::RenderLayer::currentMousePosition):
* rendering/RenderLayer.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@80800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rebaseline a test which differs on the bots from my local machine.

        * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Update results.

git-svn-id: svn://svn.chromium.org/blink/trunk@80799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Hyatt.

        Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
        https://bugs.webkit.org/show_bug.cgi?id=55069

        * platform/win/Skipped: Removed text-combine-parser-test.html
2011-03-10  takano takumi  <takano@apple.com>

        Reviewed by David Hyatt.

        Crash in RenderCombineText::combineText when running fast/text/international/text-combine-parser-test.html on Windows with full page heap enabled
        https://bugs.webkit.org/show_bug.cgi?id=55069

        No new tests. If the test above runs without crash, the fix should be okay.

        * dom/Node.cpp:
        (WebCore::Node::diff):
        - Changed to return Detach when textCombine style was changed.
        * rendering/RenderCombineText.cpp:
        (WebCore::RenderCombineText::styleDidChange):
        (WebCore::RenderCombineText::setTextInternal):
        (WebCore::RenderCombineText::width):
        (WebCore::RenderCombineText::adjustTextOrigin):
        (WebCore::RenderCombineText::charactersToRender):
        (WebCore::RenderCombineText::combineText):
        - Added assertions to ensure the passed object is RenderCombineText.
        * rendering/RenderCombineText.h:
        (WebCore::RenderCombineText::isCombineText):
        - Added to distinguish plain RenderText and RenderCombineText.
        (WebCore::toRenderCombineText):
        - Added assertions to ensure the passed object is RenderCombineText.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isCombineText):
        - Added to distinguish plain RenderText and RenderCombineText.

git-svn-id: svn://svn.chromium.org/blink/trunk@80798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Collection cache not reset when moving base node between documents
        https://bugs.webkit.org/show_bug.cgi?id=55446

        Add tests for accessing elements moved across documents using namedItem.

        * fast/dom/HTMLFormElement/invalid-form-field-expected.txt: Added.
        * fast/dom/HTMLFormElement/invalid-form-field.html: Added.
        * fast/dom/HTMLFormElement/move-option-between-documents-expected.txt: Added.
        * fast/dom/HTMLFormElement/move-option-between-documents.html: Added.
        * fast/dom/collection-nameditem-move-between-documents-expected.txt: Added.
        * fast/dom/collection-nameditem-move-between-documents.html: Added.
2011-03-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Collection cache not reset when moving base node between documents
        https://bugs.webkit.org/show_bug.cgi?id=55446

        Fix bug where HTMLCollection::resetCollectionInfo does not reset the
        cache when the base node is moved to a different document by making sure
        that the DOMVersion is updated and that it's unique across documents.

        Tests: fast/dom/HTMLFormElement/invalid-form-field.html
               fast/dom/HTMLFormElement/move-option-between-documents.html
               fast/dom/collection-nameditem-move-between-documents.html

        * dom/Document.cpp:
        (WebCore::Document::Document):
        * dom/Document.h:
        (WebCore::Document::incDOMTreeVersion):
        (WebCore::Document::domTreeVersion):
        * dom/Node.cpp:
        (WebCore::Node::setDocumentRecursively):
        * html/FormAssociatedElement.cpp:
        (WebCore::FormAssociatedElement::resetFormOwner):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::resetCollectionInfo):
        * xml/XPathResult.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@80797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Laszlo Gombos.

        [Qt] Text layout is broken on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=56046

        Change integers included into bitfields to be signed by default on RVCT
        compiler as a lot of other compilers do (gcc, msvc, winsc).
        There are a lot of places in webkit where integers included in bitfield
        are assumed to be signed.

        * Source/WebKit.pri:

git-svn-id: svn://svn.chromium.org/blink/trunk@80796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Formatted Diff for attachment 23920 is mangled
        https://bugs.webkit.org/show_bug.cgi?id=21222

        The mangled diff files mentioned in the bug were using Mac line
        ending and this was causing problems for String#each_line. Now we
        normalize the line endings in patch data before processing it.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: svn://svn.chromium.org/blink/trunk@80795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix.

        [EFL] Fix build break when CROSS_PLATFORM_CONTEXT_MENUS is disabled.
        https://bugs.webkit.org/show_bug.cgi?id=56005

        There are build breaks when CROSS_PLATFORM_CONTEXT_MENUS is disabled.

        * platform/efl/ContextMenuEfl.cpp:
        (WebCore::ContextMenu::ContextMenu):
        * platform/efl/ContextMenuItemEfl.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@80794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        startOfBlock and endOfBlock may return a position inside hr
        https://bugs.webkit.org/show_bug.cgi?id=56025

        Replaced calls to enclosingBlockFlowElement in startOfBlock and endOfBlock by
        calls to enclosingBlock. Added EditingBoundaryCrossingRule to the argument lists
        of startOfBlock, endOfBlock, and enclosingBlock. Also replaced the last boolean
        argument variable of enclosingNodeOfType by EditingBoundaryCrossingRule.

        Also replaced calls to enclosingBlockFlowElement in inSameBlock by calls to
        enclosingBlock to be consitent with startOfBlock and endOfBlock.

        This patch also replaced calls to deprecatedNode in startOfBlock, endOfBlock,
        and inSameBlock by calls to containerNode because the enclosing block of a position
        should never be before or after the position.

        No tests are added because this change only affects WebCore internally.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData): Calls enclosingNodeOfType.
        Pass CanCrossEditingBoundary instead of false.
        * editing/htmlediting.cpp:
        (WebCore::unsplittableElementForPosition): Ditto.
        (WebCore::enclosingBlock): Takes EditingBoundaryCrossingRule and passes it to
        enclosingNodeOfType.
        (WebCore::enclosingNodeOfType): Takes EditingBoundaryCrossingRule instead of boolean.
        Fixed a bug that it stops walking the tree when it reached the root editable node
        even when the editing boundary crossing rule is CanCrossEditingBoundary.
        * editing/htmlediting.h: Prototype changes.
        * editing/visible_units.cpp:
        (WebCore::startOfBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
        Also added an early exit when there's no enclosing block.
        (WebCore::endOfBlock): Ditto. The early exist in this case prevents crash in
        lastPositionInNode.
        (WebCore::inSameBlock): Calls enclosingBlock instead of enclosingBlockFlowElement.
        (WebCore::isStartOfBlock): Calls startOfBlock with CanCrossEditingBoundary because
        we don't care where the start of block is when we're comparing against the given position.
        (WebCore::isEndOfBlock): Ditto.
        * editing/visible_units.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@80793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Build for WebKit2 GTK+ after r80714.

        * GNUmakefile.am: Update source list.
        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        (WebKit::x11Display): Add missing semicolon.

git-svn-id: svn://svn.chromium.org/blink/trunk@80792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dan Bernstein.

        Backspace deletes all non-BMP symbols at once, and then some
        https://bugs.webkit.org/show_bug.cgi?id=55971
        <rdar://problem/8725312>

        * platform/mac/editing/input/insert-delete-smp-symbol-expected.txt: Added.
        * platform/mac/editing/input/insert-delete-smp-symbol.html: Added.
2011-03-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Dan Bernstein.

        Backspace deletes all non-BMP symbols at once, and then some
        https://bugs.webkit.org/show_bug.cgi?id=55971
        <rdar://problem/8725312>

        Test: platform/mac/editing/input/insert-delete-smp-symbol.html

        * rendering/RenderText.cpp:
        (WebCore::isMark): This matches what Core Foundation does for all characters that I tested.
        (WebCore::RenderText::previousOffsetForBackwardDeletion): Changed to use isMark().

git-svn-id: svn://svn.chromium.org/blink/trunk@80791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=55959

Reviewed by Darin Adler.

NSApplication has to return the focused element within the app in order
for NSAccessibilityHandleFocusChanged() to work. The default implementation
relies on keyWindow. Consequently, in WK2, the WebProcess must override that method
to return the appropriate focused element within the WebProcess, since
there is no keyWindow.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::focusedWebPage):
* WebProcess/WebProcess.h:
* WebProcess/mac/NSApplicationOverride.mm: Added.
(-[NSApplication accessibilityFocusedUIElement]):



git-svn-id: svn://svn.chromium.org/blink/trunk@80789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        Error in StyleElement::process with large nodesets
        https://bugs.webkit.org/show_bug.cgi?id=56150

        Test: none due to excessive runtime and CRASH() vs. real crash.

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::process): Handle large node sets better.


git-svn-id: svn://svn.chromium.org/blink/trunk@80787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Reviewed by Simon Fraser.

Percentage heights should skip anonymous containing blocks when computing the used value.

Added fast/block/basic/percentage-height-inside-anonymous-block.html

Source/WebCore: 

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):

LayoutTests: 

* fast/block/basic/percent-height-inside-anonymous-block.html: Added.
* platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Added.
* platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Added.
* platform/mac/fast/block/basic/percent-height-inside-anonymous-block-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@80786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by James Robinson.

        [chromium] Make updateAndDrawLayers argumentless.
        https://bugs.webkit.org/show_bug.cgi?id=55985

        Made the TilePainters and viewport parameters for
        LayerRendererChromium member variables instead of arguments on
        updateAndDrawLayers. In a future change, this will allows us to
        draw the layer tree without the WebView's assistance.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::verticalScrollbarRect):
        (WebCore::LayerRendererChromium::horizontalScrollbarRect):
        (WebCore::LayerRendererChromium::invalidateRootLayerRect):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::setRootLayer):
        (WebCore::LayerRendererChromium::getFramebufferPixels):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::viewportSize):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
2011-03-10  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Make updateAndDrawLayers argumentless.
        https://bugs.webkit.org/show_bug.cgi?id=55985

        Made the TilePainters and viewport parameters for
        LayerRendererChromium member variables instead of arguments on
        updateAndDrawLayers. In a future change, this will allows us to
        draw the layer tree without the WebView's assistance.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::scrollRootLayerRect):
        (WebKit::WebViewImpl::invalidateRootLayerRect):
        (WebKit::WebViewImplContentPainter::create):
        (WebKit::WebViewImplContentPainter::paint):
        (WebKit::WebViewImplContentPainter::WebViewImplContentPainter):
        (WebKit::WebViewImplScrollbarPainter::create):
        (WebKit::WebViewImplScrollbarPainter::paint):
        (WebKit::WebViewImplScrollbarPainter::WebViewImplScrollbarPainter):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        * src/WebViewImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@80785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Andreas Kling.

        Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1, part3
        Solving conflict of Qt and Xlib includes

        * Shared/Plugins/NPIdentifierData.cpp:
        * Shared/Plugins/NPIdentifierData.h:
        * Shared/Plugins/NPObjectProxy.cpp:
        * Shared/Plugins/NPVariantData.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@80784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        [GTK] Implement spin buttons for GTK+ 2.x
        https://bugs.webkit.org/show_bug.cgi?id=53098

        Unskip tests which are now passing with the spin button implementation.
        Add results for one test.

        * platform/gtk/Skipped: Unskip passing tests.
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
2011-01-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Implement spin buttons for GTK+ 2.x
        https://bugs.webkit.org/show_bug.cgi?id=53098

        Implement spin buttons for GTK+ 2.x. This allows proper render and functioning
        for input type=number. The implementation is based on the one in gtkspinbutton.c
        from the GTK+ sources.

        * platform/gtk/RenderThemeGtk.h: Added new members and getters.
        * platform/gtk/RenderThemeGtk2.cpp:
        (WebCore::RenderThemeGtk::platformInit): Initialize spin button widget.
        (WebCore::RenderThemeGtk::adjustRepaintRect): We need to draw outside the
        spin button area to have proper rendering. There doesn't seem to be any other
        clean way of having spin buttons that are the size of the text input frame.
        (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): Added implementation.
        (WebCore::RenderThemeGtk::paintInnerSpinButton): Ditto.
        (WebCore::RenderThemeGtk::gtkSpinButton): Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@80783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        PrettyPatch displays last two lines of a git-format-patch diff strangely
        https://bugs.webkit.org/show_bug.cgi?id=29317

        If the diff section has full range information, we parse only enough to cover the
        range. This avoids incorrectly showing trailing lines (like git signature) as part
        of the patch.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: svn://svn.chromium.org/blink/trunk@80782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix after r80774.

        QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
        See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451

        * declarative/plugin.cpp:
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp:
        * declarative/qdeclarativewebview_p.h:
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:


git-svn-id: svn://svn.chromium.org/blink/trunk@80781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ryosuke Niwa.

        InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
        https://bugs.webkit.org/show_bug.cgi?id=53409

        Avoiding crashes and infinite loops when listifying content with mixed-editability

        * editing/execCommand/insert-list-with-noneditable-content-expected.txt: Added.
        * editing/execCommand/insert-list-with-noneditable-content.html: Added.
2011-03-10  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        InsertUnorderedList over a non-editable region and multiple lines enters an infinite loop
        https://bugs.webkit.org/show_bug.cgi?id=53409

        Fixing broken handling of mixed-editability content for InsertListCommand. Previously, if the selection
        spanned non-contenteditable regions, it would get stuck endlessly iterating the same region as the algorithm
        didn't skip the editable boundary.

        Test: editing/execCommand/insert-list-with-noneditable-content.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::cleanupAfterDeletion): Changed signature to take the destination
        position for the active editing command. Without this, there are cases when the destination happens
        to be a placeholder, and we remove it.
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/CompositeEditCommand.h:
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Added logic to the paragraph iteration loop to handle pockets of
        non-editable content in an editable context. Previously, this could cause an infinite loop.
        * editing/visible_units.cpp:
        (WebCore::startOfParagraph): Added a mode of operation where we'll jump across non-editable
        content in the same paragraph to reach the actual editable paragraph start.
        (WebCore::endOfParagraph): Ditto.
        (WebCore::startOfNextParagraph): Now uses the aforementioned non-editable content skipping mode of
        endOfParagraph.


git-svn-id: svn://svn.chromium.org/blink/trunk@80780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Calling focus() on an area element not in a document should not cause a NULL ptr crash
        https://bugs.webkit.org/show_bug.cgi?id=54877

        * fast/dom/HTMLAreaElement: Added.
        * fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash-expected.txt: Added.
        * fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html: Added.
2011-03-10  Berend-Jan Wever  <skylined@chromium.org>

        Reviewed by Darin Adler.

        Calling focus() on an area element not in a document should not cause a NULL ptr crash
        https://bugs.webkit.org/show_bug.cgi?id=54877

        Test: fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html

        * dom/Element.cpp:
        (WebCore::Element::focus): Check element is in the document before allowing focus
        * html/HTMLAreaElement.cpp:
        (WebCore::HTMLAreaElement::imageElement): Check element has a parent before checking if its parent is a map

git-svn-id: svn://svn.chromium.org/blink/trunk@80779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Windows rebaselines for r80755.

        * platform/win/editing/selection/caret-ltr-right-expected.txt:
        * platform/win/editing/selection/caret-rtl-2-left-expected.txt:
        * platform/win/editing/selection/caret-rtl-right-expected.txt:
        * platform/win/fast/forms/file-input-disabled-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@80778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Tony Chang.

        [Chromium] Fix default single selection select's popup background on chromium/linux
        https://bugs.webkit.org/show_bug.cgi?id=56023

        * fast/html/select-dropdown-consistent-background-color-expected.txt: Added.
        * fast/html/select-dropdown-consistent-background-color.html: Added.
2011-03-10  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Fix default single selection select's popup background on chromium/linux
        https://bugs.webkit.org/show_bug.cgi?id=56023

        Test: fast/html/select-dropdown-consistent-background-color.html

        * css/themeChromiumLinux.css:

git-svn-id: svn://svn.chromium.org/blink/trunk@80777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        Testing the improved Accept header as per bug 27267.
        https://bugs.webkit.org/show_bug.cgi?id=27267

        * http/tests/misc/xhtml-expected.txt: Tests against improved Accept header.
2011-03-10  Kris Jordan  <krisjordan@gmail.com>

        Reviewed by Alexey Proskuryakov.

        Improve default Accept header to give preference to HTML over XML.
        https://bugs.webkit.org/show_bug.cgi?id=27267

        * loader/FrameLoader.cpp:Changed default accept header to match
        FireFox' as per bug 27267.

git-svn-id: svn://svn.chromium.org/blink/trunk@80776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Xan Lopez.

        [GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=56125

        No new tests. This functionality will be tested once we have TestRunner
        implementation for WebKit2 with pixel dumping support.

        * GNUmakefile.am: Add a new define with tracks whether or not we are using
        our specialized GTK+ ScrollView.
        * platform/ScrollView.cpp: Only use the GTK+-specific ScrollView if we are compiling
        WebKit1.
        (WebCore::ScrollView::wheelEvent):
        * platform/gtk/ScrollViewGtk.cpp: Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Andreas Kling.

        [Qt] QtDeclarative Webview element has a fixed white background
        https://bugs.webkit.org/show_bug.cgi?id=40918

        Implement a way to change the background color of the WebView QML element.
        This feature is activated for QtWebKit 1.1 version of the plugin.

        * declarative/plugin.cpp:
        (WebKitQmlPlugin::registerTypes):
        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::backgroundColor):
        (QDeclarativeWebView::setBackgroundColor):
        * declarative/qdeclarativewebview_p.h:
        * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
        (tst_QDeclarativeWebView::backgroundColor):
        * tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:

git-svn-id: svn://svn.chromium.org/blink/trunk@80774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Assertion fails by validating a form twice very quickly
        https://bugs.webkit.org/show_bug.cgi?id=56069

        * fast/forms/interactive-validation-assertion-by-validate-twice-expected.txt: Added.
        * fast/forms/interactive-validation-assertion-by-validate-twice.html: Added.
        * fast/forms/interactive-validation-attach-assertion.html: Remove unnecessary offsetLeft trick.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-10  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Assertion fails by validating a form twice very quickly
        https://bugs.webkit.org/show_bug.cgi?id=56069

        If the interactive validation is invoked when a form control is in
        needsLayout() state, an assertion in isFocusable() fails. To avoid it,
        Add a call to updateLayoutIgnorePendingStylesheets() before isFocusable().

        Test: fast/forms/interactive-validation-assertion-by-validate-twice.html

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::validateInteractively):
          Calls updateLayoutIgnorePendingStylesheets().

git-svn-id: svn://svn.chromium.org/blink/trunk@80773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unskipping some crashers on GTK+. These no longer crash locally and we'd
        like to figure out if they still crash on the bots. Move one flaky test
        to the appropriate section.

        * platform/gtk/Skipped: Unskip tests passing locally.

git-svn-id: svn://svn.chromium.org/blink/trunk@80772 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Antonio Gomes.

        [EFL] Limit touch events when only page required touch events.
        https://bugs.webkit.org/show_bug.cgi?id=54857

        Block touch events when ChromeClient::needTouchEvents got false.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::needTouchEvents):
        * WebCoreSupport/ChromeClientEfl.h:
        * ewk/ewk_frame.cpp:
        (ewk_frame_feed_touch_event):
        * ewk/ewk_private.h:
        * ewk/ewk_view.cpp:
        (ewk_view_need_touch_events_set):
        (ewk_view_need_touch_events_get):

git-svn-id: svn://svn.chromium.org/blink/trunk@80771 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Reviewed by Beth Dakin.

Static distance computation is wrong when an ancestor is also positioned.  We need to go up the container()
chain (after initially starting with the parent()) when doing this computation, so that we properly skip
intermediate boxes between two positioned blocks.

Added fast/block/positioning/static-distance-with-positioned-ancestor.html.

Source/WebCore: 

* rendering/RenderBox.cpp:
(WebCore::computeInlineStaticDistance):
(WebCore::computeBlockStaticDistance):

LayoutTests: 

* fast/block/positioning/static-distance-with-positioned-ancestor.html: Added.
* platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Added.
* platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Added.
* platform/mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@80770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Laszlo Gombos.

        [Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
        https://bugs.webkit.org/show_bug.cgi?id=55945

        Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
        set interval used to trigger when decoded data in dead list of object cache will
        be purged from object cache.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):

git-svn-id: svn://svn.chromium.org/blink/trunk@80769 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Antonio Gomes.

        Simplify how QWebFrame::requestedUrl() is obtained
        https://bugs.webkit.org/show_bug.cgi?id=55842

        When a load starts, store the requested URL until we know that it'll be
        available for us in the document loader -- after load finished.

        The existing auto tests cover the three different code paths in
        requestedUrl() and the new code passes the autotests. In each of those
        cases, we looked for the information in a different place, but in all
        of them, dispatchDidStartProvisionalLoad was called.

        This simplification will be useful to fix bug 32723. The way requestedUrl()
        is implementent, we can't use it as a fallback for url() when the setUrl()
        was called with an invalid URL.

        * Api/qwebframe.cpp:
        (QWebFrame::requestedUrl):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
        * WebCoreSupport/FrameLoaderClientQt.h:
        (WebCore::FrameLoaderClientQt::lastRequestedUrl):

git-svn-id: svn://svn.chromium.org/blink/trunk@80768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Russell.

        [chromium] Make tiled compositor data structure more efficient.
        https://bugs.webkit.org/show_bug.cgi?id=54133

        Previously, the compositor had a sparse 2D array of tiles for the
        whole page, most of which were null.  The tiles were implicitly
        located based on their position in the array. This was inefficient
        when the page grew (e.g. infinite scrolling) and caused some bugs
        (e.g. width * height > MAX_INT).  This change modifies tiles to have
        explicit positions so they can be stored in a hash map.

        Tests: LayoutTests/compositing/

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::reset):
        (WebCore::LayerTilerChromium::createTile):
        (WebCore::LayerTilerChromium::invalidateTiles):
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::tileAt):
        (WebCore::LayerTilerChromium::tileContentRect):
        (WebCore::LayerTilerChromium::tileLayerRect):
        (WebCore::LayerTilerChromium::invalidateRect):
        (WebCore::LayerTilerChromium::invalidateEntireLayer):
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::updateFromPixels):
        (WebCore::LayerTilerChromium::draw):
        (WebCore::LayerTilerChromium::growLayerToContain):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::Tile::Tile):
        (WebCore::LayerTilerChromium::Tile::i):
        (WebCore::LayerTilerChromium::Tile::j):
        (WebCore::LayerTilerChromium::Tile::moveTo):
        (WebCore::LayerTilerChromium::TileMapKeyTraits::emptyValue):
        (WebCore::LayerTilerChromium::TileMapKeyTraits::constructDeletedValue):
        (WebCore::LayerTilerChromium::TileMapKeyTraits::isDeletedValue):

git-svn-id: svn://svn.chromium.org/blink/trunk@80767 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix for r80752; Negated the boolean logic.

        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):


git-svn-id: svn://svn.chromium.org/blink/trunk@80766 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Mark Rowe.

* WebKit2.xcodeproj/project.pbxproj:
Make sure to base the PluginProcess target on the correct xcconfig file
in all configurations.



git-svn-id: svn://svn.chromium.org/blink/trunk@80765 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Adam Roben.

* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):



git-svn-id: svn://svn.chromium.org/blink/trunk@80764 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't paint more than 60 times per second even when scrolling

Reviewed by Sam Weinig.

* WebView/WebClipView.mm:
(-[WebClipView _immediateScrollToPoint:]):



git-svn-id: svn://svn.chromium.org/blink/trunk@80763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, roll chromium version to r77259 to pick up
        webfontinfo api change.

        * DEPS:

git-svn-id: svn://svn.chromium.org/blink/trunk@80762 bbb929c8-8fbe-4397-9dbb-9b2b20218538