GitLab

R=lushnikov

Review URL: https://codereview.chromium.org/334313002

git-svn-id: svn://svn.chromium.org/blink/trunk@176302 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The flakiness is caused by unpredictable order of stylesheets binding in InspectorCSSAgent.
This patch replaces HashSet with Vector to make sure the order is maintained.

R=lushnikov

Review URL: https://codereview.chromium.org/339133002

git-svn-id: svn://svn.chromium.org/blink/trunk@176301 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specs state in section 5.2.2 that explicitly adding named lines of the form
<foo-start>/<foo-end> should effectively create a named grid area (named foo
in this case). We got this for free in r174021 as a nice side effect of
implementing the resolution for named grid lines. We just lack proper test
coverage to ensure that we don't regress.

Review URL: https://codereview.chromium.org/313263003

git-svn-id: svn://svn.chromium.org/blink/trunk@176300 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. (https://codereview.chromium.org/333403004/)

Reason for revert:
This patch leaks svg-font-face-leak-document test

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=svg/svg-font-face-leak-document.html

Original issue's description:
> Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement.
> 
> BUG=357163
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176270

BUG=357163

Review URL: https://codereview.chromium.org/337703004

git-svn-id: svn://svn.chromium.org/blink/trunk@176299 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec says that bufferedAmount must not decrease in the task that
send() is called.
Fixed both the new and the old implementation although the old implementaion
is at any rate broken (bufferedAmount in the old implementation includes
the protocol overhead).

BUG=159563

Review URL: https://codereview.chromium.org/311993006

git-svn-id: svn://svn.chromium.org/blink/trunk@176298 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This was introduced in r176205.

BUG=None
TBR=caseq

Review URL: https://codereview.chromium.org/339873002

git-svn-id: svn://svn.chromium.org/blink/trunk@176297 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change removes the "invalid media attribute" case from this test
so that it passes on release builds. This test was passing for the
wrong reasons on the Chromium waterfall because an error was being generated
for MP4 not being supported instead of the invalid attribute. The test
URL was changed to an Ogg file so that a supported media type will
be used on both the Chrome and Chromium builds.

BUG=338197
TESTS=LayoutTests/media/video-source-error-no-candidate.html

Review URL: https://codereview.chromium.org/334353003

git-svn-id: svn://svn.chromium.org/blink/trunk@176296 bbb929c8-8fbe-4397-9dbb-9b2b20218538

From the grid layout spec we can extract the following sentence:
"If the grid item has an automatic position and a grid span for a named
line in a given dimension, instead treat the grid span as one."

The main reason is that as you don't know where the item is going to be
placed (because of it's auto-positioned), spanning to a particular line
makes no sense.

Updated GridResolvedPosition code to include this restriction when
resolving positions.

Adapted auto-placement algorithm implementation in RenderGrid as now
it's possible to pass row and column spans to
GridIterator::nextEmptyGridArea() simplifying the code.

Updated layout test to the new behavior.

BUG=353789
TEST=fast/css-grid-layout/grid-item-auto-placement-automatic-span.html

Review URL: https://codereview.chromium.org/320093002

git-svn-id: svn://svn.chromium.org/blink/trunk@176295 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The core:core_generated target previously needed many include_dirs in
its path, due to unqualified include statements.
These have been resolved, and now we can remove them!

R=haraken
BUG=377364

Review URL: https://codereview.chromium.org/340473002

git-svn-id: svn://svn.chromium.org/blink/trunk@176294 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/275043002

git-svn-id: svn://svn.chromium.org/blink/trunk@176293 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bonus: sort expectations file

TBR=dmikurube@chromium.org
NOTRY=true
BUG=364390

Review URL: https://codereview.chromium.org/334403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176292 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/341433003

git-svn-id: svn://svn.chromium.org/blink/trunk@176291 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and make m_mediaElement Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/339843002

git-svn-id: svn://svn.chromium.org/blink/trunk@176290 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- added "all" property to CSSProperties.in and so on.
- added "unset" CSSValue. "unset" is defined in all spec.

all spec: http://dev.w3.org/csswg/css-cascade/#all-shorthand

BUG=172051
TEST=fast/css/all-shorthand-css-text.html,fast/css/all-shorthand.html,fast/css/getComputedStyle/getComputedStyle-all.html

Review URL: https://codereview.chromium.org/338023002

git-svn-id: svn://svn.chromium.org/blink/trunk@176289 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In the latest editor's draft spec [1], FontFaceSet#ready has been
changed from a method to an attribute. We are likely to deprecate
ready() in favor of ready attribute. To prepare for a deprecation
process, this patch adds a UseCounter for FontFaceSet#ready().

[1] http://dev.w3.org/csswg/css-font-loading/#dom-fontfaceset-ready

BUG=380990

Review URL: https://codereview.chromium.org/339563006

git-svn-id: svn://svn.chromium.org/blink/trunk@176288 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/334373004

git-svn-id: svn://svn.chromium.org/blink/trunk@176287 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NavigatorContentUtilsClientImpl has been placed in ChromeClientImpl.cpp.
It would be good if NavigatorContentUtilsClientImpl has own file, because
new functions have been added to the NavigatorContentUtilsClientImpl. Besides
more functionality will be added in future.

BUG=none

Review URL: https://codereview.chromium.org/331223002

git-svn-id: svn://svn.chromium.org/blink/trunk@176286 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Don't try to mimic IE's special hit-testing behavior for touch-action - it probably only adds confusion and is unlikely to cause compat issues in practice.  See http://crbug.com/380203 for details.

Also reduces the hit tests done on touchstart from 2 to 1 for improved performance.

BUG=380203

Review URL: https://codereview.chromium.org/329773002

git-svn-id: svn://svn.chromium.org/blink/trunk@176285 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, static SVGPropertyTearOff items inserted into a SVGListTearOff were not marked as a tear-off.
For such items, |svgAttributeChanged| was not dispatched to its context element, and view was not updated when its value changed.

This patch fixes the issue by converting a static tear-off inserted into a list to a dynamic tear-off.

Also this patch fixes an issue that a tearoff returned from replaceItem/removeItem was still attached to the list.

BUG=380546, 380176

Review URL: https://codereview.chromium.org/321403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176284 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebSocket::resume starts a timer which does the actual resume work when fired.
WebSocket::suspend must stop the timer in case it is called while the
timer is active.

BUG=NONE
R=tyoshino

Review URL: https://codereview.chromium.org/330253002

git-svn-id: svn://svn.chromium.org/blink/trunk@176283 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the document gets detached before Service Worker registration
completes, the CallbackPromiseAdapter promise gets cleared. Then when
registration completes, ServiceWorker::from is passed the resolver with
the empty promise. Before this patch, an assert would then occur because
ScriptPromise::then bails before adopting its fulfilled/rejected
arguments. This patch fixes an overly aggressive assert in
V8GarbageCollected and also makes ServiceWorker creation skip waiting
on an empty promise.

BUG=384498

Review URL: https://codereview.chromium.org/337053004

git-svn-id: svn://svn.chromium.org/blink/trunk@176282 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Forbid creating new wrapper from SetWrapperReferenceTo (https://codereview.chromium.org/332643003/)

Reason for revert:
There seems to be an existing bug which hits this callpath. Reverting the change until the bug is fixed.

Original issue's description:
> Forbid creating new wrapper from SetWrapperReferenceTo
> 
> SetWrapperReferenceTo IDL attribute is a hack to use V8 wrapper reference
> to avoid reference cycles in Blink. The |visitDOMWrapper| callback is
> used to create a temporary strong reference between the wrappers in GC
> prologue.
> 
> Before this patch, |visitDOMWrapper| was allowed to create a new wrapper
> if the wrapper for target object didn't exist. However this is dangerous,
> as the target object may be already destructed. The target wrapper must
> already exist for this reference hack to work correctly.
> 
> This patch forbids creating a new wrapper from |visitDOMWrapper| callback,
> and adds an ASSERT that checks that the target object wrapper already
> exists.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175998

TBR=nbarth@chromium.org,haraken@chromium.org
BUG=384459

Review URL: https://codereview.chromium.org/332183008

git-svn-id: svn://svn.chromium.org/blink/trunk@176281 bbb929c8-8fbe-4397-9dbb-9b2b20218538

m_fontElement is a parent element. It's ok to use a strong reference.

BUG=357163

Review URL: https://codereview.chromium.org/338213004

git-svn-id: svn://svn.chromium.org/blink/trunk@176280 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken,sof
BUG=none

Review URL: https://codereview.chromium.org/338833002

git-svn-id: svn://svn.chromium.org/blink/trunk@176279 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When the font name passed to check() does not match any font face in the
FontFaceSet, current implementation always returns true.  As per the
latest spec draft [1], it should return true if it matches platform font
name, otherwise false.

[1] http://dev.w3.org/csswg/css-font-loading/#font-face-set-check

BUG=378989
TEST=fast/css/fontfaceset-check-platform-fonts.html

Review URL: https://codereview.chromium.org/324293003

git-svn-id: svn://svn.chromium.org/blink/trunk@176278 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/331283004

git-svn-id: svn://svn.chromium.org/blink/trunk@176275 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/336323002

git-svn-id: svn://svn.chromium.org/blink/trunk@176273 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SubtargetGeometry is used only in Vector.

BUG=357163

Review URL: https://codereview.chromium.org/332183006

git-svn-id: svn://svn.chromium.org/blink/trunk@176272 bbb929c8-8fbe-4397-9dbb-9b2b20218538

and makes their element members Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/334223009

git-svn-id: svn://svn.chromium.org/blink/trunk@176271 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/333403004

git-svn-id: svn://svn.chromium.org/blink/trunk@176270 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/336293002

git-svn-id: svn://svn.chromium.org/blink/trunk@176269 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGLengthContext is made STACK_ALLOCATED, as it is currently never used
on a heap.

BUG=357163

Review URL: https://codereview.chromium.org/339793004

git-svn-id: svn://svn.chromium.org/blink/trunk@176268 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/333413006

git-svn-id: svn://svn.chromium.org/blink/trunk@176267 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Types of m_maximumAge and m_imeout are "unsigned long"
but they are "int". Therefore their types should change to
"unsigned" for align with others.

BUG=368184

Review URL: https://codereview.chromium.org/336213002

git-svn-id: svn://svn.chromium.org/blink/trunk@176266 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=376377
TEST=no new test; just refactoring

Review URL: https://codereview.chromium.org/330543004

git-svn-id: svn://svn.chromium.org/blink/trunk@176265 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change cleans up the code a little to make it easier to see that
the "direction of playback" is being used and corrects the definition of
"forward" to include playbackRate == 0. New test cases were added to
expose the change in behavior.

BUG=385343
TESTS=LayoutTests/media/media-ended.html LayoutTests/media/video-seek-to-duration-with-playbackrate-zero.html

Review URL: https://codereview.chromium.org/331063006

git-svn-id: svn://svn.chromium.org/blink/trunk@176264 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Mark XMLTreeViewer STACK_ALLOCATED().
- Make m_document Member<>.

BUG=357163

Review URL: https://codereview.chromium.org/339703004

git-svn-id: svn://svn.chromium.org/blink/trunk@176263 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ThisValue should support "any" type other than "object".

BUG=382728

Review URL: https://codereview.chromium.org/330163004

git-svn-id: svn://svn.chromium.org/blink/trunk@176262 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The content should take total window width while overlay-scrollbar is enabled. 

BUG=382900

Review URL: https://codereview.chromium.org/333633003

git-svn-id: svn://svn.chromium.org/blink/trunk@176261 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This simply calls its superclass since about four months ago.
https://codereview.chromium.org/129873009/

Review URL: https://codereview.chromium.org/339753002

git-svn-id: svn://svn.chromium.org/blink/trunk@176260 bbb929c8-8fbe-4397-9dbb-9b2b20218538