- 06 Feb, 2019 40 commits
-
-
Sigurd Schneider authored
PDFiumEngine uses V8 headers (transitively through gin) without importing the right build config hence getting potentially wrong definitions due to missing #defines from the V8 build config. This CL adds gin to the public_deps to the pdf target, which fixes the problem. Bug: v8:8788 Change-Id: I37bdf3a778c35f9cf25db22b5c898607c9f0a88f Reviewed-on: https://chromium-review.googlesource.com/c/1454374 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#629507}
-
Marc Treib authored
Bug: none Change-Id: I0faaf70f23ae12f67c4e17d308a4ab22a7759ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1454479Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629506}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a3b840037dfd..78b1c61fff2b git log a3b840037dfd..78b1c61fff2b --date=short --no-merges --format='%ad %ae %s' 2019-02-06 perezju@chromium.org [Telemetry] Remove inspector_importer Created with: gclient setdep -r src/third_party/catapult@78b1c61fff2b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921000 TBR=sullivan@chromium.org Change-Id: Ifed9b86b405b6365c362319a53c9208d773033b7 Reviewed-on: https://chromium-review.googlesource.com/c/1454889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629505}
-
Reilly Grant authored
The Serial API won't be implemented on Android. Bug: 884928 Change-Id: I37a38f4b762442f4449bfb7e27087dcf7ec939bd Reviewed-on: https://chromium-review.googlesource.com/c/1455503 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629504}
-
Joel Hockey authored
Do not show the toast in file chooser dialog. BUG=928142 Change-Id: Ifd5fe1a7719b0a9b535c4be67fe3c3ee2cb599e9 Reviewed-on: https://chromium-review.googlesource.com/c/1454112 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#629503}
-
Maksim Sisov authored
Depending on the gpu driver, gbm_bo_get_format_modifier may return DRM_FORMAT_MOD_INVALID, which resulted in empty |modifiers| container passed to WaylandBufferManager. The empty container resulted in the gpu process being terminated as long as data validation expects all the three containers with offsets, strides and modifiers be of the same size. Thus, in order to fix the issue, store DRM_FORMAT_MOD_INVALID and check for it on the WaylandBufferManager side. If that value exists, pass 0 modifier_lo and modifier_hi to zwp dmabuf params and DCHECK that the size of planes is 1. Otherwise, multiplanar formats require modifiers. Bug: 928261 Change-Id: I1e57dc604a616ae77dc88e08e3f65693d6e58818 Reviewed-on: https://chromium-review.googlesource.com/c/1454496 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#629502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa101807f2a3..5ae20aeb4844 Created with: gclient setdep -r src-internal@5ae20aeb4844 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0baf221f09167c6a2d6cf99f59367346942c01a7 Reviewed-on: https://chromium-review.googlesource.com/c/1455607Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629501}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e0b10f3e2c36..b0d7bc961a5a git log e0b10f3e2c36..b0d7bc961a5a --date=short --no-merges --format='%ad %ae %s' 2019-02-06 lamontjones@chromium.org portage_util: add yet more logging for chromeos-verison.sh failure. Created with: gclient setdep -r src/third_party/chromite@b0d7bc961a5a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I13bda60f77aee0407ffa8f6ae8757d9ae1046fa7 Reviewed-on: https://chromium-review.googlesource.com/c/1455763Reviewed-by:
-
Kent Tamura authored
This CL has no user-visible behavior changes. Bug: 927166 Change-Id: Iffced87ee7d13dd9bd3e81ca28341abdfd15888d Reviewed-on: https://chromium-review.googlesource.com/c/1454207 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629499}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23873283..95b3a9a6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifa79fd2cc3ebb05725d7e0db2e818a53cf0552eb Reviewed-on: https://chromium-review.googlesource.com/c/1455810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629498}
-
Hans Wennborg authored
To allow us to make changes to the chromium.clang console and builders. Bug: 926191 Change-Id: I204dfd327c04d3c735a9cc8d32054a3362c791c3 Reviewed-on: https://chromium-review.googlesource.com/c/1454498Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629497}
-
Joel Hockey authored
Callers can have only 1 outstanding call to Export or Import. Any calls in progress are cancelled when VM stops. Bug: 912638 Change-Id: Iccff5027c0dfadd22fc269016f9d84e4de1b2804 Reviewed-on: https://chromium-review.googlesource.com/c/1436462Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#629496}
-
Tsuyoshi Horo authored
Bug: 928588 Change-Id: I87f048f0979f227aa90a78f099d8300892b86681 Reviewed-on: https://chromium-review.googlesource.com/c/1454069 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629495}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 478e8930. With Chromium commits locally applied on WPT: af3b056c "[WPT] [wasm] Add JS-API tests for wasm threads" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ice8880127eceef2a87c2db63493ecd4d92484b95 Reviewed-on: https://chromium-review.googlesource.com/c/1455725Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629494}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fac1e367f428..3abdd7a90e45 git log fac1e367f428..3abdd7a90e45 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@3abdd7a90e45 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ic1661500bd567e25fcff8a09b1a51c9051c44436 Reviewed-on: https://chromium-review.googlesource.com/c/1455761Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab06f0c622bf..fa101807f2a3 Created with: gclient setdep -r src-internal@fa101807f2a3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860880 TBR=mmoss@chromium.org Change-Id: I87ea7f4f71b3f83313bbe10c4b92ee3ce29908e7 Reviewed-on: https://chromium-review.googlesource.com/c/1455762Reviewed-by:
-
Dana Fried authored
We have had several recent problems with the lower bound on browser width being driven by the toolbar, which can have its minimum size change as buttons are hidden or shown, or as elements in the omnibox are hidden or shown or change size. The change to the new FlexLayout for the toolbar has made the browser much more responsive to the toolbar's minimum size, and has resulted in an overall smaller minimum width for the browser window. This has created additional problems, such as WebUI pages which have important content or controls cut off due to not having enough room to render. This patch kills two birds with one stone - it restores the minimum width required for our WebUI pages, while also making the contents view the long tent pole for browser minimum width rather than the toolbar, which should also solve a number of minor regressions caused by the switch to declarative layout for the toolbar that were the result of its minimum size being able to change. For this CL the value of 500 DIPs was chosen. This is not enough to display chrome://settings without a horizontal scroll bar, but none of the UI elements are completely hidden either, and it is also enough to display the content in WebUI dialogs. The choice of 500 (rather than, say, 550, which would have accommodated the entire width of WebUI) was to maintain the tradeoff betwqeen usability and privacy; some users like to browser certain content in a very small window even on large screens to prevent others from seeing what they are doing. Bug: 927708, 927846 Change-Id: Ie30e6dd31d26e01900b4f5ee0a1209164e151e59 Reviewed-on: https://chromium-review.googlesource.com/c/1450647 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#629491}
-
Kent Tamura authored
Fix it in order to match to DOM Parsing and Serialization specification. We should not expose hash values of strings. Bug: 928639 Change-Id: I589572d87715805961f2931c6808c1bd38acade6 Reviewed-on: https://chromium-review.googlesource.com/c/1454070Reviewed-by:
-
Hiroshige Hayashizaki authored
To remove ExecutionContext::Url() call before worker top-level script response is received. Bug: 861564 Change-Id: I94de13404a54a248663579b755c9270b1d299968 Reviewed-on: https://chromium-review.googlesource.com/c/1394381Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL ensures we consistently use GTK theme colours for PWA windows. Before this change the title bar colour would use the GTK theme but the title text would not; resulting in unreadable text for dark GTK themes. This CL adds BrowserFrame::ShouldIgnoreTheme() as an equivalent to BrowserNonClientFrameView::ShouldPaintAsThemed(). The latter cannot be used everywhere due to initialisation order dependencies. Deduping these functions is done in a separate CL https://chromium-review.googlesource.com/c/chromium/src/+/1453217 in the interest of keeping this CL merge friendly. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378056&signed_aid=KLS7LkKg4N2vijhbrVDErQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=378057&signed_aid=_AbZIHu6j7Hwm57_i9KhRA==&inline=1 Bug: 927381 Change-Id: I308d8c3c0606cb54ba708cee1ec89a620c1f9d6c Reviewed-on: https://chromium-review.googlesource.com/c/1453558 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#629488}
-
Yoshisato Yanagisawa authored
Let me rename filter to git_log_filter to fix the following pylint warnings. W: 54,32: Redefining built-in 'filter' (redefined-builtin) W: 89,37: Redefining built-in 'filter' (redefined-builtin) W: 191, 2: Redefining built-in 'filter' (redefined-builtin) Change-Id: Ie0a58a5640d388ecb8ee015f29bd1af53d4ce638 Reviewed-on: https://chromium-review.googlesource.com/c/1454353Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#629487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3f7ec52eaa5f..ab06f0c622bf Created with: gclient setdep -r src-internal@ab06f0c622bf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I00b3efe72fbbd93f16159ec1424cbb38fdea02b5 Reviewed-on: https://chromium-review.googlesource.com/c/1455759Reviewed-by:
-
Jun Cai authored
Revert "Network Service: Use histograms instead of chartjsons for network service performance tests" This reverts commit 44a1b51b. Reason for revert: linux-perf-fyi bot failed: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/1762 Original change's description: > Network Service: Use histograms instead of chartjsons for network service performance tests > > This CL modifies the network service performance tests to generate > histograms instead of chartjsons so that the Pinpoint can automatic > bisect CLs. > > Bug: 927155 > Change-Id: I3619704882c3636e76790d610e719a97c045e165 > Reviewed-on: https://chromium-review.googlesource.com/c/1454633 > Commit-Queue: Jun Cai <juncai@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Simon Hatch <simonhatch@chromium.org> > Reviewed-by: Ben Hayden <benjhayden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629424} TBR=jam@chromium.org,benjhayden@chromium.org,simonhatch@chromium.org,crouleau@chromium.org,juncai@chromium.org Change-Id: I6115a10797ec60dd5623dc1ef0e763b2eb84bd9a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927155 Reviewed-on: https://chromium-review.googlesource.com/c/1455856Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#629485}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d9ed5b949aa2..fac1e367f428 git log d9ed5b949aa2..fac1e367f428 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a69ca6050e3e..c81766320762 (1 commits) Created with: gclient setdep -r src/third_party/skia@fac1e367f428 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ica9a638b95e8fd0125932fbd877f5c405fecac5d Reviewed-on: https://chromium-review.googlesource.com/c/1455760Reviewed-by:
-
tzik authored
The web tests below are served as `file:` scheme resources, and uses `setAllowUniversalAccessFromFileURLs(true)` to bypass all origin check. So that they can access the URL of iframes. - forms/formtarget-attribute-button-html.html - forms/formtarget-attribute-input-2.html - forms/formtarget-attribute-input-html.html This CL moves them from web_tests/fast to web_tests/http/tests, so that they are served via http, and they can access iframes without disabling the origin check. Change-Id: I408ac5714d1e81adc248307a3534fb014f2811c9 Reviewed-on: https://chromium-review.googlesource.com/c/1454200Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#629483}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5830d87cf137..1b8d2cc9056a git log 5830d87cf137..1b8d2cc9056a --date=short --no-merges --format='%ad %ae %s' 2019-02-06 thestig@chromium.org Fix integer overflow in CPDF_DocPageData::GetFontFileStreamAcc(). Created with: gclient setdep -r src/third_party/pdfium@1b8d2cc9056a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:925736 TBR=dsinclair@chromium.org Change-Id: Id7f0982b07a4a0e3f9f666398558ca7a0e29f715 Reviewed-on: https://chromium-review.googlesource.com/c/1455758Reviewed-by:
-
Yutaka Hirano authored
Design doc: https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit Bug: 902633 Change-Id: I5f2c70db01019af9816980c2c83b0f1840ecfe3d Reviewed-on: https://chromium-review.googlesource.com/c/1454346 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#629481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa9e5064..23873283 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I038f5ec27f85d9d0ece5bc867fe15f5e564db7ca Reviewed-on: https://chromium-review.googlesource.com/c/1455744Reviewed-by:
-
Fergus Dall authored
This CL changes CrostiniManager to not try to install/restart crostini while it is being uninstalled, and to abort any running restarts if the uninstall process starts. It does not update the UI to prevent the user from trying to do both operations at the same time. Bug: 919153, 928339 Change-Id: Iccb829228e902c24a1ce653c1c244ad789bebe41 Reviewed-on: https://chromium-review.googlesource.com/c/1453956 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
-
Alex Moshchuk authored
When a new proxy is created, its renderer-side loading state is currently initialized as not loading. This is not always accurate, however, if the proxy is created for a frame that hasn't yet finished loading after a navigation. Our current DidStartLoading and DidStopLoading IPC only update the loading state of any existing proxies, but this isn't done for new proxies. Password manager is currently running into an issue stemming for the fact that a proxy's loading state is inaccurate. To fix this, this CL sends a separate IPC to update the proxy's renderer-side loading state whenever a new proxy is created for a frame that's currently loading. This is a reland of https://crrev.com/c/1440728, with the fix to not send the IPC when creating proxies while swapping out. Bug: 916137, 928209 Change-Id: I004c8fb89fb0af0317be70cea14c4452012db66b Reviewed-on: https://chromium-review.googlesource.com/c/1440728 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628577} Reviewed-on: https://chromium-review.googlesource.com/c/1455117 Cr-Commit-Position: refs/heads/master@{#629478}
-
Kenneth Russell authored
The test is intermittently crashing the GPU process in webgl_conformance_d3d11_validating_tests . Bug: 929009 Change-Id: I2f91f232c257521d7cbb460861b754901ba5cef3 Tbr: geofflang@chromium.org Tbr: enga@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1454143Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629477}
-
Jimmy Gong authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9ae41aa0622c..13b2686c57be $ git log 9ae41aa06..13b2686c5 --date=short --no-merges --format='%ad %ae %s' 2019-01-07 matthewmwang shill: Add fallback URL and rotation URLs to PortalDetector::Properties 2019-01-18 jimmyxgong smbprovider: Add UpdateSharePathOptionProto 2019-01-25 ljusten cryptohome: Dedupe install_attributes.proto Created with: roll-dep src/third_party/cros_system_api Bug: none Change-Id: I791333c48797b620ef33be75cf87a96e82a85e7c Reviewed-on: https://chromium-review.googlesource.com/c/1455504Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#629476}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a69ca6050e3e..c81766320762 git log a69ca6050e3e..c81766320762 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 sugoi@google.com Basic DescriptorPool and DescriptorSetLayout implementation Created with: gclient setdep -r src/third_party/swiftshader@c81766320762 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I3861108e738405fd5fe1df571eef2bcf78485acb Reviewed-on: https://chromium-review.googlesource.com/c/1454888Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c12f92a4b03..d9ed5b949aa2 git log 0c12f92a4b03..d9ed5b949aa2 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 09a91e48c066..a69ca6050e3e (4 commits) 2019-02-06 ethannicholas@google.com Reland "SkSL is now pickier about type conversions" 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-06 fmalita@chromium.org Revert "third_party/icu: use upstream" 2019-02-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-06 fmalita@chromium.org [skottie] Fix logging of oversized messages Created with: gclient setdep -r src/third_party/skia@d9ed5b949aa2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I411d186748036a5b2b22324db541d1007295f508 Reviewed-on: https://chromium-review.googlesource.com/c/1455604Reviewed-by:
-
Kent Tamura authored
Serializer-related classes should not change the state of node objects. This CL has no behavior changes. Change-Id: Ic0a1075ae437a2b5387079902a7b373b5a5c1685 Reviewed-on: https://chromium-review.googlesource.com/c/1454018 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 927118 Change-Id: I9f45b349f94edec5326aad35ee8b3cf7091ce8d5 Reviewed-on: https://chromium-review.googlesource.com/c/1441649 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Do early rejection of the case where the user requests an ES 3.0 or WebGL 2.0 context, but the driver is not capable of it. Previously, this was going down the full initialization path, and failing first during creation of the black 3D textures in the TextureManager. Added an integration test which verifies the fix; it crashes the GPU process in the same way the browser was crashing under the Android emulator. It was infeasible to add a unit test due to how the harness works. The new test is currently skipped on Android and macOS due to difficulties in making the new lower-level driver bug workaround work on those platforms. Bug: 923134 Change-Id: I4c89d5c5e144e5b3f6b8c47f912e7123242860ae Reviewed-on: https://chromium-review.googlesource.com/c/1419340 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#629471}
-
Yuki Shiino authored
This reverts commit a365352b. Reason for revert: Suspicious to have caused test failures at viz_browser_tests on GNU/Linux. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31373 Original change's description: > cros: Simplify how views/screens are mocked in WizardControllerBrowsertest > > This eliminates MockOutShowHide and simplifies lifetime. > > MockOutShowHide derived from another Mock class, and also embedded the > view inside of it. This means that the view was destroyed while the > model was being destroyed. > > EXPECT_* methods are now moved to test code instead of the mock class, > since the EXPECT_* methods assume a specific type of usage that is not > always present. > > ScreenManager is also cleaned up so that it does not declare any friend > tests. > > Bug: 928555 > Change-Id: I2f61648dc980e4d5b08620d76d3bbd4d58cd2403 > Reviewed-on: https://chromium-review.googlesource.com/c/1450281 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629264} TBR=antrim@chromium.org,alemate@chromium.org,jdufault@chromium.org Change-Id: I7b3dc97e5425e3bf1b743fe130fcb985f61df9e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928555 Reviewed-on: https://chromium-review.googlesource.com/c/1454352Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#629470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/377617c6c0d9..3f7ec52eaa5f Created with: gclient setdep -r src-internal@3f7ec52eaa5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69cbddd068b9d2c6bee035a874d09938ba6c4574 Reviewed-on: https://chromium-review.googlesource.com/c/1455374Reviewed-by:
-
Etienne Pierre-doray authored
Creates a feature kMayBlockWithoutDelay that changes SchedulerWorkerPoolImpl's behavior in response to MayBlock workers. When enabled, the blocked worker is replaced immediately instead of waiting for a threshold. Bug: 874080 Change-Id: I81be2f43e9603754328b4901a1e9b9acc59baffc Reviewed-on: https://chromium-review.googlesource.com/c/1452759 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#629468}
-
