GitLab

Change one more native layer message to cr.sendWithPromise and adjust
tests to use browser proxy for this message instead of triggering an
event.

BUG=717296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2919693002
Cr-Commit-Position: refs/heads/master@{#476503}

BUG=687863

Review-Url: https://codereview.chromium.org/2914193003
Cr-Commit-Position: refs/heads/master@{#476502}

- make View::set_background take a smart pointer (a la SetBorder)
- move background factory functions out of views::Background (also a la
  Border) for reduced verbosity
- remove a couple redundant background factory functions

No behavioral changes.

Bug: none
Change-Id: I4d4971ea04dcb1f17ebda5671fd997beb1a692a3
Reviewed-on: https://chromium-review.googlesource.com/520702
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476501}

BUG=728789

Review-Url: https://codereview.chromium.org/2915013003
Cr-Commit-Position: refs/heads/master@{#476500}

BUG=715193
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2918613003
Cr-Commit-Position: refs/heads/master@{#476499}

This reverts commit eb03fb79.

Reason for revert: Test is still flaky after all.

Original change's description:
> Re-enable WebVrTest#testPoseDataUnfocusedTab
> 
> Re-enables the previously flaky WebVrTest#testPoseDataUnfocusedTab.
> Flakiness appears to have been caused by the move to JUnit4 and fixed
> in one of the CLs that did additional cleanup and improvements after the move.
> 
> Bug: 726986
> Change-Id: I6e54b87e21eaed91ac668125857c09e6df4b46e2
> Reviewed-on: https://chromium-review.googlesource.com/521842
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476409}

TBR=mthiesse@chromium.org,bsheedy@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 726986

Change-Id: Iecf5abe7ab0f1d27dcb149ca53f480f758de7be3
Reviewed-on: https://chromium-review.googlesource.com/522182
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476498}

1) We need the outer-container to be scrollable when gaia screen and
virtual keyboard are shown together, so the dark overlay ('login-shield')
should always have the same size with the larger one of
the outer-container and the scroll-container, otherwise we see areas
without overlay when scrolling up.

2) We should remember to clear contents on the small pods container
before rebuilding pods.

BUG=718156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2916973002
Cr-Commit-Position: refs/heads/master@{#476497}

Revert of ChromeOS: Per-user time zone: refactor tests first. (patchset #10 id:180001 of https://codereview.chromium.org/2907493002/ )

Reason for revert:
Looks to have caused Linux CrOS link failure:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/87898

Original issue's description:
> ChromeOS: Per-user time zone: refactor tests first.
>
> This Cl prepares tests to support per-user timezone implementation.
>
> BUG=622555, 699472
>
> TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org
>
> Review-Url: https://codereview.chromium.org/2907493002
> Cr-Commit-Position: refs/heads/master@{#476478}
> Committed: https://chromium.googlesource.com/chromium/src/+/410dbeb8df3d4ab140390d7d1e603163885c8c9c

TBR=stevenjb@chromium.org,phajdan.jr@chromium.org,xiyuan@chromium.org,alemate@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622555, 699472

Review-Url: https://codereview.chromium.org/2919933002
Cr-Commit-Position: refs/heads/master@{#476496}

BUG=672263

Review-Url: https://codereview.chromium.org/2917803002
Cr-Commit-Position: refs/heads/master@{#476495}

TBR=grt
BUG=712414

Review-Url: https://codereview.chromium.org/2916953002
Cr-Commit-Position: refs/heads/master@{#476494}

The "Images" content setting is missing from "Site Details". Add it.

chrome: //settings/content/siteDetails?site=http%3A%2F%2Fpermission.site%3A80
Review-Url: https://codereview.chromium.org/2915743002
Cr-Commit-Position: refs/heads/master@{#476493}

Depending on:
https://chromium-review.googlesource.com/c/518308/

Bug: 727804
Change-Id: I70e48bd5336a2fca3e5661ef1df8e03941003a10
Reviewed-on: https://chromium-review.googlesource.com/517675Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476492}

resulting in the connection being closed due to a synchronous write error.

BUG=728434

Review-Url: https://codereview.chromium.org/2915973002
Cr-Commit-Position: refs/heads/master@{#476491}

preferences.mojom and preferences_configuration.mojom had to be merged as they
would cause a circular import otherwise.

BUG: 654988
Change-Id: I061365e7c6c7ae3c851e427a24d2a322e1210987
Reviewed-on: https://chromium-review.googlesource.com/514902Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Johan Tibell <tibell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476490}

Per MTBR review, this list is growing too big to keep living inside
MediaLog; so create a new home for all watch time related keys in
a new "watch_time_keys.{h,cc} file.

BUG=none
TEST=compiles

Change-Id: Ib927f21f04d0a321dac0eec8cc81af74302334e3
Reviewed-on: https://chromium-review.googlesource.com/521804Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476489}

BUG=725736

Review-Url: https://codereview.chromium.org/2899203002
Cr-Commit-Position: refs/heads/master@{#476488}

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG=690239

Review-Url: https://codereview.chromium.org/2906983002
Cr-Commit-Position: refs/heads/master@{#476487}

It is mostly unused, there is only one constant in that header file,
which is "used" at content/public/common/content_descriptors.h. But
let's just use 0 there, and remove this header file now.

BUG=None

TBR=bradnelson@chromium.org,isherman@chromium.org

Change-Id: Ibb768b429f79693f5b85f0ea47d037cf954badfd
Reviewed-on: https://chromium-review.googlesource.com/520942
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476486}

Adds a few simple signals for a Tap gesture relative to the content
that was tapped.  These signals include word length and tap offset.
Logs UMA for CTR when these signals are present.

Updates the CS Context with analysis of the content where the Tap
gesture occurred.

One signal determines if the user tapped near the edge of a word
or not. The rest look at very short words, or relatively long words.

All signals use the existing CSHeuristics framework to do the checking and logging.

Updates the CSHeuristics framework to make the CSContext available
to heuristics so they can inspect the text tapped before deciding
whether to suppress or not.

Adds Field Trial params to enable actual suppression based on
these new signals (likely to be used only for interactive-testing
and demonstration purposes).

BUG=723194

Review-Url: https://codereview.chromium.org/2906763002
Cr-Commit-Position: refs/heads/master@{#476485}

BUG=672263

Review-Url: https://codereview.chromium.org/2916203002
Cr-Commit-Position: refs/heads/master@{#476484}

Right now EventTargeter talks to EventDispatcherDelegate directly but it
should not have any knowledge of EventDispatcherDelegate. Adding an
EventTargeterDelegate to route calls to EventDispatcher and then
EventDispatcherDelegate.

BUG=none, related to https://codereview.chromium.org/2905333002/
TEST=covered by tests

Review-Url: https://codereview.chromium.org/2911293002
Cr-Commit-Position: refs/heads/master@{#476483}

Previously, chrome only handled launching with launch mode MAKE_NEW.
Now it can also be launched with launch mode REUSE (which is the mode
quick_launch uses by default) and launch mode DEFAULT (which is
interpreted as REUSE).

Typing chrome into quick_launch restores focus only to the original
chrome window; it doesn't restore focus to chrome windows launched
through quick_launch for some reason.

BUG=727837

Review-Url: https://codereview.chromium.org/2920473003
Cr-Commit-Position: refs/heads/master@{#476482}

This comes from a review comment on http://crrev.com/2917483002. The
if guard on the function call to GetLinuxWindowManager is no longer
the same as the guard of the function definition.

This CL makes them the same again.

BUG=724244
R=thestig@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_ozone_compile_only_ng

Review-Url: https://codereview.chromium.org/2914963003
Cr-Commit-Position: refs/heads/master@{#476481}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dccdc028..8aacdbbc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2921723002
Cr-Commit-Position: refs/heads/master@{#476480}

This will make it easier to have sorted lists and list-like select controls.

BUG=none

Review-Url: https://codereview.chromium.org/2916743002
Cr-Commit-Position: refs/heads/master@{#476479}

This Cl prepares tests to support per-user timezone implementation.

BUG=622555, 699472

TBR=bauerb@chromium.org,rdevlin.cronin@chromium.org,reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2907493002
Cr-Commit-Position: refs/heads/master@{#476478}

Review-Url: https://codereview.chromium.org/2910823002
Cr-Commit-Position: refs/heads/master@{#476477}

This switch will be used by telemetry so all chrome logging goes to
/var/log/chrome/chrome instead of split between this location and
/home/chronos/user/log/chrome, which is in the cryptohome, and sometimes
not collected by autotests.

BUG=chromium:724273
TEST=manual

Review-Url: https://codereview.chromium.org/2893313003
Cr-Commit-Position: refs/heads/master@{#476476}

One of HttpServerPropertiesImpl's responsibilities is to store HTTP alternative services that have failed and keeps track of their time-until-retry (i.e. when their brokenness expires). The broken alt-svcs and their respective expiration times are kept in a list ordered by expiration time. When the expiration task runs, it drops items from the front of the list until the expiration time of the head alt-svc is no longer in the past. Turns out this list was kept in insertion order as opposed to expiration-sorted order. This change keeps this queue in expiration-sorted order, as expected.
The additional logic added to implement the above change led to a refactor of HttpServerPropertiesImpl: its broken alt-svc logic is put in its own class, BrokenAlternativeServices.

BUG=724302

Review-Url: https://codereview.chromium.org/2898983006
Cr-Commit-Position: refs/heads/master@{#476475}

Adds UMA for the following:
* Scheduling
* Canceling
* Starting a task
* Stopping a task
* Introduces the class to report uma: BackgroundTaskSchedulerUma

BUG=710630

Review-Url: https://codereview.chromium.org/2911503002
Cr-Commit-Position: refs/heads/master@{#476474}

Now that we have subclasses of DocumentMarker for all the different MarkerTypes,
we can make GetType() a virtual method on each of the subtypes so we don't
actually have to store a field in DocumentMarker for this information.

BUG=707867

Review-Url: https://codereview.chromium.org/2911733002
Cr-Commit-Position: refs/heads/master@{#476473}

The In-Product Help demo mode currently only supports enabling demoing
all In-Product Help features, or none of them.

This leads to issues with testing some of them, since they might
happen at the same time, and it is confusing to test.

This CL fixes that issue by adding support for selecting only a single
In-Product Help feature to demo at a time, in addition to keeping the
old choice of enabling all or none of them.

BUG=728449

Change-Id: I78902c48117eb4e6602f768186579d08f4a83217
Reviewed-on: https://chromium-review.googlesource.com/520626
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476472}

This test causes HttpNetworkTransactionTests tests to crash on iOS.

BUG=728808
TBR=mef

Review-Url: https://codereview.chromium.org/2920733003
Cr-Commit-Position: refs/heads/master@{#476471}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c294424b587e..817b8684be60

$ git log c294424b5..817b8684b --date=short --no-merges --format='%ad %ae %s'
2017-06-01 benjhayden In dashboard alerts-table, select ranges of alerts on shift+click.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I78ff3d2dd252da81164f34b79e474f84f49182f7
Reviewed-on: https://chromium-review.googlesource.com/521887
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476470}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL26

Pass a callback into ServiceLaunchedVideoCaptureDevice that gets invoked when
the connection to the video capture service is lost. The connection lost signal
is passed through the VideoCaptureController to the VideoCaptureManager.

Additional change:
Uninitialize VideoCaptureProvider when the last client disconnects. This is to
allow the service to shut down when it is no longer in use.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2902203002
Cr-Commit-Position: refs/heads/master@{#476469}

https://pdfium.googlesource.com/pdfium.git/+log/5f34d479d06e..5171a27eaa74

$ git log 5f34d479d..5171a27ea --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Use unique_ptrs for codec contexts in ccodec_progressivedecoder.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I927f171f64bba1e6b989db6a09e4bb859bc036ce
Reviewed-on: https://chromium-review.googlesource.com/521766
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476468}

Previously, isolated origins subframes from unrelated tabs would
always get their own process.  This results in too many tabs for
scenarios like sign-in, where there's a sign-in subframe on every
Google tab.  To address this, set the process reuse policy to allow
isolated origin subframes to reuse existing processes for that origin.

BUG=713444
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2920473005
Cr-Commit-Position: refs/heads/master@{#476467}

This patch is in preporation to break target dependency in
NetworkRequest. This specific patch is because we will be adding more
conditions in canReplayRequest().

R=dgozman,pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2906843002
Cr-Commit-Position: refs/heads/master@{#476466}

This is a continuation of changes in http://crbug.com/616967; the purpose
is to make it so that in general there's one class per file, and files
aren't too large.

This CL also makes a couple of minor clean-up changes in the classes
that are moved, e.g. changing method order, but this CL doesn't
include any changes to behavior.

Bug: 616967
Change-Id: I4f6aade879d0f660d3f35668448028e8ef0651b0
Reviewed-on: https://chromium-review.googlesource.com/521787
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476465}

This is additional CL to support update over cellular.
- add a property in NetworkState indicating tethering state.
- show a warning message in about Chrome OS page on tethered networks.

BUG=691108

Review-Url: https://codereview.chromium.org/2919683002
Cr-Commit-Position: refs/heads/master@{#476464}