- 20 Aug, 2018 40 commits
-
-
Devlin Cronin authored
Relanding since the CL wasn't the cause of test flakiness. Original change's description: > [Extensions] Introduce common client initialization > > In order to extract apps-specific code from extensions, we'll need to > be able to add extra information to the extensions client from outside > extensions code. This will require having a centralized initialization > for the extensions client. > > Introduce a single method, EnsureExtensionsClientInitialized(), which > constructs and sets the ChromeExtensionsClient. Remove the old way of > constructing the client, ChromeExtensionsClient::GetInstance(). Update > all callers to construct the client via the new method. > > While we're at it, update the client to use base::NoDestructor instead > of LazyInstance. > > Bug: 873937 > Change-Id: I47147cd5f33ea44079c0a319626c57f3c5813af8 > Reviewed-on: https://chromium-review.googlesource.com/1175459 > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583217} TBR=thestig@chromium.org,rdevlin.cronin@chromium.org Bug: 873937 Change-Id: Idf8fdc2ca89e3f0e481fbfd310c5ebc6067311f1 Reviewed-on: https://chromium-review.googlesource.com/1181162Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584461}
-
stkhapugin@chromium.org authored
Ignores the scroll events caused by the updated suggestions. Bug: 813025 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10bee25484c964ded91afe47e7f51f8146e16f7b Reviewed-on: https://chromium-review.googlesource.com/1181131Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584460}
-
Lukasz Anforowicz authored
Bug: 816318, 874515 Change-Id: I8d165ec355036f8c190bb21e1c50ee8f9b6a4d5a Reviewed-on: https://chromium-review.googlesource.com/1176389Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#584459}
-
Friedrich Horschig authored
This test is already disabled for all other platforms but (as linked in the bug) Windows bots also reported flakes. Therefore, disable it for windows as well. TBR=clamy@chromium.org Bug: 665296 Change-Id: I3991d966d72509324c00c28d82ace55d698eecb4 Reviewed-on: https://chromium-review.googlesource.com/1181262Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584458}
-
Dominic Battre authored
This CL disables manual password generation in the context menu in case the user has disabled the password manager or the site has an SSL problem (in which case Chrome would not fill the credential). Bug: 875751 Change-Id: I900590e6674ba0d039033fb5bacfb83f39bcba52 Reviewed-on: https://chromium-review.googlesource.com/1180966Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#584457}
-
Nico Weber authored
Setting YASM_TEST_SUITE makes yasm output deterministic: - the PE/COFF timestamp field is always 0 (this breaks link.exe /incremental, but we no longer user link.exe) - in debug info, yasm identifies itself as "yasm HEAD" instead of e.g. "yasm 1.3.0" (we don't care much about this effect) - in debug info, file paths are no longer absolute but relative to '.' Bug: 330260 Change-Id: Icafe7abd6a637b86af2b5b8e7f88e0bfa042da50 Reviewed-on: https://chromium-review.googlesource.com/1180718Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584456}
-
Mohsen Izadi authored
This change replaces usage of content::BrowserGpuMemoryBufferManager with viz::HostGpuMemoryBufferManager. With this change BrowserGpuMemoryBufferManager is not needed anymore and code to handle buffer allocation in GpuProcessHost is also removed. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6a9387e2e33a5d98d4ed7559618f4995256bafa4 Reviewed-on: https://chromium-review.googlesource.com/1095815 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#584455}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/908689d04718..f1f363fae757 git log 908689d04718..f1f363fae757 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 srte@webrtc.org Renames test::VideoCapturer to TestVideoCapturer. 2018-08-20 titovartem@webrtc.org Mark DirectTransport subclasses ctors as deprecated and switch from them 2018-08-20 titovartem@webrtc.org Deprecate two DirectTransport ctors and remove their direct usage. Created with: gclient setdep -r src/third_party/webrtc@f1f363fae757 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I499c1d650c245f84c711271483112bfc4ff36158 Reviewed-on: https://chromium-review.googlesource.com/1181182Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584454}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I10afdab7594aaf5d79a6e8c1c98911511b55969d Reviewed-on: https://chromium-review.googlesource.com/1177701Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#584453}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0e1fc1042fe0..f8268f7ccb65 git log 0e1fc1042fe0..f8268f7ccb65 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 derat@chromium.org chromeos_config: Remove warn_only from Tast suites. Created with: gclient setdep -r src/third_party/chromite@f8268f7ccb65 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifca7c0600690cf69ea8975ff990301114dff801b Reviewed-on: https://chromium-review.googlesource.com/1181201Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584452}
-
Thomas Tangl authored
This is a reland of 28ac1ad7 The were two problems: - There was a call to internal::GetUnifiedConsentFeatureState() in UnifiedConsentService::ShouldShowConsentBump(). Instead of using this function, the check for the feature state should happen on the platform level. This is already done on Desktop, so removing the call will resolve the problem. - The initialization of scoped_unified_consent_ in the unit tests had a bug. When the variable was reset with a new value, the new value was created before the old one was deleted which led to a memory leak. Original change's description: > [unified-consent] Refactor migration code and add settings updates > > The migration code in the UnifiedConsentService is refactored: > - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is > extracted to it's own pref kShouldShowUnifiedConsentBump. > - The migration state kInProgressWaitForSyncInit is introduced > to be able to update the settings for migration when sync is > initialized. > > Additional changes: > - ShouldShowConsentBump only returns true if the consent bump > feature is enabled. > - The rollback enables sync-everything now also when the user is > not syncing USER_EVENTS (which is disabled during the migration). > > Users that previously had the unified consent feature enabled and > for which ShouldShowConsentBump=true, will not be shown the consent > bump anymore after this CL is landed. This will only affect a few > users on Canary and Dev. > > Bug: 863932 > Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c > Reviewed-on: https://chromium-review.googlesource.com/1172690 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584341} TBR=ellyjones@chromium.org TBR=droger@chromium.org Bug: 863932 Change-Id: Ic041ac99da729d072f49fc9aa6adfe5624fc089e Reviewed-on: https://chromium-review.googlesource.com/1180921 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#584451}
-
Devlin Cronin authored
Test is still flaky. Original change's description: > Disable TabManagerTest.ProactiveFastShutdownWithBeforeunloadHandler > > TBR=wjmaclean@chromium.org > NOTRY=true > > Bug: 874915 > Change-Id: Id0fae86ef2e130185d92ad28383c74036dcd96f3 > Reviewed-on: https://chromium-review.googlesource.com/1177881 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583660} TBR=xidachen@chromium.org,wjmaclean@chromium.org Bug: 874915 Change-Id: I75d5ca813702dace0d3966baac2bd69d517dd1c8 Reviewed-on: https://chromium-review.googlesource.com/1181164Reviewed-by:
-
Peter Wen authored
GMSCore API libraries now ship their own third party licenses. We append these licenses to the Android SDK license for each package in order to ensure that they are all present in our releases. Bug: 868879 Change-Id: Ib169e7cbb4c67a1f6a34b11dfe1502fcf4d4155e Reviewed-on: https://chromium-review.googlesource.com/1159323 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#584449}
-
Xiyuan Xia authored
test_ws could exit before |aura_test_helper_| is created. This CL handles such case. TBR=sky@chromium.org Bug: 874089 Change-Id: I65a29329fb079795f939a082dd60d4e680d282f5 Reviewed-on: https://chromium-review.googlesource.com/1180362 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584448}
-
Peter Kasting authored
This required: * Deleting the old pre-custom-titlebar rect intersection code, which bypassed the drag extension code. AFIACT this code had no advantages over the common code in BrowserNonClientFrameView. * Fixing a color computation bug in GetTabBackgroundColor() that I introduced in https://chromium-review.googlesource.com/1173715 , where it ignored the requested active state of the frame. This probably had other bad effects too. * Fixing code in the tab strip that failed to mirror bounds correctly, so this would work in RTL. Again, that probably resulted in other bugs too. While testing that this worked right with the new tab button, I also fixed (via simplification) an unrelated issue where the new tab button hit test region in refresh was a rectangle instead of the correct path. Bug: 862276 Test: Run chrome on Windows 10 with --disable-features=Windows10CustomTitlebar, then hover the top couple pixels of a background tab in a restored window in the default theme. The tab should not light up with a hover effect until you get 6 px or so down into the tab. Change-Id: Iabc80cdde7f67251214c5308687105f13ea22f19 Reviewed-on: https://chromium-review.googlesource.com/1180594Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#584447}
-
Ryan Daum authored
- TTS extension API was being installed without custom bindings. - Also adds registration of the lazy_background_page API, which TTS bindings need. Bug: internal b/111972492 Test: manual Change-Id: I03307abf2c8eb996d92d8978cd565edc0c388c22 Reviewed-on: https://chromium-review.googlesource.com/1181167Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#584446}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6676079d2b79..12e3df13cfa5 git log 6676079d2b79..12e3df13cfa5 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 fmalita@chromium.org [skottie] Harden interpolation checks for shapes Created with: gclient setdep -r src/third_party/skia@12e3df13cfa5 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I150ef8cb81a1f17295fdd59566dc0eb867cefc65 Reviewed-on: https://chromium-review.googlesource.com/1181181Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584445}
-
Peter Wen authored
After this update individual API library versions can be updated independently. Licensing improvements are also in this update which will be used in a follow-up CL. Extra deps added: - com_google_android_gms_play_services_clearcut - com_google_android_gms_play_services_flags - com_google_android_gms_play_services_phenotype - com_google_android_gms_play_services_places_placereport - com_google_android_gms_play_services_stats Binary size increase of +58,148 bytes normalized apk size. These are not shipped in downstream anyways. Binary-Size: New library dependencies Bug: 869935 Change-Id: Ia53f69c4756adac4f55be820eaf7ef1393a975d2 Reviewed-on: https://chromium-review.googlesource.com/1158999 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Grace Kloba <klobag@chromium.org> Reviewed-by:
-
Bailey Berro authored
If the policy for NetworkFileSharesAllowed is set to false, users will not be able to mount shares nor will the be able to access the mount ui Bug: chromium:757625 Change-Id: Ief64c9a9c3c2a574b931bc3f21516d471c26bcd4 Reviewed-on: https://chromium-review.googlesource.com/1152490Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#584443}
-
Aldo Culquicondor authored
The used source class was causing several performance regressions. Bug: 874363, 874365 Change-Id: I697f4380c978aa6c7dbc6d41759bfbbdae0878db Reviewed-on: https://chromium-review.googlesource.com/1176379Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#584442}
-
Charlie Harrison authored
This is in preparation to add a struct UkmSource::Metadata, which would need to be used in //services. TBR=sky@chromium.org Bug: 873316 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0d33f6ece24b9176ff86310ef2e7347453b5ccfa Reviewed-on: https://chromium-review.googlesource.com/1179992Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#584441}
-
Juan Antonio Navarro Perez authored
Stories have been consinstently failing on N5X and Pixel 2 bots. TBR=nednguyen@google.com NOTRY=true Bug: 875859 Change-Id: I9d41fa293a90e6961eabc6b29711d8b824d469ce Reviewed-on: https://chromium-review.googlesource.com/1181140Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#584440}
-
Vadym Doroshenko authored
It contains a number of tiny clean ups: 1.Using range based for 2.Dropping autofill:: namespace in favor of using 3.Using map lookup instead of range based for by map. 4.Old comment removal in password_manager.cc Bug: 875768 Change-Id: I6d7c481139d59e8de35ec49ad58f9486de04359d Reviewed-on: https://chromium-review.googlesource.com/1177743 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Sriram authored
Removing media/seek-to-currentTime.html infavor of the wpt test at wpt/html/semantics/embedded-content/media-elements/seeking/ Change-Id: I115785280c5fb0a9fdab449feea1f8a348b9271e Reviewed-on: https://chromium-review.googlesource.com/1181017Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#584438}
-
David Roger authored
This CL stops recording the user actions related to the regular sync confirmation when the consent bump is used. Adds a new bucket in the consent bump histogram for the "Abort" case. Bug: 871267 Change-Id: I35b4ce80c6da0e0fe871f6d10ab799e555960e05 Reviewed-on: https://chromium-review.googlesource.com/1179664 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
They were disabled by mistake on the wrong platform. TBR=nednguyen@google.com NOTRY=true Bug: 874935 Change-Id: I9b50b481e97b9f2c01cde4cc43f1627ea4663c51 Reviewed-on: https://chromium-review.googlesource.com/1181135Reviewed-by:
-
Fredrik Söderquist authored
contextElement -> ContextElement Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If22cc5a0624cfaf9e1e448198c891de3030bc889 Reviewed-on: https://chromium-review.googlesource.com/1181058Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#584435}
-
Ben L. Titzer authored
Minimum legal asm.js heap size is 4096 bytes. R=mslekova@chromium.org Change-Id: Ia23536c4cb1660125b21cbee399ecfdefb549e08 Reviewed-on: https://chromium-review.googlesource.com/1181060 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584434}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/814f99cf275f..908689d04718 git log 814f99cf275f..908689d04718 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 ssilkin@webrtc.org Fix calculation of number of active spatial layers. Created with: gclient setdep -r src/third_party/webrtc@908689d04718 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea7d9471b05449d9774073dc8fca3a3f4f42f957 Reviewed-on: https://chromium-review.googlesource.com/1180860Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e8d43a6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23090 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6311296098cbfbfc296428b6bc4cf9857f9ea856 Reviewed-on: https://chromium-review.googlesource.com/1181062 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584432}
-
Alexander Timin authored
R=skyostil@chromium.org BUG=874497 Change-Id: Ia5546b2600b2502e3a5fa00c6631810af377d0de Reviewed-on: https://chromium-review.googlesource.com/1181027Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584431}
-
Peter Beverloo authored
A negative index is used to indicate the default, unset state of the action button index in the NotificationLaunchId, but this is not the right value to pass along to NotificationHandlers. Bug: 875091 Change-Id: I0d327eb1f3887904a674a6748cc6e9d60ec783c3 Reviewed-on: https://chromium-review.googlesource.com/1180973 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#584430}
-
Dominik Röttsches authored
Create an abstraction for platform specific font unique name matching and provide an implementation for Android that connect to the FontUniqueNameLookup service in RenderProcessHost, and retrieves a shared memory readonly region with a font lookup table. The font lookup table comes in the form of a protobuf that can be parsed using a library shared between content/browser and blink. On the first @font-face declaration that contains a src: local() value and is used in the text, connect to the service, and parse the lookup table, perform a lookup. Subsequent lookups will reuse the same table. After an Android firmware update which triggers a font rescan on the browser side service side, on a Nexus 6, rebuilding the index takes about 45ms. This is a one-time cost. After that, until the next firmware update, the browser process only needs to read the index file back from disk. On the renderer side, for the first font-face that uses src: local(), there is an initial IPC cost for retrieving the shared memory region and parsing the protobuf. Measurements on the previous implementation indicate that this takes less than 6ms. After that for the first and subsequent src: local() lookups, the cost is only the search through the in-memory list. Design doc in https://crbug.com/828317 Bug: 870223 Change-Id: I0bb200235dd7a9f29f3a5165a31e3c5c0cb7527e Reviewed-on: https://chromium-review.googlesource.com/1162166 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#584429}
-
tzik authored
std::swap overloads without exception specification are warned by cl.exe and clang-cl on C++17 mode, that belongs to -Wmicrosoft-exception-spec: ../../third_party/openvr/src/src/json/json.h(1227,13): error: 'swap<Json::Value, void>' is missing exception specification 'noexcept' [-Werror,-Wmicrosoft-exception-spec] inline void swap(Json::Value& a, Json::Value& b) { a.swap(b); } As ADL based dispatch is preferred for this case, and upstream jsoncpp[1] already does it, this CL adopts it too. [1]: Upstream jsoncpp commit: https://github.com/open-source-parsers/jsoncpp/commit/1d95628ba84189cd81fbabf70add5c1baf2912c5 OpenVR SDK has not rolled to this. Change-Id: I82494ef5aca5ff0df431f94f65ae8439c41977b5 Reviewed-on: https://chromium-review.googlesource.com/1179422Reviewed-by:Bill Orr <billorr@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#584428}
-
Friedrich Horschig authored
The failures affect all versions of decode-resize.js but the new expectations cover only http/tests/devtools/tracing/decode-resize.js. With this CL, all expectations are as well applied to virtual/threaded/http/tests/devtools/tracing/decode-resize.js TBR=caseq@chromium.org Bug: 847114 Change-Id: I35c53f7e2852afcf6bb0c82369a52845e73351ba Reviewed-on: https://chromium-review.googlesource.com/1181055Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2c687ea6e0a9..6676079d2b79 git log 2c687ea6e0a9..6676079d2b79 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 benjaminwagner@google.com [infra] Add comment regarding skcms use of mac_toolchain. Created with: gclient setdep -r src/third_party/skia@6676079d2b79 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I96749a25d4cfa99feb063a8dfaf2df3dd9157e44 Reviewed-on: https://chromium-review.googlesource.com/1181061Reviewed-by:
-
stkhapugin@chromium.org authored
Makes the accelerator omnibox button in the bottom toolbar dismiss the find in page popup on press. Bug: 863002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic293d90856a10d08c50edf8987c3eb4838c2c395 Reviewed-on: https://chromium-review.googlesource.com/1181046Reviewed-by:
-
Friedrich Horschig authored
This test is very flaky for quite a while now. For details, check the linked bug. TBR=ramyan@chromium.org, sky@chromium.org Bug: 871010 Change-Id: I5d64a708f84d11a9b4981edc2cf53ad6b1a4151d Reviewed-on: https://chromium-review.googlesource.com/1181048Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c6b2cf82b09b..ee3986dc7034 git log c6b2cf82b09b..ee3986dc7034 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 primiano@google.com TraceProcessor: Add magic ts_lower_bound to sched table Created with: gclient setdep -r src/third_party/perfetto@ee3986dc7034 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia8d46f7c91cfdd9ed273ae4d0b17e3b042648a33 Reviewed-on: https://chromium-review.googlesource.com/1180859Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584423}
-
Lucas Furukawa Gadani authored
Change-Id: I667124ece0bf1d0d39b493f859a284f028550036 Reviewed-on: https://chromium-review.googlesource.com/1179963Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584422}
-
