GitLab

https://chromium.googlesource.com/media_router.git/+log/475baa8b2eb0..29324b698ccd

$ git log 475baa8b2..29324b698 --date=short --no-merges --format='%ad %ae %s'
2018-10-05 mfoltz Fix/suppress JSCompiler errors in advance of b/117162687 && b/117162806
2018-09-18 mfoltz Added retry behavior for Slarti calls.
2018-09-06 mfoltz Support mirroring with Mirroring Service behind feature flag.
2018-08-08 mfoltz Added extra logging for GCM activity.

Created with:
  roll-dep src/chrome/browser/resources/media_router/extension/src

TBR=jrw@chromium.org

Change-Id: I1d88f7f4a6c427183d89de0a79d6636b07a73ec0
Reviewed-on: https://chromium-review.googlesource.com/c/1315695
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605054}

Changes:
Update the y positions of child views to target state upon animation
start to avoid stale positions.

Bug: 901168
Change-Id: I605d20302a7512b82ffe5cf445e7166f64da3280
Reviewed-on: https://chromium-review.googlesource.com/c/1315810
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605053}

This reverts commit 46a9bbb1.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Overview optimizations
> 
> This is 2nd attempt to land: crrev.com/c/1304973
> [2] are the difference from above CL.
> 
> *[2] Added null check in OnStartingAnimationComplete.
> * Pause occusion tracker during overview animation
>  [2] wait 5000ms when exiting overview before resume
>        because a user may re-enter overview
>  [2] wait 50ms when entering overview before resume
>        because it can take 2 frame to finish draing the frame
>        after animation observer is called.
> * Activate the text filter after animation
> * [2]Animate shelf after overview animation.
> * [2] Improve blur animation:
>  Use Compositor's AnimationObesrver to drive animation
>  Progress only by 2 to reduce the frequency.
> * Don't animate backdrop window during overview animation.
> * Fix the bounds change issue in WindowGrid. It shouldn't change
> the parent window's bounds.
> 
> 
> Bug: 898077, 897387, b/118675936
> Test: no functional change. Manually tested visual change by entering/exiting overview mode
>   in both clamshell and tabletmode.
>   The web contents should load after animations without backdrop animation.
>   No gap at the bottom of the screen after exiting overview mode.
> 
> Change-Id: I5e5dc17afd62d4dc477d87becdeee91c55bd81ca
> Reviewed-on: https://chromium-review.googlesource.com/c/1304973
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Sammie Quon <sammiequon@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#604206}
> Reviewed-on: https://chromium-review.googlesource.com/c/1312614
> Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604844}

TBR=oshima@chromium.org,sammiequon@chromium.org,malaykeshav@chromium.org

Change-Id: Ia07f696386ce2889a1d6344218be355a3515975c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898077, 897387, b/118675936
Reviewed-on: https://chromium-review.googlesource.com/c/1316169Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605052}

Adjust a few tests so that they will pass when the
RuntimeHostPermissions feature is enabled on ToT. A follow-up will
flip the default of the feature.

Bug: 869996

Change-Id: I0b677040c228cbd7762330f2f4257d37673fdfe7
Reviewed-on: https://chromium-review.googlesource.com/c/1296814Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605051}

Previous, the calls to check IsCleared() were inside a DCHECK(). We want
to promote them to always happen.

This patch does that.

BUG=897263

Change-Id: I385b4bfeb931b94e62cd88258da8873f9ddff8f9
Reviewed-on: https://chromium-review.googlesource.com/c/1315703Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605050}

The problem was only observed on Mali and could even be fixed in recent
driver versions. For now, at least narrow down the workaround to only
apply to Mali GPUs. On other GPUs we observe around 10% improvement in
framerate, which we can't leave on the table.

Bug: 301988
Change-Id: Iab07a60a74555d6935b53dc30af1b798a1c56e8f
Reviewed-on: https://chromium-review.googlesource.com/c/1312158Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605049}

This change includes 2 fixes:
 - When text and UI direction don't match, focusing the tab switch
button homes the cursor in the Omnibox. Now the cursor remains where
it is. (900244)
 - When there is autocomplete text and a tab switch button showing,
right arrow doesn't go to end. Now we check that the selection is
entirely at the end before consuming right arrow for the tab switch
button. (899597)

Bug: 899597, 900244
Change-Id: Ib5c953d22c1b80f6f516a04d8e12e7d8b5b13c19
Reviewed-on: https://chromium-review.googlesource.com/c/1312983
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605048}

On Android, we clean up non-resumable interrupted file from the history and
download db. However, the actual files may still be on disk.
This CL removes those files while cleaning up the database.

BUG=899775

Change-Id: I59bdf32c11789448295126b2819d326fedcf54ff
Reviewed-on: https://chromium-review.googlesource.com/c/1310499
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605047}

Tweak the data sent to the extensions page slightly more. Move all
runtime host permissions data into a separate field on the
developerPrivate.Permissions struct, and unconditionally populate all
fields (including specific granted hosts) if the feature is enabled.
This simplifies some of the code we need to pass to the
RuntimeHostPermissions element, since we can now just pass
developerPrivate.RuntimeHostPermissions, and paves the way for adding
a separate toggle-able implementation for extensions that request access
to specific sites.

No observable UI or behavior change is expected in this CL.

Update and add tests for the same.

Bug: 891803

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id95d3b0a77d8621db811a28fcdcfd705d60ed0f6
Reviewed-on: https://chromium-review.googlesource.com/c/1295271
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605046}

Bug: 898245
Change-Id: I591cecc162cb86d5925ec67b4bbe6b12cd72a0c2
Reviewed-on: https://chromium-review.googlesource.com/c/1313830Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605045}

Using Time::Now() resulted in a test breakage due to daylight savings time.
Specifically, given Time t, (t+TimeDelta::FromDays(1)).LocalMidnight() results
in the same day due to DST.

To fix, I changed to use a fixed date.

Change-Id: I6278c3dce4654910589649b8f724b240ae983195
Reviewed-on: https://chromium-review.googlesource.com/c/1314614Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#605044}

Currently, VizMainImpl::ExitProcess has a workaround to avoid deadlock
when shutting down the gpu process. Unfortunately, this is only wired up
to one of the ways to shut down. Other shutdown calls originating from
ChildProcessImpl miss this logic and hit the same deadlock.

This change passes a helper to ChildProcessImpl, allowing it to correctly
handle shutdown. This helper posts a task to the GPU main thread before
starting shutdown to ensure both that we're on the right thread as well
as that we're post-init.

Bug: 901396
Change-Id: I58cff914def5c05f7b9e6b6f58cb319153d685dd
Reviewed-on: https://chromium-review.googlesource.com/c/1315538Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605043}

https://chromium.googlesource.com/catapult.git/+log/a8f088180a1c..468ff3e5a030


git log a8f088180a1c..468ff3e5a030 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 ulan@chromium.org Ensure that the mutator utilization metric always makes progress.


Created with:
  gclient setdep -r src/third_party/catapult@468ff3e5a030

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id28357691867e650f0ec92bae70848c202a25fa1
Reviewed-on: https://chromium-review.googlesource.com/c/1315729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605042}

https://pdfium.googlesource.com/pdfium.git/+log/d105d2e46b9a..0e8346b53d7a


git log d105d2e46b9a..0e8346b53d7a --date=short --no-merges --format='%ad %ae %s'
2018-11-02 thestig@chromium.org Use constants for name tables in CPDF_FontEncoding.


Created with:
  gclient setdep -r src/third_party/pdfium@0e8346b53d7a

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idddac1709352aa5b5c1bf5bf60c95285d280635c
Reviewed-on: https://chromium-review.googlesource.com/c/1315732Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605041}

Right now if there is a touch start that hits a main thread touch action
region, we'd ack the touch start from the renderer and the allowed touch
action is sent together with that ack. For example, when we touch a main
thread touch action region, the InputRouterImpl::TouchEventHandled
callback is executed when the browser receives the ACK from the main
thread.

This CL changes the logic a bit without changing the behavior. Specifically,
we change InputHandlerProxy::HitTestTouchEvent to return
DID_HANDLE_NON_BLOCKING instead of DID_NOT_HANDLE, which means that
we are now sending the ACK for the touch start form the compositor instead
of the main thread. With this change, InputRouterImpl::TouchEventHandled
callback will be executed when the browser receives the ACK from the
compositor, and that the touch action computed from the main thread may
be unknown. Once the TouchEventHandled callback is executed, it calls
the ProcessTouchAck which processes the touch ack and generates gesture
events from them.

To keep the same behavior as what it is now, this CL queues all the generated
gesture events until the effective touch action is received.

To preserve the touch ack timeout behavior, what we did in this CL is that
when calling ProcessTouchAck, don't stop the timeout monitor if the main
thread touch action is not received yet. When the main thread touch action
is received, then stop the timeout monitor.

We can use the existing tests to make sure that there is no behavior
change.

Bug: 772130
Change-Id: I6376f03c938206ad4bd3d3acb00cdb6581ac4f2c
Reviewed-on: https://chromium-review.googlesource.com/c/1255442
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605040}

This reverts commit b2457b26.

Reason for revert: suspected of causing assertion failure running merge_web_test_results.py in not_site_per_process_webkit_layout_tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/53956

2018-11-02 10:44:57,220 - root: [INFO] Running with isolated arguments
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/merge_web_test_results.py", line 12, in <module>
    main(sys.argv[1:])
  File "/b/swarming/w/ir/cache/builder/src/third_party/blink/tools/blinkpy/web_tests/merge_results.py", line 775, in main
    assert args.positional
AssertionError


Original change's description:
> Make layout tests use default isolation (e.g. site-per-process on desktop).
> 
> Summary
> =======
> 
> This CL makes layout tests use the default site isolation from the
> platform they are run on (instead of opting out of strict site isolation
> via LayoutTestContentBrowserClient::ShouldEnableStrictSiteIsolation).
> Additionally, on platforms where strict site isolation is enabled,
> layout tests opt into slightly stricter isolation by enabling isolation
> of same-site origins used by Web Platform Tests - this ensures that
> features covered by WPT also get sufficient coverage of out-of-process
> iframes (OOPIFs).
> 
> After this CL, expectations for tests that differ in behavior with and
> without OOPIFs are being moved from
> LayoutTests/FlagExpectations/site-per-process to:
> - LayoutTests/VirtualTestSuites (virtual/not-site-per-process suite)
> - LayoutTests/virtual/not-site-per-process/README.md
> - LayoutTests/TestExpectations and LayoutTests/NeverFixTests
>   ("Site Isolation failures" section)
> 
> 
> Desirability
> ============
> 
> The CL helps with the following:
> 
> - Focusing on testing the mode that is actually shipped to end users
> - Helping ensure that newly developed features get site-per-process
>   coverage without having to set up a separate step (i.e. it is
>   sufficient to set-up a bot that runs layout tests with
>   --enable-features=NewFeature without also having to have a separate
>   test step for runing layout tests with *both*
>   --enable-features=NewFeature *and* --site-per-process
> 
> This CL does *not* help with reducing requirements for CQ capacity,
> because we need to maintain a separate
> not_site_per_process_webkit_layout_tests step to make sure that tests
> pass without isolation (which is the mode Chrome ships on Android).
> Also note that layout test coverage on Android is very sparse - see
> https://groups.google.com/a/chromium.org/d/topic/blink-dev/SOXhTYysYkE/discussion
> 
> 
> Preserving test coverage
> ========================
> 
> Most tests
> ----------
> 
> The CL preserves covering most layout tests with and without OOPIFs, by
> relying on the fact that CQ/waterfall run layout tests on both kinds of
> platforms - ones that default to strict site isolation (desktop
> platforms) and ones that default to no site isolation (Android).
> 
> 
> Tests that used to be excluded FlagExpectations/site-per-process
> ----------------------------------------------------------------
> 
> Around 40 tests fail when run in presence of OOPIFs.  Such tests are
> disabled by this CL by moving test expectations from
> FlagExpectations/site-per-process into the main TestExpectations file.
> The CL preserves non-OOPIF test coverage provided by the disabled tests
> by introducing virtual/not-site-per-process directory which runs all
> such tests with site isolation disabled.  Using a virtual test suites
> for preserving the test coverage relies on the ability to have separate
> test expectations for these tests (i.e. relying on the fact that
> disabling these tests in TestExpectations doesn't disable their
> virtual/not-site-per-process equivalents).
> 
> Note that the CL keeps isolating "oopif.test" site even in
> virtual/not-site-per-process suite.  This site should only be used by
> tests that require an OOPIF.
> 
> 
> Preserving site-per-process-specific test expectations
> ------------------------------------------------------
> 
> Some tests have site-per-process-specific expectations:
> - http/tests/inspector-protocol/network/security-info-on-response.js
> - http/tests/inspector-protocol/network/raw-headers-for-protected-document.js
> 
> The tests above highlight that cross-origin cookies are not displayed in
> site-per-process mode (a known regression tracked by
> https://crbug.com/849483).  This CL preserves expectations and coverage
> by shuffling things around:
> - old, main expectation -> android expectation
> - old, site-per-process expectation -> main expectation
> 
> 
> There is one additional test with site-per-process-specific
> expectations:
> - external/wpt/dom/events/EventListener-addEventListener.sub.window.js
> 
> Unlike the other 2 tests, it seems less important to preserve exact test
> expectations for the case when the test fails with Site Isolation.
> Therefore this test is covered by virtual/not-site-per-process test
> suite and an expectation for this test is added to the main
> TestExpectations.
> 
> 
> Lost test coverage
> ------------------
> 
> Even with extra caution described above, some test coverage may be lost:
> 
> - Features covered by tests only on one kind of platform (e.g. disabled
>   on Android) are at risk of losing OOPIF or non-OOPIF coverage.
> 
> - Before this CL, site-per-process was also applied to all other
>   `virtual/...` test suites.  After this CL,
>   `virtual/not-site-per-process` will not provide such coverage.
> 
> 
> Cleaned up test expectations
> ----------------------------
> 
> Some additional test expectations clean-up is done, while preserving
> test coverage:
> 
> - The http/tests/perf/large-inlined-script.html test has been already
>   present in `SlowTests` and therefore I didn't include this test in the
>   new `virtual/not-site-per-process` suite.
> 
> - The http/tests/devtools/network/network-datareceived.js test was
>   already marked as expecting a `[Failure]` in TestExpectations and
>   therefore I didn't include this test in the new
>   `virtual/not-site-per-process` suite.
> 
> - The http/tests/devtools/console-cross-origin-iframe-logging.js test
>   was already marked as `[Timeout]` in the old TestExpectations but for
>   Win only.  Since I can repro a timeout on Linux (with and without site
>   isolation), I just extended the old expectation to all platforms and I
>   didn't include this test in the new `virtual/not-site-per-process`
>   suite.  I also removed the test from SlowTests (since timeouts in the
>   test are not expected everywhere).
> 
> 
> Bug: 870761
> Change-Id: I74d8ac4ebee8f0402d449fda2cec46ba3b49cf64
> Reviewed-on: https://chromium-review.googlesource.com/c/1302662
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604955}

TBR=dpranke@chromium.org,alexmos@chromium.org,lukasza@chromium.org

Change-Id: I54b6a36922bebfbc8a3f1467bc3d4807c2322604
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870761
Reviewed-on: https://chromium-review.googlesource.com/c/1315960Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605039}

The PRD in the bug explains how we wanted it to look, and when we wanted it to appear.

SCREENSHOT: https://screenshot.googleplex.com/WEy35zvdt6O.png
SCREENCAST: https://drive.google.com/open?id=1SURR2EP4UN35lPZQYUw2iceivWGnDO2y

Bug:883456

Change-Id: Ib94be66d45cd809f995d01c6429e563371e550f1
Reviewed-on: https://chromium-review.googlesource.com/c/1259806
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605038}

This works around a bug where the fallback language (English) doesn't
get installed by Play.

Bug: 901284
Change-Id: Iff059d45903e444fa74335845a0bac280dff456f
Reviewed-on: https://chromium-review.googlesource.com/c/1315692
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605037}

GetNetworkServiceFromConnector() may be called in the early startup before the
full browser starts. Therefore, it can't use
DCHECK_CURRENTLY_ON(content::BrowserThread::UI) to check whether it is called
on the same thread. Instead, we check whether the connector is accessed on the
valid sequence to replace this DCHECK.

Bug: 729596
Change-Id: I97e2b0cae7a4a7e0dded919b9b120f60eb18fea6
Reviewed-on: https://chromium-review.googlesource.com/c/1308977Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605036}

Add a new UMA histograms metrics to record the entry point where Assistant UI
becomes visible (e.g, when AssistantVisibility changed from kClosed/kHidden
to kVisible).

Test: local compile and manually test.
Change-Id: I440ace2a719ce2bed2eda921fc9025809b414b6d
Reviewed-on: https://chromium-review.googlesource.com/c/1313117
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605035}

A new UKM event, PreviewsResourceLoadingHints, is being added. This
tracks the usage of the patterns associated with a resource loading
hints based preview and the total number of resource requests blocked
at each resource load priority.

The UKM is recorded after the URL's document finished loading and uses
the NavigationID from the browser's NavigationHandle as the source id.

Bug: 891453, 884815
Change-Id: I429a6ef5e6222d7f569c8d2eb5539d815af6ff02
Reviewed-on: https://chromium-review.googlesource.com/c/1307057
Commit-Queue: Jered Gray <jegray@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605034}

This does not add any new functionality, but sets the stage for things
like requesting the host to show a file picker.

Bug: 679313
Change-Id: Id0a25d038f274584dfd6661df50658437ad29258
Reviewed-on: https://chromium-review.googlesource.com/c/1265028
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605033}

This should make OOMs less likely for large queues, although it won't
stop misbehaving code from posting too many tasks which will lead to
and OOM.

Bug: 895930
Change-Id: Ia424dd1c2bbfaf27d1714f36c47067485060143d
Reviewed-on: https://chromium-review.googlesource.com/c/1314629
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605032}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b5f94ce7..04108353

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia223bc128fe2a07c678ff7ffebd6ee490fc10ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1315360Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605031}

clang automatically checks this value is correctly set, and it
simplifies macro usage.

Bug: 742517
Change-Id: I3b53752a7ac00e33167b9fb42fb3801ef8e7d378
Reviewed-on: https://chromium-review.googlesource.com/c/1308082Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605030}

ScopedFD will close the file descriptor on destruction, so the closes
here will end up closing the file descriptor twice, resulting in
badness if another thread opens a file descriptor between the two
closes.

Change-Id: Ib92efa06e879e1f820d51911fbaecc6cd9410268
Reviewed-on: https://chromium-review.googlesource.com/c/1315988Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Josh Gao <jmgao@google.com>
Cr-Commit-Position: refs/heads/master@{#605029}

There's evidence that some web iframes embedded on extension
background pages may be doing a lot of work with the assumption that
since this work isn't on a foreground tab, it doesn't need to be
optimized for responsiveness.  However, OOPIFs currently use an
aggressive process reuse policy, which also affects this use case,
making it possible for a web iframe on an extension to get into
another tab's process and adversely affect its performance.  This CL
avoids using that reuse policy for web iframes on extensions.

Caveats:

- When over the process limit, web iframes on extensions will still
  attempt to reuse an existing process.

- OOPIFs from normal tabs may still join processes for web iframes on
  extensions.  This and the previous point imply that there won't be a
  guarantee of perfect performance isolation for web iframes on
  extensions; the goal is to be more resilient to problems in the
  common case.

- We will stop potentially useful process reuse between same-site
  iframes on multiple instances of extensions, even for instances of
  the same extension.  We expect this to be rare in practice though.

Bug: 899418, 899838
Change-Id: I35f6ecc1945292f9fab1c21f65d1ac4b7970dbe3
Reviewed-on: https://chromium-review.googlesource.com/c/1306410Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605028}

Bug: 899183
Change-Id: I36a9c92556215d79bc40dbe9aed6ec8f1d5fa5c1
Reviewed-on: https://chromium-review.googlesource.com/c/1315627Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605027}

Bug: 610222
Change-Id: I9e94153e836f504c61ef216990d2dfd1ae77771c
Reviewed-on: https://chromium-review.googlesource.com/c/1313590
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605026}

Precisely, this disallows them when the event loop's
termination nesting level is nonzero.

This is now part of the spec,
https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name

> The window open steps, given a string url, a string target, and a string features, are as follows:
> 1. If the event loop's termination nesting level is nonzero, return null.

BUG=844455

Change-Id: I85fb003063f5ed051049c7c263391835421902ac
Reviewed-on: https://chromium-review.googlesource.com/c/1180296
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605025}

R=rch@chromium.org

Change-Id: I0dc88fee136ebc8b15260856d03be3163b566ccd
Reviewed-on: https://chromium-review.googlesource.com/c/1313849Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605024}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9e6f5134d1aa..f2cc71e5cbea


git log 9e6f5134d1aa..f2cc71e5cbea --date=short --no-merges --format='%ad %ae %s'
2018-11-02 stevenperron@google.com Handle OpMemberDecorateStringGOOGLE in ACDE (#2029)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@f2cc71e5cbea

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I96010e11cd4bdfa8d76b923cb2e4dbd2a926557b
Reviewed-on: https://chromium-review.googlesource.com/c/1315667Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605023}

https://chromium.googlesource.com/angle/angle.git/+log/99d0463cd940..6ba22ee13768


git log 99d0463cd940..6ba22ee13768 --date=short --no-merges --format='%ad %ae %s'
2018-11-02 geofflang@chromium.org GL: Implement EGL_ANDROID_get_frame_timestamps.


Created with:
  gclient setdep -r src/third_party/angle@6ba22ee13768

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I7e7d199f1adee2c6b3a34119c9e5d16b0328166e
Reviewed-on: https://chromium-review.googlesource.com/c/1315728Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605022}

The below changes were added to fix a crash on GTK4.  However, this introduced a
crash on GTK3.  I'm unable to reproduce the crash and I'm going to be afk for 4
weeks after today, so I'm reverting these changes since GTK3 is currently
supported but GTK4 is not, and I want to get the revert merged to M71.  The
changes can be relanded in the future once we have reliable repro steps.

GTK4: Fix event processing after closing dialogs
Fix crash in SelectFileDialogImplGTK::OnFileChooserDestroyThunk.
[GTK] Speculative fix for crash in SelectFileDialogImplGTK
Fix heap-use-after-free in SelectFileDialogImplGTK

BUG=880073,901282
R=sky

Change-Id: Id046e9a54527e4df251884e6447f8830a3b859d3
Reviewed-on: https://chromium-review.googlesource.com/c/1314636Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605021}

The autofill profile validator is a pointer, it is a good
practice to initialized it to null. Also, in Init, the
initialization should happen before WebDataService check.
Otherwise, sometimes (like in AutofillManager tests)
We'll miss initializing it.

Change-Id: Ibc0a74b40df40cb58b705c66925217a9bc7b8884
Reviewed-on: https://chromium-review.googlesource.com/c/1315668
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605020}

The app doesn't change state anymore so there is nothing to monitor.

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I7daa43cb9137e37b3f38cece458d7aa921239f46
Reviewed-on: https://chromium-review.googlesource.com/c/1315351Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605019}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ic0e717072a242ab397aad86a5ce651d4ea7de970
Reviewed-on: https://chromium-review.googlesource.com/c/1315488Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605018}

This is preferable because it avoids adding trace events while the
thread is idle (for which there is no precedent).

The delta between the instant events can be used to perform the same
analysis which could be performed previously (and these will be in
Slow Reports per being in an enabled category).

R=fdoray@chromium.org

Bug: 899897
Change-Id: I40d31df9f4db3ea8959f760323b7cd8f56299ce3
Reviewed-on: https://chromium-review.googlesource.com/c/1312928Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605017}

TBMv2 versions are added in
https://chromium-review.googlesource.com/c/catapult/+/1308815

Bug: 890757
Change-Id: If9f56016acbcd7f218a4e5516dcd74d0ae1a5327
Reviewed-on: https://chromium-review.googlesource.com/c/1313548Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605016}

Also,
- Enable a couple locally passing tests that don't have bugs attached.
- Disable EncryptedMediaTest suite on Chrome OS asan/lsan, to match
  Linux asan/lsan, due to flake (not unique to Mash).

Bug: 793426
Change-Id: Ia01b402234e33e5fda0f587fc8d47fad7897cbb7
Reviewed-on: https://chromium-review.googlesource.com/c/1315809
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605015}