- 20 Oct, 2020 40 commits
-
-
Colin Blundell authored
In //weblayer, SafeBrowsingDBManager currently can can be accessed only from the IO thread. However, the subresource filter component needs to take in a scoped_refptr to the embedder's SafeBrowsingDBManager on the UI thread as part of creating a navigation throttle. This instance is then internally passed to and accessed on the IO thread. In //chrome, the ServicesDelegate class creates the SafeBrowsingDBManager on the UI thread and vends a reference to it on any thread. This CL takes an analogous approach in //weblayer, allowing the method that creates the SafeBrowsingDBManager to be called on the UI thread, with the DBManager being *started* on the IO thread as it is now (via a posted task if the current thread is not the IO thread). We add an IO-thread safeguard to ensure that the DBManager is only started once. The precise structure here is not the same as that in //chrome's SafeBrowsingService, as the underlying structure is not the same: //chrome's SafeBrowsingService has an explicit Start() method from which it posts a task to start the SafeBrowsingDBManager on the IO thread. //weblayer's SafeBrowsingService has no such method and instead the SafeBrowsingDBManager is created/started on demand. Bug: 1116095 Change-Id: If6303ee0ec36ec75109eb3917dd5cea3946d98bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478950 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#818850}
-
Morten Stenshorne authored
Bug: 800764 Change-Id: I54f490a37baee7f8e98198fa28794aa216f9f33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469563Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#818849}
-
arthursonzogni authored
This was computed in CommitNavigation(). We would like to expose the sandbox flags to the NavigationThrottle, which are run earlier. This patch moves the computation immediately after receiving the response. Since computing sandbox flags will depends on is_loaded_from_mhtml_archive_ in: https://chromium-review.googlesource.com/c/chromium/src/+/2452475 both are moved. Bug: 1136873,1041376 Change-Id: I98d33ea0a9367e87571644da648d40d0487a97cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467917Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818848}
-
Lei Zhang authored
This file does not get built on bots by default, so https://crrev.com/817812 broke it without anyone noticing. Update the TestPrintBackend::AddValidPrinter() call with the missing parameter. Change-Id: Iaa6118381e8743e0e052415a12bae874bf30da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483027Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818847}
-
Michele Mancina authored
Bug: b/170722915 Change-Id: Ia887555904f1eba8c039ca6460c88d42b2b9352b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480522Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#818846}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If5d0a7e07078aed0a38a6eb9c745a8e710da5a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485780Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818845}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6929e8957a1..feeda66ef207 2020-10-20 changhaohan@chromium.org TypeScriptify elements/EventListenersWidget.js 2020-10-20 alexrudenko@chromium.org Inspector overlay: remove common.css resource 2020-10-20 jobay@google.com Typecheck source_frame/FontView.js with TypeScript 2020-10-20 alexrudenko@chromium.org Revert "Remove dependencies on ShortcutsScreen" 2020-10-20 alexrudenko@chromium.org Revert "Settings: Remove old ShortcutsScreen" 2020-10-20 jobay@google.com Typecheck source_frame/PreviewFactory.js with TypeScript 2020-10-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1139862,chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I278f16abd5614cabba4e66c7cb444439054c9b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818844}
-
Leo Lai authored
STATUS_DBUS_ERROR is introduced to distinguish dbus error from attestation service internal error. In the near future, it will be used at consumer side for more clear error handling. BUG=b:158955123 TEST=unittests. Change-Id: I7590c8156f4098bf305cfb59ecac1551baf92994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428349 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#818843}
-
Fredrik Söderqvist authored
Return a bool from LayoutSVGContainer::UpdateCachedBoundaries() to indicate if the oBB (object bounding box) has changed. This allows merging the two resource-related invalidation code-paths while making them somewhat more precise. It also allows separating the handling of the |needs_boundaries_update_| flag from the the general bounds propagation. LayoutSVGContainer::UpdateCachedBoundaries() is also called, but since that callsite matches the IsSVGHiddenContainer() is doesn't have to respond to/handle the return value. Bug: 1028061 Change-Id: I57a2ed3a3c5d8aa420eb79f67240b69352ee6a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485155Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818842}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef6ea580ba4a..b3199231953f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I999a9ef22047415433939e11587e6a29aa1b95c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486853 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818841}
-
Paula Vidas authored
This is a reland of 291faaf5 The original version of the test was flaky. The bug was in assuming the entities are ordered by arrival time. They are actually ordered by some unique id, which is random, and so the order was "wrong" about half of the time. Original change's description: > [SyncInvalidations] Add signout and signin integration test. > > This CL adds a test that checks the following: > - On signout, the FCM registration token should be cleared. > - On signin, it should be requested again. > > Bug: 1135167 > Change-Id: Ie1b1967b9ed317c0a36d4b751aef0dfeb81c45d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467979 > Commit-Queue: Paula Vidas <paulavidas@google.com> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Rushan Suleymanov <rushans@google.com> > Cr-Commit-Position: refs/heads/master@{#817408} Bug: 1135167 Change-Id: I5ea7c873d6782bf53ccff040d956c2a03845acd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485105 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#818840}
-
chrome://quota-internalsdpapad authored
- Generate a JS module for cr/ui/tabs.js. In order to do so changing cr.defineProperty() to Object.defineProperty() as done for other cr.ui elements as part of crbug.com/1133198 - Include tabs.m.js, tree.m.js and ui.m.js in Desktop builds. - Fix getPropertyDescriptor() signature in cr.m.js to address JS compiler errors when used from tabs.m.js. - Update chrome://quota-internals to use the module versions of its dependencies. Bug: 1028829 Change-Id: Icf6576d4111f7bc7481b1a105b80d76ebe4d91d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478887 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818839}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/502e98295625..6fac705e7616 2020-10-19 afdx@google.com spirv-val: Fix validation of OpPhi instructions (#3919) 2020-10-19 afdx@google.com spirv-fuzz: Avoid void struct member when outlining functions (#3936) 2020-10-19 afdx@google.com spirv-fuzz: Do not allow Block-decorated structs when adding parameters (#3931) 2020-10-19 afdx@google.com spirv-fuzz: Fix to operand id type (#3937) 2020-10-19 afdx@google.com spirv-fuzz: Handle dead blocks in TransformationEquationInstruction (#3933) 2020-10-19 afdx@google.com spirv-fuzz: Do not allow sampled image load when flattening conditionals (#3930) 2020-10-19 afdx@google.com spirv-fuzz: Take care of OpPhi instructions when inlining (#3939) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC jonahr@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: jonahr@google.com,radial-bots+chrome-roll@google.com Change-Id: I4f3a6977cab44d24ece2e4e364eaa7227f1dfce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486859Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ac1ded033136..38688fcdba24 2020-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from cb9deed9 to 60b90a0b (436 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ie10ba56d6554c25d9a03a41fb4a4aa22422f2c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485119 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1078618d07a0..749daf949871 2020-10-20 dberris@chromium.org pinpoint: Use getattr for missing properties If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: Iff6373aea5a7ae1eac8012e64a37534c7ebb934b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486814Reviewed-by:
-
Alfonso Castaño authored
This CL enhances the existing CSP Issues with information about whether the header is report-only or not. This CL will be extended with another CL to surface those changes in the Devtools frontend. It includes the corresponding layout tests and the existing layout tests. Bug: chromium:1139223 Change-Id: Ic63c7edd68e56cb5464e451030d9fcf2900ecd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480243 Commit-Queue: Alfonso Castaño <alcastano@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#818835}
-
Luciano Pacheco authored
This is a preparation to migrate to JS modules. Bug: 1133186 Change-Id: I9e6a01f783299018bf0bce56844bfe10cd8b4a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469347Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818834}
-
Arthur Sonzogni authored
This reverts commit 61329208. Reason for revert: https://crbug.com/1140413 Original change's description: > [TTS] Fix a disabled test (OOP issue) > > Speculate fix for testLivePrefetchFailoverRequestMadeAfterOpen > which was failing with out-of-process network service error. > > BUG=1071721 > > Change-Id: I95cc3bba5ffd17e38b58fc88a3ff227045fe9feb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486072 > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Reviewed-by: Sinan Sahin <sinansahin@google.com> > Auto-Submit: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818664} TBR=donnd@chromium.org,sinansahin@google.com,jds@google.com Change-Id: I1e90b5f194fce483f3440fe125c0fd6f4c492015 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485107Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#818833}
-
Andy Paicu authored
TBR: chfremer@chromium.org Bug: 840294 Change-Id: Ifd69205db90a4a8a77387d62ab812eb4d4c7f446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485159Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818832}
-
Martin Robinson authored
When an action is triggered on a container with selectable children and that container has a focused or activedescendant child, retarget the action to that child. This fixes an issue where when the VoiceOver cursor is on a tree with a focused child, triggered context menus would use the tree as the target element. menu on a tree instead of a focused child. Bug: 1114892 Change-Id: Ibe580beed93aeaac54d1dabaee28443b290fd0e2 AX-Relnotes: Fix an issue where VoiceOver would trigger a context Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466281 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#818831}
-
Luciano Pacheco authored
This is a preparation to auto-generate the JS module using polymer_modulizer() which requires the <script> tag to be inside the <dom-module>. This has no impact in the Polymer element behavior. Bug: 1133186 Change-Id: I97102f37502bd35eb7110a59633a627f022598dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470062 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Mason Freed authored
Change-Id: Idf58c176a453d6fc64b35fe284ac7a1cd2145dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485697 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#818829}
-
Luciano Pacheco authored
This is a preparation to auto-generate the JS module using polymer_modulizer() which requires the <script> tag to be inside the <dom-module>. This has no impact in the Polymer element behavior. Bug: 1133186 Change-Id: I80a6c3f98e5b37a2041f88bdce4990496455f5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469922 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
Updated the logic to generate timing list. Bug: chromium:1130157 Change-Id: I285a6712ade0018bae4e1af23081827124b146ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468291Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#818827}
-
Reda Tawfik authored
This CL enables PhishGuard for passwords selected from AllPassswordBottomSheet by notifying PasswordReuseDetectionManager after filling the password field with the selected password. Bug: 1138612, 1104132, 1006430 Change-Id: I83cd6fbab78778ec7883f82011ec97a238e4ea09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472358Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#818826}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603151856-f47d024d838dc85b63fc569bff574a3f3aa4f83b.profdata to chrome-mac-master-1603172634-987778035e1cace5841998f11e79079a8a8488cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idbfc9b0fd97b6e3417fb84be66772ec08eaef2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485120Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603151856-6eb5756dcc723ec6d37bc459a0cd70533fdc40e5.profdata to chrome-linux-master-1603172634-0379c4f8f7d3cbe89c00f53d2913dcf6ff1ea486.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If02bef0467986450bcc12937794b80c2d5990cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486852Reviewed-by:
-
Hiroki Nakagawa authored
This flag is now enabled by default and no longer necessary, so this CL removes it. We could remove more code (e.g., PrerenderManager::SetMode()), but this CL focuses on the flag to minimize changes. Subsequent CLs will remove them. Bug: 632361 Change-Id: Ib4a0edfbfb4c62c6e98a112ecf7fdfa604063454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485412 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#818823}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8f4c6aa05d54..f6929e8957a1 2020-10-20 jobay@google.com Typecheck source_frame/SourceFrame.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iac18f7366d78caa8d07d6955c0858e21f43c12f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486572Reviewed-by:
-
Fredrik Söderqvist authored
The following tests: fast/events/mouse-cursor.html fast/hidpi/image-srcset-png-canvas.html fast/hidpi/image-srcset-relative-svg-canvas-2x.html fast/hidpi/image-srcset-relative-svg-canvas.html fast/hidpi/image-srcset-svg-canvas-2x.html fast/hidpi/image-srcset-svg-canvas.html appear to have been cycling green successfully for a while, so drop them from TestExpectations. (fast/events/mouse-cursor.html had a single timeout on one Mac bot, which is disregarded.) Bug: 652536, 1064839, 1065335, 1071915 Change-Id: Ia2e8b0c40f0246c8182f9706f2676be5854f8f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484704Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818821}
-
Noel Gordon authored
Move DevTools listener to the file_manager_browsertest_base.h (to keep out of the way of other work that'll go on here). Tbr: alex Bug: 1113941 Change-Id: Ie814fda50afef3d1cd19ce7d47ebc8a39a2b0818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485373Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#818820}
-
Evan Shrubsole authored
Adds blink feature WebRtvLibvpxEncoderNV12. When enabled which will avoid copying and converting GMB frames in NV12 format, by mapping the data for reading. This is only available when scaling does not need to be done. When scaling is needed, the frame will be converted to I420 and scaled as before. Comparing encode times with the feature on and off shows trivial differences with the Mac facetime camera, capturing NV12 to an IOSurface shows a trivial difference in encode time (10.2ms for I420 vs 9.8ms NV12 on mapped GMB). Both runs done in compiled Chrome with appr.tc sending HD encoded with VP9. Power draw is also about the same (+0.2W with I420 at a stddev of 2.4W) Tested running Chrome with the feature on and off, confirming that NV12 images were encoded with the VP9 encoder. Bug: 1134165 Change-Id: I479e3541536317268c5ca25a3e88c4898bfa2ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467860Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#818819}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/babce049d02e..f0dcaca2c2d8 2020-10-20 cnorthrop@google.com FrameCapture: Image Texture binding in MEC 2020-10-20 cnorthrop@google.com FrameCapture: Implement Gen/DeleteVertexArraysOES 2020-10-20 cnorthrop@google.com Perf tests: Bump replay ES version to 3.1 2020-10-20 cnorthrop@google.com FrameCapture: Fix GLSync creation for MEC on 64-bit 2020-10-20 jmadill@chromium.org Perf Tests: Call finish every step in calibration. 2020-10-20 cnorthrop@google.com Add ES 3.1 check to ValidateBindImageTexture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1136900 Tbr: jonahr@google.com Test: Test: FIFA Mobile MECTest: Test: LEGO MECTest: Test: Lots of traces were hitting this Change-Id: I421a812513ff59b22dd803c33be0ba582a2cb01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486817Reviewed-by:
-
Greg Thompson authored
The UpgradeDetector responds to an in-use update by advancing the browser through various "annoyance levels". These cause things like the app menu to change to an update arrow, or a relaunch notification to show. Previously, the very first evaluation of the annoyance level following an update was delayed by 20 minutes. This CL removes that delay. The only significant observable change is that notification of critical updates will no longer be delayed. This is conceptually the right thing, as delaying anything deemed "critical" doesn't make sense. BUG=1099386 Change-Id: I14c0b7f1a7530dc89a7a1e63fa8d9a6c0345c387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479371Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#818817}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38f7cc8c..d9768e31 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I81d46433639389487c64283f95ff67145abfebb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486177Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 00bc27e4. With Chromium commits locally applied on WPT: c31f15ed "WebMediaPlayerImpl: err if no A/V in ::OnMetadata" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Iacdbe4988350c465f2b2d3daf3f8e2925efe890c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486881Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818815}
-
Yury Khmel authored
This adds notifications from ARC about power mode changes and request to read current state. Android part: ag/12863924 DD: go/arc_power_control BUG=b:170982650 TEST=In context of prototype. Change-Id: I4593eb8284d8473a249d71f00aa5c979bd1c3bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480707Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Auto-Submit: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#818814}
-
Mike West authored
This patch adds network::features::kCrossOriginOpenerPolicyByDefault, which changes documents' default COOP from `unsafe-none` to `same-origin-allow-popups`, as suggested by the proposal at https://github.com/mikewest/coop-by-default/. The feature is disabled by default, and should not (yet!) have any impact on ordinary browsing. Bug: 1139911 Change-Id: Ib97b51ee0ac7f76e2d67bb14ce47ba610cdb8d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485492Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e3107eb1fb9..ef6ea580ba4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: calamity@google.com Change-Id: Ie0ecfb8057eb5b07b4ab29b6b7af50c437fe6cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486409Reviewed-by:
-
Jan Wilken Dörrie authored
This change prolongs a few password manager histograms that are expiring in M88 and are still useful. jdoerrie@ replaces battre@ as an OWNER where approriate. R=chromium-metrics-reviews@google.com Fixed: 1138301, 1138303, 1138307 Change-Id: Id4ef858e6ac546640575d889307c66613abde8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485051 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
