GitLab

This avoids getting a newly created ContextImpl from every call to
Context.createContextForSplit().

Bug: 1126301
Change-Id: I080841b697e2f28000d2a4d11ff197a015a1dca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527852
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825990}

Bug: 1146552
Change-Id: I6b4ee181e0b62044892b2649033f426544f25c04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526703
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825989}

- Remove restart the chrome while switching between dark and light mode.
- Preference will retain the value once it has been registered and set
  the value before. Go back to the |kDefaultDarkModeEnabled| if the flag
  is disabled.

Bug: 1146531, 1131543
Change-Id: Ie32da506f61fe78e31820456fe8ffc92d862ba8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530249Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825988}

A server change caused us to fail to compute the index
of the card when the action originates from the bottom sheet.
This change lets us continue to record metrics even if we
don't identify the card index, using MAX_INT as a special
value.

While this fix isn't ideal, it's better than missing out
on these metrics. We can improve this later.

Bug: 1111101
Change-Id: I063835a44ad4abb92f05e997fd27c535dc4dcb23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522574
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825987}

Tricium service will reject the config if the "platform" for the
definition and selection don't match -- but in fact the platform
field is not important anymore, since platform is actually determined
by the builder config. It doesn't make any difference whether we
specify UBUNTU or LINUX, so just unify it to one.

Bug: 1105239
Change-Id: I8822957fa34e9e5afaa06a687cdeed50614aa087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530749
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825986}

Change-Id: Ie1416346c5ba30775e005c96512c2de770c6b635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527630
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825985}

On ChromeOS the text does not appear in the output, so we should just
pass "" like other EXPECT_DEATH calls do.

  Result: died but not with expected error.
  Expected: contains regular expression "Check failed"
  Actual msg:
  [  DEATH   ]
  Stack trace:
  #0 0x5577cb1ef7ee ui::(anonymous namespace)::ClipboardTest_Bitmap_F16_Premul_Test<>::TestBody()

R=sky@chromium.org

Bug: 1144462
Change-Id: I8890b6fe3e5bfacf49c8bbb840a21543502ea537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530797Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825984}

We need to update the child iterator with where we ended up, so that the
check (after the outer loop) for whether we're at the end or not works
as intended, so that we SetHasSeenAllChildren() if we're at the end,
lest we start from the very beginning of the multicol container when
resuming layout after the spanners, which would result in an "infinite"
loop (well, until we run out of memory, anyway).

Bug: 1052834
Change-Id: I6650e9dc2c209ef6097b067344c9cff019ee4071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527139Reviewed-by: Alison Maher <almaher@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825983}

TBR=nektar@chromium.org

Bug: None
Change-Id: If65d7e630b152a48759be2016928895a06094b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530209Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825982}

Added unit test to ensure full destruction of the Widget.

Bug: 1146238
Change-Id: I4b5a463e5f657fb3084f664f1ecc2acf0e2ac0a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527849
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825981}

Disable WebBluetoothScanningIdsNotPersistent test

NOPRESUBMIT=true

Bug: 1147575
Change-Id: I5e5db1e7a066f96155173922fe5e2d740a99ce7f
NoTry: True
Tbr: msw@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530748Reviewed-by: Yu Han <yuzhehan@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825980}

The icon isn't a <cr-icon-button>, so it doesn't already have styling
for RTL inversion.

Fixed: 1146941
Change-Id: I5267cdecc6da48c3167c44d81904dac963d008d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528919Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825979}

This adds a new BufferUsage of PROTECTED_VDA_WRITE which is intended to
be used by HW video decoders to decode to a HW protected buffer.
Initially this will only target the VAAPI decoders.

This path will not be used yet, as there are other CLs pending to
enable protected decode in VAAPI as well as kernel patches for the
graphics driver. The high level functionality is also behind a Chrome
flag.

BUG=b:153111783
TEST=Built/ran with full prototype

Change-Id: I775bda3782e5c72b28cbbf2c6c4b0e0eed76abaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499087Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#825978}

The goal of this change is to try to improve scroll latency for paint
preview, by freeing competing resources eagerly. Instead of freeing
bitmaps/compositing after animating a fade we can do so beforehand.

Change-Id: I8f91792e66c83765335a77683f3c35b85108f79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527506
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825977}

Existing logic currently dismisses all infobars that are presented
before the page is loaded for a navigation request. This means that in
some cases the sign-in infobar may be removed before it is presented to
the user.

Move the logic to display the sign-in infobar after the page is loaded.

Bug: 1145592
Change-Id: I2404009417aa66e8b1c9836571ef88f9eb5e6f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527147Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825976}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85f69d7b20d2..fa36737aeb08

2020-11-10 yangguo@chromium.org Fix assertions in assertion_test
2020-11-10 andoli@chromium.org [ts] Typecheck elements/NodeStackTraceWidget.js with TypeScript
2020-11-10 changhaohan@chromium.org Fix CSSAngle unit conversion issue
2020-11-10 tvanderlippe@chromium.org Typecheck node_main/NodeConnectionsPanel.js with TypeScript
2020-11-10 wolfi@chromium.org Disable flaky console.error assertion test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1145969,chromium:1147435
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0ef37d753004cc6b1a646918266bba038d3733f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529878Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825975}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.
This CL was uploaded by git cl split.

R=tapted@chromium.org

Bug: 1145565
Change-Id: Ic8f6127259269507bb4c44bdb4abd8371da08ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526961
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825974}

Java bitmaps come from many places, but they originate from one of:
- mojom::ImageDecoder::DecodeImage() IPC replies from a renderer
- Resource bundles from disk
- mojom::ImageDownloader::DownloadImage() replies from a renderer
- WebContents::DownloadImage() or WebContents::DownloadImageInFrame()
  which use mojom::ImageDownloader::DownloadImage()
- qrcode_generator::mojom::QRCodeGeneratorService::GenerateQRCode()
  replies from a utility process
- mojom::WidgetHost::SetCursor() IPC from a renderer

The ImageDecoder is made to verify replies in
https://chromium-review.googlesource.com/c/chromium/src/+/2518931

The others are made to made to verify in this CL.

For IPC replies, we expect the result to be an N32 32bpp bitmap, and
we CHECK() when it differs. We do make an exception for DownloadImage
replies as the downloaded image may have an arbitrary type. We would
need to have the renderer convert instead otherwise.

For IPCs originating from the renderer (aka SetCursor), we convert the
sent bitmap to an N32 32bpp bitmap on receipt, or drop the request if
that is not possible.

R=boliu@chromium.org

Bug: 1144462
Change-Id: Ie3b839360fd9098af341a778c0c6ec20ecb72a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520236
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825973}

Bug: 1142572
Change-Id: I67ca2b66c9a10d68e0952bd46ef3cae8ae8865bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528638Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#825972}

This interface is basically a simpler VoteConsumer. It allows
to observe votes made through a voting channel without having
to deal with AcceptedVotes.

One limitation it has is that it is no longer possible to
submit multiple votes to the same context through a single
VotingChannel. In practice, this was never done anyways. To
support multiple votes for one context, it is easy to build
multiple voting channels.

Of course, AcceptedVotes still exists. Those are managed by
the VoteConsumerDefaultImpl, which is a temporary class that
handles creating and deleting AcceptedVotes as needed, then
notifying the VoteObserver.

The goal in the future is to fold this functionality into
the VotingChannelFactory and remove VoteConsumer entirely.

This will be done after each users of VoteConsumer are migrated
one at a time.

Bug: 971272
Change-Id: I4e890435cf29d4375ccb41b393b6d80b2d392778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519207
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825971}

TBR=govind@chromium.org

Change-Id: I96ef90953c873bcd20d3a665e8bac347b54c74ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529672Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825970}

This CL is adding unittests for ELIDE_HEAD text eliding.

The test coverage of this eliding mode is low and we want to increase
it before trying to refactor the code.

This CL has no behavior changes.

R=gab@chromium.org,msw@chromium.org

Bug: 1085014
Change-Id: I7f84fba3c558fcf2fa63a9f07fa0e0270ce7d121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522918
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825969}

Add UI for button to skip the profile discovery page and go to the
activation code page.

Bug: 1093185
Change-Id: I558f2df186829ddb9147dff19a0e34289fa20a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528142
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825968}

As specified in https://github.com/WICG/trust-token-api/pull/48, the
Sec-Signature header now includes the algorithm identifier of the
signing algorithm used to sign the header. We add this alg
identifier to align with the spec.

Change-Id: I90023b3f40fdb18d18aa73edbbecdcc25cf5aacf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505813Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: Callum May <camay@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#825967}

This reverts commit 674a1af2.

Reason for revert: suspected cause of crbug.com/1146687

Original change's description:
> Refactor subresource redirect renderer code
>
> This CL refactors the existing subresource redirect code to make the
> robots rules and login based image compression implementation easy.
>
> * Separate out the url loader throttle that does redirect and timeout
> handling from the public image hints decider logic. The robots decider can
> be subclassed and used.
>
> * Make public image hints agent as renderframeobserver. This reduces
> cluttter in ResourceLoadingHintsAgent. The upcoming robots checker agent
> could also observe renderframeobserver directly.
>
> No change in behavior is expected.
>
> Change-Id: Ic555a4402016a645b8820fa87dd5157c7112fb71
> Bug: 1144836
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514068
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Michael Crouse <mcrouse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825115}

TBR=rajendrant@chromium.org,mcrouse@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1144836, 1146687
Change-Id: I483882b29ac342d188137690e7ba9f8cbedcd6ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527859Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825966}

Expose ChromeStartupDelegate feature flag to Java (missed in
https://crrev.com/c/2523359) and cache flag and variations so they can
be accessed before the native FeatureList is initialized.

Bug: 1143402
Change-Id: I1f624009e00bc6d40bbef39b6a093cb15a60c50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529701Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825965}

Allow tab/shift+tab to navigate through all elements in the UI. Let up/down arrows move focus between read later list items. Let right/left arrows cycle focus between a list item and its buttons. This behavior comes from discussion during a11y office hours.

Still TODO: add dark mode support for buttons and hover/focus states (crbug/1147457).

Bug: 1140166
Change-Id: I3a119e8d940a4307e746c10f3ded7541963f46f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527345
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825964}

Use testdriver Action API to simulate mouse actions in
html/user-activation/activation-thru-contextmenu-event.html.

Bug: 1145677
Change-Id: I8c287cd45d87e809cfa4b5967df38ed0b58d0d37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520453Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825963}

The low entropy source is reported as a variation ID offset from
3320978. For example, a low entropy source value of 10 is reported
as variation ID 3320988.

The low entropy source is a locally-generated value in the range of
0-7999 that's used by Chrome to derive the variation ids included
in the X-Client-Data header. Since other variation ids have been
selected based on this value, this does not expose any additional
entropy in the header given enough variation ids.

Note: 8000 possible values is under 2^13, therefore having 13+ A/B
variations would carry the same amount of entropy. A typical
Chrome client has more than 13 variation ids reported.

Adding this value allows for retrospective A/A tests for
validating that there's no existing bias between two randomized
groups of clients for a later A/B study.

Bug: 1134444
Change-Id: Ia1af76f469cb2e3e25b03884abc4974cec237977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461906
Commit-Queue: Karthika Pai <karthikapai@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825962}

Currently if a user hovers their mouse over a selection in a desk's
renaming textfield or a folder's renaming textfield, the default cursor
behavior is a normal pointer. Based on UX, we would like to display
an ibeam instead.

This CL overrides the default cursor behavior of both textfields to
allow this.

Test: manual
Bug: 1133681
Change-Id: I8aef053a7355e8ed873685c0b54f8de96d47da3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464123Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825961}

This CL is adding to the RenderText API fuzzer the calls to
  * GetSubstringBounds(...)
  * GetCursorSpan(...)

These calls were missing to trigger the following bug:
  http://crbug.com/1146674

R=gab@chromium.org,msw@chromium.org

Bug: 1146674, 1146674
Change-Id: I2867262bcc8cba97f666bbc084656dd4e1ac7362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530369Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825960}

Since the background tracing trial names are different for Chrome and
WebView, this change makes the trial name a parameter of
BackgroundTracingManager::GetBackgroundTracingConfig().

Bug: b/170513316
Change-Id: I963d6d34e87d70633fab9cfda36d96ba8ab770f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523904
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Michael Bai <michaelbai@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825959}

The service controller passed to ServiceControllerProxy was being
initialized asynchronously, and could occasionally be passed into
ServiceControllerProxy before being correctly initialized, causing
a segfault once accessed. This CL changes that behavior to simply
immediately initialize the service controller.

Fixed: 1147293
Change-Id: Ie4e396706b5477befca47805c8984c697a814bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527633Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825958}

This patch enables rounding of the profile icons in the Mac's people
menu to align with the GM2 circular icons used elsewhere in Chrome.
This is achieved by applying a circular mask to the image and
increasing the resolution of the avatar icons requested.

This CL also avoid a call to AvatarMenu::GetImageForMenuButton() and
calls GetAvatarIcon() directly (the additional logic of
GetImageForMenuButton() is not needed here).

Bug: 857064
Change-Id: I1444dc6081f3af6289be7fa6a886153a70c9ecf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517059
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825957}

extension_messages.h included a typedef for SubstitutionMap, which
mimicked MessageBundle::SubstitutionMap (each a
std::map<std::string, std::string>). Instead, just include
message_bundle.h in extension_messages.h, and remove the extra typedef.

Bug: None
Change-Id: I1a076b7dd8f45f774296dcf2cd64fa3ea2960356
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528092
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825956}

The additional crash keys should help determine what happens in ~77% of
reports where the "DetermineSiteInstanceForURL / same-site-navigation"
branch was picked.  In particular, the new crash keys should help
understand why the earlier "DetermineSiteInstanceForURL =>
source_instance" branch was not picked for about:blank navigation when
calculating the SiteInstance in
RenderFrameHostManager::DetermineSiteInstanceForURL.

Bug: 1116320
Change-Id: If54e0a230a5f89b8169fdf2d26022a8267223ea6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527963Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825955}

Reorder the file type options to match the spec.

Bug: 1059779
Change-Id: I1dc213f2cfb1f1b388288552b8391ef69ef3e38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529236
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825954}

Bug: None
Change-Id: I1f436a10c64f9e8ca59dfbe0d811cfc6904ca680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530257
Commit-Queue: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825953}

Plumb though better error information (for a future change) and some
status updates. Use the status updates to visually indicate the progress
of a QR transaction.

BUG=1002262

Change-Id: I94ce3abf4accb5b28273fc5ee6a9f07386f64d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511975
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#825952}

forms.

Bug: 1147363
Change-Id: Ie89fba59a8ea75ae8bed2a150e1cb45af34329e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527127
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825951}