- 12 Dec, 2018 40 commits
-
-
Stephen White authored
The plan is to move the actual test targets in Dawn to Dawn's src/test directory. This change makes Chrome temporarily point at some intermediate proxy targets, so we can move the real ones without breaking Chrome. Bug: dawn:61 Change-Id: I27a66a0daffe212da3fe2a0aaba7d4a250a376ea Reviewed-on: https://chromium-review.googlesource.com/c/1373892Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615895}
-
Friedrich Horschig authored
The tests were reenabled in https://crrev.com/c/1362814 but started to flake again. Probably for a different reason but the tests have changed a lot since, so disabling is easier wrt conflicts and keeps any possible improvements. TBR=achuith@chromium.org Bug: 891484, 891277 Change-Id: Id046f7bf0558dcd98c4e0c06dc71049feb938a3d Reviewed-on: https://chromium-review.googlesource.com/c/1373822Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615894}
-
Thomas Tangl authored
Before: https://drive.google.com/file/d/1CGW5Lfwln-jO1d_yCleuOtYv8lIRFyiy/view?usp=sharing After: https://drive.google.com/file/d/1oXkLoEzcUjto-0wvG9tKiPfC1jEbtU9u/view?usp=sharing Bug: 914030 Change-Id: I5dea177a8cb0c479ce491729a80fd5e88d5cfd5e Reviewed-on: https://chromium-review.googlesource.com/c/1371880 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615893}
-
Jan Krcal authored
This CL changes the implementation of CreditCard::Compare() so that we do not distinguish masked from unmasked server cards. This distinction was not needed by any of the call sites and it is undesired for wallet data sync. Namely, we do not want to write to database new server cards if the only difference is that some cards in the DB are unmasked whereas all cards from sync protos are (by definition) masked. This DB write does not change anything in the DB but it is unnecessary and it also pollutes UMA metrics. Bug: 908905 Change-Id: I187e8f717c7595220545febc22e479ea6806baf9 Reviewed-on: https://chromium-review.googlesource.com/c/1373449Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615892}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd3ad7fe5db7..2b0ac1d1ccfa git log dd3ad7fe5db7..2b0ac1d1ccfa --date=short --no-merges --format='%ad %ae %s' 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 09056de49d52..9fbaf697cd86 (1 commits) Created with: gclient setdep -r src/third_party/skia@2b0ac1d1ccfa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I8f732e106dd9eac2ea57f6014319fc4940a39178 Reviewed-on: https://chromium-review.googlesource.com/c/1374030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615891}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b7b8ca415e..50dd0e1a15cc Created with: gclient setdep -r src-internal@50dd0e1a15cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifd07ededc05d4f9d3af7c34a76b42b53993344ae Reviewed-on: https://chromium-review.googlesource.com/c/1374031Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615890}
-
Charlie Andrews authored
This reverts commit 3179adc4. Reason for revert: Problem was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1373373 Original change's description: > Disable blink_perf.dom custom element default style story > > TBR=crouleau@chromium.org > CC=hayato@chromium.org,tkent@chromium.org > > Bug: 914084 > Change-Id: I42a62fdb5bb6b7f74291272b4c3d1fc14bfbdbfa > Reviewed-on: https://chromium-review.googlesource.com/c/1372721 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615748} TBR=tkent@chromium.org,charliea@chromium.org,crouleau@chromium.org Change-Id: If7349256e7b5b4d8d84f3dff2cad7a813455c235 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914084 Reviewed-on: https://chromium-review.googlesource.com/c/1374091Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#615889}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e98d9aa1ef9b..572100bbdaa1 git log e98d9aa1ef9b..572100bbdaa1 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 lamontjones@chromium.org signing: Eliminate needless conversion of partition name to number. Created with: gclient setdep -r src/third_party/chromite@572100bbdaa1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia233ddf077a3ec9be9e87d3ce356911178bbc888 Reviewed-on: https://chromium-review.googlesource.com/c/1373936Reviewed-by:
-
Armando Miraglia authored
BUG=736309 TESTED=ninja -C out/Default/ content_unittests && ./out/Default/content_unittests R=guidou@chromium.org Change-Id: I838b68b20ed81a088312a4b0fd0f4527ada9b3b7 Reviewed-on: https://chromium-review.googlesource.com/c/1373817Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#615887}
-
Tomas Popela authored
Add a new enable-webrtc-pipewire-capturer about flag, that when enabled, will allow to use the PipeWire media server for providing the screen content for screen casting when user is running on Wayland display server on Linux. The flag is disabled by default, due to the user experience as it involves two extra confirmation dialogs outside of Chromium - requested by Weiyong Yao. It could change the default, once it goes through Chromium UI review. Bug: 682122 Change-Id: I70c07a4a170b2bf1717f6c155905625eba84ff5a Reviewed-on: https://chromium-review.googlesource.com/c/1365444Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#615886}
-
tzik authored
This reverts https://crrev.com/df46b528df23b652. After uprev'ing //base/third_party/symbolize at https://crrev.com/3f2959908f72e8b0, google::Symbolize is thread-safe itself, and the lock around here is no longer needed. Bug: 904743 Change-Id: If6d659491ebcca548363a98c91334693334f6a0b Reviewed-on: https://chromium-review.googlesource.com/c/1362712Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#615885}
-
Jan Krcal authored
This CL removes a server address from an integration test that deals with server cards. The goal is to (a) keep the tests minimal and (b) verify that the removed line is causing occasional flakiness of the test. Bug: 894001 Change-Id: Ia773506a051ef4134c37154900c2ffd54ede7048 Reviewed-on: https://chromium-review.googlesource.com/c/1373764 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Olga Sharonova authored
I don't recall how it was used before; but apparently it's not used any more. Bug: 914323 Change-Id: I4c9bd365b4f2331999b973dfd09bba0dc1ced279 Reviewed-on: https://chromium-review.googlesource.com/c/1373833Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#615883}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72448bed..8aca9026 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I717f9c3d843808fc3391716a77fcd47fe82df4e0 Reviewed-on: https://chromium-review.googlesource.com/c/1373929Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615882}
-
Andrew Grieve authored
There's no downside that I've been able to see, so makes sense as the default. Bug: 439949 Change-Id: Iecf8beee2f3c7160c700ea3417a1f74ff7f97873 Reviewed-on: https://chromium-review.googlesource.com/c/1372536Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c00efea4fee9..7cfbbc30ae1c git log c00efea4fee9..7cfbbc30ae1c --date=short --no-merges --format='%ad %ae %s' 2018-12-12 hjd@google.com Merge "perfetto-ui: Preperation for adding counter details" Created with: gclient setdep -r src/third_party/perfetto@7cfbbc30ae1c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7c9d6073db4e22775b2159102d47cfe9a207008e Reviewed-on: https://chromium-review.googlesource.com/c/1374029Reviewed-by:
-
Friedrich Horschig authored
Like other before-unload-return-value-from-listener.html, this one also crashes flakily with the "bad mojo message" reason. It also has a history of flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fuser-activation-v2%2Ffast%2Fevents%2Fbefore-unload-return-value-from-listener.html&testType=webkit_layout_tests TBR=yutak@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906952 Change-Id: I13b618385de5a49f83638229b05454ef38092fad Reviewed-on: https://chromium-review.googlesource.com/c/1373762Reviewed-by:
-
Friedrich Horschig authored
This reverts commit ad12d441. Reason for revert: Findit found this to be the most likely culprit for the single_process_mash_browser_tests failures on various Linux bots: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/30518 Original change's description: > Reland "Disable the new tab-loading animation" > > This reverts commit 742b8857. > > Reason for revert: Flaky tests should be fixed in r615470. > > Bug: chromium:912543, chromium:913135, chromium:913784 > > Original change's description: > > Revert "Disable the new tab-loading animation" > > > > This reverts commit 355b8185. > > > > Reason for revert: Made several tests flaky: https://crbug.com/912543 > > > > Original change's description: > > > Disable the new tab-loading animation > > > > > > Makes sure that a lot of animation-related code is bypassed when the > > > new-tab-animation flag is off. This should hopefully fix a couple of > > > performance regressions that have not yet been root caused so that they > > > don't go out with M72. > > > > > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > > > Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1364212 > > > Reviewed-by: Sidney San Martín <sdy@chromium.org> > > > Commit-Queue: Peter Boström <pbos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#614199} > > > > TBR=pbos@chromium.org,sdy@chromium.org > > > > Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > > Reviewed-on: https://chromium-review.googlesource.com/c/1366359 > > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> > > Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614440} > > TBR=jyasskin@chromium.org,pbos@chromium.org,sdy@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > Change-Id: I3981455a00f743fae535de4626179dcceab9b2c4 > Reviewed-on: https://chromium-review.googlesource.com/c/1372236 > Reviewed-by: Peter Boström <pbos@chromium.org> > Commit-Queue: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615581} TBR=jyasskin@chromium.org,pbos@chromium.org,sdy@chromium.org Change-Id: Ib9599bb8fd44327ae756d3c9523049367409612c Bug: chromium:912543, chromium:913135, chromium:913784, chromium:912328, chromium:905745, chromium:905918, chromium:910265 Reviewed-on: https://chromium-review.googlesource.com/c/1373832 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
-
Ben Kelly authored
The CacheStorageContext::cache_manager() value can be nullptr if the BrowserContext and its StoragePartition is in the process of shutting down. Bug: 914052 Change-Id: I10735b1c6e4ad2bc7700c6508dd8d24e81f8b666 Reviewed-on: https://chromium-review.googlesource.com/c/1372554Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#615877}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/beee6ad0f2af..e1b7b8ca415e Created with: gclient setdep -r src-internal@e1b7b8ca415e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I429b76f3d3198c0b93fc6958e52886c84da68e68 Reviewed-on: https://chromium-review.googlesource.com/c/1374009Reviewed-by:
-
Arthur Sonzogni authored
Add instrumentation to help debugging bug 904248. Bug: 904248 Change-Id: Ic2e7401065a77d8f2e0b540fd7add4a1a210b2f1 Reviewed-on: https://chromium-review.googlesource.com/c/1371872Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615875}
-
Roger McFarlane authored
The server generated profile validity priority pref is encoded as a base64 encoded serialized proto within a pref string value. Misc: - Fixes the name of a member variable (was missing trailing _) - Move impl of a method whose address is taken from .h to .cc Bug: 913685 Change-Id: I6ddf194a54d536289b1fcb5a95067d24cb642f4c Reviewed-on: https://chromium-review.googlesource.com/c/1371006 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
-
tzik authored
CreateVideoCaptureDeviceFactory requires the task runner for UI thread, but the task runner passed by DeviceFactoryProviderImpl to CVCDF is not. That causes DCHECK failure around AddObserverOnDisplayThread on ScreenObserverDelegate. Bug: 909975 Change-Id: I778647b87c619002c64fa871252e88ac184ea5cf Reviewed-on: https://chromium-review.googlesource.com/c/1367388Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
-
Friedrich Horschig [CET] authored
This reverts commit 28e9c18c. Reason for revert: Broke numerous browser_tests and viz_browser_tests on Linux ChromiumOS MSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10120 Relevant log snippet: ==23389==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55d8b905b0bd in views::PlaybackImageButton::UpdateImageAndTooltipText() ./../../chrome/browser/ui/views/overlay/playback_image_button.cc:65:3 #1 0x55d8b905ac31 in views::PlaybackImageButton::SetButtonSize(gfx::Size const&) ./../../chrome/browser/ui/views/overlay/playback_image_button.cc:52:3 ==> 37 broken *PictureInPictureWindowControllerBrowserTest* Original change's description: > Add replay button to Picture-in-Picture window when video ends > > This CL makes sure there's a new replay button visible in the PiP window > when video ends. This icon comes from Material Icons library at > https://material.io/tools/icons/?icon=replay. > > https://i.imgur.com/I1n90tM.png > > Bug: 911620 > > Change-Id: Ibfcb96b9c69228ad74afe96ec00eb0e28d335ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/1360852 > Commit-Queue: François Beaufort <beaufort.francois@gmail.com> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615846} TBR=beaufort.francois@gmail.com,estade@chromium.org,mlamouri@chromium.org Change-Id: I655a32a2e5033500392cd44c921442f066297190 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911620 Reviewed-on: https://chromium-review.googlesource.com/c/1373758Reviewed-by:
-
Francois Doray authored
The failure reason is missing from logs received as part of user feedback reports. Change-Id: I8b0d7e06f7ab78595f30fb2eb6b949a3eaead705 Reviewed-on: https://chromium-review.googlesource.com/c/1371933Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#615871}
-
Noel Gordon authored
Foreground import_controller_unittest needs a mock MediaScanner. Allow background {MockMediaScanner} to be used by foreground tests. No change in test behavior. Tbr: slangley@ Bug: 914197 Change-Id: I146bff5e4ef5f12df5a060b3efedb1c2e1ea378e Reviewed-on: https://chromium-review.googlesource.com/c/1373589Reviewed-by:Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615870}
-
Peter Beverloo authored
Also change the variable's name from camelCase to hacker_style. Change-Id: Ib8ef997fa0193b00874d880053a495d649a08175 Reviewed-on: https://chromium-review.googlesource.com/c/1371806 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4998533202d9..c00efea4fee9 git log 4998533202d9..c00efea4fee9 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 hjd@google.com Merge "traced_processor: Convert CoerceTo* functions to use base::Optional" Created with: gclient setdep -r src/third_party/perfetto@c00efea4fee9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If14758940a4077cd205ed067f71331d4b0469c36 Reviewed-on: https://chromium-review.googlesource.com/c/1373890Reviewed-by:
-
Friedrich Horschig [CET] authored
This reverts commit 229cb506. Reason for revert: Builder Deterministic Linux (dbg) failed several fuzz tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20%28dbg%29/3801 From Log: Unexpected files with diffs: libboringssl_fuzzer.so libboringssl_fuzzer_no_fuzzer_mode.so merkle_integrity_source_stream_fuzzer renderer_fuzzer renderer_proto_tree_fuzzer renderer_tree_fuzzer Original change's description: > [code coverage] Add all fuzzer targets > > R=jbudorick,stgao,liaoyuke > > Change-Id: I78ffec6525cd1d808a4b431ae1e2729b76357d46 > Reviewed-on: https://chromium-review.googlesource.com/c/1372917 > Commit-Queue: Shuotao Gao <stgao@chromium.org> > Reviewed-by: Shuotao Gao <stgao@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615834} TBR=stgao@chromium.org,robertocn@chromium.org,liaoyuke@chromium.org,jbudorick@chromium.org Change-Id: Id148793c58c415ceec56a532257f1beebfdee041 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1373835Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a193dc7e2b4..dd3ad7fe5db7 git log 8a193dc7e2b4..dd3ad7fe5db7 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a48f26fb7a4d..88faa6967431 (1 commits) Created with: gclient setdep -r src/third_party/skia@dd3ad7fe5db7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Iac9ace9f9a41cf9b0e28a90ca61d0ce6accd357b Reviewed-on: https://chromium-review.googlesource.com/c/1373889Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff9b06b60550..beee6ad0f2af Created with: gclient setdep -r src-internal@beee6ad0f2af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2ded4a8b88a61743e511899b17186c62e32a5ff7 Reviewed-on: https://chromium-review.googlesource.com/c/1373439Reviewed-by:
-
Henrik Grunell authored
Bug: 826664, 830624 Change-Id: I55a214693cd2af11467a198ee85b926f822225f9 Reviewed-on: https://chromium-review.googlesource.com/c/1371429Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#615864}
-
Matthew Cary authored
Extends the dexlayout build path with profile obfuscation. This hooks build/android/gyp/dex.py into the recent convert_dex_profile.py, and makes the necessary changes to GN to pass the proguard mapping to the dex pass. Bug: 875276 Change-Id: Id595b17fdba69c7e2e2dcd252c467954a558c56f Reviewed-on: https://chromium-review.googlesource.com/c/1366315 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615863}
-
Christopher Cameron authored
The previous name was no longer reflective of the behavior. Updated comments as well. TBR=dominickn Change-Id: Id8791c8e4272e51f86ac84c93f94ed06a49f2de7 Reviewed-on: https://chromium-review.googlesource.com/c/1373733Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615862}
-
Yi Su authored
This CL migrates the SavePasswordsCollectionViewController from CollectionViewController, which is based on MDCCollectionViewController, to ChromeTableViewController, which is based on UITableViewController. old version UI: https://drive.google.com/open?id=1wep_qWxpoFYed6K3k2y2uwN6nJZut5f3 https://drive.google.com/open?id=1n_Vzc5AjlnrmAL5BmaGEuY18kG_3DKL4 https://drive.google.com/open?id=1G3ceF52yDQcg2WDvthP7dIPCy-BND_w1 new version UI: https://drive.google.com/open?id=1HC33oWDWtgd0V1daf7OYceUo7zj5dB8t https://drive.google.com/open?id=1P7wi_a47hpWzzB30nzIV9JIu1puwGL8r https://drive.google.com/open?id=1E1EYLq56jsy9QjSkzqcPTUCdV0XBkeS1 Bug: 894791,751311 Change-Id: I7ae4b244a9eb18d0c4af556ae2ed39da4fec0451 Reviewed-on: https://chromium-review.googlesource.com/c/1361241Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615861}
-
Yuki Shiino authored
Run script in content attributes that are injected by Chrome extensions (content scripts) in the main world in order to keep backward compatibility. Change-Id: Ie50d62e4a19c050dd2187638b383680bde492e2a Bug: 912069 Reviewed-on: https://chromium-review.googlesource.com/c/1373283 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615860}
-
Hajime Hoshi authored
Use per-frame task runners instead of per-thread task runners for bfcache. This is based on Alexander's CL https://chromium-review.googlesource.com/c/chromium/src/+/1367325 Bug: 913912 Change-Id: If41723bc50fb402414e8108a4f99755c982e33af Reviewed-on: https://chromium-review.googlesource.com/c/1369748 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The API was rewritten in https://crrev.com/c/1363140. This CL changes chromium code to use the new API. R=mlippautz@chromium.org Bug: chromium:912031 Change-Id: I10493dd711b565217fcdb437bb70fa380b4cfa84 Reviewed-on: https://chromium-review.googlesource.com/c/1373749Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615858}
-
François Beaufort authored
Change-Id: I887f62915f3220652cfe9a440d1d2133f61b7bf8 Reviewed-on: https://chromium-review.googlesource.com/c/1360651Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#615857}
-
Daniel Bratell authored
Compiling app_icon_factory code triggered compilation errors in some Windows and Mac builds since the code references app_list which only exists in ChromeOS. In most builds it was ok because the generated object file was unused and got stripped by the linker before the dangling references was found. BUG=826982 TBR=nigeltao@chromium.org,rdevlin.cronin@chromium.org,dominickn@chromium.org Change-Id: I25f0fa090f3466bcc83e06a070c7aa6c8600976d Reviewed-on: https://chromium-review.googlesource.com/c/1373450Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#615856}
-
