- 01 Jan, 2019 20 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2ebf2eb6d72..8fc56b86c1e5 Created with: gclient setdep -r src-internal@8fc56b86c1e5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I070b00f952050f96d06ad8d13bc30c3be30a66a4 Reviewed-on: https://chromium-review.googlesource.com/c/1392991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619341}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8d6203a906fe..4978088dea32 git log 8d6203a906fe..4978088dea32 --date=short --no-merges --format='%ad %ae %s' 2019-01-01 nednguyen@google.com run_tests: Remove stale test file references Created with: gclient setdep -r src/third_party/chromite@4978088dea32 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iefaa017ae7f4d8aea2ad46cdcfeb46254f34610f Reviewed-on: https://chromium-review.googlesource.com/c/1392992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619340}
-
Noel Gordon authored
V8 started throwing an assignment to const error for the variable name |month| in this test, causing this test to fail on multiple bots. Make the const a let. No-Presubmit: true No-Tree-Checks: true No-Try: true Tbr: engedy@ Bug: 918417 Change-Id: I0239d3d142828c39b2ecc7806c8488d2e802b79e Reviewed-on: https://chromium-review.googlesource.com/c/1392695Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#619339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f42e2467cd9..4f050fb81955 git log 8f42e2467cd9..4f050fb81955 --date=short --no-merges --format='%ad %ae %s' 2019-01-01 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@4f050fb81955 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ifd6fa5b7de735297928195fe54c1c7a967942b7d Reviewed-on: https://chromium-review.googlesource.com/c/1392987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619338}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I8ae155f083cdba40ae51037ce0ce993029df8e05 Reviewed-on: https://chromium-review.googlesource.com/c/1392990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619337}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7d78ebacfda..a2ebf2eb6d72 Created with: gclient setdep -r src-internal@a2ebf2eb6d72 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3f8a440cf079a02fae79105e3f6846b10b36cd10 Reviewed-on: https://chromium-review.googlesource.com/c/1392989Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6992e2c4287..a7d78ebacfda Created with: gclient setdep -r src-internal@a7d78ebacfda The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I291761f80c3a6aed09d9c173640645aabc91f60b Reviewed-on: https://chromium-review.googlesource.com/c/1392988Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619335}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5a74c434..2da0629a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia296e1d4fe0d49b454d77138bd40b541333dc635 Reviewed-on: https://chromium-review.googlesource.com/c/1392441Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619334}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43fadbd1c818..f6992e2c4287 Created with: gclient setdep -r src-internal@f6992e2c4287 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iac2d618b688439a261ef59fd1aac9dcaa530e744 Reviewed-on: https://chromium-review.googlesource.com/c/1392986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619333}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/353f1ba62657..43fadbd1c818 Created with: gclient setdep -r src-internal@43fadbd1c818 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic082c0f56af9c5d78cda985695f1056dc06bad5e Reviewed-on: https://chromium-review.googlesource.com/c/1392985Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619332}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bc33b963844..8f42e2467cd9 git log 9bc33b963844..8f42e2467cd9 --date=short --no-merges --format='%ad %ae %s' 2019-01-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 60a50cfcb876..cc37cbf20179 (1 commits) Created with: gclient setdep -r src/third_party/skia@8f42e2467cd9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: If3ae4b524bd18dba9bf49945d8c3dca3c1412a98 Reviewed-on: https://chromium-review.googlesource.com/c/1392984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619331}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I15c2784e300c8ddf70a3a5a6b8cefb3e8a51d8d6 Reviewed-on: https://chromium-review.googlesource.com/c/1393004Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#619330}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46742c5a4aea..353f1ba62657 Created with: gclient setdep -r src-internal@353f1ba62657 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I12854aac31fdd23818611485bc0efd8a1eaceabf Reviewed-on: https://chromium-review.googlesource.com/c/1392901Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619329}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I07466c9573616d2ae7c55fdc45864e3c2697930a Reviewed-on: https://chromium-review.googlesource.com/c/1392983Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619328}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/60a50cfcb876..cc37cbf20179 git log 60a50cfcb876..cc37cbf20179 --date=short --no-merges --format='%ad %ae %s' 2019-01-01 matavenrath@nvidia.com Apply several small micro-optimizations to ValidateDrawElementsCommon Created with: gclient setdep -r src/third_party/angle@cc37cbf20179 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I64dbff7beebc9321925365e95f430c2900ca55eb Reviewed-on: https://chromium-review.googlesource.com/c/1392902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619327}
-
Xianzhu Wang authored
This reverts commit 29021ede. Reason for revert: Suspect performance regression Bug: 918276 Original change's description: > [CompositeAfterPaint] Invalidate chrome client when needed > > For pre-CompositeAfterPaint, we call InvalidateChromeClient() > when an object is invalidated in a view referenced from a plugin or > an svg-image. > > Now let the path also work for CompositeAfterPaint. > > This fixes several web plugin tests for CompositeAfterPaint. > > Bug: 524134 > Change-Id: Ia4c3ccba4632ddcdfdfdfec299fb7a68440a1419 > Reviewed-on: https://chromium-review.googlesource.com/c/1385112 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618316} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 524134 Change-Id: I9b4f67a74732919ba23acc00fd501d45baa498e6 Reviewed-on: https://chromium-review.googlesource.com/c/1392439Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619326}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61b3d1d00057..9bc33b963844 git log 61b3d1d00057..9bc33b963844 --date=short --no-merges --format='%ad %ae %s' 2018-12-31 Tom.Tan@microsoft.com Fix header file for _byteswap_ulong from MSVC CRT Created with: gclient setdep -r src/third_party/skia@9bc33b963844 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:893460 TBR=bungeman@chromium.org Change-Id: Ibb9f050d8ff1956fc9e54ec1b37e1476be4342d3 Reviewed-on: https://chromium-review.googlesource.com/c/1392898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619325}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1716f486f900..8d6203a906fe git log 1716f486f900..8d6203a906fe --date=short --no-merges --format='%ad %ae %s' 2019-01-01 manojgupta@google.com cros_chrome_sdk: Use cros readelf for target builds. Created with: gclient setdep -r src/third_party/chromite@8d6203a906fe The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I870c3a3c8d2321044596c152dc733fd2789c4d4e Reviewed-on: https://chromium-review.googlesource.com/c/1392900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619324}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e423e31785e..46742c5a4aea Created with: gclient setdep -r src-internal@46742c5a4aea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I75a21b627f4dfbae82889b10eec98c206d9fd06f Reviewed-on: https://chromium-review.googlesource.com/c/1392899Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619323}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63384d3469e6..5e423e31785e Created with: gclient setdep -r src-internal@5e423e31785e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I584b7db4ef6f548de158349c49b6d3ecf2dd70f0 Reviewed-on: https://chromium-review.googlesource.com/c/1392897Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619322}
-
- 31 Dec, 2018 20 commits
-
-
Christopher Cameron authored
There is currently a ui::TextInputClient* stored in BridgedContentView. This is problematic because the ui::TextInputClient lives in the browser process while the BridgedContentView lives in the app process. Cut-and-paste-move textInputClient_ and pendingTextInputClient_ from BridgedContentView to TextInputHost, and make it a member of the BridgedNativeWidgetHostImpl class, using the views_bridge_mac:: BridgedNativeWidgetHostHelper structure to close the gap between the two. This leaves many direct accesses of the ui::TextInputClient from the app process, which we can now replace one-by-one with mojo calls in subsequent patches. Bug: 901490 Change-Id: Ib4497afd4dd7a4e41541eaab170157e1c7eeb90e Reviewed-on: https://chromium-review.googlesource.com/c/1391879 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619321}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c49505f1..5a74c434 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I27accea957fca27d0c09932f54e139a553116617 Reviewed-on: https://chromium-review.googlesource.com/c/1392721Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619320}
-
Joel Hockey authored
Bug: 916297 Change-Id: I9cebd2e2077b47ae2221b918a11f475b586a48b8 Reviewed-on: https://chromium-review.googlesource.com/c/1392690Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619319}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6c0102d6f76d..63384d3469e6 Created with: gclient setdep -r src-internal@63384d3469e6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic1b645e4c1f4832ef9a83d9e29c7de204da8f0c6 Reviewed-on: https://chromium-review.googlesource.com/c/1392896Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619318}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5693a2d81ef0d2f7853db8762bd54b3aa33312e0 Reviewed-on: https://chromium-review.googlesource.com/c/1392895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619317}
-
Samuel Huang authored
ClusterFuzz found a 32-bit PE file that triggers DCHECK(). The cause (in DisassemblerWin32): * ParseAndStoreRelocBlocks() reads malformed reloc region and rejects it, but writes bad result to |reloc_region_| (with kInvalidOffset). * MakeReadRelocs() passes the invalid |reloc_region_|, which causes uint32_t overflow (for 32-bit size_t), and triggering DCHECK(). * MakeWriteRelocs() was not reached, but has similar problem. Main fix: * Initialize |reloc_region_| to invalid state. * In ParseAndStoreRelocBlocks(): * On first run: Only write |reloc_region_| on success. * On later runs: Return validity of |reloc_region_|. * In MakeReadRelocs() and MakeWriteRelocs(): Already calls ParseAndStoreRelocBlocks(). Change this to return vacuous ReferenceReader / ReferenceWriter on failure, i.e., if |reloc_region_| is invalid. * Need to add EmptyReferenceWriter for this. DisassemblerWin32 is also too lax in dealing with malformed input, so this CL also implments more stringent checks: * Disallow ImageSectionHeader (+ ImageOptionalHeader) from overlapping with ImageDOSHeader. * Apply more stringent checks for |size_of_optional_header| and |number_of_rva_and_sizes|: Consistency and bounds. Bug: 917042 Change-Id: I661303d49a57025a877585eb175f369d067652a4 Reviewed-on: https://chromium-review.googlesource.com/c/1390766Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#619316}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/95bdf5f39ec6..c98c8a0a9d19 git log 95bdf5f39ec6..c98c8a0a9d19 --date=short --no-merges --format='%ad %ae %s' 2018-12-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 27eb7bb4..c5391e48 (619209:619309) Created with: gclient setdep -r src/third_party/webrtc@c98c8a0a9d19 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9b137a964b700b643e3782e3a3b1c9f3c974d52b Reviewed-on: https://chromium-review.googlesource.com/c/1392890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619315}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef22344d5e92..6c0102d6f76d Created with: gclient setdep -r src-internal@6c0102d6f76d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If72ad26155ec2bc1a97e772f8c0829e70d37bda5 Reviewed-on: https://chromium-review.googlesource.com/c/1392891Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619314}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8894a8cc4e7..ef22344d5e92 Created with: gclient setdep -r src-internal@ef22344d5e92 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I404ba149efd3561d7f7f6545b6e54af57ca3e352 Reviewed-on: https://chromium-review.googlesource.com/c/1392889Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619313}
-
Aleks Totic authored
The old code made an incorrect assumption that if Legacy's IntrinsicSizingInfo did not compute width/height, the fallback should be LayoutBox::IntrinsicSize. I thought I was being clever, and was trying to keep sizing computation logic out of LayoutBox. Unfortunately, not enough information is exposed by LayoutBox to compute ReplacedSize from raw IntrinsicSize, and IntrinsicSizingInfo must be used. The correct fix is to use ConstraintSpace::AvailableSize if IntrinsicSizingInfo is unavailable. Bug: 916387 Change-Id: Ib58bbd4775aa9fe1129bc5613d1652123b12670e Reviewed-on: https://chromium-review.googlesource.com/c/1392367 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619312}
-
Balazs Engedy authored
Bug: 918124 Change-Id: I2b4c03454cacd17bb85f52819789fde6e5eb689e TBR: mastiz@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1392946 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619311}
-
Balazs Engedy authored
Bug: 891427 Change-Id: I0a3e53ee9e3b6dbe5989adf4286ce2cbfef3ef59 TBR: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1392945 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619310}
-
Balazs Engedy authored
This reverts commit 11078061. Reason for revert: Broke ios-slimnav ios_chrome_integration_egtests. Original change's description: > [iOS] Convert ContextMenu Franky tests to EG > > This CL adds two EarlGrey test to replace Franky tests. > > Bug: 910345 > Change-Id: I11ec95f0292839c150f79dd7ffd69a50b05fb9cd > Reviewed-on: https://chromium-review.googlesource.com/c/1392091 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eric Noyau <noyau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619159} TBR=noyau@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910345 Change-Id: Ic80974585f453575309e4a6d1fc5d1abc45c070e Reviewed-on: https://chromium-review.googlesource.com/c/1392944Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619309}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb9739d1965b..a8894a8cc4e7 Created with: gclient setdep -r src-internal@a8894a8cc4e7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8b8b9c1e5e3d455d0407f1e8fb14181dc7d425c7 Reviewed-on: https://chromium-review.googlesource.com/c/1392888Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619308}
-
gambard authored
This CL fixes some crashes in the Collection Cell Catalog. Bug: 894791 Change-Id: I2ae86bfbbd46cde6dbee1a28808c7d611b802961 Reviewed-on: https://chromium-review.googlesource.com/c/1392095Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619307}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61218df62bb7..bb9739d1965b Created with: gclient setdep -r src-internal@bb9739d1965b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I612a23c480c41ab1761205efa41167a896f91f31 Reviewed-on: https://chromium-review.googlesource.com/c/1392887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619306}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/881309cf58af..61218df62bb7 Created with: gclient setdep -r src-internal@61218df62bb7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie24f3b810779d5e70d530f11712c2e375eda52b8 Reviewed-on: https://chromium-review.googlesource.com/c/1392886Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619305}
-
Morten Stenshorne authored
This is an outline paint order issue. TBR=chrishtr@chromium.org Bug: 915204 Change-Id: I604b741d18b8c4806ac4020d97ce2b2478ef10e2 Reviewed-on: https://chromium-review.googlesource.com/c/1392184Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619304}
-
Avi Drissman authored
BUG=837308 Change-Id: I6aafd4b6e2fcc2dc5e021a6322c2e9ce1e23284c Reviewed-on: https://chromium-review.googlesource.com/c/1391957Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#619303}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef399182b51e..881309cf58af Created with: gclient setdep -r src-internal@881309cf58af The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I09b2c8f282654e5c2011048879bcfb59c72cde21 Reviewed-on: https://chromium-review.googlesource.com/c/1392885Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619302}
-