- 09 Apr, 2019 40 commits
-
-
Sammie Quon authored
Test: added test Bug: 950100 Change-Id: Ia05e481a15ac3c42bdfef075b5f1b930f37f3605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559253Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#649265}
-
Corentin Wallez authored
Mac is the first platform where WebGPU is implemented. Enabling use_dawn there makes sure that dawn-related tests are run on the CQ, and allows developers to use Mac Canary to test WebGPU. BUG=chromium:852089 Change-Id: Ic076afbe4d6d9efe97bee7bb56f0d375a35bec5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559319Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649264}
-
Paul Miller authored
WebView times out while waiting for the seed too frequently, and the current metrics don't explain why. We record Variations.SeedLoadResult and Variations.SeedLoadBlockingTime, but these are rather coarse measurements. Add Variations.SeedLoadSuccessTime, specifically for loading the seed file, and Variations.SeedLoadWouldBlockTime, to measure how long loading would take if not for the timeout. The latter should show how much we'd have to increase the timeout in order to improve the success rate. BUG=936172 Change-Id: Ia3fcd7bfdf394a4e6e4bdd85a2c6682425552194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552487Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#649263}
-
Josh Horwich authored
Current ARC Bluetooth bridge assumes that setting of discoverable timeout implies the adapter should go into discoverable mode. This change tracks the discoverable timeout separately from the actual transition to discoverable mode, and only puts the adapter into discoverable mode when the scan mode is set to discoverable. Bug: 945076 Test: OOBE flow on kevin Change-Id: I5b154af261563bb4d241327c81bb9a819259dcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559992Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#649262}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3ed8ba0c5a4b..3d497385cd77 git log 3ed8ba0c5a4b..3d497385cd77 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bclayton@google.com src/Pipeline: Add SIMD::Pointer 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitFieldInsert 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitFieldSExtract and OpBitFieldUExtract 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitReverse 2019-04-09 bclayton@google.com SpirvShader: Implement OpBitCount 2019-04-09 bclayton@google.com SpirvShader: Implement OpTranspose 2019-04-09 bclayton@google.com SpirvShader: Implement OpOuterProduct 2019-04-09 bclayton@google.com SpirvShader: Add type field to GenericValue Created with: gclient setdep -r src/third_party/swiftshader@3d497385cd77 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455,chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Icef00374eae583f1b0fa34ec982d0d844b1595ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560174Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649261}
-
Takuto Ikuta authored
This is preparation CL to enable some tests on win10_chromium_x64_rel_ng builder. I don't have mini_installer_tests due to some cases fail. Bug: 950584 Cq-Include-Trybots: luci.chromium.try:win10_chromium_x64_dbg_ng Change-Id: Ic4dcf82a80b6a8a5309a6f8365ebadfd53a6627e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559090 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649260}
-
May Lippert authored
Build this by setting optimize_webui = false (default is true) What's in this change: - Move os_settings.html to c/b/r/settings/chromeos - Add new os_settings_resources.grd What's still WIP: - Optimized webui build BUG=950007 Change-Id: I752153668877a25a29b315cb82456ed564fd52df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553820Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#649259}
-
Tony de Luna authored
This is a reland of 426df2be Original change's description: > Increase coverage for EULA browser tests > > Adds tests for: > * Clicking on "System security settings" button in EULA screen > * Accepting and rejecting usage stats collection > * Clicking on "Learn more" button in EULA screen > > Removes dead code from EulaScreen class. > > Adds a HelpApp extension manifest to use in tests and modifies > HelpAppLauncher class to allow tests to set the extension id. > > Adds a HelpAppTestHelper class to facilitate writing tests that > open HelpApp dialogs. > > Change-Id: Id7841be5bf3faabb067d3a75d3b034bdf0e00e32 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554123 > Commit-Queue: Tony De Luna <tonydeluna@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648759} TBR=hashimoto Bug: 947358 Change-Id: I23865c1957f300f55812f3275e830772aa27c32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560146Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#649258}
-
Devlin Cronin authored
The `tabs` custom bindings have been entirely replaced by native counterparts. Remove the JS version. Bug: 938998 Change-Id: I7a55e00fb2bf008bcecae6c3b00179040f6aba8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559255Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649257}
-
Mike Wasserman authored
Destroy old embeddings as needed when a new one is requested. Bug: 944699 Test: No flaky window service DCHECKs running files app browser tests. Change-Id: I77d681b222a3e6608354f72dfe2663d7574e2c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559336 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649256}
-
John Budorick authored
This script is currently only invoked for cronet, but when we switch the perf bots to invoking it for chrome & webview, we can create separate chrome_sizes and webview_sizes scripts to similarly handle the compile targets. Bug: 861983 Change-Id: I98a77cedc40b356be0a07268fcb511e657c73ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560141Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#649255}
-
Mike Reed authored
Bug: skia:8937 Change-Id: I59be04380805a78b7a9e24721e4f4349797735f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558685 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#649254}
-
Sigurdur Asgeirsson authored
This simplifies the property setter interfaces and allows using the process without race on the PM sequence (on Windows). Bug: 910288 Change-Id: I15a5e25a8ee3ab5f08464c819475a298491da11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558573 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#649253}
-
Mehran Mahmoudi authored
This adds a new Apphooks method that instantiates TouchlessMenuCoordinator. Link to the internal CL in the bug. Bug: 930744 Change-Id: I5f7bf87b50633b793980e6dd945952f8b096910b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559018Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649252}
-
Takumi Fujimoto authored
When mirroring a tab using the Mirroring Service, show an indicator icon on the tabstrip. Bug: 889942 Change-Id: I3e95484e01d84ac94d3afd400703ccc19119bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550637Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#649251}
-
Daniel Cheng authored
base::Optional::value() already does this; change operator* and operator-> to match, and ensure the behavior is tested. Change-Id: Id686b86d0e68360dea3a92d01206aefde6782a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531498 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#649250}
-
Meilin Wang authored
This change adds a new chromeos switch "redirect-libassistant-logging" to control redirect libassistant logging from /home/chronos/user/log to /var/log/chrome. One scenario to use this switch is in the Tast integration tests, where we want to export libassistant.log into the test result package to help debugging test failure. The previous logging directory /home/chronos/user is an encrypted user home directory, so we need to move the log to /var/log/chrome where Tast collects newly-written data after running all tests. Bug: 950197. Test: local compile and manually test. Change-Id: I4f5124d53d1c55f03738b9823c82dc83c3e3580f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560145 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649249}
-
dpapad authored
This is part of the effort to remove unnecessary "md_" prefixes from various parts of the WebUI codebase. Bug: 887150 Change-Id: I5769e7064e8acd359a3293a42a3bded90072d0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559460 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#649248}
-
Josh Nohle authored
This CryptAuth backend CL converted the long_device_id field of the ClientAppMetadata proto from type "bytes" to type "string": https://critique.corp.google.com/#review/242222308. Because Chrome OS has already been setting this field with a string, this change should have no effect. Note: This change is only necessary for v2 Enrollment; v1 code should remain the same. Bug: 899080 Change-Id: Icf4bd1c93b0c6aaad4a5245de8c882baa7b31f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559757Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#649247}
-
Jun Mukai authored
This SchedulePaint causes to request repaints of the entire browser frame when overview-mode / splitview-mode changes. This can cause significant load on GPU, especially when there are many browser windows, and actually this is unnecessary because View::SetVisible change invalidates the painting of its bounds. I tried on nocturne with 15 browser windows; the toggle overview by key changes the Overview.AnimationSmoothness histogram as; - Enter: 18.9 -> 86.9 - Exit: 7.2 -> 61.3 Bug: 949227 Test: manually Change-Id: I9a71776a66d4b609027d18c17f6796114fdb3f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560019Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#649246}
-
David Tseng authored
Fixed issue by only using the AXTree::GetPosInSet/AXTree::GetSetSize heuristics if they provide a nonzero answer. Otherwise, fall back to raw attributes. This also exposes pos in set/set size if they are set without doing a role check as some renderers like ARC++ have no such restrictions. TBR=dmazzoni@chromium.org Original change description: This moves ChromeVox to use AXNode::GetSetSize and AXNode::GetPosInSet through their automation bindings. One issue is fixed: In AXTree:PopulateOrderedSetItems, an assumption is made that the first child node of the ordered set node, should determine the hierarchical level of the current layer of items. Unfortunately, for trees like: tree static text tree item ... this hueristic fails. See output_test.extjs::NestedLists. Test: browser_tests --gtest_filter=ChromeVoxOutput*.* Change-Id: I54911673215e245808a88fab07275a83c2d7109d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536470Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#645669} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560015 Cr-Commit-Position: refs/heads/master@{#649245}
-
Mei Liang authored
This CL adds the following user actions for TabGroups UI: * GridTabSwitcher.UndoCloseTab * GridTabSwitcher.UndoCloseTabGroup * TabGridSheet.UndoCloseTab * TabStrip.UndoCloseTab Bug: 950190 Change-Id: Ic456b9f118e185f62c3866492e77ade27b51f7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553090 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#649244}
-
Amit Hilbuch authored
WPT tests will now fail with different error message (due to RTCError not being translated correctly). Tests are disabled temporarily until WebRTC change is merged. Bug: webrtc:10491 Change-Id: I89525bbe51a6606e71affa0e035b9e12f828b02c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560330Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649243}
-
Tanya Gupta authored
Bug: 941124 Change-Id: I0955071e3aefccbe947752bd9ceea4fb8edfe088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559397 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649242}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80658204f417..d54b1fcdd915 git log 80658204f417..d54b1fcdd915 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 nifong@google.com full collection of externs 2019-04-09 herb@google.com Reland "Handle translating blob to origin in bulk" 2019-04-09 halcanary@google.com SkPDF: move annotations away from device. 2019-04-09 mtklein@google.com some refactoring ideas 2019-04-09 ethannicholas@google.com SkSL 'key' variables can now be controlled by 'when' expressions Created with: gclient setdep -r src/third_party/skia@d54b1fcdd915 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4cf00e7fb7a99cec5e74606bcdb4f625c4e87d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649241}
-
Caroline Rising authored
Prior behavior was for bubbles to stay within the screen bounds. With this change the bubble will also attempt to stay within the parent window bounds (if one exist) while always staying within the screen bounds. Also add ability for any bubble to offset if out of given bounds instead of mirror. This behavior is used for tab hover cards. Bug: 910739 Change-Id: Ib1137646e818b09fe5192896414be9686d1e01fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552284Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#649240}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cce609cb3785..572984e9ca2b Created with: gclient setdep -r src-internal@572984e9ca2b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:949743,chromium:946405 TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Ife907dace76f72caafa13309fc4a8b1340a5261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649239}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc15ae5571b3..3702d8c9d300 git log fc15ae5571b3..3702d8c9d300 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 geofflang@chromium.org Propogate dirty bit signals from TextureImpl to Texture up to Context. 2019-04-09 timvp@google.com Re-Enable MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN Created with: gclient setdep -r src/third_party/angle@3702d8c9d300 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949985 TBR=ynovikov@chromium.org Change-Id: I85b61516d4fd1c118469780b5650f2107ff6050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560212Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649238}
-
Raul Tambre authored
Ran "2to3 -w -n -f print ./base" and manually added imports. There are no intended behaviour changes. Bug: 941669 Change-Id: If5eb9217385a6d9a7807a4ca03116e1db9999695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559958 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#649237}
-
khmel@chromium.org authored
In case arc-disable-locale-sync is used this limits ARC container to start with 'en-US' as a locale and 'en-US,en' as preferred languages. This stabilizes tests that expects UI resources be fixed in English. There is an alternative solution that could be implemented when needed to pass required combination as a switch. However this is not required at this time once we don't have such auto-tests. TEST=Set locale for local test account to 'ru' and confirmed that cheets_AppCompatTest.clamshell.com.google.android.apps.books is failing similar as described in bug. Apply this patch and test passes. BUG=b:130142125 Change-Id: I2219207d2d75c00c6ee04590e430a929389c7319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559463Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#649236}
-
Devlin Cronin authored
Add an install warning for extensions added with a higher manifest version than is fully supported. We use a warning (rather than an error) so the extension still loads, and runs as best it can. Bug: 950647 Change-Id: I32ae2b21bb8cc83e2ec0effaab6d58324a93a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559021Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649235}
-
Dominik Laskowski authored
DisplayConfigurator serializes asynchronous content protection requests by storing pending query/apply tasks as closures in a queue. It also maintains queues for the query/apply callbacks supplied by the client. This CL consolidates the queues by relating QueryContentProtectionTask and ApplyContentProtectionTask by a common base class. It also replaces the Boolean for task success/failure with tri-state, whose extra bit is used to distinguish killed tasks during DisplayConfigurator destruction and (in a future CL) display reconfiguration. Bug: 929449 Test: display_unittests Change-Id: I3640b657ed5952c40e0999836ae92287984a3e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495201Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#649234}
-
Mehran Mahmoudi authored
This fixes an issue which prevented the progress bar to be dismissed. Bug: 950988 Change-Id: I790b0eb4a3ef02b2d166edbc6e636c2803067e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560018 Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649233}
-
Greg Thompson authored
We find that C:\Windows\System32\OpenWith.exe sometimes has focus and prevents tests from running to completion. This change logs the command line of the process and of its ancestors. With luck, this will shed a little more light on why this window appears. BUG=711256 Change-Id: I0553665f5f36e1e2be5be268479d5095a5771b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559073 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#649232}
-
Chris Lu authored
Add integration test coverage for calling FindInPageNext and FindInPagePrevious actions. Bug: 919685 Change-Id: If8894564135dacf61c4bd3510504013d4ef74ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551498 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#649231}
-
Sam Maier authored
We had upstreamed min-sdk so that R8 could use it, but Proguard was forgotten. This adds min-sdk support for Proguard. Bug: 950918 Change-Id: I46aeb63ed89abcb2e384f874d3dbc1d43093884d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559579 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#649230}
-
Luke Halliwell authored
libinteraction is used in certain internal builds. Bug: b/110808839 Change-Id: I51c29bd0033d608413e97029f288de44b89fc441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560138Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649229}
-
Felix Ekblom authored
This informs the user that enrollment is on-going. The 'alert' role is probably not perfect for this use case but it's the best I could find, and it's used in nearby code for similar scenarios. Testing by running through the remora enrollment flow and observing that "Enrolling device..." is read out. BUG=b:80126209 Change-Id: Iee7388dae29458412cb44f9d3578cfeee2d234cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559182 Auto-Submit: Felix Ekblom <felixe@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649228}
-
Elly Fong-Jones authored
Bug: None Change-Id: Id7d285352115e0aa97288a391b28782271a7bbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559700 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#649227}
-
Sidney San Martín authored
Followup from https://crrev.com/c/1427799. Bug: 868398 Change-Id: Id0c1f9ee80b90b9c3db0847b7df9de8e7aa8e888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560149 Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649226}
-