- 22 Oct, 2018 31 commits
-
-
Heng-Ruey Hsu authored
Since blob stream needs higher resolution, it causes higher cpu loading to require higher resolution and resize to smaller resolution. In hangout app, we don't need blob stream. Enabling blob stream when needed can save a lot of cpu usage. BUG=b:114676133 TEST=manually test in apprtc and CCA. make sure picture taking still works in CCA. Change-Id: I9144461bc76627903d0b3b359ce9cf962ff3628c Reviewed-on: https://chromium-review.googlesource.com/c/1261242 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601492}
-
Fergal Daly authored
Revert "media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame" This reverts commit 04f8f2c0. Reason for revert: breaks windowd compile Original change's description: > media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame > > When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't > realize the code assumed the I420 when creating frame. Therefore, it passes > invalid pointer and wrong stride when the number of planes are less than 3. > This change fixes it by creating video frame, taking into account the number of > planes of input buffer format. > > BUG=chromium:894381 > TEST=VEA unittest for NV12 and I420 on kevin > > Change-Id: I31e157ce9317139e7cc42a38ba77b34c13d70d70 > Reviewed-on: https://chromium-review.googlesource.com/c/1293095 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601489} TBR=hiroh@chromium.org,acourbot@chromium.org Change-Id: I02e53782dd3240da1dfd4548daefe275854601b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:894381 Reviewed-on: https://chromium-review.googlesource.com/c/1293099Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601491}
-
Kent Tamura authored
This CL makes it blink::foo_names::kNamespaceURI. The new behavior is applied only to lower-cased blink::foo_names. Bug: 889726 Change-Id: Ib1b0e55a7e135941b87055f0fd4e75956568c59a Reviewed-on: https://chromium-review.googlesource.com/c/1293061 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#601490}
-
Hirokazu Honda authored
media/gpu/VEA unittest: Fill plane pointer and stride with NULL and 0 for 1- or 2- planes VideoFrame When I enable VEA unittest to run any yuv format in crrev.com/c/1135106, I didn't realize the code assumed the I420 when creating frame. Therefore, it passes invalid pointer and wrong stride when the number of planes are less than 3. This change fixes it by creating video frame, taking into account the number of planes of input buffer format. BUG=chromium:894381 TEST=VEA unittest for NV12 and I420 on kevin Change-Id: I31e157ce9317139e7cc42a38ba77b34c13d70d70 Reviewed-on: https://chromium-review.googlesource.com/c/1293095 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601489}
-
Dong-hee Na authored
SerializeForNumberType() should be used instead of AtomicString::Number() in Element::SetFloatingPointAttribute(). Bug: 894661 Change-Id: I6d4efd2d14fb7e01e0fb47cc703fd2d7d12cde18 Reviewed-on: https://chromium-review.googlesource.com/c/1288929 Commit-Queue: Dong-hee Na <donghee.na92@gmail.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601488}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I3857cdbdd245658470a8919255b9d757288131b1 Reviewed-on: https://chromium-review.googlesource.com/c/1293093Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia133725981e31017e062449627cd97105abca9bc Reviewed-on: https://chromium-review.googlesource.com/c/1293239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601486}
-
Stuart Langley authored
Added BUILD target for mock_actions_model.js that is testonly. Bug: 860355 Change-Id: Idb81f1e2bdcbda7ba4164b502e4b81f551f2b0bb Reviewed-on: https://chromium-review.googlesource.com/c/1292660 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601485}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I230b9f4370594029d9ae7ecf222e0b04074d7e35 Reviewed-on: https://chromium-review.googlesource.com/c/1285989Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#601484}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b1a002e850e1..80c6909bf7ee git log b1a002e850e1..80c6909bf7ee --date=short --no-merges --format='%ad %ae %s' 2018-10-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0cc11c684b54..7818a85c33d3 (1 commits) Created with: gclient setdep -r src/third_party/skia@80c6909bf7ee The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I899cb511b2056adccaea94e354a510e1339a4132 Reviewed-on: https://chromium-review.googlesource.com/c/1293236Reviewed-by:
-
Fergal Daly authored
This reverts commit 4d310087. Reason for revert: Findit identifies this CL as a source of flakiness with 100% confidence https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKpAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ0NTYxL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1UyRjJaVU5oY21SQ2RXSmliR1ZXYVdWM2MwWjFiR3hHYjNKdFFuSnZkM05sY2xSbGMzUXVVM1J5YVd0bFJHRjBZV0poYzJWZlZYQnNiMkZrWDBaMWJHeEdiRzkzVkdWemRBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Original change's description: > [Autofill] Add strikes when CC save ignored/denied/fails > > This is a retry/relanding of > https://chromium-review.googlesource.com/c/chromium/src/+/1269524. > We're having a *very* hard time reproducing the flakes that the trybots > experienced, but I've made some improvements to attempt to reduce > possible race conditions in the browsertests. > > Patch set 1 is the original CL; patch set 2 contains the new changes. > > (When a card accrues 3 strikes, future offers to save for that card > should show the omnibox save icon, but NOT pop up the bubble. > On Android, no offer to save is shown at all.) > > TBR=mahmadi@chromium.org > > Bug: 884817 > Change-Id: If641cff300cab6122bfd0a52942376b8b6449fed > Reviewed-on: https://chromium-review.googlesource.com/c/1292169 > Commit-Queue: Jared Saul <jsaul@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601278} TBR=estade@chromium.org,mahmadi@chromium.org,jsaul@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884817 Change-Id: I1761991641b0b89274e2e8233c8150c8d688cb34 Reviewed-on: https://chromium-review.googlesource.com/c/1293055Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b603f6c919c..06413e47c96e Created with: gclient setdep -r src-internal@06413e47c96e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3318804fac62c926eb0f57ddde189cb6edbed296 Reviewed-on: https://chromium-review.googlesource.com/c/1293235Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601481}
-
Sunny authored
According to spec[1], when a string starts with CR/LF set as innerText, the first child node should not be an empty text node. So we adjust the logic in HTMLElement::TextToFragment to make sure it follows the spec. Besides, same in spec[1], there is no special procedure for setting innerText when the element is being rendered and styled as preserving new line, so corresponding code was removed in this commit. 15 failed wpt tests could be passed after this change. [1] https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute Bug: 573309, 705478 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6765601a14c2e95cec3841e084046da79aca065c Reviewed-on: https://chromium-review.googlesource.com/c/1266728Reviewed-by:
-
Mikel Astiz authored
This is a reland of 66a392fa Reland fixes unit tests that accidentally used DCHECKs with side effects, making tests fail in non-debug builds. Original change's description: > Add encryption support to pseudo-USS > > This patch extends SyncableServiceBasedBridge (core to pseudo-USS) > with support for encryption, via a newly introduced interface > (ModelCryptographer), which needs to be usable in the model thread > (where the bridge lives). > > This should unblock the migration of PASSWORDS to pseudo-USS, because > password data must be encrypted at all times. This is a first step of > a proposal described in a dedicated section in the Design Doc: > https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot > > Actual usage of this functionality will be introduced in follow-up > patches. > > Bug: 870624 > Change-Id: I227d429dc952bfe1a3a4fb05cd1ab71cac9ba1c6 > Reviewed-on: https://chromium-review.googlesource.com/c/1288594 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601254} TBR=treib@chromium.org Bug: 870624 Change-Id: Ie576b1aebf6bb989bba95d808031ab8433ec8b6a Reviewed-on: https://chromium-review.googlesource.com/c/1292556 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601479}
-
Antonio Gomes authored
This is a reland of c7e36b09 The difference between this CL and its original version (https://crrev.com/c/c1289849) is that dependencies are made more explicit in chrome/test/chromedriver/BUILD.gn. TBR=mmenke@chromium.org,johnchen@chromium.org (John +1'ed the original incarnation of this CL at [1]). Original change's description: > Migrate chrome/test/chromedriver/net/net_util.cc using SimpleURLLoader > > URLFetcher will stop working with advent of Network Service, and > SimpleURLLoader is the replacement API for most clients. > This CL migrates chromedriver and its respective unittests away from > URLFetcher. > > Note that because of the multithreaded nature of the code, the natural > approach was to simply call SharedURLLoaderFactory::Clone and pass > the "info" mojo handle accross threads, until the operational thread. > However, the structure holding this mojo handle is called/passed from > > (i) an indirect chain of BindRepeating calls, > (ii) various threads. > > Given that network::mojom::URLLoaderFactoryPtrInfo and > network::SharedURLLoaderFactoryInfo are both move-only object > (which does not comply with BingRepeating) and that raw > a network::SharedURLoaderLoader instance must operate on the same > thread it was created on, this CL comes up with a local thread-agnostic > "wrapper" to mojom::URLLoaderFactory, named WrapperURLLoaderFactory > (see chrome/test/chromedriver/server/http_handler.cc). > Its instance replaces URLRequestContextGetter instead across threads > and BindRepeating chains just fine. > > This CL is based on the original work of Sergio Villar (svillar@igalia.com) > on [1]. > > TBR=johnchen@chromium.org (John +1'ed the original incarnation of this CL at [1]). > > [1] https://crrev.com/c/1221256 > > Bug: 872887 > > Change-Id: I21386edb04b25438ba3aa40dd5ecc1461342aecf > Reviewed-on: https://chromium-review.googlesource.com/c/1289849 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601422} Bug: 872887 Change-Id: I645a34d28cfb92c15f2f2db409e0fe7cb7a5ac6b Reviewed-on: https://chromium-review.googlesource.com/c/1292933Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#601478}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0cc11c684b54..7818a85c33d3 git log 0cc11c684b54..7818a85c33d3 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 yizhou.jiang@intel.com Implement GL_ANGLE_texture_multisample API part Created with: gclient setdep -r src/third_party/angle@7818a85c33d3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I1b8140af6464ff3a13ca1270bb1c499a7bf51d3b Reviewed-on: https://chromium-review.googlesource.com/c/1293233Reviewed-by:
-
Sam McNally authored
Fake DriveFS uses a native filesystem so file watch events are expected to be the same for Drive and local filesystems now. Bug: 891197 Change-Id: Ic14a70c32adc718137f45682457b1944a6a5f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1292662Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#601476}
-
Amos Lim authored
Generated header files need to follow chromium style on header guards. This CL has no behavior changes. Bug: 896720 Change-Id: I97dbc277af5fc7b85fef3a6f93facdfce2742927 Reviewed-on: https://chromium-review.googlesource.com/c/1292652Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#601475}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/042ec8ef9710..2b603f6c919c Created with: gclient setdep -r src-internal@2b603f6c919c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib093438863a6beb231904cc5840ac5f4fd9d893d Reviewed-on: https://chromium-review.googlesource.com/c/1293232Reviewed-by:
-
Amos Lim authored
According to the HTML standard, usemap="no-hash-name" should not work with <map name="no-hash-name"> [1]. [1] https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#rules-for-parsing-a-hash-name-reference Bug: 897025 Change-Id: Ib8ef533795e986e782a702c2562a155f59d7ce13 Reviewed-on: https://chromium-review.googlesource.com/c/1291190Reviewed-by:
-
Amos Lim authored
Generated header files need to follow chromium style on header guards. Follow up to crrev.com/c/1235356 Bug: 896720 Change-Id: I0b7e1f7a3e6ba2d743979808d2b6247b6a19e12c Reviewed-on: https://chromium-review.googlesource.com/c/1291192Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9fca45445880d222546468fa762cead4a79bc732 Reviewed-on: https://chromium-review.googlesource.com/c/1293269Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601471}
-
yoshiki iguchi authored
Bug: 122863 Change-Id: I9135498788382c89846d2be11f38fec3558f134d Reviewed-on: https://chromium-review.googlesource.com/c/1258782Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601470}
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I37b55635b6f9278813689c3c9c51323870391c60 Reviewed-on: https://chromium-review.googlesource.com/c/1293052Reviewed-by:
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I6ba69e982ff0d8d94ecd223597c63190bcdf5f32 Reviewed-on: https://chromium-review.googlesource.com/c/1292657Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21b78cac03d3..042ec8ef9710 Created with: gclient setdep -r src-internal@042ec8ef9710 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I57cbf484742f83d668509c07e361143418892110 Reviewed-on: https://chromium-review.googlesource.com/c/1293230Reviewed-by:
-
Fergal Daly authored
This reverts commit 12e96721. Reason for revert: Reland also causes flakes https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyygELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKTAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0OTYzL3NpbmdsZV9wcm9jZXNzX21hc2hfYnJvd3Nlcl90ZXN0cy9WRzl3UTI5dWRISnZiSE5UYkdsa1pVTnZiblJ5YjJ4c1pYSlVaWE4wTGxSbGMzUlViMmRuYkdWRGFISnZiV1ZXYjNnPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Original change's description: > (Reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. > > Users of Chromevox may need to touch explore the webpage, and for > things to remain consistent, we should disable hiding top-chrome > with gesture scrolls as long as Chromevox is enabled. > > R=sky@chromium.org > BUG=857331, 896514 > TEST=Added a new browser test. > > Reviewed-on: https://chromium-review.googlesource.com/c/1284289 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#600408} > Change-Id: I388bc5056f956bea2edffc7127dcab533824e56b > Reviewed-on: https://chromium-review.googlesource.com/c/1287510 > Cr-Commit-Position: refs/heads/master@{#600966} TBR=sky@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 857331, 896514 Change-Id: I62e0f5202c2b5c408dfeb6555d4ca378038be267 Reviewed-on: https://chromium-review.googlesource.com/c/1293091Reviewed-by:
-
Asami Doi authored
to use an existing script on offline is correct or not. The goal is to import and evaluate as a module script at ServiceWorker. Users can use it by adding type 'module' when register a service worker script. The reason why I use browser tests instead of WPT tests is I want to make sure an installed script works well offline. There is no way to terminate a worker from WPT tests. These new tests are for 'classic' and 'module' scripts. Change-Id: I17f201080eeced93b8dccb8a3867721798b3699c Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 824647 Reviewed-on: https://chromium-review.googlesource.com/c/1276046 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601465}
-
Nico Weber authored
The value is never read, and storing it makes context snapshot writing nondeterministic. A comment claims that the mere presence of the field is needed to identify prototypes, with a link to https://bugs.webkit.org/show_bug.cgi?id=110436 The code in that patch does indeed use v8PrototypeInternalFieldcount to identify prototypes (see CustomElementHelpers::findWrapperType in that patch), but the corresponding code in modern blink is V0CustomElementConstructorBuilder::HasValidPrototypeChainFor which instead uses a pointer comparison with script_state_->PerContextData()->PrototypeForType(type). However, V0CustomElementConstructorBuilder::PrototypeIsValid() does check `prototype_->InternalFieldCount()` to check if a prototype is already registered -- so keep kV8PrototypeInternalFieldcount around and just keep the uninitialized default value (the code only cares about the number of fields being > 0, not about the value of the field). TBR=peria (who lg'd this, but Gerrit lost the LG) Bug: 870584 Change-Id: If5474f37499121047c4b0232a85435f139e5cbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1292385 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601464}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0b0136ae0e2..21b78cac03d3 Created with: gclient setdep -r src-internal@21b78cac03d3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8adf9ff479a3580f4a77d5bac5caa1a03e940e16 Reviewed-on: https://chromium-review.googlesource.com/c/1292988Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Bug: 896113 Change-Id: I60f8e082a01dd1a7007004ae26ff275c87eaa8bf Reviewed-on: https://chromium-review.googlesource.com/c/1290576Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#601462}
-
- 21 Oct, 2018 9 commits
-
-
Sergei Datsenko authored
If there are watchers on a mount that just got unmounted some paths there will be unresolvable. Fix the code to handle those errors reasonably. BUG=chromium:862835 Change-Id: I9cc993d01c98a20da06a6487dfc59a342f0c7412 Reviewed-on: https://chromium-review.googlesource.com/c/1290055Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#601461}
-
Dominic Battre authored
The privacy team considered the precondition to have browsing history syncing enabled in order to fetch password requirements files as arbitrary as Google cannot learn what sites you visit from the spec fetching (only a very short hash prefix is sent, currently this has size 0). They asked to remove that precondition, which is happening with this CL. This is largely a revert of crrev.com/566756. Bug: 846694 Change-Id: I65ad40758d81de7ba6ab816be8e874e561b06a8b Reviewed-on: https://chromium-review.googlesource.com/c/1292051Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#601460}
-
Robert Sesek authored
Change-Id: I9e929ef2ac76d6bf5a30a538bc2bb84510eb1ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1291629Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601459}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24281eafcf82..e0b0136ae0e2 Created with: gclient setdep -r src-internal@e0b0136ae0e2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic7e805b31bcf019f3147d2cfff4afa08170f06fa Reviewed-on: https://chromium-review.googlesource.com/c/1292987Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60d5074bd655..24281eafcf82 Created with: gclient setdep -r src-internal@24281eafcf82 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I84510d9b88e91f4cf886e6335188b11597153be5 Reviewed-on: https://chromium-review.googlesource.com/c/1292986Reviewed-by:
-
John Delaney authored
Record the Media.BytesRecevied metrics separately for media players contained in ad subframes. Currently, there is no metric capturing the amount of bytes used to load ad videos via MSE. These metrics are useful for measuring impact of any ad interventions targeting video playback. Bug: 884899 Change-Id: I95a519d2f7393103b5e67d5bed4bf9217a4b2f99 Reviewed-on: https://chromium-review.googlesource.com/c/1288855 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#601456}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c3446511. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26460 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib4460436ccd7b0cde87ff5c8c2d18226eeb33542 Reviewed-on: https://chromium-review.googlesource.com/c/1293048 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601455}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bcf7f1a7ed0..60d5074bd655 Created with: gclient setdep -r src-internal@60d5074bd655 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I101d88397140624a7227806c3e2dcb5b4a9a9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1292985Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47876718a546..4bcf7f1a7ed0 Created with: gclient setdep -r src-internal@4bcf7f1a7ed0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9c217d42268193138bb253d6e68a14f37c68530c Reviewed-on: https://chromium-review.googlesource.com/c/1292984Reviewed-by:
-
