GitLab

This issue was found by a linter.

R=kaiwang@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/22339009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216819 0039d316-1c4b-4281-b951-d872f2087c98

The primary motivation for this change was to remove the
unnecessary include of kernel_wrap.h from nacl_io.h.

In doing this is realised that we shouldn't be declaring
the mount(2) function in nacl_io.h but instread relying
on <sys/mount.h> for this.

The doxygen comment that was previously attached to
the mount(2) declaration was merged with nacl_io_init.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/22642016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216818 0039d316-1c4b-4281-b951-d872f2087c98

GPU microbenchmarking framework is being deleted.

BUG=168460

Review URL: https://chromiumcodereview.appspot.com/22320018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270976

Review URL: https://chromiumcodereview.appspot.com/22303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216816 0039d316-1c4b-4281-b951-d872f2087c98

If a test adds its own command line options, we need to make sure those
are included in the options variable. Previously, AddCommandLineOptions
wasn't even called. Now we grab the defaults from it and then add those
to |options| as long as |options| hasn't already set them.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/22268006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216815 0039d316-1c4b-4281-b951-d872f2087c98

Unwanted sign in to Chrome occurred when the user signed in to another service (Gmail, crbug.com...) from a tab that previously showed the Chrome sign in flow.

This CL clears the state of the OneClickSigninHelper associated with a web contents when it's detected that the sign in process has been aborted (i.e. a navigation to a page which is not part of the web-based sign in is triggered by something else than the web contents). It's necessary to maintain the state when a navigation to an unknown page is triggered from the web contents in order to support SAML.

TEST=
1.Launch Chrome and create new user ('Welcome to Chrome' page will appear).
2.Type 'crbug.com' in omnibox and hit 'Enter' key. ('Omnibox' of the same tab that showed the Chrome sign in page).
3.Click on the 'Sign in' link of 'crbug.com'
4.Login with valid account credentials.
Expected result: You are not signed in to Chrome and no message related to sync appears.
BUG=269421

Review URL: https://chromiumcodereview.appspot.com/22253010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216814 0039d316-1c4b-4281-b951-d872f2087c98

Certain prefs will now elicit stat tracking
whenever they are changed locally and pushed to
sync, or when changes from sync server are pulled
down to update the local pref store.

New histogram names take the form:

Settings.$prefname.Changed{FromSync,Local}

The logged value is the new pref value imposed by
the change.

BUG=265627

Review URL: https://chromiumcodereview.appspot.com/21580002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216813 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261834

Review URL: https://chromiumcodereview.appspot.com/21042013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216812 0039d316-1c4b-4281-b951-d872f2087c98

Adapts the WebContentsDelegate::RunFileChooser into a java embedding
callback.

BUG=Internal b/6930981
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20666003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216811 0039d316-1c4b-4281-b951-d872f2087c98

These had some failures on the Mac bots a few weeks ago, but that was
presumably due to a bad build of Chromium.  The tests are passing fine
on the trybots now.

BUG=261724
TEST=Mac trybot

Review URL: https://chromiumcodereview.appspot.com/20577003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216809 0039d316-1c4b-4281-b951-d872f2087c98

Lots of tree breakages on Windows bots.

> Adding check for OS support to AVX
> 
> AVX support requires OS level support, this patch adds the relevant
> checks to ensure AVX is truly supported on a given cpu.
> 
> It also fixes a missing initializer for has_avx_.
> 
> This is a takeover of https://codereview.chromium.org/12511002/ from
> whunt@ who no longer works on the Chrome team.
> 
> BUG=171824
> TEST=none
> TBR=brettw,apatrick_chromium,whunt
> 
> Review URL: https://chromiumcodereview.appspot.com/22354004

TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/22604007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216807 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216803 0039d316-1c4b-4281-b951-d872f2087c98

content should not be of poking around the internal structure of Blink,
instead it should just use things exposed through public.

This is necessary because DumpRenderTree is going away soon.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/22432006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216801 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270431
R=dewittj@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22375008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216800 0039d316-1c4b-4281-b951-d872f2087c98

TBR=isherman@chromium.org
NOTRY=true

BUG=267638

Review URL: https://chromiumcodereview.appspot.com/22602004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216799 0039d316-1c4b-4281-b951-d872f2087c98

This will help debug any flake in the unit tests.

R=jvoung@chromium.org
BUG=none
TEST= unit_tests --gtest_filter=Pnacl*

Review URL: https://chromiumcodereview.appspot.com/22608005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216798 0039d316-1c4b-4281-b951-d872f2087c98

Profiles info is being passed to JS in |BrowserOptionsHandler::GetLocalizedValues| which gets called only once when the settings page is opened but not on page reload.
When a user edits in the profiles list (adds or deletes a profile) and then reload the settings page we end up populating the profiles list with old cached data. Accordingly,
we request the profiles info in BrowserOptions.initializePage to get a fresh list of the profiles info every time the page is loaded.

BUG=269942

Review URL: https://chromiumcodereview.appspot.com/22642011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216797 0039d316-1c4b-4281-b951-d872f2087c98

BUG=259206
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/22352005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216796 0039d316-1c4b-4281-b951-d872f2087c98

AVX support requires OS level support, this patch adds the relevant
checks to ensure AVX is truly supported on a given cpu.

It also fixes a missing initializer for has_avx_.

This is a takeover of https://codereview.chromium.org/12511002/ from
whunt@ who no longer works on the Chrome team.

BUG=171824
TEST=none
TBR=brettw,apatrick_chromium,whunt

Review URL: https://chromiumcodereview.appspot.com/22354004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216795 0039d316-1c4b-4281-b951-d872f2087c98

R=eliben@chromium.org

Review URL: https://codereview.chromium.org/22686004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216794 0039d316-1c4b-4281-b951-d872f2087c98

We were simply close the device handle and left all the flying transfers hanging. libusb guarantees that the transfer callbacks will be called even if canceled. But it was not freed because during the libusb_close the user_data of the transfer is reset, so our handler will not be relaid to. 

This change is to wait for all the transfers to be canceled before we really close the platform handle.  

BUG=223817
BUG=261695
BUG=269048

Review URL: https://chromiumcodereview.appspot.com/22492003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216793 0039d316-1c4b-4281-b951-d872f2087c98

This change brings in a new version of naclports which
is needed to fix the current breakage due to pnacl-translate
no longer working on non-finalized executables.

The new version of naclports, among other things, will
always finalize before translating during build.

TEST=build_sdk.py --build-ports
R=binji@chromium.org

Review URL: https://codereview.chromium.org/22674012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216792 0039d316-1c4b-4281-b951-d872f2087c98

1. Move category_group_enabled checking out of lock.
2. Move thread_name checking out of lock. Lock on thread_name changes
to check and update thread_names_ map.
3. Check if thread_id is the id of the current thread before checking
thread name change.
4. Move TraceEvent construction out of lock.
5. Put code ECHO_TO_CONSOLE code together and under lock.
6. Add a missing lock in TraceLog::RemoveProcessLabel().

This is the first step for bug 264667. Next step is thread-local event
buffer.

BUG=264667

Review URL: https://chromiumcodereview.appspot.com/22294006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216791 0039d316-1c4b-4281-b951-d872f2087c98

Once http://crrev.com/22652003 lands, and Blink rolls, this is the Chromium
side that will allow the use of <webview> as a custom element. The actual
changes to webview to use the custom element API will come in a separate patch.

BUG=178663

Review URL: https://chromiumcodereview.appspot.com/22709003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216790 0039d316-1c4b-4281-b951-d872f2087c98

TrackedCallback handles re-entry into the Plugin. Add
a way to insert a task into this process so resources
can perform any completion work on the proper thread
without having to duplicate this re-entry work.

BUG=
R=dmichael@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/22606005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216789 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed PYTHONPATH so that old generated *.pyc in chromedriver/ won't be picked up unexpectedly after the *.py were moved from chromedriver/ to chromedriver/test/.

TBR=kkania@chromium.org
BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22601006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216788 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268984
TEST=no change
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22632004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216787 0039d316-1c4b-4281-b951-d872f2087c98

For HLS, seekTo() can cause media player to stuck in a error state.
Since the returned duration < 0 for HLS, we can ignore all seek positions that are negative

BUG=265460

Review URL: https://chromiumcodereview.appspot.com/22605013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263983
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/22375009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254738
R=dpolukhin@chromium.org, zelidrag@chromium.org

Review URL: https://codereview.chromium.org/22329008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216783 0039d316-1c4b-4281-b951-d872f2087c98

This adds AddValue support to FrameData, RenderPass, *DrawQuad, FilterOperations, etc.
It also adds an optional 'frame' field to the LTHI state which is the frame
being produced at this point, with everything mentioned above.

BUG=None
R=danakj@chromium.org, nduca@chromium.org, vmpstr@chromium.org

Review URL: https://codereview.chromium.org/20667002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216782 0039d316-1c4b-4281-b951-d872f2087c98

This matches an updated spec.  Now, the menu for profile
switching has a checkbox next to the currently selected
profile. Additionally, the leftmost edges of all the visible
controls are now lined up.

R=jianli@chromium.org
BUG=269757

Review URL: https://chromiumcodereview.appspot.com/22720004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216781 0039d316-1c4b-4281-b951-d872f2087c98

Moved from https://codereview.chromium.org/21052007/

Currently the ContextFactory is outliving the compositor thread in 
tests, which is bad since the contexts in there can be bound to the 
compositor thread. Then we end up reusing those contexts and bad 
things happen. 

This enforces ordering for initializing and destroying the 
compositor as follows: 

Initialize ContextFactory 
..Compositor::Initialize 
....Create Compositor instances 
....Delete Compositor instances 
..Compositor::Terminate 

The Compositor::Terminate call also destroys the ContextFactory. 

The ContextFactory can be initialized in one of two ways: 
1. ImageTransportFactory::Initialize will set up the 
ContextFactory. This is used by things that invoke all of 
content/browser/. 
2. Compositor::InitializeContextFactoryForTests() must be 
explicitly called by any unit tests that create a compositor. 

Since some tests want a real GL context and some don't, this 
does away with the misnomer of initializing the Compositor once 
for the entire test suite, and then re-initializing somewhere 
in the middle of the test suite. Instead, each test must 
Initialize/Terminate the compositor with the ContextFactory 
type of its choice. 

Incidently, this test enables 20 tests on aura or win_aura that 
were previously being skipped. 

TBR=piman@chromium.org
BUG=258625

Review URL: https://chromiumcodereview.appspot.com/22293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=266006

If the MediaFormat indicates 1 channel for the file but the MediaCodec decoder changes the output format to 2 channels, we remove the data from the second channel before sending to the receiver.  This makes the the transmitted data consistent with the expected number of channels.

Review URL: https://chromiumcodereview.appspot.com/21618002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216779 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for ozone to allow implementations of
VSyncProvider outside of ui/gl.

Review URL: https://chromiumcodereview.appspot.com/22710008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216778 0039d316-1c4b-4281-b951-d872f2087c98

If the root scroll layer is nonscrollable (particularly when fully
zoomed out on a viewport-sized page), then ScrollIgnored is returned on
ScrollBegin, but we still want to support the scrolling portion of pinch
gestures.

Fix this by forcing CurrentlyScrollingLayer to the root layer
on pinch (which is also desirable so that the scroll portion doesn't go
to sublayers anyway).  Secondly, always call ScrollEnd so that the pinch-set
CurrentlyScrollingLayer is cleared.

New test case in LayerTreeHostImplTest.PinchGesture.

NOTRY=true
BUG=269669

Review URL: https://chromiumcodereview.appspot.com/22527005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216777 0039d316-1c4b-4281-b951-d872f2087c98

We want to know if users react differently to the SSL warning the first time they encounter a website with an SSL error vs on subsequent encounters with SSL warnings. We determine this by checking to see if a site is in the user's history.

BUG=255288

Review URL: https://chromiumcodereview.appspot.com/22350004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216776 0039d316-1c4b-4281-b951-d872f2087c98

Because of a bug in the gesture config UI (chrome://gesture), whenever a
user tried to reset a gesture preference to default, the preference was
set to whatever the default value of the preference was at that time,
instead of unsetting the preference. This bug is now fixed, but many
users may have unintentionally set their gesture preferences to the
default values.

A temporary preference is introduced to unset all gesture preferences
once.  This preference will be removed in a proper time in future when
we think that a good portion of users have their gesture preferences
unset.

BUG=251858

Review URL: https://chromiumcodereview.appspot.com/21983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216775 0039d316-1c4b-4281-b951-d872f2087c98

- This CL darkens the light bars when they are throbbing. Previously, the light bars for inactive tabs would animate from 0 - 33% opacity.
- This CL ignores the mini tab title animation for immersive fullscreen tabs. Previously, the inactive mini tabs would be completely transparent while the animation was running.

BUG=265553
TEST=Manual, see bug
R=jamescook
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/22353017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216774 0039d316-1c4b-4281-b951-d872f2087c98