- 26 Mar, 2020 40 commits
-
-
Felipe Salazar authored
Bug: internal b/152060494 Change-Id: I47d3e4abce88008798a68b0273c4f3d0c60b5f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121428 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#753703}
-
Juanmi Huertas authored
RedirectDisabledSubresourceRedirectBrowserTest TestCSSBackgroundImageRedirect Has been disabled as this is a flaky test at the moment as well for Linux Test Bug:1063736 TBR=tbansal@chromium.org Change-Id: I889f135755057ef2a7bf82322b736230fd0e55a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120923Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#753702}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4085.6-1584956258-benchmark-82.0.4085.16-r1 to 83-4085.6-1584956258-benchmark-83.0.4091.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3df1b196c18910ed7999eec8da281b52dd65d642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753701}
-
Wei Li authored
The url used by HaTS survey status check was incorrect due to a missing slash before the path. This CL also added a test to verify the url. BUG=1048385 Change-Id: I6ef6e29a13f61a56147bfd258af101cd103bbadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114163 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753700}
-
Yulun Wu authored
Bug: 1064854 Change-Id: I4f3ce5280f251b955fbe693da0a628e8394cf17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121433 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753699}
-
W. James MacLean authored
Adding synchronization points to test to see if we can decrease the level of flakiness. Bug: 992419 Change-Id: I86949388dc491a82dbff212fe5a14d566bce7326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120103Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#753698}
-
ssid authored
The service performs expensive computations on UI thread in both browser and renderer processes. The computation of VM regions, creating OS memory dump, graph computation of chrome dumps are all expensive. So, this moves the coordinator and clients to memory-infra thread which is created for this purpose. Change-Id: I6da7e5a0a8d6f8e4b91b8071bf464fb9eaced2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109457Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#753697}
-
W. James MacLean authored
FindOptions::run_synchronously_for_testing is only ever used by FindTaskController::FindTask, it should have no effect in tests that are testing PDF find in page functionality. This CL modifies those tests to stop using it. Bug: n/a Change-Id: I0386d3139f07beee2345bf1ffd571fedded86cff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122046Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#753696}
-
Navid Zolghadr authored
Keep blink test config excluded from RenderAccessibilityImplTest as some of the tests would fail there. BUG=1064735 Change-Id: I134eb7183e8061539bed6f5bf5e80d069be49eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115886 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753695}
-
Theresa Wellington authored
This test was flakily failing due to improper calculation of motion event x/y coordinates. An animatioin runs when the app menu is opened and ending it doesn't immediately result in the views reaching their resting position. This CL adds a wait for AppMenuDragHelper to be ready for menu item actions and retrieves the View rect on the UI thread. 0 flakes in 120 runs locally. BUG=1062236 Change-Id: Ie7264fb23ceaf9e0b6653c7ca78c1b5d2bf555b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121451Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#753694}
-
Lijin Shen authored
When the switch option is toggled, the popup menu is not updated. Add a new method to notify the adapter of data set changes. Bug: 1064192 Change-Id: I638f37157fb8966c200af098589290cde9574c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116925Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#753693}
-
manuk authored
Background: - A doc suggestion can be provided by (1) the doc provider, (2) the shortcut provider, or (3) both. - Doc suggestion descriptions include the last access date when available. When doc suggestions are suggested by the shortcut provider, this date can be stale if the actual last access date has changed since the shortcut was created. - In case (3), the suggestion scored highest is preferred during deduping. With this CL: - The doc suggestions will set a description_for_shortcuts field similar to their descriptions but excluding the last access date. The shortcut backend will store description_for_shortcuts instead of description when description_for_shortcuts is set. This avoids storing stale dates without losing doc suggestions in case (2). - Deduping will prefer doc suggestions from the doc provider over the shortcut provider. Thus, in case (3), dates will continue to be shown. Change-Id: Ibdd9e52ccdd37894177f11ce89a0e5789bf90af9 Bug: 1035105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107811 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#753692}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36272def..5e04fbf9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1e784c4fe7909fa6313526630a888cfc272e4199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121317Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753691}
-
Nina Satragno authored
We are requiring a version that is higher than actually needed and has not been deployed to production which is breaking web authentication on canary. Bug: 1064934 Change-Id: If52ca4f5f4ff846da35628a26080c1f401e807f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121452Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#753690}
-
Frank Liberato authored
TextureSelector now asks FormatSupportChecker before choosing an output format for the video processor, to see if it's supported. It tries FP16, 10 bit BGRA, then binding P010 textures directly. This probably covers the intel workarounds for P010 binding. Change-Id: Ib2ab4d00ba033465ecae3e78bba80dc999ae84b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108905 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#753689}
-
Peter Beverloo authored
Bug: 1064589 Change-Id: Ic578d2d6d733dc194bf4eb9209cf57d56abae3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119529 Auto-Submit: Peter Beverloo <peter@chromium.org> Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753688}
-
Tim Schumann authored
BUG:1063844 TBR=dpapad@chromium.org Change-Id: I6c1173b8fa75d808e4bbeb65803c23765c954c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121263 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#753687}
-
Ewann authored
This CL adds the new Block Third-Party Cookies UI to the incognito NTP. screenshots: https://drive.google.com/drive/folders/1Q5L3S1V5gjU-UyRMMnaVWi9XIGNN3tSA?usp=sharing Bug: 1063824 Change-Id: Ia895b23e35614bfcbd1c33e87238b9043d6d1847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116221 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#753686}
-
Patrick Monette authored
This CL simply adds the worker nodes to the graph but does not make the connections between the service workers and their clients. As opposed to the DedicatedWorkerHost and SharedWorkerHost, the ServiceWorkerVersion does not observe when its associated render process host exits because that class does not live on the UI thread. This leads to ordering issues between the deletion of the service worker node and the worker node. Since the ServiceWorkerVersion is meant to eventually move to the UI thread, this CL temporarily works around this issue by wrapping the ServiceWorkerContext in an adapter class that observes the render process host of each running worker to ensure that the OnVersionStoppedRunning() notification is delivered in a timely manner. Bug: 993029 Change-Id: Ie6e5b525727c12f98fe8a28b04ccfa9795f59003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042283Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#753685}
-
Peter Beverloo authored
Also modernize and clean up the rest of the file and histogram usage a bit. Bug: 1053439 Change-Id: Id2047169f960986cae5eb08b4a2202e3c84aae3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071264 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753684}
-
Patrick Noland authored
This change does two things for optional button animations: 1) Prevents the hide button animation from running when transitioning away from displaying the LocationBar on the NTP 2) Prevents us from re-running the hide button animation when it's currently running; previously it was cancelled and restarted Bug: 1064303 Change-Id: Ib843edf7e33e6d521d26788eb8fffac3272b5b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120265Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#753683}
-
Erik Jensen authored
To keep Chrome within CRD from conflicting with Chrome running on the local console, CRD currently sets CHROME_USER_DATA_DIR to a custom location. However, this can cause issues if the user has multiple channels installed, as they will all try to use this same profile directory. This can lead to errors such as "Your profile can not be used because it is from a newer version of Google Chrome" if, e.g., the user tries to use Stable after using Beta. M61 introduced a new CHROME_CONFIG_HOME environment variable, which instead specifies a base directory in which Chrome will create channel- specific data directories. This allows us to tell Chrome to store config data in a separate location when running under CRD without interfering with the ability to run multiple Chrome channels. M61 is old enough by now that it makes sense to set CHROME_CONFIG_HOME by default in CRD rather than CHROME_USER_DATA_DIR, which is exactly what this change does. To prevent interfering with existing users who already have a Chrome profile created under previous versions, CHROME_USER_DATA_DIR is still set (and not CHROME_CONFIG_HOME) if the old chrome-profile directory exists and the new chrome-config directory does not. Change-Id: I25feed41488d55998de9557fd63091426e4d09d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121435Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753682}
-
Mark Cogan authored
Removes use of TabModelList from the translate internals handler, using an AllWebStateListObservationRegistrar and an inner observer class to produce the same behavior. Bug: 1058352 Change-Id: I7ffe1d4c1cea80831a2dd538b9abdcc46ee08070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119537 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#753681}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e322072ab4fb..cafff78f665b git log e322072ab4fb..cafff78f665b --date=short --first-parent --format='%ad %ae %s' 2020-03-26 bclayton@google.com CMake: Add option for selecting LLVM version. Created with: gclient setdep -r src/third_party/swiftshader@cafff78f665b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I286300979519fc852f90ed1ccd8f3b0623c81af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753680}
-
John Abd-El-Malek authored
This is necessary because we need to be able to notify the embedder of resumed downloads which aren't associated with any Tabs. Bug: 1025603 Change-Id: Ie6f749ff17db9bc42f578c275d3f427d91cc3de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118681Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#753679}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 83-4044.62-1584958487-benchmark-82.0.4085.16-r1 to 83-4044.62-1584958487-benchmark-83.0.4091.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia8244eefe04845fa4a3e4a70088123f6e2137a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122514Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753678}
-
Bo Liu authored
Explain WebContents destructor can callback to delegate methods as well. Change-Id: I97bc237806902365ab03d5857229165cdf0a9c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121502Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753677}
-
John Budorick authored
Follow-up to crrev.com/c/2111652. Bug: 812428 Change-Id: I6ddb60cc1c096276186d39b27f66cdbc6e69fa61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122238Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#753676}
-
Henry Jian authored
Add an extra check step in the "Setting up code completion/reference finding/etc" section. Change-Id: I1f76849fcb9179b7f6bc0f5669669cbff98c40cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121454 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753675}
-
Sahel Sharify authored
This is a reland of 352154b4 Original change's description: > [Payments][Android] Move PayerData.java into components/payments/.. > > This cl moves PayerData.java class into components/payments so that > the WebPaymentIntentHelper.java class can use it without depending on > chrome/browser. It also introduces a new Address class and its > converter utility class so that PayerData.java does not depend on > mojom.PaymentAddress. > > Change-Id: Idb737bc2697212af7542d3abbd1488461a7d3074 > Bug: 1026667 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110678 > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752597} TBR=rouslan@chromium.org,kenrb@chromium.org Bug: 1026667 Change-Id: Ibccddb04432466f2e1668f6468792c7496ebbc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122232Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753674}
-
David Jean authored
Bug: 1045454 Change-Id: I4e87ed37f6d5d4e4ee650c824bd6a4754529b6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120504Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#753673}
-
spdonghao authored
Bug: 1061906 Change-Id: I7134e66f8b62e7f9beb5d37bf61534ca7a29776a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107056 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753672}
-
Wei-Yin Chen (陳威尹) authored
When developing https://crrev.com/c/2118621, we found that if the following line is deleted, no tests would fail. https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherCoordinator.java;l=189;drc=556bf45e2c50857b400b30ed4b74ed6617091126 This CL amends the test coverage so that if that line is missing, testTabSuggestionMessageCard_review() would fail. Bug: 1041865 Change-Id: I774b796bf97b0a40789d365d4d0a7ebee055afff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121763Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753671}
-
Tim Schumann authored
TBR=rbpotter@chromium.org,dpapad@chromium.org BUG: 1064966 Change-Id: I4168bac2ca2acebbc3cf33db3f68cdbf1b60b84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121381Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Auto-Submit: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#753670}
-
Andrew Grieve authored
They only crashed when no loadable_modules exist, so didn't affect main targets. Does affect test targets though. The error was caused by a mistake during a prior refactoring where "invoker.native_libs_filearg" should have been changed to local variable "_native_libs_filearg". Change-Id: Ibd9e0fe6c54deac20cdb503d56632065299a6a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122237 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753669}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4079.0-1584354054-benchmark-82.0.4085.13-r1 to 83-4085.6-1584956258-benchmark-82.0.4085.16-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5d50f4c635ffc74378974ef09e0477748cdf9bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753668}
-
David Van Cleve authored
This change adds an about:flag for enabling the prototype Trust Token API (https://github.com/wicg/trust-token-api), which is currently behind a base::Feature. This will make manual testing easier. Bug: 1036483 Change-Id: I4cb85381462faa794bdaa2ab8b239aaf7ce41027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120100Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753667}
-
adamta authored
Truncate the resolving hyperlink URL in the context menu title to 101 characters. //ui/gfx was added as a public dependency in url_formatter since both //ui/gfx/text_elider.h and the context_menu_params_utils import headers from //ui/gfx. Bug: 1059285 Change-Id: I3dd46fd93fd96e1dbf01b7b19a0a9dec194154e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101251 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#753666}
-
Robbie Gibson authored
These suggestions represent old searches, so they should use the clock icon. Bug: 1064971 Change-Id: If2257637e8a6f8ef041dd5c6a04059c114933f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122026Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#753665}
-
Dave Tapuska authored
The image source may not get loaded immediately so the size was reported as 0x0. Turn test into one that waits for the expected condition or timesout. BUG=652536 Change-Id: I0213383a7678f120cab8b0a55c4f10639183aaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121079 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753664}
-