GitLab

There is race when request to set system modal received before
surface window is actually created. This CL keeps system model
property and apply it once window is created.

TEST=Manually, simulate situation for early system modal switch.
     Before fix it crashed with the same stack trace as crash
     reports. After this I observed warning message in log and
     system modal state is working as expected.
BUG=639511

Review-Url: https://codereview.chromium.org/2743053002
Cr-Commit-Position: refs/heads/master@{#456256}

Add SafeArchiveAnalyzer mojom service used to inspect ZIP / DMG
file archives for safe browsing download protection. Expose the
mojo to the browser via the utility process policy file. Update
clients to call the service using a mojo utility client, remove
all dependencies on UtilityProcessHostClient. Add native traits
for the file analyze results.

Align the ZIP/DMG clients: make their API's match, remove class
base::File fields (curry the file(s) to the analyzer step), and
remove ZIP client temp file clean-up code (not needed since the
utility process now owns the files).

Covered by existing tests:

SandboxedDMGAnalyzerTest.AnalyzeDMG, SandboxedZipAnalyzerTest.*

both of which use a content::InProcessUtilityThreadHelper viz.,
SafeArchiveAnalyzer mojo is called by these tests.

BUG=597124

Review-Url: https://codereview.chromium.org/2737763002
Cr-Commit-Position: refs/heads/master@{#456255}

description when the <paper-toggle-button> is focused

R=hcarmona@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743063004
Cr-Commit-Position: refs/heads/master@{#456254}

R=dschuyler@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2743733005
Cr-Commit-Position: refs/heads/master@{#456253}

This CL makes the RTT and throughput estimates available on the UI
thread. It also makes it possible to add observers on UI thread that
can listen to changes in the RTT/throughput estimations.

BUG=700215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
TBR=bmcquade@chromium.org, petewil@chromium.org

Review-Url: https://codereview.chromium.org/2717153002
Cr-Commit-Position: refs/heads/master@{#456252}

MD Settings: fix attribute name typo to enhance a11y of JavaScript subpage button on content settings page

R=dschuyler@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2742983003
Cr-Commit-Position: refs/heads/master@{#456251}

Also replace some elifs after returns with ifs.

BUG=648423

Review-Url: https://codereview.chromium.org/2745863002
Cr-Commit-Position: refs/heads/master@{#456250}

[CrOS Tether] Create KeepAliveScheduler, a class which schedules keep-alive tickles to be sent to a connected host every 4 minutes until the device disconnects.

BUG=672263

Review-Url: https://codereview.chromium.org/2741253002
Cr-Commit-Position: refs/heads/master@{#456249}

BUG=None
R=erg@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

Review-Url: https://codereview.chromium.org/2740933005
Cr-Commit-Position: refs/heads/master@{#456248}

This CL adds a controlled-by indicator when a slider is controlled by
policy or an extention.

BUG=693302
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2737083002
Cr-Commit-Position: refs/heads/master@{#456247}

This simplifies the code and makes it easier to understand for the casual
reader.

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/QwLhUSk6kfI/HN5-df0-AwAJ

BUG=None
TEST=net_unittests
R=eroman@chromium.org

Review-Url: https://codereview.chromium.org/2746653002
Cr-Commit-Position: refs/heads/master@{#456246}

Revert of Improve transition between opaque and translucent compositor views. (patchset #24 id:460001 of https://codereview.chromium.org/2201483002/ )

Reason for revert:
This change unfortunately breaks WebVR and probably VrShell, I confirmed via
bisect that 5fe29f76 is the last working change
right before this. It's plausible since it touches code such as detachForVR and
related code, seems like they don't agree on which surfaces should be visible.

Original issue's description:
> Improve transition between opaque and translucent compositor views.
>
> On Android, when we'd like to use a SurfaceView for video playback,
> we must enable the alpha channel on the CompositorView.  Otherwise,
> we cannot draw a hole to see the video's SurfaceView.  We can't keep
> transparency enabled all the time since it can cause power
> regressions on some hardware.
>
> However, because SurfaceView destroys and recreates the surface when
> changing the pixel format, there is a visible flash during the
> transition.  This CL removes that.
>
> It causes the CompositorView to have two SurfaceView child views,
> rather than extending SurfaceView directly.  When a request is made
> to switch the output format, it makes the change to the background
> SurfaceView, and swaps it to the front.  It also keeps the outgoing
> SurfaceView around until the new one is in use by the compositor.
>
> There are a few interesting bits:
>
> - SurfaceViews are invisible until the first buffer is posted.  So,
>   we can continue to see the outgoing view until the compositor is
>   ready to use the new one.
> - All buffers are released by the outgoing SurfaceView when its
>   visibility is set to Gone.  'dumpsys SurfaceFlinger' shows that the
>   same amount of gralloc memory is used in steady state.
> - No power regression was observed on a Nexus 5.
> - Unfortunately, new SurfaceViews are z-ordered behind existing ones,
>   which makes it critical that we guess when to delete the outgoing
>   (topmost) SurfaceView.  We currently time one frame, and then hide
>   it.  Empirically, this works fine.
> - This might seem like a more natural extension to
>   CompositorViewHolder, but the CompositorView currently owns the
>   native compositor.  Since CompositorViewHolder is already fairly
>   complicated, it wasn't clear that it would be a good idea to
>   refactor that into CVH.
>
> Another approach is to use EGL to change the buffer format to include
> an alpha channel, or not.  This avoids the power regression, since
> opaque surfaces and buffers without alpha channels are treated the
> same by SurfaceFlinger.  However, it causes problems for virtualized
> contexts.  In particular, the off-screen contexts will have an alpha
> channel at all times, so they cannot be shared with the compositor
> context without one.  For some hardware (e.g., QC) that requires the
> use of virtualized GL contexts rather than share groups, this may
> have a stability regression.  So, we don't try it.
>
> Please see https://goo.gl/aAmQzR for the design doc.
>
> BUG=629130
>
> Review-Url: https://codereview.chromium.org/2201483002
> Cr-Commit-Position: refs/heads/master@{#456142}
> Committed: https://chromium.googlesource.com/chromium/src/+/1e87636c63028418b779dadeaadbe4e5f487c76e

TBR=aelias@chromium.org,dtrainor@chromium.org,mdjones@chromium.org,tedchoc@chromium.org,watk@chromium.org,liberato@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=629130

Review-Url: https://codereview.chromium.org/2742133002
Cr-Commit-Position: refs/heads/master@{#456245}

We are adding COMPONENT/TEAM information into OWNERS file(
views, etc).

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2740203004
Cr-Commit-Position: refs/heads/master@{#456244}

BUG=684609

Review-Url: https://codereview.chromium.org/2743843002
Cr-Commit-Position: refs/heads/master@{#456243}

Remove GpuMsg_Finalize, and associated code (e.g.
GpuProcessHost*::StopGpuProcess()). Introduce GpuService::Stop() mojom
api in its place, and content::StopGpuProcess() so that content embedders
(e.g. chromecast) can stop the gpu process when desired.

BUG=639941, 643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2723363002
Cr-Commit-Position: refs/heads/master@{#456242}

This test has syntax error and is missed in gn build file when added.

Review-Url: https://codereview.chromium.org/2738983006
Cr-Commit-Position: refs/heads/master@{#456241}

Currently, all external clients of SpellCheckRequest use it in only
one way -- pass it to SpellCheckRequester::requestCheckingFor
directly.

Hence, this patch makes the clients call the function directly without
knowing about details of this class, to reduce exposure of implementation
details.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2740603003
Cr-Commit-Position: refs/heads/master@{#456240}

R=rdevlin.cronin@chromium.org
BUG=700312
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745733004
Cr-Commit-Position: refs/heads/master@{#456239}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/aa4354795733..5cdfbfc97459

$ git log aa4354795..5cdfbfc97 --date=short --no-merges --format='%ad %ae %s'
2017-03-10 benjhayden Hide the InteractionTrack when only 1 UE.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2741803006
Cr-Commit-Position: refs/heads/master@{#456238}

BUG=680578

Review-Url: https://codereview.chromium.org/2713003003
Cr-Commit-Position: refs/heads/master@{#456237}

BUG=695952
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2733953008
Cr-Commit-Position: refs/heads/master@{#456236}

Keeping DisplaySnapshotMojo in display/types enables tighter use of
DEPS in ozone/platform/drm so relocate it appropriately.

BUG=620927

Review-Url: https://codereview.chromium.org/2738043004
Cr-Commit-Position: refs/heads/master@{#456235}

When associating bookmarks, sync nodes are matched to BookmarkNodes.
To match a BookmarkNode with a sync node, a BookmarkNodeFinder is
created and asked to find the child node with the matching title. When searching
for the title, BookmarkNodeFinder returns the first matching child in
its child_nodes_ map. This map is an unordered_map with undefined
iteration order. If sync node siblings share a title, the
BookmarkNodeFinder can erroneously swap their respective
BookmarkNodes.
To fix this, this CL makes the iteration order defined with
std::multimap, which stores pairs in insertion order.
This is safe since sync nodes are processed in the same
order as BookmarkNodes are stored.

R=skym@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2743713005
Cr-Commit-Position: refs/heads/master@{#456234}

FROM_CHROME_UI results in animations that we do not want and
FROM_EXTERNAL_APP allows the NTP to be closed if you hit back,
which I think is nice since we are creating a tab without any
user gesture so making it discardable seems correct.

BUG=695306

Review-Url: https://codereview.chromium.org/2742783004
Cr-Commit-Position: refs/heads/master@{#456233}

Revert of evaluating clipboard event target acording to w3c specification (patchset #7 id:120001 of https://codereview.chromium.org/2685723005/ )

Reason for revert:
Changing this functionality improved spec conformance, but introduced regressions where text that used to be copied is no longer copied:
crbug.com/695568
crbug.com/700163

A proposal to change the spec was made here:
https://github.com/w3c/clipboard-apis/issues/40

Original issue's description:
> Make Editor::findEventTargetFrom() to align Clipboard API specification
>
> This patch changes |Editor::findEventTargetFrom()| to return focused element if
> selection start is not editable to align Clipboard API specification[1] for
> improving interoperability.
>
> [1] https://w3c.github.io/clipboard-apis/#to-fire-a-clipboard-event
>
> BUG=690104
> TEST=webkit_unittests --gtest_filter=ClipboardEventFlowTest.*
>
> Review-Url: https://codereview.chromium.org/2685723005
> Cr-Commit-Position: refs/heads/master@{#451716}
> Committed: https://chromium.googlesource.com/chromium/src/+/7afbab0f7619c89aa7a5896024d1628a59cc0ef1

TBR=tkent@chromium.org,ojan@chromium.org,yosin@chromium.org,yutak@chromium.org,sigbjornf@opera.com,mwrobel@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=690104

Review-Url: https://codereview.chromium.org/2745813002
Cr-Commit-Position: refs/heads/master@{#456232}

This is follow up cleanup after renaming NavigationHandle::IsSamePage to
NavigationHandle::IsSameDocument in this CL:
https://codereview.chromium.org/2716493004/

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742923002
Cr-Commit-Position: refs/heads/master@{#456231}

cros-disks's Unmount method now ignores the "force" option (CL:388592,
chromium:646224). This CL updates CrosDisksClient to stop passing the
"force" option when invoking the Unmount method.

BUG=700548
TEST=chromos_unittests

Review-Url: https://codereview.chromium.org/2743113003
Cr-Commit-Position: refs/heads/master@{#456230}

Added missing files.

BUG=none
R=jochen@chromium.org, thakis@chromium.org

Review-Url: https://codereview.chromium.org/2747483002
Cr-Commit-Position: refs/heads/master@{#456229}

This makes it easier/cleaner to implement CoreOobeView::Delegate on ScreenManager in a follow-up CL.

BUG=672142

Review-Url: https://codereview.chromium.org/2739073002
Cr-Commit-Position: refs/heads/master@{#456228}

This uses auto convert script to convert content instrumentation tests to JUnit4,
assisted with some manual clean up. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

BUG=640116

Review-Url: https://codereview.chromium.org/2708243004
Cr-Commit-Position: refs/heads/master@{#456227}

Building with VS 2017 using a packaged toolchain is not yet supported
but if you try to do it you get a surprising result - the VS 2013
toolchain gets downloaded. This adds a 2013 check to avoid this, and
also simplifies/corrects an existing 2017 check and comment.

This lets us fail-fast if a user tries the VS 2017 depot-tools
combination before it is supported.

BUG=683729

Review-Url: https://codereview.chromium.org/2741783006
Cr-Commit-Position: refs/heads/master@{#456226}

CUPS provides cupsGetJobs2 but it doesn't provide the necessary fields
to report status accurately.  Notably, it doesn't provide
job-impressions-completed or printer-state-reasons both of which are
necessary to differentiate errors.

BUG=684853

Review-Url: https://codereview.chromium.org/2691093006
Cr-Commit-Position: refs/heads/master@{#456225}

This CL fixes an issue where Chrome would display a banner saying that it
was not the default browser when it actually was.

The cause of this was 'xdg-settings check default-web-browser
google-chrome.desktop' returning 'no' when Chrome might have been the
default (see further explanation in the CL comments).

BUG=578888
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2737283002
Cr-Commit-Position: refs/heads/master@{#456224}

BUG=699287
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2742103002
Cr-Commit-Position: refs/heads/master@{#456223}

This exercises the is_cast_audio_only=true and enable_webrtc=false
codepaths which periodically break because they are not built.

Corresponding CL at https://chromium-review.googlesource.com/c/452802/

BUG=667546
TEST=`gn gen out_audio/ --args='is_chromecast=true
is_cast_audio_only=true enable_webrtc=false' && ninja -C out_audio/
cast_shell`

Review-Url: https://codereview.chromium.org/2538883003
Cr-Commit-Position: refs/heads/master@{#456222}

See bug for details of regression.

This reverts commit be0cfa14 which was:

Make Crashpad start asynchronous, and move back to chrome_elf

Crashpad initialization has been reworked to support an asynchronous
mode where StartHandler() only calls CreateThread() and does not
synchronize with that thread, making it safe to use in DllMain().

So, we can now move it back into chrome_elf to catch earlier crashes.

We block much later now in browser startup, before a renderer (i.e.
another client that would connect to the handler) will be started. This
should not be strictly necessary, but is slightly more conservative as a
first pass. This allows for error reporting, and prevents log spew from
each renderer that starts up and tries to connect to a nonexistent
handler. Also added is a UMA timer to see how long we're blocking
startup for by joining with the background thread.

TBR=mark@chromium.org, thestig@chromium.org, grt@chromium.org
BUG=700371

Review-Url: https://codereview.chromium.org/2743923003
Cr-Commit-Position: refs/heads/master@{#456221}

BUG=674667

Review-Url: https://codereview.chromium.org/2734963002
Cr-Commit-Position: refs/heads/master@{#456220}

This change emits a UKM PageLoad metric for the EffectiveConnectionType
observed at navigation start.

This change also corrects an issue where we logged some information in
OnStart. When OnStart is invoked, we don't yet know if we're observing
a page load, so we move all logging to later in the flow, when we know
we're observing a page load.

BUG=700537

Review-Url: https://codereview.chromium.org/2740403002
Cr-Commit-Position: refs/heads/master@{#456219}

BUG=675285

Review-Url: https://codereview.chromium.org/2745893002
Cr-Commit-Position: refs/heads/master@{#456218}

Update waterfall testing config for AutofillCreditCardDropdownVariations

BUG=

Review-Url: https://codereview.chromium.org/2741043002
Cr-Commit-Position: refs/heads/master@{#456217}