- 13 Apr, 2020 40 commits
-
-
Chris Thompson authored
U+2800 (BRAILLE PATTERN BLANK) isn't in the WSpace or Formatting/Invisibles sets, but should be treated like a space for purposes of unescaping. Bug: 1068531 Change-Id: I151f7c803898bc86d81570a93fbe682daf1cca86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147477Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#758627}
-
Xiaohan Wang authored
This reverts commit 02f002af. Reason for revert: test failure. see https://crbug.com/1070388 Original change's description: > [Upboarding]: Add a tile group proto. > > Bug: 1068368 > Change-Id: I1a2da9a32a71537abb3fd3626ef2614dcd24e0ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145703 > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Hesen Zhang <hesen@chromium.org> > Reviewed-by: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758600} TBR=shaktisahu@chromium.org,xingliu@chromium.org,hesen@chromium.org Change-Id: Iaadf0809f227e401b42d28d69dc6518c564a87e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068368, 1070388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148069Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#758626}
-
Allen Bauer authored
TBR=thomasanderson@chromium.org, atwilson@chromium.org Bug: 1056944 Change-Id: I2fa2aa79634a85db72472067d2faeb9be5b26ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134703Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758625}
-
Hirokazu Honda authored
The new tests to check VaapiVEA::Initialize() returns false with a temporal layer and spatial layer configuration. Bug: 1030199 Test: media_unittests on eve and on CQ Change-Id: I161409a992eb20531174f61fb4cfa14b43337903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141501 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#758624}
-
Bruce Dawson authored
When testing whether a system's status is clean or not it is possible to not have enough events to be able to make a determination. In this case we are in a state of not-success but not-failure. Given that this state is known to happen we need to not fail the test. The cause of insufficient events is well understood (running browser_tests generates enough events to flush out all older events) and Microsoft's recommendation is to ignore the DCOM events that cause this flushing so that is what this effectively change does. Reference: https://support.microsoft.com/en-us/help/4022522/dcom-event-id-10016-is-logged-in-windows Bug: 968440,1070362 Change-Id: Ie5e2e10289da02b306419cdbcccc707774f55001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147795 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#758623}
-
Xinghui Lu authored
According to b/150472142#comment28, header is not needed when oauth token is empty. Bug: 1041912 Change-Id: Ia2301ca017777319449f4e07bbdd185f8d871dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147040 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#758622}
-
Joshua Peraza authored
Crashpad began using ScopedClearErrno in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2119645 but chromium's ScopedClearErrno was replaced with ScopedClearLastError. mini_chromium was updated to mirror chromium's ScopedClearLastError in https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/2141050 Change-Id: I562e25c4033a3c892a6982e3a827a9ee821d8d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142144 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758621}
-
Torne (Richard Coles) authored
Background/persistent window types are only used by Chrome extensions/apps and can't be created by web pages or service workers. Resolve the TODO by commenting to this effect. Fixed: 1019923 Change-Id: I584288997b2942f05460b725dedc68e2c4f09653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148033 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#758620}
-
chrome://interstitialsKurt Horimoto authored
This CL adds support for the chrome://interstitials WebUI, which contains links for dummy interstitials. Currently only a subset of the available links are implemented for iOS. Bug: 1064803 Change-Id: Ie8fed45623f18319ff1c8a9de5108108a796b2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145154 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#758619}
-
Xiaohan Wang authored
The test has been flaky. See Bug for details. Bug: 1070344 Tbr: kelvinjiang@chromium.org Change-Id: I106784d25661a04c6cf7340d349e3d8a8785f212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146299Reviewed-by:
-
Carlos IL authored
The test in this file checks the SB reporting API is called when an SSL interstitial is shown or clicked through, but checks the non committed interstitials code (and has been disabled for a long time). For committed interstitials this is better checked with a browser test and one already exists (SSLUITest.TestExtensionEvents). Bug: 1026557 Change-Id: I696e628a66341a377130bbc201db9cc25a98a064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145871Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
This reverts commit f5bc3fb9. Reason for revert: causing compile failure, see crbug.com/1070377, or https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/5772 Original change's description: > Reland "Uprev LibAssistant to 1.46s" > > This is a reland of e3f29527 > > Original change's description: > > Uprev LibAssistant to 1.46s > > > > The current LibAssistant branch (1.42c) is no longer maintained, > > and also does not contain the latest features. > > > > * This will only be landed after M83 branches > > * This depends on the internal changes to land first > > > > Note: > > Bug: b/152777569 > > Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617 > > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758408} > > Bug: b/152777569 > Change-Id: I2aa720f229708d8ccfac7656a5d5d41606a13b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147808 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Cr-Commit-Position: refs/heads/master@{#758603} TBR=xiaohuic@chromium.org,wutao@chromium.org,jeroendh@google.com Change-Id: I7a080b04ea9cc03391564ae7c215d72b7ffc2eb1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/152777569, 1070377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145707Reviewed-by:
-
Sreerenj Balachandran authored
If the Video Encode hardware accelerator has support for VP9Profile0 and VP9Profile1, RTCVideoEncoderFactory creates a pipeline for Profile1 which is not supported by blink or webrtc. Moreover, it will mess up the h/w encoder by sending an illegal combination of chroma-subsampling 4:2:0 raw input and a Profile1 config. This patch is trying to address two issues: a) make sure that CreateVideoEncoder return successfully once there is a match found with SdpVideoFormat, otherwise a video-encoder will get created for each supported format and override the previous one. b) Ensure that VEAtoWEBRTCFormat doesn't return a legit profile id for VP9 profile1 otherwise, SupportedFormats will get populated with wrong sdp_formats against VideoCodecProfile. Webrtc supports profile0 & profile2. BUG = b:153680337 TEST = Run https://appr.tc/?debug=loopback&vrc=vp9&vsc=vp9 on a platform that has more than one profile encode support for VP9. H/W encode will fail and fall back to the software encoding. Change-Id: Ic779375d98fb56d9a1509e042faedfa002f9bf29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146173Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Cr-Commit-Position: refs/heads/master@{#758615}
-
Katie D authored
Updates colors, fonts, sizes to match new Live Caption spec. Adds a title per spec which is shown when the caption is only one line high. Sets the max width of the bubble, but does not yet dynamically resize. Note that the bubble is still too tall because it shows a close button. Per spec we will probably move this close button out later, but leaving it in for functionality during testing. Bug: 1055150 Change-Id: I5f4a3fa0b218f5c8a4b50fb0fedb8d4a1547f44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144813Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#758614}
-
Xianzhu Wang authored
We should do this regardless of the box's scrollability, because we create a scroll node for the root scroller even it's not scrollable. Previously a root scroller without ScrollHitTest caused mistaken main thread scrolling because the scroll node for the root scroller didn't have a corresponding cc::Layer [1]. [1] https://source.chromium.org/chromium/chromium/src/+/master:cc/trees/layer_tree_host_impl.cc;drc=3acc95496c515d8c58aa6fff63ac7da5455e9eb5;l=3723 Bug: 1041322 Change-Id: Idd6841b87f3e0a101746d0dca15e5eba19cc77a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143511 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758613}
-
Hirokazu Honda authored
Temporal and spatial layer encoding configuration has been refused in RtcVideoEncoder (VEAClient for webrtc). crrev.com/c/2131444 starts to propagate the configuration to VEA so that each VEA judges if they are supported. As VaapiVEA and V4L2VEA support neither temporal nor spatial layer encoding currently, this CL modified their Initialize() to fail if such mode is requested via the Config parameters. Bug: 1030199 Test: HW decoder and encoder is used in appr.tc on shyvana Bug: vea test on shyvana Bug: media_unittests --gtest_filter=VaapiVEA* on shyvana Change-Id: Ic5501230e1d1f82bb20901915c264d1c67691061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132007Reviewed-by:
-
Philip Rogers authored
Backdrop-filter should create a containing block for fixed and absolute position except for the root[1]. Will-change: backdrop-filter should do the same[2]. [1] https://drafts.fxtf.org/filter-effects-2/#BackdropFilterProperty [2] https://drafts.csswg.org/css-will-change/#will-change Bug: 960953 Change-Id: Icaddd0ad44cc64a146233ed6e793ea2b295c3b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147510Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758611}
-
Mohit Hotwani authored
Reboot shared library needs to be initialized before using. Bug: internal b/153597183 Change-Id: I8cf6b28a85aec274e3561367a2d7d0aafe1d5f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146074Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Mohit Hotwani <hmohit@chromium.org> Cr-Commit-Position: refs/heads/master@{#758610}
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I9e7d8857b9606ee5db57e22482a3557ea2343f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147549 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#758609}
-
Nate Fischer authored
This always shows the icon on L-M (because "report a bug" is still useful), and just hides the "switch WebView provider" menu option. Bug: 1070306 Test: Manual - launch on L-M and verify menu has "report bug" option Change-Id: I6baf14fcaa39d1f76decdb3214d2414d779b0750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147871Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#758608}
-
dpapad authored
Fixed: 1064234 Change-Id: I608d1b2a0b824bde5c430bc85df3323dd42ece49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147848 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758607}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I6d394f94447293853f2ea2f4bdc116f2bf7a5802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147793Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#758606}
-
Mohit Hotwani authored
The crash uploader applies a rate limit to handling crash reports. If the upload fails, it retries the upload, and the rate-limiter treats the retry as another crash. This stops it from treating a retry as another crash. dumps so that the crash uploader can't read them. Bug: internal b/153742798 Test: cause upload failures by changing the permissions of the crash Change-Id: I4d09b90e97b9ff24cc68308219049faf6aa3371d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147801Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ecd82d832f4f..f3953d04a0b8 git log ecd82d832f4f..f3953d04a0b8 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 robertphillips@google.com Non-substantive GrText-related changes 2020-04-13 csmartdalton@google.com Add a cap for when dual sided stencil refs and masks must match 2020-04-13 jvanverth@google.com Clean up GrVkStencilAttachment 2020-04-13 jvanverth@google.com Add GrD3DStencilAttachment Created with: gclient setdep -r src/third_party/skia@f3953d04a0b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ieb97cd24033898492f5239b7ff6eecbce676229d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758604}
-
Jeroen Dhollander authored
This is a reland of e3f29527 Original change's description: > Uprev LibAssistant to 1.46s > > The current LibAssistant branch (1.42c) is no longer maintained, > and also does not contain the latest features. > > * This will only be landed after M83 branches > * This depends on the internal changes to land first > > Note: > Bug: b/152777569 > Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617 > Commit-Queue: Jeroen Dhollander <jeroendh@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758408} Bug: b/152777569 Change-Id: I2aa720f229708d8ccfac7656a5d5d41606a13b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147808Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#758603}
-
chrome://flags/#enable-unsafe-webgpuKai Ninomiya authored
Bug: 852089 Change-Id: Ic327c81818932cd8647c9d66d6c3718aad87eb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147858Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758602}
-
Kurt Horimoto authored
This interface returns the additional standard and secure schemes added by web::RegisterWebSchemes() so that these schemes can be used in the test process for EG2 tests. Bug: none Change-Id: Id02340bc11bc725ecc2c9b802455b8d669ec2b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144840 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Hesen Zhang authored
Bug: 1068368 Change-Id: I1a2da9a32a71537abb3fd3626ef2614dcd24e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145703 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758600}
-
Jon Mann authored
This marks the expired and unused ConnectivityDiagnostics.HTTP_LATENCY, ConnectivityDiagnostics.TestVerdict.*, and ConnectivityDiagnostics.TimeTaken.* histograms as obsolete. Bug: 1036994 Change-Id: Ie401ccf40fe4211d0b28e7dc21b5acdc11af95bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147835Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#758599}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/6812621f27e9..533a31d92b64 git log 6812621f27e9..533a31d92b64 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 jophba@chromium.org Move ARM64 bot back from stretch to sid Created with: gclient setdep -r src/third_party/openscreen/src@533a31d92b64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I4957adb586ffc4edf8ec22cdf9802578319c1314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147899Reviewed-by:
-
Bettina authored
The wording is confusing to translators due to "fingerprint" in PasswordProtectionChangePasswordUrl does not mean an actual fingerprint. Bug: 1064036 Change-Id: I4d6184a29c4ef22043f4de03d38cdeaa5070ecbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116151 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#758597}
-
Doug Arnett authored
This is a subset (2nd of 3) of a large change proven out in CL 2117459. Its focus is to maintain the existing ContentTranslateDriver code as much as possible for patch-ability while adding a PerFrameContentTranslateDriver that is meant to replace it in the future. [Update: there will also be a follow-up CL to move the CLD3 language detection work into a sandboxed utility process.] The overall change description: This conditionally will perform language detection in the browser process using Accessibility apis to get page contents in order to determine language from subframes as well as main frame and then supports translating subframes in addition to the main frame. This new behavior is available when Feature "TranslateSubFrames" is enabled; otherwise, the existing language detection (using WebFrameContentDumper) and main frame translation support is preserved (in the spirit of the current guidelines against refactors). Bug 1064974 tracks follow-up clean-up tasks for the duplicated code in this CL once the feature is launched (once refactors encouraged again). Bug: 797328, 1063520 Change-Id: I98b21af2d32285cb0ceb61672ad7140fc21e40d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141217Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#758596}
-
Greg Guterman authored
Background: http://g/chrome-browser-core-engprod/ItUSl2yOxIM Bug: 1069975 Change-Id: I7f2735563d74408df5200a932ded5e3a82d291da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146236Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#758595}
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I5aa8ae5036e7a9341da32b6d27317e2f5c30580d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147807 Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: I9a9545c5aaedad66ff5b455b27111c714aa9c773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146936 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#758593}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04ab397e8e8a..449545fd382b Created with: gclient setdep -r src-internal@449545fd382b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Icf1ed6ec61c4aa322596a15236394a5af499429c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147078Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758592}
-
Filip Gorski authored
Bug: 1070272 Change-Id: I2631365c7032c054addfb5a14de73f865d95523f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147842Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#758591}
-
Dominic Mazzoni authored
It always returns true, because we never keep a BrowserAccessibility alive when its corresponding AXNode* is destroyed. In the past when platform objects directly inherited from BrowserAccessibility we needed to worry about an object being alive but inactive, but that can't happen now. Note that it *is* possible for an AXPlatformNode to be alive but detached / inactive. Follow-up to http://crrev.com/c/2141047 and http://crrev.com/c/2130631 Bug: None Change-Id: I30b731b7fc8e63e8a373cf559119c197e3bd5a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146334Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758590}
-
Wei-Yin Chen (陳威尹) authored
This CL also increases the instruction coverage of ReaderModeManager.java from 62% to 87%. Bug: 1070293 Change-Id: I11af0f524cd01d0741f9a6c9f4ca17b51c2c145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143675 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#758589}
-
Katie D authored
* No HTTP or HTTPS in steady state * Editing returns HTTPS into view (but does not restore HTTP) * Focusing and hitting enter goes to original URL without downgrading HTTPS users This makes the behavior of reader mode page URLs in the omnibox appear the same as the behavior on their original pages. Bug: 992073 Change-Id: Ic8f8f75545e0aaf3562190908f8136c7b04351eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144617 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758588}
-
