- 20 Sep, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f837545214f5..a5ac303c5308 git log f837545214f5..a5ac303c5308 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a5ac303c5308 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If57dd96856740a4bbcbc96f8733961ea938d35c0 Reviewed-on: https://chromium-review.googlesource.com/1236878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592889}
-
Joey Arhar authored
Bug: 879219 Change-Id: I6cf01b36326a8b7727a870f2f7e2d061774d1c5b Reviewed-on: https://chromium-review.googlesource.com/1226797Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592888}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /device. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 874080 Change-Id: I1bad5e82040c40aa770c36d3825dfc14dd9aad0f Reviewed-on: https://chromium-review.googlesource.com/1191813Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#592887}
-
Vladimir Levin authored
This patch does two things: 1. Explicitly checks for absolute position object containment where before it was checking for the equivalence of the position attribute. My suspicion is that this is the intent of the check. 2. Makes the paint layer creation or deletion only set the paint property update instead of a subtree update, since it seems that the initial intent was that the local border box properties existence may change. R=pdr@chromium.org, wangxianzhu@chromium.org Change-Id: I9d93020a6f68213b1e4b49731c7b0e0d80c65681 Reviewed-on: https://chromium-review.googlesource.com/1235128 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592886}
-
Michael Spang authored
Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on ozone as well to make sure we have build coverage. Fix chromium.memory/Linux Chromium OS ASan LSan Tests issue by breaking unnecessary dependency on //gpu/vulkan/init. Bug: 887110 Test: compile Change-Id: I298704cf3b199c5c4ecf5173e137293650c5734a Reviewed-on: https://chromium-review.googlesource.com/1235286 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592885}
-
Fuchsia SDK Autoroller authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I422477c3b77a2c1901728108133d8d5df482f182 Reviewed-on: https://chromium-review.googlesource.com/1236477 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592884}
-
Lucas Gadani authored
Since a RenderWidgetHostView is destroyed when a renderer process crashes, it is necessary to null-check it before de-referencing it. This CL is based on nick@'s CL: https://chromium-review.googlesource.com/c/chromium/src/+/956624 Bug: 859215 Change-Id: I029d3615fee56c9cd2287ee816b269338802937c Reviewed-on: https://chromium-review.googlesource.com/1234873 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592883}
-
Drew Davenport authored
This reverts commit 57af9203. After bisecting the changes between the failing and passing pfq runs, the CL responsible for fixing desktopui_MashLogin was CL:1215947 and not the revert of "Use minigbm mmap for modeset buffers" BUG=b:78892556 Change-Id: I07908ca894d9132073c1846277d3e32fa1e7d4a8 Reviewed-on: https://chromium-review.googlesource.com/1235202Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#592882}
-
Johannes Henkel authored
v8_session_ starts out being a nullptr, and the constructor of InspectorSession initializes it. However, this initialization involves calling inspector->connect which calls the inspector session (this) with sendResponse / flushProtocolNotifications. This PR tries to resolve it by guarding v8_session_ for the V8Inspector::Channel methods. Bug: 873811 Change-Id: I8142eb61f9a8f6fb003b9baa0b6222730234ccae Reviewed-on: https://chromium-review.googlesource.com/1235054Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#592881}
-
Li Lin authored
Bug: b:114302330 Change-Id: I2e295a6ac8b3e78ecc92dd7bfba20b2e673cd04e Reviewed-on: https://chromium-review.googlesource.com/1212094 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592880}
-
Eric Seckler authored
This removes BrowserThread::Post(NonNestable|)(Delayed|)Task and moves GetTaskRunnerForThread into the impl (it's still used to vend TaskRunners in BrowserTaskExecutor). These methods have been replaced by base/post_task.h in conjunction with content/public/browser/browser_task_traits.h Bug: 878356 Change-Id: Ia122dc0921769f43da9271ddd6e1ce2f402df779 Reviewed-on: https://chromium-review.googlesource.com/1235728 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ib0b5ea0ad7e4ff08c9d0ae6b65cfd91d9a468a75 Reviewed-on: https://chromium-review.googlesource.com/1236254 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592878}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dd92aa594625..1605351382db git log dd92aa594625..1605351382db --date=short --no-merges --format='%ad %ae %s' 2018-09-20 thestig@chromium.org Remove extraneous 'extern "C"' entries. Created with: gclient setdep -r src/third_party/pdfium@1605351382db The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id2f91863b9ad1d648810f65a15212a46475d5660 Reviewed-on: https://chromium-review.googlesource.com/1236517Reviewed-by:
-
Bin Wu authored
This relands 355a3311 which was reverted in 37c07096, after fixing a stack overflow in QuicUnackedPacketMapTest.CannotAggregateIfDataLengthOverflow. Below is the commit message of the original cl: Landing Recent QUIC changes until 2:35 PM, Sep 14, 2018 UTC-4 Turn on FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans https://chromium-review.googlesource.com/c/chromium/src/+/1228857 Update IETF QUIC Transport Error codes The IETF QUIC transport error codes are updated to reflect version 14 of the QUIC transport IETF draft: - SERVER_BUSY is added - FRAME_FORMAT_ERROR is changed to FRAME_ENCODING_ERROR - UNSOLICITED_PONG is removed - INVALID_MIGRATION is added Merge internal change: 213016352 https://chromium-review.googlesource.com/c/chromium/src/+/1228548 Fix a ACK frame reporting issue caused by unsigned integer wrap around. Protected by flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2. Flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2 is the v2 of the existing flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames. Merge internal change: 212991266 https://chromium-review.googlesource.com/c/chromium/src/+/1228894 Implement support for framing QuicCryptoFrames from IETF QUIC. Merge internal change: 212917548 https://chromium-review.googlesource.com/c/chromium/src/+/1228436 Turn on FLAGS_quic_reloadable_flags_quic_fix_reset_zombie_streams in quartc. Merge internal change: 212810521 https://chromium-review.googlesource.com/c/chromium/src/+/1228435 In QUIC, fix a bug that zombie streams cannot be closed when gets reset locally. Protected by FLAGS_quic_reloadable_flag_quic_fix_reset_zombie_streams. Merge internal change: 212676554 https://chromium-review.googlesource.com/c/chromium/src/+/1228434 Split QUIC's FramerVisitor into two methods, OnAckRange and OnAckFrameEnd(). No functional change, not flag protected. Merge internal change: 212629799 https://chromium-review.googlesource.com/c/chromium/src/+/1228394 Move multiple (repeated) definitions of QuicConnectionArena to a single place in quic_one_block_arena.h. Move only, not protected. Merge internal change: 212626492 https://chromium-review.googlesource.com/c/chromium/src/+/1228393 Change-Id: I735a825502eaf03eb465a58a67bfcf89d9e5e069 Reviewed-on: https://chromium-review.googlesource.com/1236733 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#592876}
-
Mike Wasserman authored
Do not construct a stub InputMethodKeyboardController, check for null. Also cleanup StubInputController decl and use NOTIMPLEMENTED_LOG_ONCE. Bug: 881475 Test: No functional changes, less debug log spam. Change-Id: Ib8db1778f1ae09227bf559f1bb2fe6ac752649d2 Reviewed-on: https://chromium-review.googlesource.com/1222349Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#592875}
-
Jian Li authored
We should check if current activity is ChromeActivity in UpdateOfflineIndicator to avoid wrong cast in HideOfflineIndicator later when activity is not. Bug: 886537 Change-Id: Ic7bca23b26d396651efb0b47d3c325c8bd7a89b5 Reviewed-on: https://chromium-review.googlesource.com/1235375Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592874}
-
gogerald authored
Will style it more in the upcoming CLs Screenshot https://drive.google.com/file/d/1h50bgzIvVkZMjsjbYDel97P1JrBfWDj4/view?usp=sharing Bug: 806868 Change-Id: Ib6ba1d040302b90f36bcd16726fca833b1f1b167 Reviewed-on: https://chromium-review.googlesource.com/1234020 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592873}
-
Clark DuVall authored
This flag was used in a canary finch experiment to make sure there was not a regression in Variations.SeedFreshness. The experiment shows no change, so enabling the new behavior: https://uma.googleplex.com/variations?sid=5356f4f970495339c96d6af50868accf Bug: 868021 Change-Id: I6f756be28a89226ef596c12cb09b032f2e672a75 Reviewed-on: https://chromium-review.googlesource.com/1222286 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#592872}
-
Becky Zhou authored
We need to detach the MarginResizer so that it doesn't hold onto any Stream related object such as HeaderViewHolder. Bug: 884906 Change-Id: Icf2dd3e367735185f5d08378651e6a16667729ac Reviewed-on: https://chromium-review.googlesource.com/1235016 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6e2dab2ffd46..9bfe0eb25e3d git log 6e2dab2ffd46..9bfe0eb25e3d --date=short --no-merges --format='%ad %ae %s' 2018-09-20 antiagainst@google.com Wrap tests needing effcee inside SPIRV_EFFCEE Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9bfe0eb25e3d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5da1ed460b08714caae3aee7f4fffbd4c2c209b7 Reviewed-on: https://chromium-review.googlesource.com/1236875Reviewed-by:
-
Egor Pasko authored
TBR=perezju@chromium.org Bug: 887546 Change-Id: Ia96997eb631402aab7f5fe1ad4ede733d383969d Reviewed-on: https://chromium-review.googlesource.com/1236278Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592869}
-
Dmitry Gozman authored
Bug: 841739 Change-Id: I6e61a5c11253096d80aeafb4b83ce653fbcfa0f0 Reviewed-on: https://chromium-review.googlesource.com/1235119 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#592868}
-
Adam Kallai authored
It used 'json' output-format which is not supported. This change intents to removes 'json' output-format from the options in order to fix an invalid format assert. Add self to AUTHORS Change-Id: I3c7ea4ff54cb23dbadbce57e0e41d4fefc97de54 Reviewed-on: https://chromium-review.googlesource.com/1136639 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#592867}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /gpu. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=piman@chromium.org Bug: 874080 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I94991868b2383b0f5b359399ea97597518ebea7f Reviewed-on: https://chromium-review.googlesource.com/1191410Reviewed-by: -
Nicolas Pena authored
Per discussion with tdresser@, add an OWNERS file. We'll add more reviewers over time and as needed. Also while at it, rename progressive-web-metrics to speed-metrics-dev, see: https://groups.google.com/a/chromium.org/forum/#!topic/speed-metrics-dev/hPP-T56fUvE Change-Id: Ic48b3970393c558b3ade0334891bf1485d6b5e1f Reviewed-on: https://chromium-review.googlesource.com/1231395Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#592865}
-
Scott Violet authored
In hopes of having base::debug::Alias work better on ChromeOS. BUG=867035 TEST=none Change-Id: I509efc3bcafe71beaa86c9f5180043255e3ec3db Reviewed-on: https://chromium-review.googlesource.com/1219889Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592864}
-
Javier Ernesto Flores Robles authored
Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie114d9a6d540ee69a085024b023de70047578223 Reviewed-on: https://chromium-review.googlesource.com/1230679 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592863}
-
Luke Sorenson authored
Bug: chromium:887533 Test: No test necessary. Change-Id: I9fb495308c2f64796dd529fc1fcfec795957d042 Reviewed-on: https://chromium-review.googlesource.com/1236734Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#592862}
-
David 'Digit' Turner authored
Add a way to detect system libraries, and fallback to the system linker whenever they need to be loaded. This is needed because Chrome probes a few system libraries like libEGL.so to check that certain GL-related symbols are available. It does that by using dlopen() + multiple dlsym() + dlclose(), which end up being performed through the crazy linker wrappers (e.g. WrapDlopen()). When enabling the crazy linker, it seems this happens everytime the user navigates to a different web page! Due to the way the code works before this CL, this ended up loading said system libraries with the crazy linker, which is problematic because: - If the system library was already loaded in the Zygote, this would create a duplicate copy, loaded at a different address. Also this is much slower than simply incrementing the reference-count of an existing system library entry. - This creates pending RDebug-related tasks, which happen to be racy, and the source of runtime crashes. By detecting system libraries properly, the code can now always fall back to use the system linker to load them, avoiding these two problems entirely. In particular, it is hoped that this will decrease the amount of runtime crashes described in 831403. BUG=843987,831403 R=pasko@chromium.org, agrieve@chromium.org, rcmilroy@chromium.org Change-Id: I86d89d6a812b778cf962aa5da028449b2b79f1fa Reviewed-on: https://chromium-review.googlesource.com/1236656Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#592861}
-
Steven Bennetts authored
This reverts commit 09a198c9. Reason for revert: <INSERT REASONING HERE> Original change's description: > KeyboardController: Integrate code from keyboard_util.cc > > This CL: > * Moves KeyboardConfig and the global instance and setter/getter to > KeyboardController > * Moves KeyboardControlEvent and LogKeyboardControlEvent to > KeyboardController (which is the only consumer) > * Moves KeyboardOverscrolOverride and SetKeyboardOverscrolOverride > to KeyboardController > * Removes keyboard::IsKeyboardVisible (only one non test call which > already checks enabled() separately) > * Moves InsertText to KeyboardController > * Makes some changes to KeyboardController to improve alignment of > header definitions and implementations. > * Removes keyboard_util.h from keyboard_controller.h and removes > unnecessary keyboard_util.h includes. > > For trivial code removal from component_loader.cc: > TBR=benwells@chromium.org > > Bug: 843332 > Change-Id: I5226380a80bba1286b36d5d68c5e30c74f4cd9ad > Reviewed-on: https://chromium-review.googlesource.com/1225853 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592483} TBR=jamescook@chromium.org,stevenjb@chromium.org,shuchen@chromium.org,shend@chromium.org Change-Id: Id568f0bdc20c3093f6757c644a6a9b8311f06e3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236841Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592860}
-
Steven Bennetts authored
This reverts commit c1e2f785. Reason for revert: desktopui_MashLogin is crashing Original change's description: > Remove KeyboardController::ui() > > This removes direct access to KeyboardUI outside of tests while > the code is re-factored for Mash. > > Bug: 843332 > Change-Id: Ic6b60032512b36b7ff1ae05bb8d12060db8f8d29 > Reviewed-on: https://chromium-review.googlesource.com/1227171 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592526} TBR=jamescook@chromium.org,stevenjb@chromium.org,shuchen@chromium.org,shend@chromium.org Change-Id: I2708807e60023d952792e96ac58841c89a0353bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236465Reviewed-by:
-
Steven Bennetts authored
This reverts commit cedf185f. Reason for revert: Crashes in desktopui_MashLogin Original change's description: > keyboard_util: Remove flag/switch wrappers > > This CL moves some common flag/switch wrappers into the callers to > remove unnecessary dependencies on keyboard_util.h. With the upcoming > Chrome/Ash separation, the wrappers cause more confusion than they > improve readability. > > This CL also moves some keyboard_util.cc code only used in > KeyboardController to that class. > > Bug: 843332 > Change-Id: I042928bebfe4f9ea93ccb4fb7a24f8fc46f555cf > Reviewed-on: https://chromium-review.googlesource.com/1226191 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Shu Chen <shuchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592545} TBR=stevenjb@chromium.org,shuchen@chromium.org,shend@chromium.org Change-Id: I0875394e434c6beeceb11e93a64b16f1a5a42b7c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236466Reviewed-by:
-
Dominik Röttsches authored
Fallback to FreeType on Mac OS < 10.13 as there is no support for COLR/CPAL layered fonts in CoreText before this version. Bug: 882844 Change-Id: I80ed16d1e6e23ee36dd5ad179e7712a53381e7c4 Reviewed-on: https://chromium-review.googlesource.com/1235995 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#592857}
-
yileili authored
This is a reland of c9b5d530 The internal repo uprev has landed in public HEAD. Original change's description: > Refresh access token only for auth error. > > Bug: b:114756954 > Test: Manual > Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 > Reviewed-on: https://chromium-review.googlesource.com/1226527 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592467} Bug: b:114756954 Change-Id: I695953226bfaea3f332cccb7b61a98be2c541297 Reviewed-on: https://chromium-review.googlesource.com/1235330Reviewed-by:
-
dpapad authored
These seem to have been fixed at r591110, but they were not properly re-enabled. Bug: 875452 Change-Id: Icdab27f5afd81a8e8c2c7a30b1ab76ec05ee8d8e Reviewed-on: https://chromium-review.googlesource.com/1235285Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592855}
-
Mark Cogan authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I785464f847ff6344201a5ac8f7aa2a6a1aa2f3f5 Reviewed-on: https://chromium-review.googlesource.com/1233701 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#592854}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/52c63fdabb72..7b11354810a9 git log 52c63fdabb72..7b11354810a9 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 mtklein@google.com add a bot that oughta fail Created with: gclient setdep -r src/third_party/skia@7b11354810a9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic05e70f49f6496ad6ff979829f7be1a2d6b7dc16 Reviewed-on: https://chromium-review.googlesource.com/1236513Reviewed-by:
-
Steven Bennetts authored
This reverts commit 2457438e. Reason for revert: desktopui_MashLogin is still failing Original change's description: > Mash: Protect virtualKeyboard events for null KeyboardController > > Currently the code is triggering a crash indesktopui_MashLogin: > http://ubercautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/239691238-chromeos-test/chromeos4-row2-rack3-host12/debug/ > > Bug: 843332 > For extensions change: > TBR=benwells@chromium.org > > Change-Id: I51d94a6924407fffbb49994ff4cb02718b517866 > Reviewed-on: https://chromium-review.googlesource.com/1235206 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592620} TBR=jamescook@chromium.org,stevenjb@chromium.org Change-Id: If44890c68926d991d4642fde4566408b6ce57fa0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843332 Reviewed-on: https://chromium-review.googlesource.com/1236837Reviewed-by:
-
Kyle Milka authored
Bug: None Change-Id: Ie03079ca73e9e2593b73ff0e17e13c47bc077d3e Reviewed-on: https://chromium-review.googlesource.com/1231987Reviewed-by:
-
Antoine Labour authored
This reverts commit 1e9e40b7. Reason for revert: crbug.com/887263 and crbug.com/887398 Original change's description: > Use SharedImageInterface for gpu and OOP raster > > This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster. > This also adds memory accounting in SharedImageFactory/SharedImageStub. > > Bug: 870116 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I37eba221bc2aeb4d03b7d4d93bde772482dc681b > Reviewed-on: https://chromium-review.googlesource.com/1178977 > Commit-Queue: Antoine Labour <piman@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592419} TBR=sadrul@chromium.org,boliu@chromium.org,piman@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870116 Change-Id: Ie4fbd60787c6fc3cefbc695595bc80234be6cfc1 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1236457Reviewed-by:
-
