GitLab

Fuzzer caught a NULL deref crash. Running with DCHECK,
found a problem before the deref, we were cloning
LayoutNGInsideListMarker inside LayoutInline::SplitInlines.
This was triggering a DCHECK in LayoutInline::Clone.

I am not very familiar with how LayoutInline line splitting
works. I have a patch created with my shallow understanding
that fixes the crash, but I am not sure if this is the
right thing to do.

Bug: 962242
Change-Id: I11e4cf3307c257e7c396b4112888bad0cd76ac5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610522
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659286}

This CL verifies we are not laying out when analyzing metrics elements.
A lifecycle observer is used to wait to record and send metrics until
the lifecycle is not in the middle of layout.

Subframe anchors do not record size metrics anymore.

Bug: 957026
Change-Id: I1fe67350d2c5c800697e412b4604b760fce2f859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592323Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659285}

Refactors all the classes in wmr_input_manager.h,
wmr_holographic_frame.h, and wmr_holographic_space.h in the same way as
crrev.com/c/1603748.

Bug: 961020
Change-Id: Ie4dc432823cfdbe506d2616fb9005ce5392035e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610592
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659284}

The clicked element will no longer report its size (or relative size) to
the browser/UMA. Instead, we plan to see if it is in the Anchors
reported on load. Its size would only be valuable if we knew about the
anchor from OnLoad.

Bug: 957026
Change-Id: I59a98348fd0d58a4dd1a99bd86c2720b36f1af88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602773
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659283}

Looks like this is broken in production, and almost no one noticed. We
also want to drive down FTP use in Chrome so that we can eventually
remove it. It's insecure (which is particularly concerning when
downloading files), and requires a lot of code, increasing potential
attack surface area.

Bug: 925531, 960607
Change-Id: I56792700f913f0af2562cfabec7fa27ea5f444fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606822
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659282}

Add the media metadata to the AX data so that it can
be picked up by a screen reader.

BUG=962682

Change-Id: I78a0d5c09c13450d5486c94b7d04b5fa36cce9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610028
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Auto-Submit: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659281}

At current version there is race that prevents setting default app pins
correctly for the new user.

Following happens:
  * Start new user in Chrome
  * App sync starts asynchronously and flashed existing apps with
    default unpinned state for each app.
  * Chrome is restarted automatically
  * At new session Chrome shelf is activated.
  * Default pins are created.
  * App sync starts asynchronously again and pins on previous step are
    lost.

This CL makes applying default shelf pin explicit and under the strict
rules.
 * Reserve sync preference to store rolled default pin layout.
 * Wait until App sync either started or works locally in case
   disabled.
 * Wait until preference to store rolled shelf pin layouts is synced or
   works locally in case 'settings' sync is disabled.
 * When conditions above are met and requested shelf pin layout was not
   rolled, apply default shelf pin layout.

This also adds possibility to roll custom layout.

There is a drawback of this CL that few apps might re-appear on user's
shelf in case they were explicitly unpinned in past. (Gmail, Google Docs,
Youtube and Play Store)

TEST=Locally
BUG=958988
BUG=958389

Change-Id: I980660d359ec496592ba67d245c5101888f08883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606563
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659280}

The present CL is for the animation of the divider and its white handle,
when split view is activated by dragging a window, if the window is not
minimized and the dragging is not tab dragging. The animation is based
on:
https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop

The present CL deviates from the specification in an edge case as shown
in the video linked in Comment 14 here:
https://bugs.chromium.org/p/chromium/issues/detail?id=934977#c14

See how the divider moves toward the side of the screen where the window
is snapped, whereas the mockup shows the divider moving away from that
side of the screen. The specification says that the white handle shall
spawn from "2dp off centerline of divider (in direction of drop)," which
in this case is 2dp to the left of where the divider spawns from. Then
the divider would pass through the point where the handle spawns.
Because that seems wrong, where the specification says "in direction of
drop," I instead use the direction from which the divider spawns, as you
see in the video.

chrome://flags/#ui-slow-animations affects the divider but not the white
handle, because the white handle uses SlideAnimation. The flag therefore
desynchronizes the spawning animations, but fortunately, the video
referenced above opens in a player where playback speed can be adjusted.

Test: manual
Bug: 934977
Change-Id: Ide325c36c939fbf4af07b878811207c79afc206c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601368Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659279}

This reverts commit ae792bea.

Reason for revert: Broke build
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913531942624945040/+/steps/compile/0/stdout

Original change's description:
> [Files Ranking] Add a new Dolphin model for zero-state ranking
> 
> This CL adds a new Dolphin model to the search result ranker for zero
> state files ranking. Additionally, it:
> 
> 1. Adds a new Finch flag to guard the construction of the model.
> 2. Adds/renames some getters/setters for consistent naming: the app
>    model is an AppSearchResultRanker (Roselle) object, and the non-app
>    model is a SearchResultRanker (Dolphin) object.
> 
> This CL also makes a small change to the SearchController's members:
> the Mixer is moved above the SearchProviders. This is because, in
> future CLs, a search provider will hold a pointer for a model owned
> (indirectly) by the Mixer, and this ensures the model outlives the
> provider.
> 
> Bug: 959679
> Change-Id: Ib101463c61ed79657e380870eeb749e08188a131
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604387
> Reviewed-by: Jenny Zhang <jennyz@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Jia Meng <jiameng@chromium.org>
> Commit-Queue: Tony Yeoman <tby@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#659273}

TBR=xiyuan@chromium.org,jennyz@chromium.org,jiameng@chromium.org,tby@chromium.org

Change-Id: Icebce6483275b23d55621d75bff1b85a7dbf1038
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 959679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609587Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659278}

Previously extensions::Dispatcher::GetJsResources() relied on a manually
specified boolean which had to be kept in sync with a grd file's
compress="gzip" attributes (only leveraged by IDR_MOJO_MOJO_BINDINGS_JS).

This is no longer necessary since ResourceBundle::IsGzipped() can be used
to determine if the file is gzipped or not.

Basically this CL undoes a subset of the changes introduced at r516811.

Bug: 961063
Change-Id: I03740235f2c0ee62c9f406be336fa524e89d2d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602132
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659277}

Using wpt-import in Chromium 9ef8c134.
With Chromium commits locally applied on WPT:
c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed"
fec827fb "Added wpt tests for overscroll customization."
c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet"
d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Iaae22642525237c35e67ad11f3afe2156f0f2d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610880Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659276}

Only pause/freeze realtime audio destinations. Offline destinations are
controlled by the thread scheduler itself for pausing/resuming tasks.

BUG=959191

Change-Id: Ie92111af53e651d9d7d3f193921a504935af9c1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604493Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659275}

Change-Id: Ifafd8ad395939011ce9d48e39d04a8d3fcda90cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610849Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659274}

This CL adds a new Dolphin model to the search result ranker for zero
state files ranking. Additionally, it:

1. Adds a new Finch flag to guard the construction of the model.
2. Adds/renames some getters/setters for consistent naming: the app
   model is an AppSearchResultRanker (Roselle) object, and the non-app
   model is a SearchResultRanker (Dolphin) object.

This CL also makes a small change to the SearchController's members:
the Mixer is moved above the SearchProviders. This is because, in
future CLs, a search provider will hold a pointer for a model owned
(indirectly) by the Mixer, and this ensures the model outlives the
provider.

Bug: 959679
Change-Id: Ib101463c61ed79657e380870eeb749e08188a131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604387Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659273}

LoadDataWithBaseURL is never subject to --site-per-process policy
today, since this API is only used by Android WebView where OOPIFs
have not shipped yet.  Therefore, skip the test in --site-per-process
mode to avoid renderer kills which won't happen in practice.  This
should fix the current failures of this test on Site Isolation FYI
bots.

Bug: 962643
Change-Id: I6a5e721f0402a764d03e291aa920660c53af39e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610940
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659272}

Change links pointing to old expectation's files and folders to links pointing
to new expectation's files and folders.

Bug: chromium:698902
No-Try: True
Change-Id: Icbf5220c12b303c838a3ae2a60de95b2b63a4015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606966
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659271}

Bug: 962381, 962386
Change-Id: Ide420cf85b90b11e1b255db279f703a570fec9f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609670Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659270}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58d7304e63dc..23a97021347c


Created with:
  gclient setdep -r src-internal@23a97021347c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=anthonyvd@google.com,alph@google.com,battre@google.com

Change-Id: Ia5c8e24dd7b4f7da9c1fb12f50f30afd719204ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610351Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659269}

This CL makes modifications to the architecture of the RecurrenceRanker
and RecurrencePredictor to:

 1. Allow for better API support for targets and conditions.
 2. Store all target and condition strings in the Ranker, and only pass
    IDs to the predictors.
 3. Modify the ZeroStateFrecencyPredictor to work with IDs instead of
    strings.

This will have several follow-up CLs:

 1. UMA logging for various error cases, eg. proto serialisation
    errors.
 2. Cleanup logic for the ZeroStateFrecencyPredictor.
 3. A general conditional predictor for use with query-based
    predictions.

Change-Id: I86e38c28738adf7d5115d1dcd3b5953fab739ebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534583Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659268}

This change adds a confirmation step when creating resident credentials
with Windows Webauthn DLL version one (currently in 19H1). This version
requires the use of native APIs for interaction with security keys, but
doesn't show a notice informing the user that creating a resident
credential will store information on their security key.

However, such a notice is a privacy requirement and therefore a
confirmation step is added prior to dispatching the API call.

Bug: 941120
Change-Id: Ia39aefe7e2b294a604346a66851dbda67372bd63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601299Reviewed-by: Martin Kreichgauer <martinkr@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659267}

And use error code key in app list responses expected by the fetcher.
(Error code instead of Error Code).

BUG=None

Change-Id: Ic77ab9d2e7eef7b1cdf4cd55f6879835a4ae7a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607127Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659266}

https://chromium.googlesource.com/catapult.git/+log/e33ee3bd7c70..114240247a61


git log e33ee3bd7c70..114240247a61 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 rmhasan@google.com [Trace] Fix flakiness in telemetry_tracing_agent tests
2019-05-13 jbudorick@chromium.org Raise timeout for system_app_devicetest PullFile invocation.


Created with:
  gclient setdep -r src/third_party/catapult@114240247a61

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:960609
TBR=skyostil@google.com

Change-Id: I234bfa7b8bd5de1deba70d189fac2d8dc5f110c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611002Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659265}

https://skia.googlesource.com/skia.git/+log/2b8b06e79309..8fae51b699a6


git log 2b8b06e79309..8fae51b699a6 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 herb@google.com Introduce SkStrikeSpecStorage.
2019-05-13 robertphillips@google.com Standardize DDL images to RGBA
2019-05-13 michaelludwig@google.com Use per-edge AA flags to respect mixed AA between clip and draw
2019-05-13 robertphillips@google.com Revert "Remove some uses of GrBytesPerPixel"
2019-05-13 robertphillips@google.com Remove some uses of GrBytesPerPixel


Created with:
  gclient setdep -r src/third_party/skia@8fae51b699a6

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:957946
TBR=michaelludwig@google.com

Change-Id: Ie2d959605e212b32f8f3f0aa423dc95c15bba56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659264}

This is a preparation of https://chromium-review.googlesource.com/c/chromium/src/+/1608381
and https://chromium-review.googlesource.com/c/chromium/src/+/1608088
which use PhysicalRect, PhysicalOffset and PhysicalSize in more places.

Change-Id: I86dcc5701716ea0bc2775636685460f7b3a6533c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607512
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659263}

Use View's property for these two member variables in MdTextButton.

TBR=cjgrant@chromium.org,derat@chromium.org
BUG=957270

Change-Id: I4d06fad56f0f48f88be184847851bfed9e94c4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609614
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659262}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ccf1a17964ab..4e4b7dee3c41


git log ccf1a17964ab..4e4b7dee3c41 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 alevkoy@chromium.org Mark moblab-generic-vm experimental
2019-05-13 mikenichols@chromium.org chromeos-config:  Disable build affinity for CQ builders
2019-05-13 saklein@chromium.org scarlet-pre-cq: Use -chrome_internal.


Created with:
  gclient setdep -r src/third_party/chromite@4e4b7dee3c41

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Change-Id: I8be8e88bbec9b4fa1c00e8810591283c89dbb676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659261}

crrev.com/c/1604427 removed the result field from the heartbeat reponse
and made set_interval_seconds take its field. However, the server side
change didn't take effect on time so the host still sees the 'SUCCESS'
result and interprets it as a 1s heartbeat delay, which is too frequent
and thus a "tarchycardia".

This CL prevents future host tarchycardia by enforcing a minimum
heartbeat interval on the host.

Bug: 954695
Change-Id: I87b3a52bafa17dd46246b4f488e4478d7884e91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610852Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659260}

When a.com embeds a PDF in b.com, {embed, object}.postMessages sends the
messages from a.com to the WebRemoteFrame corresponding to the GuestView.

On the browser side, the target RenderFrameHost is determined to be the outer
WebContents's frame that is used to attach MimeHandlerViewGuest. This means
at the end of routing, the IPC ends up going to a dead RenderFrameHost (dropped
on the way since there is no RenderFrame to handle it).

This CL fixes this issue by a) checking if target RenderFrameHost is live, and
b) if not try to find an inner delegate or drop the message.

Note that this CL fixes several tests which currently fail (or timeout) with
--enable-features=MimeHandlerViewInCrossProcessFrame (the list of such tests
is included in the linked bug). This CL fixes some of those tests and together
with https://crrev.com/c/1607425 should make most tests including all of the
PDFExtensionTest* pass (with the flag).

Bug: 961786
Change-Id: I876b971f40d54f3386e23b9750420bbfc1bbbe01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606769
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659259}

This should help investigating a recurring crash (see linked bug).

Bug: 957121
Test: none
Change-Id: I78f30855201ebd9fb4d8d1738131f5c2308f1e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586227
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659258}

Bug: 960564, 900188
Change-Id: Ie4650b0aa9d57a9932a6b2cace8ca46a01fa4130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601687Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659257}

The main goal is to avoid session start delay while chrome is
attempting to fetch fresh child user's policy. The user session manager
implements fetch timeout (so tests pass without this), but waiting for
it adds some 10s to test login.

To fix this:
*   have login manager mixin mark child users as requiring policy
*   add support for configuring policy test server (in addition to
    session manager cache) to user policy mixin
*   add utility method to fake gaia to setup child user credentials
    (needed as policy fetch will be blocked on getting policy
     auth token)

Bug: None

Change-Id: I5a2e65a4cbf1e9ce192fb0ac750a1661f895e462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602153Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659256}

Bug: 931843
Change-Id: I585768f94c6b71558b35b0a1598bb1bc65cc6f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610571Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659255}

Also skip lofi fallback test in M74, that fails due to server support
removed.

Bug: 934875
Change-Id: Ic5d0d00d63d95cf458e0afc3eaf0a3cf16743c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611078Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659254}

This CL add a check to properly populate fullscreen option.

Bug: 942156
Change-Id: I8227a91cac36c57ff1f63065af8cea72f34ee344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610585Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659253}

Follow up for issue 959125 where we add a test for an AudioWorklet to
verify that if a source connected to an AudioWorklet stops, the
AudioWorklet still continues to call process.

Bug: 960590, 959125
Test: the-audioworklet-interface/simple-input-output.https.html
Change-Id: I3db82c29737c084c576d81bd067741ca5e1845ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600406Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659252}

Change-Id: If951059de8e60009df6a3f4b9075bdda56dd761e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604042
Auto-Submit: Lakshman Annadorai <lakshmana@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659251}

This CL changed the way how we handle conversion failures from strings.
Instead of using the default values, this CL returns 'false' to indicate
the conversion errors. This returned result is useful in case we need to
handle more complex type conversions such base::optional type.

Also, this CL simplify the type converter function definitions since we
only need to and from string conversions, not between arbitrary two
types.

BUG=938501

Change-Id: I1e6d8510c39a9a240161aa0b36c2141ab62ed0e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606772
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659250}

Bug: 927840
Change-Id: I97ca518d172c0e208b0d8828c2c73d78c0b4523a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610223Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Auto-Submit: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659249}

https://pdfium.googlesource.com/pdfium.git/+log/3475b482fefa..b2d0ebdef207


git log 3475b482fefa..b2d0ebdef207 --date=short --no-merges --format='%ad %ae %s'
2019-05-13 thestig@chromium.org Remove unneeded iostream includes.
2019-05-13 thestig@chromium.org Remove a static initializer in fx_dib_main.cpp.
2019-05-13 patrik@pspdfkit.com Add documentation about pixel tests and in files.
2019-05-13 tsepez@chromium.org Make CXFA_LayoutItem inherit from fxcrt::TreeNode<>.


Created with:
  gclient setdep -r src/third_party/pdfium@b2d0ebdef207

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: I85e8ee93c39abd4e47d1af92719757c4fe257a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610839Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#659248}

Language details page allows the user to choose whether or not Translate
should be offered for a given language. If Translate cannot be offered for
a language such as the last Translate-blocked language or the target
language, the option to "Offer Translate" is disabled for it.

Demo: https://drive.google.com/file/d/0B2sUCLY7X-D2enZRZE9hUmUwa0pjNkpYWHVFbzV6cEhDbUVr/view?usp=sharing

Bug: 957688
Change-Id: I0a6b6286c2097c460bb41c33b274e96d9cde3fbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601979Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659247}