- 16 May, 2018 40 commits
-
-
Henrique Nakashima authored
When destroying the page we may need to cancel timers. Currently, the timers will be free'd before the page. This CL changes the destruction order to free the pages before freeing the timers. Bug: 843493 Change-Id: Ic96707bd1dc7510f65218679dc12cd44ba012db8 Reviewed-on: https://chromium-review.googlesource.com/1062195Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#559264}
-
Joshua Peraza authored
9115494e8aa4 fuchsia: Increase timeout for WorkerThread.DoWork test dea8fa51d0b5 fuchsia: Changes to allow analyzer-style exception handling d78bd067c7f3 linux: Initialize a crashing thread's stack from its exception context 75b672be06c5 Fix arm build with glibc 2.27 Change-Id: I1187b6c1f651761dc65818c24441943b25b7519c Reviewed-on: https://chromium-review.googlesource.com/1060117Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559263}
-
Moe Ahmadi authored
Replaces the iOS icon with what's being used on Android. Bug: 841758 Change-Id: I31576c9bd4925c91ca28afe46c9071d97cb0ea43 Reviewed-on: https://chromium-review.googlesource.com/1061586Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559262}
-
Josh Karlin authored
What: 1. Sends a message to the browser part of the subresource_filter component to make it aware of which frames have been identified as ads by the AdTracker. 2. The browser monitors movement of RFHs across processes and copies over the ad_subframe bit to new RFHs in ReadyToCommitNavigation. 3. Simplified OngoingThrottleInfo::is_ad_subframe and renamed it to OngoingThrottleInfo::navigating_to_ad_url. 4. Added tests. Why: Because while the render process knows if a subframe that it creates is an ad frame or not, if the frame changes processes (due to site isolation) the browser has to tell the new process that the frame is an ad. Bug: 993493 Change-Id: I2a17660251cdd238853990e2384a7e287f5c659b Reviewed-on: https://chromium-review.googlesource.com/1044425 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#559261}
-
Lukasz Anforowicz authored
This CL replicates existing test expectations for media/video-controls-focus-movement-on-hide.html into the virtual/video-surface-layer flavour of the test. Before this CL: crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ] crbug.com/841922 [ Mac10.12 Mac10.13 Win7 ] virtual/video-surface-layer/media/... [ Failure Pass ] After this CL: crbug.com/833658 [ Linux Win Mac ] media/... [ Pass Failure ] crbug.com/841922 [ Linux Win Mac] virtual/video-surface-layer/media/... [ Pass Failure ] Bug: 833658, 841922 Change-Id: Ib3de8102f5e947215133f42c2dc522d612394789 Reviewed-on: https://chromium-review.googlesource.com/1062587Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559260}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/72b67fe2e3ac..d95db22a613c $ git log 72b67fe2e..d95db22a6 --date=short --no-merges --format='%ad %ae %s' 2018-05-15 benjhayden Add app-route to third_party/polymer2. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic5e25e2af70e188a51c43dbe25b6986ac15dbd0b Reviewed-on: https://chromium-review.googlesource.com/1062205 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559259}
-
Eugene But authored
This data will be passed to DownloadTask so DownloadManagerTabHelper can distinguish downloads requested by the user vs. downloads requested by a web page. DownloadManagerTabHelper drops subsequent downloads requested by the web page to prevent spam. Currently tab helper relies on download task's transition type (which is incorrect). Fixing download transition type is possible, but much harder (see crbug.com/549301). This API mirror's content's NavigationHandle::HasUserGesture Bug: 842828 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79fc2a57af4594494e27613996c39e0153857e5c Reviewed-on: https://chromium-review.googlesource.com/1060575Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#559258}
-
David Jacobo authored
Removing the namespace preffix since its redundant, also adding comments to the parameters (i.e. "should_persist"). Bug: None Test: Build Change-Id: I266396e75d5d12c86dfd53f0099d1b63c61998b9 Reviewed-on: https://chromium-review.googlesource.com/1059720Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#559257}
-
Sorin Jianu authored
This allows the clients of UpdateClient inspect the error codes when an update is complete. Bug: 843657 Change-Id: I667a58a2723846cdcc4070fc9b103419ea4859d1 Reviewed-on: https://chromium-review.googlesource.com/1060586Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559256}
-
Bill Budge authored
- This is a speculative fix to address a large performance regression on Android WebView. - Restricts the range on 64 bit ARM Android to 0x20000000 - 0x60000000. Bug: chromium:837640 Change-Id: I913ed62a9d360ae96aeaab80f468c18f357f956f Reviewed-on: https://chromium-review.googlesource.com/1062012Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#559255}
-
Eugene But authored
The test verifies is_post argument passed to WebClient::PrepareErrorPage Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9f5a6035f1c49dc3cc0a1a144b096ff2fc035989 Reviewed-on: https://chromium-review.googlesource.com/1062079Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#559254}
-
Bailey Berro authored
This changes adds an SmbMountResult enum to represent the various possible results for attempting to mount an SMB share. This SmbMountResult enum will be mirrored by SmbHandler so that the Smb Shares Settings Page can show the user a more helpful message. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2da586c74ba71bf231ff3d5cb572f4a7df26c89e Reviewed-on: https://chromium-review.googlesource.com/1056350 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#559253}
-
Lukasz Anforowicz authored
Bug: 843691 Change-Id: Ic066c88c0c452b1c257f857af694a51ed89cd044 Tbr: brucedawson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1062197Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#559252}
-
Tom Anderson authored
BUG=591980 Change-Id: I9a16d9a27d909dc696b816ab96e9e154f06d5175 Reviewed-on: https://chromium-review.googlesource.com/1062209Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559251}
-
Tom Sepez authored
Land this functionality before continuing with the other PDF JS efforts. Split off from https://chromium-review.googlesource.com/c/chromium/src/+/1055773 Change-Id: Ibbcc8598886466126111d3a9f5449bd7412f30c2 Reviewed-on: https://chromium-review.googlesource.com/1060025 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#559250}
-
Derek Cheng authored
This will be used for in-browser DIAL MRP (https://chromium-review.googlesource.com/c/chromium/src/+/1036611) and other future MRP implementations to indicate a MediaRoute already exists when trying to CreateRoute. Bug: 816628 Change-Id: Id43d91be7318362043cc33a3c0500cc9463f5a5d Reviewed-on: https://chromium-review.googlesource.com/1062145Reviewed-by:
Adam Parker <amp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#559249}
-
Becky Zhou authored
A ModalDialogView might have a different dialog size. For example, the AlertDialog-like dialog view would have width MATCH_PARENT as the Android AlertDialog, and PageInfo would have width WRAP_CONTENT. Bug: 837036 Change-Id: I134862bf61ecc57bdb6b3a2ad6cbafa36c03fab8 Reviewed-on: https://chromium-review.googlesource.com/1058322Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559248}
-
Mounir Lamouri authored
Previously, the promise was resolved before hitting the IPC to the browser process. This adds an ACK IPC that notifies that the operation is done. Technically, this isn't checking that the window is really closed but instead the ACK is sent after `Close()` is called. Bug: 806249 Change-Id: Ibcae8789275f743a827340d0f22485484cbac5b1 Reviewed-on: https://chromium-review.googlesource.com/1042572Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#559247}
-
Mark Pearson authored
Add advice relating to good engineering practices. Also add a section about interpreting metrics. Change-Id: I3b72f54b8b6807bccaaaa98d4a76513983cb8772 Reviewed-on: https://chromium-review.googlesource.com/1058587 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#559246}
-
Scott Chen authored
The device page was doing quite a lot of work to prevent link-clicking from selecting a radio-button. This CL moves the responsibility to cr-radio-button. Also cleans up key-event handling within cr-radio-button a bit. Bug: 840527 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86701cd53e1a6794d8661c5ef66ac9d2e0d4f81a Reviewed-on: https://chromium-review.googlesource.com/1060164Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559245}
-
CJ DiMeglio authored
GPU factories may be null when we ask for it so we should handle it. If GPU factories is null, we should fall back to software compositing. Bug: 843044 Change-Id: I611c19ed1d253c509fca6cb0cf6a69642d9080b9 Reviewed-on: https://chromium-review.googlesource.com/1060615Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#559244}
-
David Black authored
Previously, Assistant UI could only be launched via hotword. This meant it was impossible to see Assistant UI if the underlying service was not started. Now, there are non-hotword entry points wired up and it is possible to launch Assistant UI with the underlying service in an unready state. This can happen if the underlying service fails to get a token and bind itself to AssistantController, as happens when logging in without a network connection. Now we will show a toast. Just a generic message for now, need to get final text from UX. Bug: b:79752950 Change-Id: I48ae014e257db0012ac791be40f1245e5c3316b0 Reviewed-on: https://chromium-review.googlesource.com/1060603 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559243}
-
Esmael El-Moslimany authored
Bug: 832181 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia1f518476fca1e76223ddc072001c91e241dd44c Reviewed-on: https://chromium-review.googlesource.com/1062226 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#559242}
-
Moe Ahmadi authored
This only affects Mac and iOS. Android and Linux will keep using the non-title-cased version. Bug: 841758 Change-Id: I82d0c4e6ffc5d6e9975ffd18f33c56957023592e Reviewed-on: https://chromium-review.googlesource.com/1061589Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559241}
-
Majid Valipour authored
The last two values should be optional according to the specification [1]. Added two new factory methods to allow this. To do this cleanly switched WorkletAnimation to have Member<AnimationTimeline> instead of holding onto a DocumentTimelineOrScrollTimeline. [1] https://wicg.github.io/animation-worklet/#creating-worklet-animation TEST: virtual/threaded/fast/animationworklet/worklet-animation-creation.html Bug: 840383 Change-Id: Ida5aa077fbf19b4918652c02e92f40435db4fbb4 Reviewed-on: https://chromium-review.googlesource.com/1047691 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#559240}
-
Esmael El-Moslimany authored
Bug: 832179 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7db70455f9e9a6f72840b51ba8d9f89dab38d406 Reviewed-on: https://chromium-review.googlesource.com/1060472 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#559239}
-
Koji Ishii authored
Following bot results are included. 5481 5487 5495 5503 5510 5512 5515 5519 5521 5530 6 lines were removed and 1 lines were deflaked by consecutive results since 5415. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8425fc95505fb852cbdcce272cae87a4dfc3114e Reviewed-on: https://chromium-review.googlesource.com/1059534 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559238}
-
Takumi Fujimoto authored
Reorder the methods in .cc files to match the order in .h files. No functional changes. Change-Id: Ie798b6ee82d7fbd6913fe58b01bb9a177aba9d12 Reviewed-on: https://chromium-review.googlesource.com/1058603Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#559237}
-
Vasilii Sukhanov authored
The CL is created in response to https://chromium-review.googlesource.com/c/chromium/src/+/1057235 SubmissionIndicatorEvent is already recorded via UMA. It indicates the event that made the password manager believe that there was a submission. The UKM is to be recorded only when a password is saved. It means that the submission detectioln was probably correct. Bug: 842643 Change-Id: Ic381ee93de7459d7d942a9ee1b27d43e39095fc7 Reviewed-on: https://chromium-review.googlesource.com/1060034Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559236}
-
Scott Chen authored
Bug: 843334 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e087221f922f9abf2327bd10defb19b671dfb29 Reviewed-on: https://chromium-review.googlesource.com/1059867Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559235}
-
Xiaohan Wang authored
Even though a new |cdm_context| is passed in re-initialization, the current MediaCodecVideoDecoder (MCVD) code assumes SetCdm() only happens in the first initialization. Instead of trying to fix MCVD to support setting CDM on a later config change, we'll only allow CDM setting in the initial initialization. More precisely: - SetCdm() is only triggered in initial initialization, if |cdm_context| is non-null, even if the initial config is clear. - In a re-initialization, if the config is encrypted, and we don't have a MediaCrypto already, we'll simply fail, even if a non-null |cdm_context| is passed in. For the reference, "Support of switching [between clear and encrypted] when MediaKeys is set after the playback starts, [or ...], is a quality of implementation issue" [1]. We may apply this to our media pipeline and all decoders to simplify our code. The cost for a JS player to setMediaKeys() before playback starts is really minimal (no need to even start license exchange). There are some other changes in this CL: - Fix AVDA so that if MediaCrytoContext is not available but the stream, is clear, we'll not try to initialize CDM. - Misc logging fixes based on media logging guidance [2]. [1] https://github.com/w3c/encrypted-media/pull/374/files [2] https://chromium.googlesource.com/chromium/src/+/master/media/README.md#logging Bug: 840586 Test: Manually tested switching from clear to encrypted H264. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I584a21dc992ae8bf13794b9310cb2a549e73bade Reviewed-on: https://chromium-review.googlesource.com/1056490Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#559234}
-
Mustafa Çamurcu authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1048043. Also removes OSMesa implementation on Windows platform. Also removes CreateNativeViewGLSurfaceEGL. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie7bdcfc5fbe24a24df5eb6416bb6062812a7cc1f Reviewed-on: https://chromium-review.googlesource.com/1055680 Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#559233}
-
khmel@google.com authored
We switched to new unified (Android Play Store and ARC++ OptIn UI) Play Store id year ago. Now it is time to clean up conversion code. Test: Manually, no problem observed. Positions are preserved. Bug: 722675 Change-Id: Ief70ea26b6ec1b446c72fed63ffec8edf56bb956 Reviewed-on: https://chromium-review.googlesource.com/1062218Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#559232}
-
Nico Weber authored
Remove all unreferenced bots this finds, and even a whole unused waterfall. The testing/buildbot presubmit doesn't run on infra/config/global/luci-milo.cfg changes, so it will instead fire on the first testing/buildbot change after removing a bot, but that seems better than not having this check. Bug: 843511 Change-Id: I8319329d01217cb5c4129c523f79ebd81732d8d9 Reviewed-on: https://chromium-review.googlesource.com/1061597 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#559231}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: I3a8e6393d0a9981aa890fb6d8c302ed8d2bdd69d Reviewed-on: https://chromium-review.googlesource.com/1031099 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#559230}
-
Ryan Hansberry authored
This object will replace the direct usage of the RemoteDevice in future CLs. It serves as a reference to a RemoteDevice for clients to pass around amongst themselves, while providing the guarantee that the RemoteDevice object is not copied (it's important that its BeaconSeeds are not copied because of their size), and has an explicit lifetime (which will be tied to lifetime of the RemoteDeviceCache, introduced in a future CL). Bug: 824568, 752273 Change-Id: Ic2c0f15d5edf893e5c1d9e01c91a95f3e6894340 Reviewed-on: https://chromium-review.googlesource.com/1060090 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#559229}
-
Jacob Dufault authored
Also extend fake_cryptohome_client to support multiple keys, checking keys, and removing keys. The implementation is still not entirely correct, but good enough for testing PIN. Bug: 826773 Change-Id: I3f789c87095b663ca3ab6fb8becae5e924f02a5a Reviewed-on: https://chromium-review.googlesource.com/1054247Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#559228}
-
chrome://snippets-internalsBrandon Wylie authored
Create/implement a mojo interface for snippets-internals. Bug: 830931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I48978cab1c26e88d588f6f56e6cae80cbe13826b Reviewed-on: https://chromium-review.googlesource.com/1033807 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#559227}
-
Andrew Grieve authored
They are both close to the dex limit. Change-Id: Ie5041bca4b4fc3cc56f97351455fa3db29500773 Reviewed-on: https://chromium-review.googlesource.com/1061624Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#559226}
-
Mustafa Çamurcu authored
A small appendix to https://chromium-review.googlesource.com/c/chromium/src/+/1011109 Change-Id: I7247b274fc2083a743437d9cb5aeec488237cba3 Reviewed-on: https://chromium-review.googlesource.com/1062213Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mustafa Çamurcu <camurcu@google.com> Cr-Commit-Position: refs/heads/master@{#559225}
-