- 07 Sep, 2018 40 commits
- 
- 
Dan Sanders authoredBug: 881212 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I02462453e8f62286861c9e299d4c7a5dde612666 Reviewed-on: https://chromium-review.googlesource.com/1213877Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#589721} 
- 
Min Qin authoredThis CL introduces the skeleton UI code for OfflineItems. see https://docs.google.com/document/d/1xDRCoDYnOb9PvwJ8juSmG75jsE-YKzNomCMaoFtQWtQ/edit# BUG=881499 Change-Id: Ie31f6bcc77c65a4343f2e5a0be54f3b9b5fdd5bc Reviewed-on: https://chromium-review.googlesource.com/1211445 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589720} 
- 
Mathias Carlen authoredConnect selecting a script in the UI with the native side so that it can be routed to the executor. R=gogerald@chromium.org, szermatt@chromium.org Bug: 806868 Change-Id: Icf85027c2e50a073d805dbcb3e99017ce66b5850 Reviewed-on: https://chromium-review.googlesource.com/1206373Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589719} 
- 
mrefaat authoredBug: 877984 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idcecd7ba8d49fa8045483f7b2309c3e3eecb3b92 Reviewed-on: https://chromium-review.googlesource.com/1211670 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#589718} 
- 
Chris Palmer authoredThis enables callers to avoid doing it themselves (centralizing the `memset` in 1 place, rather than duplicating it at every call site that wants it), and to allow the PartitionAlloc implementation to avoid doing it itself if the operating system has already zero'd the new page(s). This is a re-land, with fixes, of https://chromium-review.googlesource.com/c/chromium/src/+/1162825. Bug: 864462,680657 TBR: ajwong,haraken Change-Id: Icfe05bca82c79c8a8029db40b2902271d3d10347 Reviewed-on: https://chromium-review.googlesource.com/1214173Reviewed-by: Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589717} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/24de64834600..24e8f58cfa9c git log 24de64834600..24e8f58cfa9c --date=short --no-merges --format='%ad %ae %s' 2018-09-07 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader a062f321768d..3655209d86f4 (1 commits) 2018-09-07 reed@google.com Revert "Revert "add flag to soften the blow of removing a legacy api for flutter"" 2018-09-07 bsalomon@google.com Preseve tangents when converting cubics->quads in GrAAHairlinePathRenderer 2018-09-07 borenet@google.com [infra] Revert broken recipe rolls, add test for missing patch_ref 2018-09-07 brianosman@google.com Add support for gray + colorspace to SkCodec 2018-09-07 bungeman@google.com Simplify FreeType glyph bounds. 2018-09-07 caryclark@google.com reland fix picture subclass destructor doc 2018-09-07 mtklein@google.com add clamp_gamut 2018-09-07 jvanverth@google.com Revert "add flag to soften the blow of removing a legacy api for flutter" 2018-09-07 borenet@google.com Add new autoroll service accounts to AUTHORS check bypass 2018-09-07 mtklein@google.com remove -k 0 from builds Created with: gclient setdep -r src/third_party/skia@24e8f58cfa9c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:847759 TBR=jvanverth@chromium.org Change-Id: I5346f6bf867e5501abfe07bf4f1a78db070605b9 Reviewed-on: https://chromium-review.googlesource.com/1213446Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589716} 
- 
Tim Zheng authoredThis is to avoid a sequence checker debug error. BUG=b/113298882 TEST=Manually tested on Linux workstation simulator. Change-Id: I07b43e315335bf95e67b4567aedd4b7466cc5391 Reviewed-on: https://chromium-review.googlesource.com/1213950Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#589715} 
- 
Robert Ogden authoredEnsures that a preview is not shown when the previews server cannot be reached. Bug: 864656 Change-Id: I417e7988bce7509ddbc31dfadfd48d91f1434e16 Reviewed-on: https://chromium-review.googlesource.com/1213664Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#589714} 
- 
Justin Donnelly authoredThis reverts commit f79adf2a. Reason for revert: The ChromeLauncherControllerWithArcTest.ArcCustomAppIcon test is failing repeatedly on the linux-chromeos-rel bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel Starting with build 13071: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/13071 Original change's description: > arc: Fix shelf item icon flickering on app start. > > When app is pinned, icon image is loaded via controller using loader > owner by chrome launcher controller. Once new ARC app window appears in > the system, it's icon is loaded asynchronously. In this flow, default > app icon is applied first and then, once real image is loaded final icon > is set. Each update of ARC window icon is reflected on shelf. That > means default app icon appear on the shelf for a moment and in most cases > this is very noticeable. > This CL prevents setting default app in favor of final app icon and > default icon is set only as a fallback when final icon could not be > loaded. > > TEST=Manual > BUG=b:114246197 > > Change-Id: I2de9e9d99b313f7538dce9dd732164335f32a42a > Reviewed-on: https://chromium-review.googlesource.com/1212348 > Commit-Queue: Yury Khmel <khmel@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589627} TBR=xiyuan@chromium.org,khmel@google.com Change-Id: I1005d78330dc87b1ce0a925d05d6df48cb68b9ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:114246197 Reviewed-on: https://chromium-review.googlesource.com/1213953Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589713} 
- 
Nicolas Pena authoredThis CL adds support to observe the first time an <img> element paints via the PerformanceObserver (no support for performance timeline yet) and under a flag that is disabled by default. Implementation proposal: https://docs.google.com/document/d/1BvHknbj3T-fUuj4RxHF8qGRNxbswtBqUjKiPx7iLXCc Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/2twP4Xdd1VI Bug: 879270 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I715bd71be088f8055ece493db208caa9b97d736b Reviewed-on: https://chromium-review.googlesource.com/1197349 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#589712} 
- 
Bailey Berro authoredThis change modifies the current GetSharesInNetwork function so that a callback is fired as soon a discovery is done to indicate that name resolution is possible. Additionally, a new ShareFinder::DiscoveryHosts method enables performing host discovery without querying each host for its shares. This change will make it possible to perform name resolution on reboot. Bug: chromium:757625 Change-Id: I437ca8ad6400824a3fbc9b870b5fb0307cee2ac4 Reviewed-on: https://chromium-review.googlesource.com/1199685 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#589711} 
- 
v8-ci-autoroll-builder authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3ee20bcf..6f64185a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I55b239a60848302d980d1accd3cdfdc70a6cdc53 Reviewed-on: https://chromium-review.googlesource.com/1214178Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589710} 
- 
Tarun Bansal authoredUse WeakPtr instead of raw ptr for the callback used by socket watchers when calling back into network quality estimator. Bug: 879071 Change-Id: I1f97fd391fe6b709c45dd87c242467d73ae36dfc Reviewed-on: https://chromium-review.googlesource.com/1213932 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#589709} 
- 
Ryan Cui authoredBug: 880584 Change-Id: I6272bf7e5b99353a0b0b4f8e944747da7b83c944 Reviewed-on: https://chromium-review.googlesource.com/1214177Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#589708} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 821ebe6c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24232 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If4240180a9804dfaea232f3c19cc714bb352c9d3 Reviewed-on: https://chromium-review.googlesource.com/1214067 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589707} 
- 
Maksim Ivanov authoredThis reverts commit 978c0e67. Reason for revert: Breaks enrollment - it fails with this error: "Oops! The system failed to authorize API access for this device." Bug: 854101, 881867 Original change's description: > Generify authentication during enrollment. > > Add DMAuth class, that would be used during enrollment > instead of individual tokens. > > TBR: oshima@chromium.org > Bug: 854101 > Change-Id: I150b9dd5a91c7ba37b14f6dffbaf62f8f00dbb8b > Reviewed-on: https://chromium-review.googlesource.com/1194233 > Commit-Queue: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588007} TBR=antrim@chromium.org,oshima@chromium.org,poromov@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 854101 Change-Id: I24b15104fb8e958832b83c7c32ce6bba990c7ab0 Reviewed-on: https://chromium-review.googlesource.com/1214224Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#589706} 
- 
angle-chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/d84b6737fa10..3b9680534909 git log d84b6737fa10..3b9680534909 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 fjhenigman@chromium.org Clean up state in EGLDebugTest. 2018-09-07 jmadill@chromium.org Vulkan: Make ContextVk driver uniforms a dirty bit. 2018-09-07 jmadill@chromium.org Vulkan: Correct gl_FragCoord with default FBO. 2018-09-07 fjhenigman@chromium.org Fix ClearTest.RGB8WithMaskFramebuffer. Created with: gclient setdep -r src/third_party/angle@3b9680534909 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880495 TBR=fjhenigman@chromium.org Change-Id: Ibc35a52b39df10cc9d6cab6500eff19204dca7aa Reviewed-on: https://chromium-review.googlesource.com/1213826Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589705} 
- 
Wez authoredIf mapping of a DLL into the sandboxed process is blocked then we unmap it and return an "unsuccessful" status, but we left the DLL base-address out-parameter set to a non-NULL value. Reset the out-parameter to null when blocking a DLL, to ensure that callers don't get confused into thinking the operation was successful. This replicates the change from https://chromium-review.googlesource.com/c/chromium/src/+/1211322 to the ThirdPartyModulesBlocking implementation of NtMapViewOfSection(). Change-Id: I7c326a1c78870888c2141f24ae357d0f9be55a62 Reviewed-on: https://chromium-review.googlesource.com/1213561 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589704} 
- 
Mathias Carlen authoredR=gogerald@chromium.org Bug: 806868 Change-Id: I1b7503c801916fb7bd7e0bcde2361f0bfd15d7cf Reviewed-on: https://chromium-review.googlesource.com/1202205 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589703} 
- 
Andrew Xu authoredModify the function CanHandleToggleCapsLock: pressing any redundant key will prevent triggering the Capslock shortcut. In original code, pressing Alt + M + Search then releasing Alt will trigger CapsLock. Because AcceleratorHistory will receive Alt + Search when Search is pressed. The fact that key M is pr- -essed is ignored. R=afakhry@chromium.org Bug: 789283 Test: ash unittests Change-Id: Id359d11cda4562a0b90da97af6c3dde3faf33c53 Reviewed-on: https://chromium-review.googlesource.com/1199853 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#589702} 
- 
Ryan Hansberry authoredImprove user experience by showing the "Start" page first, and the "Password" page after, making for a less jarring experience. Bug: 881610 Change-Id: I0a54c0d6c8b5ffc11e6bfdd2aba80adf6bab374d Reviewed-on: https://chromium-review.googlesource.com/1214169Reviewed-by: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#589701} 
- 
David Tseng authoredIn some instances, we receive a significant number of attribute changes within a short delay. This change throws away attribute changes that generate the same output on the same target. Test: manually on settings page. Verify that ChromeVox only announces the radio button once rather than > 30 times (and plays the radio button earcon 30 times). Change-Id: I92127ad074b3a73ce269077cae6b69ba71f59c52 Reviewed-on: https://chromium-review.googlesource.com/1211972 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589700} 
- 
Katie Dillon authoredBug: 878975 Change-Id: If951e1f175c4103006845bda9bb740f2b2a6afc6 Reviewed-on: https://chromium-review.googlesource.com/1212090 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#589699} 
- 
Vikas Soni authoredThe code in CompositorImpl currently assumes that only a single CompositorImpl instance exists for an application in management of the GPU process. This includes sending app foreground/background state updates to the GPU process and to GpuDataManagerImpl. This is a brittle assumption since the embedder can potentially create multiple Compositor instances. This CL uses the ApplicationStateListener to correctly detemine the state of application. Bug: 859723 Change-Id: Icdad848298f1cdd75995f496b2f0bdf70385336b Reviewed-on: https://chromium-review.googlesource.com/1205202 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#589698} 
- 
pdfium-chromium-autoroll authoredhttps://pdfium.googlesource.com/pdfium.git/+log/26fbb0328d57..5fea8ca820be git log 26fbb0328d57..5fea8ca820be --date=short --no-merges --format='%ad %ae %s' 2018-09-07 hnakashima@chromium.org Force gclient sync in safetynet_compare.py. Created with: gclient setdep -r src/third_party/pdfium@5fea8ca820be The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia33549f08a52f9e17ac427d8fb51858227a319e8 Reviewed-on: https://chromium-review.googlesource.com/1214282Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589697} 
- 
John Abd-El-Malek authoredMost features work now. Change-Id: I3e3d73ff98fafa567bb66162eb4ab30a75739ee3 Reviewed-on: https://chromium-review.googlesource.com/1213278Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#589696} 
- 
Ted Meyer authoredIt is basically a mimic of the h264 picture, and will be used in the D3D11Vp9accelerator class, when that is ready. There also appear to be two styles for accelerators to downcast, where vaapi & V4L2 use as___Picture() methods to get a raw pointer, but D3D11 just uses static casts. I think a future good cleanup is to get rid of the extra methods and not rely on forward declarations. Bug: 881922 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6a7cfbb81e230a7ea46ae3c3e27aebf52a559913 Reviewed-on: https://chromium-review.googlesource.com/1213871 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589695} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/febcf8764dc1..ead23c2a266c git log febcf8764dc1..ead23c2a266c --date=short --no-merges --format='%ad %ae %s' 2018-09-07 dtu@chromium.org [pinpoint] Fix edge case in _Percentile(). Created with: gclient setdep -r src/third_party/catapult@ead23c2a266c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:881661 TBR=sullivan@chromium.org Change-Id: I4cfde01f46b232a9328c49a03ae33a75537be9a7 Reviewed-on: https://chromium-review.googlesource.com/1214283Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589694} 
- 
Scott Chen authoredBug: 832933 Change-Id: I6399c3c2687e553d5d05df14d6b5263e985badab Reviewed-on: https://chromium-review.googlesource.com/1194835Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589693} 
- 
Stephen McGruer authoredStoring a scoped_refptr<ComputedStyle> in SVGElementRareData can cause a noncollectable Blink GC reference cycle, as there can be a path from the Document --> SVGElementRareData, and a path from ComputedStyle --> SVGLocalResource --> Document. The scoped_refptr in the center stops Oilpan from being able to detect the cycle. To fix this we clear the overridden ComputedStyle when the SVGElement is detached from the layout tree. Doing so breaks the cycle and allows Oilpan to collect everything as normal Bug: 878032 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib1095a9ae63b0499332e0e7369621ec6b8f961c0 Reviewed-on: https://chromium-review.googlesource.com/1213367Reviewed-by: Anders Ruud <andruud@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589692} 
- 
David Tseng authoredTBR=dcheng@chromium.org Bug: 669134 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I91a10a1f39a1a353ace08d54611f6daec35ea1de Reviewed-on: https://chromium-review.googlesource.com/1213879 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589691} 
- 
Steven Bennetts authoredThis CL: * Eliminates some scenarios using fake implementations (tests, linux) where bogus ERROR messages were being spammedn. * Converts some usage of base::DictionaryValue to base::Value. Bug: None Change-Id: If63ddfe3b00ecd7125848a162f0fffb9dcf7d679 Reviewed-on: https://chromium-review.googlesource.com/1211956 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589690} 
- 
Manuel Rego Casasnovas authoredThe CSSWG has recently resolved that layout containment should create a stacking context like paint containment (see issue https://github.com/w3c/csswg-drafts/issues/2942). This is the spec text about this (https://drafts.csswg.org/css-contain/#containment-layout): "5. The element creates a stacking context." The patch is just a simple change in ComputedStyle::UpdateIsStackingContext() to add the new condition. Apart from that TestExpectations file is updated as we're now passing some tests from WPT. We're also failing one test, but for an unrelated issue (see bug #880802). BUG=870157 TEST=external/wpt/css/css-contain/contain-layout-016.html TEST=external/wpt/css/css-contain/contain-layout-018.html TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-stacking-context-001.html Change-Id: Icdc102692801534364adf3fc0929192b886cdbc4 Reviewed-on: https://chromium-review.googlesource.com/1211922 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589689} 
- 
Sunny Sachanandani authoredAutomatically growing transfer buffer removed the flush when it would run of space. This decreased canvas throughput by reducing pipelining. Automatic flushes are another way of improving throughput by submitting work to the GPU process often. This CL enables automatic flushes for the shared main thread context used for canvas which might have been disabled unintentionally. Bug: 880901 Change-Id: Ib48d9c56c18c9e2d449d7c42f74b16609ad3ea55 Reviewed-on: https://chromium-review.googlesource.com/1213665Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#589688} 
- 
Yuchen Liu authoredJS may invoke Image.decode without capturing the Image object. If GC kicks in, ImageLoader will be destroyed as no one owns it, which leads to unresolved/unrejected Promise. The callback of ChromeClient::RequestDecode should take a persistent reference instead of weak reference to avoid ImageLoader GC. BUG=881060 TEST=LayoutTest image-decode-promise-when-gc.html Change-Id: Ief9c7956ddd0df81ea1f1643eb6f6c7bac946a7c Reviewed-on: https://chromium-review.googlesource.com/1205798Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589687} 
- 
Istiaque Ahmed authoredUse ServiceWorkerContext::RunTask() to make sure that ServiceWorkerContext* is kept alive while transitioning from UI thread to IO thread. Bug: 875376 Change-Id: Ib961931260b453e8a99828b8598d77c7821cff06 Reviewed-on: https://chromium-review.googlesource.com/1211971 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589686} 
- 
Frank Henigman authoredUpdate "Mac FYI dEQP Release AMD" on the GPU FYI waterfall to look for machines running OS 10.13.6. Bug: chromium:881952 No-Try: True Change-Id: I12e0f82f4cc29fdbe36f7f76ad5d945228eaf4a7 Reviewed-on: https://chromium-review.googlesource.com/1213704 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589685} 
- 
Mythri Alle authoredThis reverts commit f17b2cd3. Reason for revert: <INSERT REASONING HERE> Original change's description: > Update ResourceLoader to also fetch cached code for inline scripts > > V8 also stores code caches for inline scripts in the html resources. > This cl updates ResourceLoader to fetch cached code for inline scripts > in MainResources. > > Bug: chromium:880212, chromium:812168 > Change-Id: I822453b52897aac292444df20e50937d8198064d > Reviewed-on: https://chromium-review.googlesource.com/1208391 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589137} TBR=kinuko@chromium.org,mythria@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:880212, chromium:812168 Change-Id: I4e24815c37378a86e334c8fe88129dff39ee87dd Reviewed-on: https://chromium-review.googlesource.com/1213094Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589684} 
- 
Ryan Tseng authoredThey need large core machines. This is fine since auto_builder_dimensions is on. Bug: 868213 TBR: tandrii Change-Id: I3aa153e09afbd7e9ddc885441a09183f73727232 Reviewed-on: https://chromium-review.googlesource.com/1214220Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#589683} 
- 
John Budorick authoredThis adds filter file support to all test types that previously supported gtest-style test filtering, notably including instrumentation and junit tests. This was requested in crrev.com/c/1208442 Change-Id: I552843898735b52b773bdc397c39ecf64e4df275 Reviewed-on: https://chromium-review.googlesource.com/1214083 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#589682} 
 
-