- 05 Feb, 2019 40 commits
-
-
Xiyuan Xia authored
The test expects the bounds is synchronously set when the app window contents is ready to be committed. This is not always the case under single process mash because the window bounds does not change synchronously when toggling fullscreen like in the classic mode. The CL presets window bounds when fullscreen state changes so that the bounds change happens synchronously. Bug: 926007 Change-Id: If99e5946df1f9804c21202f075cbb1bf258f4bce Reviewed-on: https://chromium-review.googlesource.com/c/1444431 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#629172}
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty dictionary (as there is an override doing this). If the dictionary is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. Bug: 646113 Change-Id: I0b6028fd9ac2a27ae9ba72d3af3c0d6a7d478301 Reviewed-on: https://chromium-review.googlesource.com/c/1454486Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629171}
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty dictionary (as there is an override doing this). If the dictionary is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. Bug: 646113 Change-Id: Ib121cd952c29d40d46ab65b02f1e305132131eab Reviewed-on: https://chromium-review.googlesource.com/c/1454545Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629170}
-
Parastoo Geranmayeh authored
from Autofill Profile to Autofill Data Model. Bug: 928527 Change-Id: Iea2ee986ef21fd3dc23ed9c20395f985e7012b78 Reviewed-on: https://chromium-review.googlesource.com/c/1453068 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#629169}
-
Scott Haseley authored
This adds compositor trace events to the BENCHMARK_RENDERERS slow reports, which is needed to analyze certain events related to frame timing. Change-Id: Iae65efa506b20a7cdee088c6c379d4e3b049b676 Reviewed-on: https://chromium-review.googlesource.com/c/1446507 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#629168}
-
Rayan Kanso authored
The delegate proxy should just communicate with the delegate. RequestInfos are moved to the job controllers. Bug: 850512 Change-Id: I1002db53225d2b7ade3b6a40549946de120cae79 Reviewed-on: https://chromium-review.googlesource.com/c/1422158 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@google.com> Cr-Commit-Position: refs/heads/master@{#629167}
-
Dan Elphick authored
Fix uses of deprecated Object::Get/Set V8 functions by instead using the Context versions and checking the return values. Bug: v8:7283, v8:8562 Change-Id: Ib404f83495ae5988050b9fd6e9722d8593b05f50 Reviewed-on: https://chromium-review.googlesource.com/c/1454490 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#629166}
-
Xiyuan Xia authored
This reverts commit f4f6c5ff. Reason for revert: Still fails on chromeos build-bot. See 919777 #4 for more details. Example failure: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8922379830326735328 Bug: 919777 Original change's description: > Reland: "Add --merge-base-ref option to lastchange.py"" > > Reland commit fb941d6f. > Revert was bff8ece1. > > The original commit changed RunGitCommand as a standard refactor > to simplify the code in a single module. Turns out that module is > called by python code in other repositories. Therefore this version > retains the old behavior of RunGitCommand until the other repositories > can be changed. > > Change-Id: Ifcbb74c6928ad27169a9381415277d95d0c9265e > Bug: 917159 > Reviewed-on: https://chromium-review.googlesource.com/c/1401511 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Eli Ribble <eliribble@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628936} TBR=alemate@chromium.org,dpranke@chromium.org,tandrii@chromium.org,jbudorick@chromium.org,eliribble@chromium.org Change-Id: Ia65dba384bf477660c33f89c1cd3c0e76d5e6d61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 917159 Reviewed-on: https://chromium-review.googlesource.com/c/1454803Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#629165}
-
Vladimir Levin authored
In cases where we might not have computed style, ensure that we pass the containment checks (optimistically). This comes with a TODO to switch to something like render=lockable to force containment. R=chrishtr@chromium.org Bug: 882663 Change-Id: I78403b9bd5577a9ff006213c8452f07fb9197f93 Reviewed-on: https://chromium-review.googlesource.com/c/1452473Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#629164}
-
Manu Cornet authored
This restores a behaviour that was mistakenly changed by CL 1445031 (I removed a class/method to get icon sizes and replaced these two calls with the wrong constant). Bug: 927506, 928175 Change-Id: I35c80a7bee03b2c150e25200715dbca34ea12b51 Reviewed-on: https://chromium-review.googlesource.com/c/1454201Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Auto-Submit: Manu Cornet <manucornet@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#629163}
-
Dan Elphick authored
Fixes use of deprecated Object::Set V8 function by instead using the Context version and checking the return value. Bug: v8:7283, v8:8562 Change-Id: Ia3ab123d36507576bde1a9dcd79ffbdc545469a4 Reviewed-on: https://chromium-review.googlesource.com/c/1454528 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Dan Elphick authored
Fixes use of deprecated Object::Get/Set V8 functions by instead using the Context version and checking the return values. Bug: v8:7283, v8:8562 Change-Id: I98481be4ddd15848df531ef6efcc85860b0362c4 Reviewed-on: https://chromium-review.googlesource.com/c/1454625 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#629161}
-
Nick Diego Yamane authored
This patch adds character composition capabilities to ozone wayland text input backend. To accomplish this it modifies WaylandInputMethodContext, reusing ui::CharacterComposer (previously chromeos-only) to handle key events forwared by InputMethodAuraLinux. BUG=921947 Change-Id: I9f06ed253ad0ba67b437ef683a6ed235cb57a1f2 Reviewed-on: https://chromium-review.googlesource.com/c/1448136Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#629160}
-
Stephen Nusko authored
This allows us to avoid having to convert these messages manually each time we want to use mojo for IPC versus a piping to our system deamon. Change-Id: I5432f952bd789781fa3cb7a78dc25d413f363e98 Reviewed-on: https://chromium-review.googlesource.com/c/1425597 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#629159}
-
Mikel Astiz authored
These ancient sync types haven't been used for years and deprecated in 2014 with https://codereview.chromium.org/780363003. We now rename the enum to prevent accidental references, and remove some code leftovers that were effectively dead (e.g. type expansion in SyncPrefs). While doing this, we unify some strings in model_type.cc to avoid prefix "Deprecated" in type names, which some types did, and instead the presubmit checks are updated to whitelist deprecated datatypes and allow their strings to be inconsistent. Bug: 923826 Change-Id: Ib1d7b90042ef4598cc80d036cc50c3494eb170a6 Reviewed-on: https://chromium-review.googlesource.com/c/1454520 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#629158}
-
Antonio Gomes authored
... in favor the IdentityManager::Observer counterparts. This is another step forward on removing the dependency of GaiaCookieManagerService from AccountReconcilor. In a follow up step, the ctor argument that still takes an GaiaCookieManagerService instance will be removed. BUG=926890,926886 Change-Id: Ibd3dab957ad5b23eefe06c5dc3963d7e566c9bcf Reviewed-on: https://chromium-review.googlesource.com/c/1454300 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#629157}
-
Koji Ishii authored
This patch fixes NGLineBreaker not to pass offset to LazyLineBreakIterator::NextBreakOpportunity that is larger than the length of the string. LazyLineBreakIterator may read out-of-bound in that case. This patch also adds DCHECK to prevent that. Bug: 926301 Change-Id: I5e94af838dcd25bceeb9b780dc2865a49d07670a Reviewed-on: https://chromium-review.googlesource.com/c/1454342 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#629156}
-
Jan Krcal authored
This CL fixes a broken invariant that is_stopping_and_clearing is false whenever StopAndClear() gets called. This does not have to be true and this CL treats this special case without talking to UserSettings. Bug: 928216 Change-Id: I4d6d9cf471d4327035f29d06635f340bfb707861 Reviewed-on: https://chromium-review.googlesource.com/c/1452002 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Adam Rice authored
The browser includes cookie headers in those it sends to the renderer if DevTools is open. Add a check that the renderer has access to cookie data for that origin. This CL only changes the non-network-service codepath. The network service code path will changed in a followup CL. BUG=924972 Change-Id: Iaa9cd66ab805fa59a61b9f4ae192b4ef94c79962 Reviewed-on: https://chromium-review.googlesource.com/c/1439461Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#629154}
-
Nicolas Pena authored
This CL removes EQT splits by task queue type. These histograms are not needed and occupy significant size. Bug: 908712, 926069 Change-Id: I3952c2f0fed110044a9a5b6878bd254eb2105622 Reviewed-on: https://chromium-review.googlesource.com/c/1452421Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#629153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0783aca7ba31..0c74d7d9283e git log 0783aca7ba31..0c74d7d9283e --date=short --no-merges --format='%ad %ae %s' 2019-02-05 reed@google.com remove mention of SkMetaData 2019-02-05 robertphillips@google.com Fix generated files 2019-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 049ff3873334..8f71f7311f29 (1 commits) 2019-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 950d2f4a..6c1a9cca (394 commits) Created with: gclient setdep -r src/third_party/skia@0c74d7d9283e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I0441cae8d5841570944d25361252145f2832e817 Reviewed-on: https://chromium-review.googlesource.com/c/1454758Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629152}
-
Koji Ishii authored
After the fix for crbug.com/915567, there are reports of cases where ShapingLineBreaker does not move forward. While I could not find a reproducible case for this, there is a case it may occur from the code review. This patch fixes the case, along with adding CHECK to ShapingLineBreaker. This is a speculative fix. Bug: 928178 Change-Id: I51cf733fdad9abf2feee529bfaf90a7e1bdbb09d Reviewed-on: https://chromium-review.googlesource.com/c/1453777 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Koji Ishii authored
LayoutInline::AlwaysCreateLineBoxes() and ShouldCreateBoxFragment() share the flag because they are used only when it is in non-LayoutNG inline formatting context, or in LayoutNG. When a LayoutInline is moved, by SplitInline, multicol, etc., between LayoutNG and non-NG inline formatting context, the flag becomes inconsistent. This patch fixes it by these functions to return false if it is used for the different context. No behavior changes. Bug: 927467 Change-Id: If6201d4c454f42ae333acfe81b6df8504e017a5e Reviewed-on: https://chromium-review.googlesource.com/c/1454099Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d01c504e0c18..e923a63e312d git log d01c504e0c18..e923a63e312d --date=short --no-merges --format='%ad %ae %s' 2019-02-05 jmadill@chromium.org Move ozone detection earlier in white list. Created with: gclient setdep -r src/third_party/angle@e923a63e312d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928583 TBR=geofflang@chromium.org Change-Id: I7e08e6b700d1f8578d4a2c53660f3008105fb03c Reviewed-on: https://chromium-review.googlesource.com/c/1454757Reviewed-by:
-
Leonard Grey authored
Bug: 915465 Change-Id: I2712459903140725c2c75dfdf0026013961ea964 Reviewed-on: https://chromium-review.googlesource.com/c/1391952 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#629148}
-
Manuel Rego Casasnovas authored
In r607786 we added support for SetText() optimization for texts longer than the container when it doesn't wrap. However we didn't modify LayoutText::SetFirstTextBoxLogicalLeft() so we were trying to align those texts, when we shouldn't. The fix is very simple as if the text is longer than the container we don't need to do any alignment. BUG=928463 TEST=fast/css/containment/change-text-node-data-nowrap-align.html Change-Id: I57d7d85c1ff652a9ccec19bee15a7cab186aa193 Reviewed-on: https://chromium-review.googlesource.com/c/1454577 Commit-Queue: Manuel Rego <rego@igalia.com> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#629147}
-
Alexandre Courbot authored
Convert what we can of the V4L2IP to use V4L2Queue, which helps removing a bit of code. The queueing of CAPTURE buffers is still not managed by V4L2Queue. This is because IP currently picks an output buffer from the index passed by its client, which the V4L2Queue interface does not allow. This can be fixed once the V4L2VDA does not depend on the V4L2IP using a given buffer index to process a given frame. In the meantime, this still makes the code a bit less verbose. BUG=792790 TEST=Checked that VDA passed on Hana and VEA on Peach Change-Id: I7538f4df496c1d435ac70695e27fb8e0df6d42a6 Reviewed-on: https://chromium-review.googlesource.com/c/1170708 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#629146}
-
Hans Wennborg authored
This reverts commit b4fb8097. Reason for revert: the test is failing flakily, see bots below. These bots all use the chrome-branded official build config. I'm not sure exactly why, but it seems relevant for the failures. https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/1948 https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/1952 https://ci.chromium.org/buildbot/chromium.clang/ToTWin/3217 https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/3137 Original change's description: > [Autofill] Add StrikeDatabase browsertests > > This is a reland (with modifications to accommodate recent changes) > of > https://chromium-review.googlesource.com/c/chromium/src/+/1316666 > > The V2 of StrikeDatabase is now used. > > Bug: 884817 > Change-Id: I13cf973bef9d0f48f218e8e76ad30e365e3617ec > Reviewed-on: https://chromium-review.googlesource.com/c/1446665 > Commit-Queue: Anne Lim <annelim@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#628538} TBR=estade@chromium.org,tmartino@chromium.org,jsaul@google.com,annelim@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884817 Change-Id: I5f93447acbf5fabd7f905deb8feb9068e1413a51 Reviewed-on: https://chromium-review.googlesource.com/c/1454370Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#629145}
-
Ken Rockot authored
There's a quite a bit of unnecessary junk and/or granularity within the Service Manager impl. This cleans up most of it. Namely: - No more service_manager::Context since it's effectively unused. It used to support a standalone command-line-driven Service Manager, and despite wanting that again in the future, this implementation wasn't production-worthy. - No more separate background/ and runner/host/ subdirectories. These defined things that just practically belong alongside the full ServiceManager impl, so they're moved there - Gets rid of ServiceProcessLauncherDelegate support on BackgroundServiceManager since it's also unnecessary. A future CL will get rid of the rest of the runner/ subdir as well as ServiceProcessLauncherDelegate altogether. Bug: 904240 Change-Id: I013c688ddb6e7ca0133b5cb5720d2b7d9de8457c Reviewed-on: https://chromium-review.googlesource.com/c/1453436Reviewed-by:
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty dictionary (as there is an override doing this). If the dictionary is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. R=battre@chromium.org Bug: 646113 Change-Id: I2406bb61aab1edfde4231fc8492b932db4eafb36 Reviewed-on: https://chromium-review.googlesource.com/c/1454543Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629143}
-
Sylvain Defresne authored
The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value> is deprecated in favor of the method taking the base::Value by value. Convert client code to either not pass default value if the value is just an empty dictionary (as there is an override doing this). If the dictionary is not empty, convert the code to create and pass it by value. This CL was uploaded by git cl split. Bug: 646113 Change-Id: I0ce16bc2720f325ae5e6349f9acf9829d23f7aa9 Reviewed-on: https://chromium-review.googlesource.com/c/1454582Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#629142}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3e66f120fbb..71b40a07a007 git log e3e66f120fbb..71b40a07a007 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 treehugger-gerrit@google.com Merge "Correct counter ref comparator" Created with: gclient setdep -r src/third_party/perfetto@71b40a07a007 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I477fa0474625e43415d8b9343cf953f49b5bf5e8 Reviewed-on: https://chromium-review.googlesource.com/c/1454756Reviewed-by:
-
Daniel Libby authored
This is a reland of a230653d There is a global singleton in user_activity which is used from multiple components - therefore, ui/base/user_activity itself has to be a component. Original change's description: > Add BUILD.gn for ui/base/user_activity > > ui/base/user_activity causes ui/base to have a dependency on ui/events. > To remove another instance of this dependency, put user_activity into > its own component. > > > Bug: 921723 > Change-Id: I8c82bcb82b876386c63fa263937280c48ceb43fb > Reviewed-on: https://chromium-review.googlesource.com/c/1448735 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#628473} Bug: 921723 Change-Id: If80874d9cf2ae032d8931bfa3aa292b63bfa7119 Reviewed-on: https://chromium-review.googlesource.com/c/1452996Reviewed-by:
-
Antonio Gomes authored
This method introduces an IdentityManager::Observer callback, namely OnAccountsCookieDeletedByUserAction(), equivalent to the existing GaiaCookieManagerService::Observer::OnGaiaCookieDeletedByUserAction. In order to unit test, FakeCookieManager and CustomTestSigninClient classes where introduced, so the the code path that triggers the call to GCMS::Observer::OnGaiaCookieDeletedByUserAction gets executed. Particularly about FakeCookieManager, it inherits from network::mojom::CookieManager which is a pure virtual class, and needed all its methods but one to be overridden / stubbed out. The method from FakeCookieManager that needed a real (although simple) implementation was AddCookieChangeListener(). BUG=926890 Change-Id: Icc1124eded616a8c31efc58c9e1950f08363c3b3 Reviewed-on: https://chromium-review.googlesource.com/c/1452816 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#629139}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/69b761e52b10..167316b8338f git log 69b761e52b10..167316b8338f --date=short --no-merges --format='%ad %ae %s' 2019-02-05 magjed@webrtc.org Remove proxy layer from AndroidVideoTrackSource Created with: gclient setdep -r src/third_party/webrtc@167316b8338f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I81e89496dc4a1979db3395096a11ec46b1196a12 Reviewed-on: https://chromium-review.googlesource.com/c/1454644Reviewed-by:
-
Matt Menke authored
They are flaky on "non_single_process_mash_browser_tests", likely due to https://chromium-review.googlesource.com/c/chromium/src/+/1443733. These look like races with network configuration changes, so are not real bugs. NOTRY=true TBR=asanka@chromium.org Bug: 928685 Change-Id: I0a6ff4df635b26af56e1c8fd60ad2bc4c1525372 Reviewed-on: https://chromium-review.googlesource.com/c/1454124Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#629137}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d1be0e707708..00976d0db135 git log d1be0e707708..00976d0db135 --date=short --no-merges --format='%ad %ae %s' 2019-02-05 cwallez@chromium.org Make setBlendColor take in a Color instead of 4 floats Created with: gclient setdep -r src/third_party/dawn@00976d0db135 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ibdc82bff5551b3b308ac8b29316659cd42e96fdf Reviewed-on: https://chromium-review.googlesource.com/c/1454425Reviewed-by:
-
Oleg Davydov authored
Investigation in https://bugs.chromium.org/p/chromium/issues/detail?id=913334 showed that blacklists (URLBlacklist and URLWhitelist policies) are applied only to “normal” urls, not ones with “javascript” scheme. This is because this URLs (and some more, like “chrome://crash”) are so-called Renderer Debug URLs, they don't need network fetch or something like that, and they are just passed into renderer. So to make blacklists work for such URLs we have to make additional check. Bug: 913334 Change-Id: I109cf27640d641fc35f449ef0bfd622d19a6c27b Reviewed-on: https://chromium-review.googlesource.com/c/1436372Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#629135}
-
Roman Aleksandrov authored
Management page was punted to M74. To ensure safety removing this page from branch: remove it from master first, then merge this CL to branch. Page could be reverted back in case chrome://management will be not ready before M74 (which is unlikely, but could happen). Bug: 879146 Change-Id: I4ba7324de794d7422d52c6e2b6a5e16af58d2da9 Reviewed-on: https://chromium-review.googlesource.com/c/1443014Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#629134}
-
Fredrik Söderquist authored
The scaling of the various edges/widths would always round down, which meant that edges that were supposed to be abutting were not. Round the scaled width instead, but take care to avoid introducing a new overlap (which we scaled down to avoid). Use LayoutUnits for this since we probably want to just compute the widths to LayoutUnit directly in the future for slightly improved fidelity (TODO added). Also, fix typo in |include_rigt_edge|. Bug: 918994 Change-Id: I359fd54d30ddcfa235217e14f340cd6139e9d040 Reviewed-on: https://chromium-review.googlesource.com/c/1452183 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#629133}
-
