GitLab

It is only useful for sites that require dedicated processes, or
in --site-per-process mode.

BUG=none
TEST=No behavior change.

Review-Url: https://codereview.chromium.org/2101293003
Cr-Commit-Position: refs/heads/master@{#402633}

Allow component installers to specify a map of installer attributes to be used in the update check requests.

This change extends the mechanism to specify "ap" in such a way that a map of name-value pairs can be returned by the component installer which need this capability.

R=waffles
BUG=599703

Review-Url: https://codereview.chromium.org/2102083002
Cr-Commit-Position: refs/heads/master@{#402632}

This will give us a bit more test coverage prior to
the branch.

R=brettw@chromium.org
BUG=618468, 605318

Review-Url: https://codereview.chromium.org/2105043003
Cr-Commit-Position: refs/heads/master@{#402631}

Adds state type changed event to remote_shell_protocol.

BUG=b/29817350

Review-Url: https://codereview.chromium.org/2109763002
Cr-Commit-Position: refs/heads/master@{#402630}

BUG=548423

Review-Url: https://codereview.chromium.org/2103383002
Cr-Commit-Position: refs/heads/master@{#402629}

BUG=613883

Review-Url: https://codereview.chromium.org/2073713002
Cr-Commit-Position: refs/heads/master@{#402628}

This Should make it so a user can override Websockets through devtools
protocol.

BUG=446909

Review-Url: https://codereview.chromium.org/2003253002
Cr-Commit-Position: refs/heads/master@{#402627}

Tables can be the containing block for positioned objects too, so when we take over
the overflow calc duties from LayoutBlock we need to cater for positioned objects
like it does too.

I also spotted an error in LayoutTable::recalcChildOverflowAfterStyleChange() - we
need to recalc overflow for all sections regardless of whether a section has already
changed its overflow.

BUG=619510

Review-Url: https://codereview.chromium.org/2100343002
Cr-Commit-Position: refs/heads/master@{#402626}

As discussed in
https://github.com/w3c/webcomponents/issues/192

document.pointerLockElement should be now shadow-dom aware,
and it gets adjusted to its node tree.

ShadowRoot.pointerLockElement is also added so it should
work similar to how document/ShadowRoot.activeElement works.

BUG=622584

Review-Url: https://codereview.chromium.org/2086293004
Cr-Commit-Position: refs/heads/master@{#402625}

R=inferno@chromium.org,ochang@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2108013002
Cr-Commit-Position: refs/heads/master@{#402624}

This will also get rid of "libfuzzer/../../" strings in libfuzzer stacktraces.

BUG=

Review-Url: https://codereview.chromium.org/2108713003
Cr-Commit-Position: refs/heads/master@{#402623}

This is a drop-in replacement of ICU library performing automatic text
encoding detection with CED (Compact Encdoing Detection).

CED is used extensively in Google for every crawled web page,
email message, query string, etc., and recently open-sourced for
public use. (https://github.com/google/compact_enc_det)

Also it is a much better alternative to ICU in terms of speed.
ICU introduces significant regression in page loading (up to 30%):

= ICU auto-detection vs. TOT =
page_cycler.typical_25:cold_times.page_load_time 1085.13±9.31% 754.28±12.03% (30.49%)

http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-08_21-20-58

while CED adds virtually no additional loading time (delta < sigma):

= CED auto-detection vs. TOT =
page_cycler.typical_25:cold_times.page_load_time ms 705.70±9.49% vs. 760.31±11.90% (-7.74%)

http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-08_20-37-54

With CED, it is feasible to turn on auto encoding detection by default
so that web pages without encoding label can be taken care of. It will be
done in a follow-up CL.

BUG=597488

Review-Url: https://codereview.chromium.org/2081653007
Cr-Commit-Position: refs/heads/master@{#402622}

Stores the updates as a V4StoreFileFormat proto with the following fields:
1. Magic number (integer)
2. Version (integer)
3. Hash prefix information (ListUpdateResponse proto).

Overall design document: https://goto.google.com/design-doc-v4store

Only FULL_UPDATEs are written to disk.

Includes tests to read from and write to the disk.

BUG=543161

Review-Url: https://codereview.chromium.org/2066083002
Cr-Commit-Position: refs/heads/master@{#402621}

Introduces CSSPendingSubstitutionValue for each longhand, containing a
reference back to the shorthand property.

Changes CSSVariableResolver to just resolve variables, rather than
resolving and applying them (a task that StyleBuilderCustom can pretty
easily take care of).

Introduces a property cache on StyleResolverState to limit the amount
of parsing required during resolution. This is somewhat unattractive to
me, but there was a lack of better alternatives.

BUG=612634

Review-Url: https://codereview.chromium.org/2089593002
Cr-Commit-Position: refs/heads/master@{#402620}

BUG=b/28602162

Review-Url: https://codereview.chromium.org/2101883002
Cr-Commit-Position: refs/heads/master@{#402619}

This patch updates the code to prevent auto deducing to a raw pointer.

R=sky, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2101323003
Cr-Commit-Position: refs/heads/master@{#402618}

DialogPresenter provides an abstract interface for handling JavaScript
alerts and the HTTP Authentication prompt. A subclass can be provided
through the WebStateDelegate.

Proposal Link:
https://docs.google.com/document/d/1d3PxHcDGyZlrgEBa58oh-eFFOWUYLOv8kIiuftFjli8/edit

BUG=620739

Review-Url: https://codereview.chromium.org/2074733002
Cr-Commit-Position: refs/heads/master@{#402617}

Revert of Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule() (patchset #13 id:240001 of https://codereview.chromium.org/2046583002/ )

Reason for revert:
Sheriff reverting on suspicion of causing the Win x64 build to fail:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1995

From the log:
FAILED: obj/base/base.file_version_info_win.obj
ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\base\base.file_version_info_win.obj.rsp /c ..\..\base\file_version_info_win.cc /Foobj\base\base.file_version_info_win.obj /Fdobj\base\base.cc.pdb
c:\b\build\slave\win_x64\build\src\base\file_version_info_win.cc(81): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64\build\src\base\file_version_info_win.cc(81): warning C4267: 'argument': conversion from 'size_t' to 'DWORD', possible loss of data
[8341/32887] CXX obj\base\threading\base.thread_collision_warner.obj

Original issue's description:
> Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()
>
> Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
> calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
> lock and potentially touches the disk to obtain the VS_VERSION_INFO
> of the module. This is gratuitous for a module that is already loaded.
>
> With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
> uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
> resource from memory.
>
> BUG=609709
>
> Committed: https://crrev.com/f177a678814f97f0b35bd6aa678c1cf885ad1656
> Cr-Commit-Position: refs/heads/master@{#402549}

TBR=grt@chromium.org,thestig@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=609709

Review-Url: https://codereview.chromium.org/2102363002
Cr-Commit-Position: refs/heads/master@{#402616}

This CL is part 2 of 2 for making cc::CompositorFrames
movable. This CL primarily tackles making cc::Surface
hold a cc::CompositorFrame by value. This impacts tons of
callsites which are updated in this patch.

https://codereview.chromium.org/2096493002/

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2d9cc5abb4745280a002822a2380e925f835ef51
Review-Url: https://codereview.chromium.org/2098953003
Cr-Original-Commit-Position: refs/heads/master@{#402545}
Cr-Commit-Position: refs/heads/master@{#402615}

R=michaelpg@chromium.org
BUG=622037
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2094223004
Cr-Commit-Position: refs/heads/master@{#402614}

BUG=619686

Review-Url: https://codereview.chromium.org/2094013003
Cr-Commit-Position: refs/heads/master@{#402613}

When a PaintLayerScrollableArea is not using composited scrolling, it must
usually issue a paint invalidation for every scroll, but it can skip the
invalidation if all scrolling content is composited.  This optimization was
added by http://crrev.com/27239004.

However, one subtlety was not accounted for: a composited child that is not a
stacking context paints negative z-index content into the GraphicsLayer of the
nearest stacking-context ancestor.  If we have such a child, we must still issue
the invalidation.

Note that any any transform-related property creates a stacking context (see
call to setZIndex(0) in StyleAdjuster::adjustComputedStyle), so this will not
de-optimize scrollers that force compositing with translateZ(0) or similar.

BUG=596060

Review-Url: https://codereview.chromium.org/2107903002
Cr-Commit-Position: refs/heads/master@{#402612}

> [DomKey] Expose Korean special keys on Korean keyboard layout only
>
> Korean keyboard has special keys "HangulMode" and "HanjaMode", we should
> only expose them when the system layout is Korean. Otherwise we should
> return "Unidentified".
>
> This matches Firefox and windows virtual key.
>
> Note: This also works with JIS keyboard + Korean layout, because we are
> mapping DomKey based on KeyboardCode instead of DomCode.
>
> BUG=612736
>
> Committed: https://crrev.com/bdcfb5a1816f1bad537d7611c7ccb972b550339c
> Cr-Commit-Position: refs/heads/master@{#399783}
> Revert: https://codereview.chromium.org/2061123005

Original issue:
Windows API |LoadKeyboardLayout()| won't pass DrMemory
tests for Korean and Japanese locale.
This should be an issue of DrMemory test or Windows itself.
See https://crbug.com/612736#c11

Solution:
Just skip |LoadKeyboardLayout()| and hardcode locale for Korean,
it works because we are only testing non-printable keys, which
doesn't care about |ToUnicodeEx()|.

Note:
|ToUnicodeEx()| returns empty string if the specified locale is invalid. (e.g. Korean HKL without calling 'LoadKeyboardLayout()')

Also Note:
"mock_keyboard.h" has the similar issue, e.g.
Call "MockKeyboard::GetCharacters(MockKeyboard::LAYOUT_KOREAN, ..)" somewhere and run DrMemory full test, which will fail as well.

BUG=612736

Review-Url: https://codereview.chromium.org/2097643002
Cr-Commit-Position: refs/heads/master@{#402611}

This fixes null dereference crashes when tabs close with open bubbles.

BUG=622973

Review-Url: https://codereview.chromium.org/2103733002
Cr-Commit-Position: refs/heads/master@{#402610}

This change can be reverted after a day or two of data.

BUG=621730
R=haraken@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/2107773002 .

Cr-Commit-Position: refs/heads/master@{#402609}

BUG=612961

Review-Url: https://codereview.chromium.org/2102773002
Cr-Commit-Position: refs/heads/master@{#402608}

1. Migrated the fast user switching buttons triggered by right clicks back to user menu's main page
2. Added a "Guest" button
3. Added a "Close all your windows" button
4. Made UI modifications such as circular icons, paddings, etc.

See screenshot:
https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGY2tBWklPOFVKS28/view?usp=sharing

Mockup:
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu#%2Fspec-2.png (Note the appropriate icons for "Guest" and "Close all your windows" will be added as a separate CL.)

BUG=615893

Review-Url: https://codereview.chromium.org/2057203002
Cr-Commit-Position: refs/heads/master@{#402607}

Revert of Add display-resolution caching to GPU IDC (patchset #10 id:310001 of https://codereview.chromium.org/2042133002/ )

Reason for revert:
This caused stability issues. Reverting until fix is in place.

Original issue's description:
> Add display-resolution caching to GPU IDC
>
> In order to save memory and upload time, images which are
> going to be drawn at less than their native resolution may
> be uploaded at a smaller scale. This change adds additional
> caching and upload logic to allow this.
> See https://goo.gl/0zCd9Z for a complete description.
>
> BUG=623688
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.blink:mac_blink_rel;tryserver.blink:win_blink_rel
>
> Committed: https://crrev.com/bc8acf2632042e5e93982088d5b7dcb7f1c0d168
> Cr-Commit-Position: refs/heads/master@{#402377}

TBR=vmpstr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=623688
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/2101403006 .

Cr-Commit-Position: refs/heads/master@{#402606}

This CL will cause presubmit to warn programmers when using single
quotes in HTML property names.

BUG=622814

Review-Url: https://codereview.chromium.org/2091903002
Cr-Commit-Position: refs/heads/master@{#402605}

BidirectionalStream.ping and BidirectionalStream.windowUpdate are unused.
This CL removes them. We can consider adding them back if there are interests
from consumers.

BUG=516342

Review-Url: https://codereview.chromium.org/2106453002
Cr-Commit-Position: refs/heads/master@{#402604}

Recently-added policy rules in the SSL client socket require that
we enable Certificate Transparency. This CL adds CT support by attaching
the relevant CT objects to the SSL client context.

R=khushalsagar@chromium.org
BUG=623684

Review-Url: https://codereview.chromium.org/2103143003
Cr-Commit-Position: refs/heads/master@{#402603}

Allows Blink to use base::debug::ScopedCrashKey.

BUG=621730

Review-Url: https://codereview.chromium.org/2105763002
Cr-Commit-Position: refs/heads/master@{#402602}

BUG=621397
R=ojan@chromium.org,japhet@chromium.org

Review-Url: https://codereview.chromium.org/2082463002
Cr-Commit-Position: refs/heads/master@{#402601}

This CL removes calls to deprecated methods MessageLoop::PostTask
and MessageLoop::RunUntilIdle in google_apis.

BUG=616447
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2083383002
Cr-Commit-Position: refs/heads/master@{#402600}

The existing behavior is to complete when the top loading frame's load event completes.

This adds 2 alternatives:
* When the main frame's DOMContentLoaded completes
* When the main frame's DOMContentLoaded completes, as well
as any images that started before DOMContentLoaded completes

BUG=513459
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1860743002
Cr-Commit-Position: refs/heads/master@{#402599}

Made it so that import_tests makes all files starting with a shebang executable regardless of file permissions in upstream repo

BUG=574461

Review-Url: https://codereview.chromium.org/2096173002
Cr-Commit-Position: refs/heads/master@{#402598}

BUG=622424

Review-Url: https://codereview.chromium.org/2106873002
Cr-Commit-Position: refs/heads/master@{#402597}

There are two places users can update their cloud services pref:
- First run flow, with a checkbox
- Contextual menu, with a toggle

Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices.

In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services.

[Reland Comments] This was initially reverted because it caused failures on official bots; there were #includes that were mistakenly removed.

BUG=621255, 623330

Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17
Cr-Commit-Position: refs/heads/master@{#402072}

patch from issue 2078213002 at patchset 160001 (http://crrev.com/2078213002#ps160001)

Review-Url: https://codereview.chromium.org/2093353002
Cr-Commit-Position: refs/heads/master@{#402596}

* Fold LastWindowClosedLogoutReminder into LogoutConfirmationController
* Move LogoutConfirmationController ownership from Shell to WmShell
* Place the logout confirmation dialog in the system modal container, not
in the root (dialogs should not live directly in the root)
* Move LabelTrayView to //ash/common/system/tray since it is not chromeos-
specific

BUG=619636
TEST=ash_unittests, manual testing after forcing the button to show

Review-Url: https://codereview.chromium.org/2108793002
Cr-Commit-Position: refs/heads/master@{#402595}

Shift the position of the material design battery
alert badge at 2x device scale factor; currently
it is too low.

BUG=623417
TEST=manual

Review-Url: https://codereview.chromium.org/2107813002
Cr-Commit-Position: refs/heads/master@{#402594}