- 28 Dec, 2020 40 commits
-
-
Ella Ge authored
Bug: 1152282 Change-Id: I44525d812f6493e64c6bd2ef1f95093e73827ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600387Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839501}
-
Theo Johnson-kanu authored
- Before this CL remove eSIM profile dialog, did not display any meaningful error if remove fails, this CL adds a meaningful error. Screenshot: https://screenshot.googleplex.com/5JVxg2tdsLued8o.png Bug: 1154787 Change-Id: Iee30704914ba582325ea9314e7a1a62736f778ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602511Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#839500}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e53a07e855c1..3279200908f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC awscreen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: awscreen@google.com Change-Id: Iccc3331d555361611993764ca33ce0d8f79fe2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605402Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839499}
-
Ella Ge authored
Bug: 1152282 Change-Id: I73c28fbaccb8d8c82402952730ffa1ac04423d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601223Reviewed-by:
-
Mike Taylor authored
This also adds support for sending multiple Set-Cookie strings to the test infrastructure. Notes for history books (and reviewers) legacy test => ported test cookie name map (ignoring Path) path0001 => (path.html) testA=11; testB=11 path0002 => (path.html) testB=12; testA=12 path0003 => (path.html) testA=13; testB=13 path0004 => (path.html) testB=14; testA=14 path0005 => (path.html) test=15 path0006 => (path.html) test=16 path0007 => (path-redirect.html) test=1 path0008 => (path-redirect.html) test=9 path0009 => (path-redirect.html) test=10 (can be improved) path0010 => (path-redirect.html) test=2 path0011 => (path-redirect.html) test=11 path0012 => (path-redirect.html) test=12 path0013 => (path-redirect.html) test=13 path0014 => (path-redirect.html) test=17 path0015 => not ported, see note below. path0016 => (path-redirect.html) test=3 path0017 => (path-redirect.html) test=4 path0018 => (path-redirect.html) test=14 (can be improved) path0019, dupe of (path.html) test1, not ported path0020, dupe of (path.html) test2, not ported path0021, dupe of (path.html) test3, not ported path0022 => (path.html) test=17 path0023 => (path.html) test=18 path0024 => (path-redirect.html) test=15 path0025 => (path-redirect.html) test=16 path0026 => (path-redirect.html) test=5 path0027 => (path-redirect.html) test=6 path0028 => (path-redirect.html) test=7a disabled-path0029 (path-redirect.html) test=7b path0029 => (path.html) test=19 path0030 => (path.html) test=21 path0031 => path.html test=20 path0032 => (path-redirect.html) test=8a; test=8b Notes: For path0027 and path0028, I'm swapping the assertions (to expected a cookie) because Firefox, Safari and Chrome do this. path0015 isn't possible to port with current WPT infra (as there are no dynamic handlers, and '/' is treated as a directory "mount"). https://bugs.chromium.org/p/chromium/issues/detail?id=1161544 is filed to track that work, and a few improvements to better capture the intents of path0009 and path0018. Bug: 1159925 Change-Id: I37da066e60d79e3f99e01a7d6ccbc408f447e01b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598139 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#839497}
-
Yu Han authored
Bug: 1161590 Change-Id: I17f1fadfba815efa42bff7afe7abc3f27960e533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605394Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839496}
-
Brandon Goddard authored
This test is now no longer flaky/failing locally on my machine. I'm attempting to re-enable in the CI system. Bug: 849284 Change-Id: I74809701307005ac90d047627b72e66b0abb19b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605395Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#839495}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5f606546cde12ee8a25f3632a9f3c918b1907d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605391Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839494}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/6866adbec5af..1d3f901aa016 $ git log 6866adbec..1d3f901aa --date=short --no-merges --format='%ad %ae %s' 2020-12-25 fbarchard Scale bug fix with msan when scaling up in height and down in width with box filter. 2020-12-22 fbarchard Test Box filter scale plane with 1 dimension growing and the other reducing 2020-12-03 eshr NV12 Copy, include scale_uv.h 2020-11-18 thakis Stop setting mac_xcode_version in DEPS 2020-11-06 libyuv-ci-autoroll-builder Roll chromium_revision 5aaa70b5..64c8c30f (822628:824854) 2020-11-03 fbarchard Scale by even factor low level row function 2020-10-30 libyuv-ci-autoroll-builder Roll chromium_revision df9aecfc..5aaa70b5 (820568:822628) 2020-10-28 fbarchard PlaneScale, UVScale and ARGBScale test 3x and 4x down sample. 2020-10-27 fbarchard MJPGToNV12 added and build files sorted 2020-10-24 libyuv-ci-autoroll-builder Roll chromium_revision e812106b..df9aecfc (817907:820568) 2020-10-16 libyuv-ci-autoroll-builder Roll chromium_revision 48924233..e812106b (815587:817907) 2020-10-13 fbarchard UVScale down use AVX2 and Neon for aarch32 2020-10-13 fbarchard UVScale down by 4 use SSSE3/NEON 2020-10-12 fbarchard 2x down sample for UV planes ported to SSSE3 / NEON 2020-10-09 libyuv-ci-autoroll-builder Roll chromium_revision ccec2ad0..48924233 (811963:815587) 2020-10-02 fbarchard I420ToARGB prototype added to convert_from.h 2020-10-01 fbarchard scale neon adjust PRFM instruction to co-issue with math Created with: roll-dep src/third_party/libyuv Bug: chromium:1158178, libyuv:875, b/176195584 Change-Id: Iecf360198a90acabcbd71e57791634f5e3e861c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604256 Commit-Queue: Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#839493}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I11f817cd5f063ed7d3e7c7ff5f9a794bdd2206b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605466Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839492}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/05f83d8d5771..9882688674c5 2020-12-28 michael.liao@microsoft.com [Network Conditions]: Fixing vertical spacing bug caused by error text If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1159319 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b9351efbb61b34af3cdd8360ea8e9aa625b03e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839491}
-
David Tseng authored
Changes are mostly mechanical, beyond which are: - introduced some facilities to break circular dependencies (Navigator, BasicNode.creators, BasicRootNode.builders) - fixed some Closure errors; various modules were not actually type-checked previously (relying upon gn compile) - tests require dynamic ES6 imports Test: existing browser_tests Change-Id: Idf385eb9ab220bf050a388f3c9cf633fb83d9e0b AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603933 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Josiah Krutz <josiahk@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#839490}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5d30dc4142c..16d86135b739 2020-12-28 bsalomon@google.com Make textures used with alpha-only color-types produce 0s for RGB 2020-12-28 bsalomon@google.com Add GrPixmap. Like SkPixmap but uses GrColorType. 2020-12-28 bungeman@google.com Make onCreateScalerContext return unique_ptr. 2020-12-28 fmalita@chromium.org Add explicit int -> size_t casts to SkTDArray.h 2020-12-28 csmartdalton@google.com Avoid uninitialized values in strokeIndirect SIMD queues 2020-12-28 johnstiles@google.com Detect and report numeric overflows in the SkSL parser. 2020-12-28 egdaniel@google.com Fix vk framebuffer attachment views to only have 1 mip level. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: I5ddc6e9f9919c668bc16320d575f76f988265208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605435Reviewed-by:
-
Daniel Clark authored
Pull the ModuleType enum out of the ModuleScriptCreationParams class so that the full class definition of ModuleScriptCreationParams doesn't need to be included in modulator.h once Modulator methods start taking ModuleType parameters as part of the Import Assertions work. Also make the names of the enum values a bit less redundant. Bug: 1132413 Change-Id: I714b0c2dfe5f6467b2e447e6e732c02509a62902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605002Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#839488}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b90546580ec3..1f0df96659ae 2020-12-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9534bf2b..b264ce95 (839344:839451) 2020-12-28 perkj@webrtc.org Send VideoLayersAllocation with resolution if number of spatial layers 2020-12-27 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2020-12-27T04:03:22). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I75413179dffa94448b310e986d68ddfa5142bb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601349Reviewed-by:
-
Jeroen Dhollander authored
The crash happened if the Android app list was updated while the Assistant was stopped. To solve this we now stop observing Android app list updates when the Assistant is stopped. Notes: - I also renamed |AddAppListEventSubscriber| to |AddAndFireAppListEventSubscriber| to better describe its behavior. - I also changed |ScopedObserver| to |ScopedObservation|, as |ScopedObserver| is deprecated. - I looked into adding unittests for this but decided against it as it won't be trivial and the code will be reworked in the near future during the Libassistant V2 migration. Bug: 1136387 Test: chromeos_unittests Change-Id: Icf536c9aad54af3e9ab306464c2a47075076e60d Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600448Reviewed-by:Yue Li <updowndota@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#839486}
-
David Van Cleve authored
This relands: - http://crrev/e98b84e "net: Change HttpRequestHeaders::SetHeader's DCHECKs to CHECK" - http://crrev/f998816347be "content: Enforce precondition that UA overrides must..." The first change upgraded a security-relevant network stack DCHECK, ensuring no invalid characters (\r, \n, \0) in headers, to a CHECK; the second bubbled this invariant up to the //content API so that its "override the UA" method wouldn't result in crashes when the CHECKs failed. We ended up reverting these changes out of Android WebView compat concerns. Torne (thanks!) has since then landed and analyzed some metrics and verified (see the linked bug) that there won't be too big a compat impact, so we're relanding these initial changes. Rather than reintroducing the second CHECK, in web_contents_impl.cc, this CL just adds an early return to WebContentsImpl::SetUserAgentOverride in the case that the given override is not a valid HTTP header value. Bug: 1105745 Change-Id: Ie2924bdbfbfd092c12e52fda8eaa52aa40e5425d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589666Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#839485}
-
Andrew Xu authored
Besides the content padding, this CL corrects the label's height to ensure that the total height of a label menu item is 36. Bug: 1159706 Change-Id: Ibb1718262f3bdce3e031e04fb34db629b8ff01b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605392 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#839484}
-
Toni Barzic authored
Do not call Button::OnGestureEvent if the event has been handled by the FrameCaptionButton. FrameCaptionButton may handle ui::ET_GESTURE_SCROLL_END by invoking click handler, which, depending on the button implementation, may end up deleting the button, so continuing to process the event is not safe. BUG=1142568 Change-Id: I6ba6099beff577026a90e749b99430c5819099a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602600Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e43f269e7aa6..e53a07e855c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC awscreen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: awscreen@google.com Change-Id: I049e236dfa4543b2029d29b55c26e729bebe3bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605005Reviewed-by:
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Ia277a910bcc837e89aabdbb26c7a14bfbc0cdaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595188Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#839481}
-
Paul Moy authored
When a client requests PolicyInfo, but Chrome's service hasn't collected any policy info from the device yet, a nullptr is returned. This currently causes an unexpected null validation error in Mojo on the client. Fix this by marking PolicyInfo optional and checking for nullptr in the client before using the returned PolicyInfoPtr. Bug: b:175792552 Change-Id: I409a83364434201c55039078ad9d183bd160cb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597905 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#839480}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c8d5277e86ee..0eb61724c8f1 2020-12-28 jiawei.shao@intel.com Enable CompressedTextureFormatTests on Win/Intel/Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ia8c0bff72f9c462f28f2e3614e7e4df2eaa78a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605428Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a1af10b707b..2813dd74be34 2020-12-28 yueherngl@google.com volteer: add firmware-volteer-13672.B branch builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I185adaa8867c170fac1a7743185958922eb806e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605427Reviewed-by:
-
Alex Newcomer authored
UX/PM want to see how often placeholder strings are shown in Clipboard History. We may design a better solution if they are seen a lot. Bug: 1156837 Change-Id: If96e86d244cd05abcbd098ea19e9af0234928046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590753 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#839477}
-
Allen Bauer authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Bug: 1159563 TBR: tbergquist@chromium.org Change-Id: Id0cccd96111f5c660bc839e81b40da2ecf72da10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597542 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#839476}
-
Ryan Sturm authored
Previously, this code assumed that OnComplete would only be called after OnReceiveResponse, but it can be called before that as well in the case of a network failure. Change-Id: I86072c1bd0e05521f2688ad1270e5b7246875676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602708Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#839475}
-
Andres Calderon Jaramillo authored
Bug: None. Test: None. Change-Id: I6e9a80823fbc14d93edaecc42b0eea9d5f5d5c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601067Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#839474}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I63c845b18ce21b9195f4a5f059d85562434a2fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605325Reviewed-by:
-
Kyle Williams authored
Bug: b:175644742 Test: N/A Change-Id: I64b50791912d8a74a590459f6038bafa6522c6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605346 Auto-Submit: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
-
Min Qin authored
There are 300 QPS for tiles now, not sure why is it happening. Adding more restrictions are tile fetching. Change-Id: Ie513364d0a072abc3f3d92ae1f09b404bf5df161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601259Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839471}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609156644-42cb6a035b1fe5a631f9a5a0f3f4dab0f809ccfe.profdata to chrome-linux-master-1609173530-a51a44ea42c1ce639e5f65da47d34d0f960968de.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic1f42abcdbb9dfada6297a4a5d2abc1e2b04b415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602863Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a29c88f5..48107c9a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1e9d3b277452df339389729f0111b98ffd70e6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605287Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839469}
-
Jao-ke Chin-Lee authored
BUG=chromium:1062407,b:175909299 Change-Id: I6cb71aa9f13f252bde352a4b558acef1eb354a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601546Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#839468}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609156644-74221c569e797d96fdd58cd45c2be34f02342fb7.profdata to chrome-mac-master-1609173530-9c0c14935df28154f2fe482e167ffd7e8e9a643c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I733549e22e09b9c46f4f3eed960ea3be2d07f6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605433Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.132. R=rmhasan@google.com, tikuta@chromium.org Bug: 1041619 Change-Id: I1bb3dee68f804ab903cba4f8d2a545d52abf0112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602664 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#839466}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.66. R=dpranke@google.com, rmhasan@google.com Bug: 1041619 Change-Id: I1e2579f3dd6ed0b5c8812a16a88a5d57a147f3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602666 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e44afbebcfce..e43f269e7aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC awscreen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: awscreen@google.com Change-Id: I88066bb91a5e5b69a084073a1bf7b6b89dfab72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605444Reviewed-by:
-
Ramya Nagarajan authored
Change-Id: I74152abbf1bd6851266fd5c14a3788d595a4ac8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601745Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#839463}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a82fd9788066..05f83d8d5771 2020-12-28 bmeurer@chromium.org [wasm] Don't look into "imports" / "exports" for mouse hover. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071432,chromium:1162069 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic2ffc4171c59f687e6b9151d1fba0a72a80beb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604155Reviewed-by:
-
