GitLab

Previously, test placeholders were extracted from test_locations_, a std::map,
which implicitly deduplicated the keys. After creating test_placeholders_, I
stored them in a vector. Unfortunately, this causes duplicate entries to occur
when iterations > 1. Storing them in a set returns the previous behavior.

Bug: 934996
Change-Id: I81825b1f95064ac59594b3531cfd8409c631e8f8
Reviewed-on: https://chromium-review.googlesource.com/c/1484074Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634868}

This is a reland of 8af85474

The original author is rmcelrath@chromium.org, yhirano replaced DISABLE_ with
DISABLED_.

Original change's description:
> Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService
>
> This test is flaky on ChromeOS when the network service is enabled.
>
> Bug: 934583
> Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1482005
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634467}

Bug: 934583
Tbr: jam@chromium.org
Change-Id: I87dc76c9e36f25d78279105b03ea9b3340e47718
Reviewed-on: https://chromium-review.googlesource.com/c/1482278
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634867}

Always use uint64_t to serialize size_t since serialization and
deserialization can occur in processes with different bitness on android
webview.

TBR=enne@chromium.org

Bug: 924042
Change-Id: I54945b0eb1a60910cb9c92e25b6d57388c4aaa85
Reviewed-on: https://chromium-review.googlesource.com/c/1475047
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634866}

We do not show the answer card when we are showing the embedded
Assistant UI.

Bug: 924624
Test: manual
Change-Id: I08fe6bcfd9e3d4e6bee2fb5236a7246405ecb53f
Reviewed-on: https://chromium-review.googlesource.com/c/1481994
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634865}

This is necessary for creating modified DropTargetEvents (e.g. if you need to
make a provided const event& relative to a new parent).

The primary concern here is |data_|, which is a reference member.  Copying a
DropTargetEvent shallow-copies this reference rather than deep-copying it, so
the lifetime of the copied event must not extend past that of the data that was
used to construct the original event.  I'm concerned that this change makes it
easier for people to cause UAFs; however, that concern already existed with the
original object, and the right fix is probably not to prevent copying but to
make DropTargetEvent not keep |data_| by reference to begin with.  That's a more
involved change than I have the scope to do for now.

Bug: 923188
Change-Id: I35d475081584577cc0217f672a45b5a9e5a60a4e
Reviewed-on: https://chromium-review.googlesource.com/c/1483673
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634864}

This reverts commit 1bc0f674.

Reason for revert: causing crashes & flakiness.
Bug: 934640, 934790

Original change's description:
> [IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager
> 
> This allows scopes to be used in the DeleteDatabase call, and cleans up
> some code in the IndexedDBDatabase class.
> 
> The last part of the codebase that doesn't have locks before being used
> is the IndexedDBBackingStore::Initialize call. Since this happens on the
> opening of the database, this can probably use just the raw database +
> a WriteBatch.
> 
> Bug: 862456
> Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48
> Reviewed-on: https://chromium-review.googlesource.com/c/1478391
> Commit-Queue: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: Chase Phillips <cmp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634358}

TBR=cmp@chromium.org,dmurph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 862456
Change-Id: I30cf895d9846308c26191984f75039306acc86e4
Reviewed-on: https://chromium-review.googlesource.com/c/1484076Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634863}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/151c3484da58..298f2cf820df


git log 151c3484da58..298f2cf820df --date=short --no-merges --format='%ad %ae %s'
2019-02-22 ehmaldonado@chromium.org git cl: Print a clear error message when we fail to find the remote url.
2019-02-22 jophba@chromium.org CppLint changes for VSCode cpplint plugin
2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2019-02-22 qyearsley@chromium.org [cpplint] Ignore fn_size check for macros with digits


Created with:
  gclient setdep -r src/third_party/depot_tools@298f2cf820df

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:914655,chromium:83036
TBR=agable@chromium.org

Change-Id: Id13e16f7ca19ec6dde3638cf336030aecf7cb111
Reviewed-on: https://chromium-review.googlesource.com/c/1483746Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634862}

When navigating to a previews URL directly, the preview code (V1) falls
back to the original URL. In this case, it should not report any
pingback metrics. It is currently DCHECKing, but in release builds it
does report the pingback.

Bug: 934865
Change-Id: I4f1749d9ddeef49e98d3d2ee041669bdce232480
Reviewed-on: https://chromium-review.googlesource.com/c/1483941
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634861}

Using wpt-import in Chromium 109f1025.
With Chromium commits locally applied on WPT:
14c11107 "Implement `Sec-CH-Lang`"
df760ab0 "Don't skip past auto-height flexboxes in quirks mode."
cd40220a "Fix as=fetch preload where preload is used before response arrives"
1d89521e "[LayoutNG] Force relayout when constraint spaces change."
98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests"
f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context."
1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function"
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ie2c5645fb11da0174a692dfd8d4b5560e0646f60
Reviewed-on: https://chromium-review.googlesource.com/c/1483731Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634860}

Using unsigned long instead of ptrdiff_t results in non-zero
pointer deltas being stored as zero delta, giving incorrect offsets
into arrays and hence out of bounds reads.

This patch fixes the issue in all places in parser.c and adds a macro
to reduce the chances of cut-and-paste errors. A chromium patch for
the libxml roll is added to apply the change to future versions.

The issue has been reported upstream to libxml2 because there are
likely other places in the code where this fails.

R=dcheng@chromium.org,palmer@chromium.org
BUG=894933

Change-Id: I13687c386231374653e499e0557838ed0ddea6af
Reviewed-on: https://chromium-review.googlesource.com/c/1483252
Auto-Submit: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634859}

The test started flaking after an unrelated CL caused a slight change to the
sharding of tests. This implies that the test has previously relied on state
carried over from previous tests to function correctly.

Bug: 934900
Change-Id: Iee0208c99751362a3c5dcf36f70a1625e3ebd6a3
Reviewed-on: https://chromium-review.googlesource.com/c/1483940Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634858}

Bug: none
Change-Id: I4a5cffd410d1f87431b7705a6ef5bb94955f6813
Reviewed-on: https://chromium-review.googlesource.com/c/1483830
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634857}

Bug: 862461
Change-Id: I624d39293e50754629b3b30990828af73f57f0b3
Reviewed-on: https://chromium-review.googlesource.com/c/1482281Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634856}

Currently Chromevox will not treat image annotation separately
from the name field, but this gives us the flexibility to add
separate Chromevox logic for annotation later.

Bug: 905419
Change-Id: I65c964dec3c869319a51f164b6c245057a362410
Reviewed-on: https://chromium-review.googlesource.com/c/1480542Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634855}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6be20565150..d2b61f7238c1


Created with:
  gclient setdep -r src-internal@d2b61f7238c1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ia035961fd860d004053dc7f02a7bb89beff44019
Reviewed-on: https://chromium-review.googlesource.com/c/1483827Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634854}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d90920be7af..c08d404a452b


git log 0d90920be7af..c08d404a452b --date=short --no-merges --format='%ad %ae %s'
2019-02-22 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@c08d404a452b

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I6e6a0f86ae426cadeaf79bb3e0aad5569934efa9
Reviewed-on: https://chromium-review.googlesource.com/c/1483741Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634853}

Gzip has a maximum compression ratio of 1032x. While, strictly speaking,
linear, this means the fuzzer will often get stuck. Stop reading at a
more modest compression ratio of 10x, or 2 MiB, whichever is larger.

Bug: 921075
Change-Id: I529632762b66e4fae0bbdce8ea6d746d98cc2d99
Reviewed-on: https://chromium-review.googlesource.com/c/1483873
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634852}

RTCVideoDecoderAdapter::Release() is called on the DecoderThread when
InitDecode() fails.

Bug: 934798
Change-Id: I8157d73511db0639d2013e2f4d62293a47ceaf5c
Reviewed-on: https://chromium-review.googlesource.com/c/1483683Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634851}

Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde
Reviewed-on: https://chromium-review.googlesource.com/c/1481121
Commit-Queue: Travis Skare <skare@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634850}

Create a cups_printing watchlist to watch the CUPS related chromium files

Bug: None.
Change-Id: I48846d834983c51d4780f4b89962a000f12cfaea
Reviewed-on: https://chromium-review.googlesource.com/c/1483944
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634849}

This reverts commit 90ffaeaa.

Reason for revert: Breaks Win x64 Builder. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/63687

Original change's description:
> Add the win::WMIRefresher class and use it in SystemMonitor
> 
> This class will be used to retrieve the disk idle time on Windows (some
> other performance counters will probably be added in the future).
> 
> The metric will initially be used in the tracing infra to make it
> easier to analyze the I/O activity in the slow reports we're getting
> from the wild.
> 
> The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373
> 
> Bug: 771478
> Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07
> Reviewed-on: https://chromium-review.googlesource.com/c/1349670
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634843}

TBR=jwd@chromium.org,fdoray@chromium.org,oysteine@chromium.org,sebmarchand@chromium.org

Change-Id: I857594acf56af3f050c1559a72269579f467a326
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771478
Reviewed-on: https://chromium-review.googlesource.com/c/1484088Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634848}

https://pdfium.googlesource.com/pdfium.git/+log/1aecf87b9620..36e541ccbf9f


git log 1aecf87b9620..36e541ccbf9f --date=short --no-merges --format='%ad %ae %s'
2019-02-22 thestig@chromium.org Add more tests for AFPercent_Format().
2019-02-22 thakis@chromium.org Another whitespace change to trigger bots.


Created with:
  gclient setdep -r src/third_party/pdfium@36e541ccbf9f

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:934825
TBR=dsinclair@chromium.org

Change-Id: Icf5b3dd16e4050c17706185fe0239a09dc11ae09
Reviewed-on: https://chromium-review.googlesource.com/c/1483826Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634847}

Create two studies since the two features have two different chrome
flags. Using one study would cause DCHECK failure (Feature has conflicting
field trial overrides) in Chromium debug mode.

Bug: 897998
Change-Id: Icf093329e30f660ce7697241f5fbcd0604a1f9ac
Reviewed-on: https://chromium-review.googlesource.com/c/1474277Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634846}

ErrorUtils.FormatErrorMessage_Death fails on official builds because
failure messages aren't passed to CHECK in official builds. Modify the death
regex for the test in official builds and fix the test.

BUG=934831

Change-Id: I4b301410ce990e3ced014c5fa82c42d1fea98cce
Reviewed-on: https://chromium-review.googlesource.com/c/1483938
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634845}

Change-Id: I81252edcac31490248001c59623b1da220136451
Reviewed-on: https://chromium-review.googlesource.com/c/1480455
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634844}

This class will be used to retrieve the disk idle time on Windows (some
other performance counters will probably be added in the future).

The metric will initially be used in the tracing infra to make it
easier to analyze the I/O activity in the slow reports we're getting
from the wild.

The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373

Bug: 771478
Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07
Reviewed-on: https://chromium-review.googlesource.com/c/1349670
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634843}

The value of these policies is written to cache.dat so IE knows how to
open a URL in Chrome.

Bug: 909878
Change-Id: I0410e9022b96f35354666946a19fa6492afc7963
Reviewed-on: https://chromium-review.googlesource.com/c/1476062
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634842}

This allows easier manual testing using chrome://flags

Bug: 934376
Change-Id: Ic9bb78c8c8db20b5a8e6f0f8f5ce26d6897d7e52
Reviewed-on: https://chromium-review.googlesource.com/c/1483390Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634841}

This CL makes a slightly expanded version of the Dolphin category ranking model
that learns information on subtypes of omnibox results, eg. history results and
bookmark results. This is guarded behind a Finch parameter.

Bug: 931149
Change-Id: I01c9edef80aee9f7f386fe301ffcd44e0a18fc78
Reviewed-on: https://chromium-review.googlesource.com/c/1482095
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634840}

The new CastToolbarButton in the toolbar's trusted area is now enabled by
default, so this CL removes the old Media Router toolbar action that was
replaced by it.

MediaRouterActionController is still used by the new icon, and will be
renamed in a separate patch.

Bug: 919185
Change-Id: I95842e657379f823bd483d0a3da00015f76d8255
Reviewed-on: https://chromium-review.googlesource.com/c/1395419Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634839}

https://boringssl.googlesource.com/boringssl/+log/f109f2087349712d3ac717d15fab48e130618110..c18353d214c04da5349e97283d6d70b8176a96f8

The following commits have Chromium bugs associated:
  c18353d21 Add uint64_t support in CBS and CBB.

TBR: davidben@chromium.org
Bug: 634570
Change-Id: Id2c0d63f53bfd683ff20f9f2745f626201b78be4
Reviewed-on: https://chromium-review.googlesource.com/c/1483700Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Auto-Submit: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634838}

The Y and UV planes weren't getting released properly because the local
variables used in base::RetainBlock() are snapshots of their current
values and do not get updated by subsequent code. In this case,
y_surface and uv_surface would always be at their original value of
EGL_NO_SURFACE and eglReleaseTexImage/eglDestroySurface would never get
called. Using pointers to these values solves the issue, since the
pointers do not get modified by subsequent code and the values can be
checked properly by dereferencing the pointers.

Bug: chromium:932986 chromium:929088
Change-Id: Id0b9fcc79af733b645eaf8fed12d905dd40e9fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1483690Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634837}

Due to issues we have with retrieving correct font metrics on Mac OS,
due to [1, 2] when computing the vertical origin for Emoji Color Emoji
we receive an incorrect vertical origin with a 0 y-value, which leads to
an emoji glyph being placed too high.

Fallback to retrieving the slightly inflated SkFont.getBounds when
SkPath + getBounds() returns an empty rectangle, as it does for Apple
Color Emoji.

Added emoji-vertical-origin-visual.html test as part of own tests, but
in the style of a WPT test. As far as I can tell, we cannot yet run
pixel tests as part of WPT but I do not see a way to verify our
rendering as a ref test.

[1] https://bugs.chromium.org/p/skia/issues/detail?id=8779
[2] https://bugs.chromium.org/p/skia/issues/detail?id=5328

Test: fast/text/emoji-vertical-origin-visual.html
Bug: 933264
Change-Id: I3487bf832b857764fb638a3f2df5803137d3fd66
Reviewed-on: https://chromium-review.googlesource.com/c/1480463
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634836}

This CL records value returned by UnPackArchive in a new histogram
Setup.Install.LzmaUnPackResult
This value contains result of GetLastError() if Unpack failed, or
ERROR_SUCCESS. Following WinGetLastError are also added to handle
WriteFile failure:
INVALID_USER_BUFFER
NOT_ENOUGH_QUOTA

Bug: 933975
Change-Id: I6177bf738383a0212d054f3cf2ddd3ec6d0b9fda
Reviewed-on: https://chromium-review.googlesource.com/c/1461083
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634835}

A network error should be reported if the resource fetch is aborted
before it is complete:
https://w3c.github.io/network-error-logging/#transmission-of-request-and-response-errors

This CL adds NEL error generation (with report type ERR_ABORTED) for
any HttpNetworkTransactions destructed without previously generating a
success or error report. This guarantees that every
HttpNetworkTransaction results in a NEL report. Successes are reported
after receiving valid headers (if the response code is 4xx or 5xx, or
if the body will not be read, or on a redirect), or after completely
reading the body. Any other outcome is reported as an error.

Bug: 934000
Change-Id: I8f71309c9cea0295546b23861fba6b131f72a3d7
Reviewed-on: https://chromium-review.googlesource.com/c/1480195
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634834}

It almost always crash on CQ bot linux-rel.

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=query-encoding%2Futf-16le.html

Bug: 930297
Change-Id: I456dddf952daffae77efdf023fe0790df4644d4a
Reviewed-on: https://chromium-review.googlesource.com/c/1483684Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634833}

This change allows AnswerSuggestionProcessor to manage Calculation
suggestions as well, ensuring all answers (including calculation) are
uniformly processed when new answer layout is enabled.

Bug: 920396
Change-Id: If233480827eb286131eae4a761b8cb9d210cdc3a
Reviewed-on: https://chromium-review.googlesource.com/c/1481953Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#634832}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/245337d62e22..151c3484da58


git log 245337d62e22..151c3484da58 --date=short --no-merges --format='%ad %ae %s'
2019-02-22 sergiyb@chromium.org Replace post-process checks with ones that are not deprecated


Created with:
  gclient setdep -r src/third_party/depot_tools@151c3484da58

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:899266
TBR=agable@chromium.org

Change-Id: I8eda5926e8c32d8be88e9b5dcd5181a5fdf23230
Reviewed-on: https://chromium-review.googlesource.com/c/1483870Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#634831}

Bug: None
Change-Id: Ibd0ba93f9b06aabe342f63b87443de46e8cf0023
Reviewed-on: https://chromium-review.googlesource.com/c/1483705
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634830}

This reverts commit 75a861f2.

Reason for revert: It turns out this is an upstream issue. See:

- https://chromium-review.googlesource.com/c/chromium/src/+/1482557
- https://github.com/Valloric/ycmd/pull/1193

Original change's description:
> [Vim/YCM] Fix missing system headers when YCM was built with its own libclang.
> 
> Bug: 932667
> Change-Id: I2eb9965da1eb3f9ad4a5ce103cf6e32d35019e48
> Reviewed-on: https://chromium-review.googlesource.com/c/1476105
> Auto-Submit: Sidney San Martín <sdy@chromium.org>
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Commit-Queue: Asanka Herath <asanka@chromium.org>
> Reviewed-by: Asanka Herath <asanka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632846}

TBR=sdy@chromium.org,asanka@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 932667
Change-Id: I5a684c91723d28470e1d903cd74674ce145b421b
Reviewed-on: https://chromium-review.googlesource.com/c/1483709Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634829}