GitLab

libwebp @ v1.1.0-37-g9f6055fc

+ sync fuzz_seed_corpus w/libwebp-test-data and delete unused local copy

animdecoder_fuzzer.cc isn't built as all its dependencies aren't
imported currently; WebPAnimDecoder is unused in chrome

NOPRESUBMIT=true (due to include/nullptr warnings in third_party code)

Bug: webp:409
Change-Id: Id41fd215652d0339af3410e7948350456ddce2ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482388
Commit-Queue: James Zern <jzern@google.com>
Reviewed-by: Urvang Joshi <urvang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818744}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chonggu@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chonggu@google.com
Change-Id: Iad4f08b81d86af1b455105bedfaa0abfa859cbea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486446Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818743}

This information is of interest, especially in case of Board ID flags
misconfiguration incidents.

BUG=chromium:1089267
TEST=none

Change-Id: Ib93b0df5b58d08e72a1075a56c1bff24df53f6ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446196Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Auto-Submit: Vadim Bendebury <vbendeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818742}

https://dawn.googlesource.com/dawn.git/+log/aff4c0366314..c4593127cbdd

2020-10-19 dsinclair@chromium.org Include compiler header
2020-10-19 cwallez@chromium.org Roll third_party/swiftshader/ 2014e7b92..df17a7610 (79 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: dsinclair@google.com
Change-Id: Ife1ab7429ea37ad4ea138e777cee6e39a8e678fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486283Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818741}

ICU 68, to work with C++20, remove the #define of TRUE
since the usage in libxml is as an int, use 1 instead.

Bug: 1138555
Change-Id: I4c5955b3e80beccc8de071a129172af07c0ae0ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478027Reviewed-by: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818740}

We had installed the accelerator via a PreTargetHandler,
mainly because we did not realize AcceleratorController existed.

Fix this, then fix a bug that was realized afterwards.
 - Prevent launcher from showing when non-related keys are pressed.
 - Send KEY_RELEASED events when sending synthetic key events
   as to not confuse AcceleratorHistory.
 - Fix some tests which do not send key release events.

Change-Id: I31678cfd05e6ccf7f662aab2d8276d5eaefa1539
Bug: 1136201, 1131727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453918Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818739}

We're no longer using this flag or it's finch equivalent in code,
this CL removes them.

Bug: 1110580
Change-Id: I7c25e134ada13d415ab34ebe6f2527e076879d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485973Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818738}

Release team strongly prefers a kill switch for merges to stable.

R=costan@chromium.org

Bug: 1139902
Change-Id: I6b7f98c3d1032c1cf9098d2ded87413e89bdd530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486396
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Auto-Submit: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818737}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ebddc236e489..13e275d7e504

$ git log ebddc236e..13e275d7e --date=short --no-merges --format='%ad %ae %s'
2020-10-16 dtor system_api: add native error codes to Parallels dispatcher responses
2020-10-15 nverne permission_broker: remove unused OpenPathWithDroppedPrivileges
2020-10-05 kevinptt runtime_probe: add probe result format error

Created with:
  roll-dep src/third_party/cros_system_api

Bug: b/168829032
Change-Id: I87516d71d4ee99a1ad212713df5b903aa0baefe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486032Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818736}

Bug: 1132403
Change-Id: I26395b161c9d9d7885e85ca83f297e032f56c362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477417Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818735}

Failing a CFI check in third_party/vulkan_memory_allocator

Tbr: kbr@chromium.org
Bug: 1139916
Change-Id: I588a5ce228b41ac386fb0a477ee4e889631c0a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485678Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818734}

This CL fixes
1 - Fixes the IPH config values for click and dismiss counts, i.e. IPH
    card disappears after one click or one dismiss.
2 - Summary card is sticky on NTP until explicilty dismissed
3 - Added finch provided image URL for summary card
4 - Reordered video tutorial IPH card to show below most visited tiles
5 - Fixed an issue in thumbnail generation for IPH and list items
6 - Changed video tutorial WebUIDataSource to be added only once.

Change-Id: Ibce134248a35af555fb1d9e146cc8fce3a87e81a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473345Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818733}

- Removes some 'pepper_flash_*' files that were removed from the build.
- Removes PPB_Flash_File and PPB_Proxy_Private that are now unused.
- Removes assorted things in content/ and ppapi/ that are no longer
  relevant without Flash.
- Removes PepperPluginInstanceImpl::is_flash_plugin method.

Bug: chromium:1064652
Change-Id: I6905b64de90a58668e007a1282a6b6b248506358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481283Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818732}

MSE worker thread termination or worker removal of SourceBuffers can
race the thread hopping of the OnMetadata signal. If MSE track removals
win the race such that pipeline's reported metadata contains no audio or
video, then when handling that metadata in WMPI, this change issues
player load error instead of transitioning to HAVE_METADATA. This fixes
a crash resulting otherwise because transition to HAVE_METADATA without
MSE pipeline metadata having any A/V previously enabled beginning
playback (in WMPI::Play()) without having a WatchTimeReporter.

I tried reproducing similar failure first using MSE from the main
thread (not MSE-in-Workers) and trying to get removeSourceBuffer to
occur precisely in time to win the race, but was unable to get a repro
with a bit of trying. However, I still suspect this issue could have
pre-existed MSE-in-Workers.

The change is not specific to MSE, since WMPI should prevent successful
playback start if the resource has neither audio nor video metadata.

This change also includes a test note to add a feature to MSE-in-Workers
(feature-detection of MSE-in-Workers support from main/Window context)
and to use it to deflake the test itself which could flakily fail (not
crash as is fixed by this change) on implementations that do not support
MSE-in-Workers yet.

BUG=878133,1139854

TEST=Updated WebMediaPlayerImplTest.NoStreams (blink_media_unittests),
and manually verified on linux locally: flaky crash appears fixed for
.../dedicated-worker/mediasource-worker-play-terminate-worker.html

Change-Id: I8a9d8428417555089c8b09f4bc1e19849bbe0162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486074Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818731}

Bug: 1131543
Change-Id: I0a4be1040028c00f720d0396a2b1cfe88ee44a60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480890
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818730}

Change-Id: I51dae7553c07f2f2ea1bc3aa9bb26cd2a3627447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481788
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818729}

Out of 15 files referring to OmniboxFocusReason only 3 need the
LocationBar itself:
 - CustomTabToolbar
 - ToolbarManager
 - ToolbarLayout

Bug: 1139481
Change-Id: I3e6cc1da9d79a8e75fb4b2b456181ab18a251b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481926Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: who/bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818728}

Change gfx::BufferHandle to use a gfx::ScopedIOSurface instead of a
gfx::ScopedRefCountedIOSurfaceMachPort.

Reason for using a mach port: It's the thing that goes over all forms
of IPC.

Reason for not using a mach port: The mach port's existence makes the
IOSurface report that it is in use. This makes it so that things like
CVPixelBufferPools will not re-use that IOSurface. The capture pipeline
keeps lots of gfx::BufferHandles around, which causes the underlying
CVPixelBufferPool to go haywire (in this case growing without bound,
but another valid way to blow up is to just hang and never capture
any more frames).

Also remove some debugging code.

Bug: 1139105
Change-Id: I1ffa11a325b6a8e1811a23b1c4d7dac00fad49db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485992Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818727}

Add optimizations to the HttpsLatency routine along with correct host
resolution code.

BUG=chromium:956783
TEST=unit_tests --gtest_filter=HttpsLatencyRoutineTest.*

Change-Id: I60b4bfc47e973acf48c289bd0bc524d7b4490bfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483032Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818726}

Increase the rate limit to prevent pita tast tests from flaking

Unlike cupsCopyDestInfo(), cupsDoRequest() does not appear to retry
requests when the server is busy.

If the tests still flake, this limit may have to be increased again.

Bug: none
Test: tast run -buildbundle pita <DUT> printer.*

Change-Id: Idbd0f485cf47e059e9bd80a5b53e338887ba7d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470302Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Pranav Batra <batrapranav@chromium.org>
Auto-Submit: Pranav Batra <batrapranav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818725}

This patch has a few fixes needed before enabling isolated splits in
canary:
- Make module_installer load classes from the application context
  ClassLoader instead of using Class.forName, since that may be using
  the base ClassLoader and not have the chrome split classes
- Fix some of the bundle smoke tests since the DFMs are merged into the
  chrome DFM.
- Fix the chrome resources package (org.chromium.chrome.R) clashing with
  the base module's resources when the APK package name matches.
- Ignore chime services which are not defined in the base module, since
  they will not be used with isolated splits.

Bug: 1126301
Change-Id: Ib149894636863408c5fd37054eacb48c214b5b3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472707Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818724}

If the overlays are the only damages in the frame, we will get a zero
root damage rect with the new way of calculating damage rect
|use_overlay_damage_list_|, which is enabled by default.

The old code of |use_overlay_damage_list_| == false is still working. It
will be cleaned up once the new code is stable.

Bug:1117235

Change-Id: Ibbede44056973a5ba9e052292673bbf0bcb4a50a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434905
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818723}

Bug: 1133748
Change-Id: I33c8d0d97e20ba86943332d41a9ee68ae1fbf4be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481463Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818722}

Bug: 1131543
Change-Id: I196eb050b6b6a91dba4da76ee9915a2011f1b57e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480802
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818721}

Original PR
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841

Explainer for this feature is https://docs.google.com/document/d/14qJ1rZyMtnIa8hPJc1V8DJRxk4lVI3hlWYGvBDICog0/edit?ts=5f7c13ce

Bug:1137050

Change-Id: I6b1dda29537e05c415b2f6479c03dee989281a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485849
Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818720}

"z-index: 1" was introduced to render the icons over the ripple when
the ripple could be opaque. The opaque ripple feature has since been
removed.

Bug: 1140234

Change-Id: Icb1d8fbe9a40f89fe7a6593f22283671ecdbcbab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486386
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818719}

http/tests/devtools/network/network-filter-service-worker.js fails on
Linux Tests,
https://ci.chromium.org/p/chromium/builders/ci/
Linux%20Tests%20%28dbg%29%281%29/92362,
disable it for now until it is fixed.

TBR=tvanderlippe@chromium.org
NOTRY=True

Bug: 1140281
Change-Id: Iaa1cdd9b6ff12fa3911dcbec647aa57a17d8ee65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486117Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818718}

Currently we don't record this for JS crash reports.
chrome://media-app wants to record the uptime of the browser process
to help track down potential race conditions.

We think this can be useful in general for JS errors.

Doc: http://go/backlight-better-crash-report#heading=h.1fkxhdmqpt47

Note: we have Process uptime & Process type fields in chrome crashes
and I believe we plan to add this in for JS crashes in crbug/1121816.

Change-Id: Ide154b49d2f9791cb044885054a5ff929f720618
Bug: b/169635499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463094
Commit-Queue: David Lei <dlei@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Auto-Submit: David Lei <dlei@google.com>
Cr-Commit-Position: refs/heads/master@{#818717}

https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..e6f794f1dc5d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I3a4fe97cd8b8d1b97a5a3c085a601467bc8327cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485623Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818716}

Each of the 6 test cases in this test take a minimum of 200ms due to
the waitForAnimationEndTimeBased call. This was resulting in flakiness
due to being too close to the default timeout for web tests. Fix the
flakiness by separating them into two separate tests.

Leaving these tests disabled as there appears to be a different
underlying issues causing failures on Mac.

Bug: 1038354
Change-Id: I9fbf07f1e5a76e770bb1c028615fa36bbb6123fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477478
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#818715}

Bug: 971272
Change-Id: I72255f8f388281977045954b1b80a28240e27b33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435580
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818714}

In the landing process of ICU68 we found these need to be changed
since ICU68 no longer define TRUE and FALSE for UBool to
avoid C++20 problem.

Bug: 1138555
Change-Id: I64fd98c99864aa86b07280537a780105cb0eabbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473522Reviewed-by: Frank Tang <ftang@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Marian Fechete <marianfe@google.com>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818713}

Append persisted breadcrumbs to Syntheric Crash report. After this CL
Synthetic Crash reports will be uploaded only if Breadcrumbs feature is
enabled as without Breadcrumbs these reports are not useful.

Bug: 1103752
Change-Id: Ia4489b86f07ea7f77e012abb8c0124d7347c2871
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410302
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818712}

Currently if a user taps on a window cycle list item it only moves the
focus ring to that item. Based on UX feedback, this interaction should
be changed such that when a user releases their finger the selection is
confirmed. This CL implements that feedback.

Test: manual + modified existing test
Bug: 1136625
Change-Id: I64736f3f98fe0b21efc1211d0e64749a42cde40b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468918
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818711}

This CL introduces no behavior changes.
Now WebAppRegistrar::GetAppIds() uses foreach GetApps().

In follow up CLs:
- rename AllApps() to GetAppsIncludingStubs() (urgent)
- migrate more cases to use GetApps() instead of AllApps() (not urgent)

Implementation details:

AllApps() and GetApps() use protected method FilterApps(filter).
In general, FilterApps() allows to iterate over various subsets from
AllApps().

Internally, Iter::FilterAndSkipApps() filters out unwanted entries.

Bug: 891172
Change-Id: I9a136f9b4f77e77eac28e13d9281453015145925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1295131Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818710}

We're still using all metrics for the local search service and auto
screen brightness, which are nearing expiry. This extends them all
to 2021-06-30.

Bug: 1139968, 1139969, 1139970, 1139971, 1139972, 1139973, 1139974, 1139975, 1139976, 1139977, 1139978, 1139979, 1139980, 1139981, 1139991
Change-Id: Iae29437854b38d99e450c48ea6b8f8d783c58d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485994Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818709}

OnPaymentAppInvoked() is not invoked immediately after invokePaymentApp().

This patch renamed from ServiceWorkerPaymentApp::OnPaymentAppInvoked()
to ServiceWorkerPaymentApp::OnPaymentAppResponse().

Bug: 1132405
Change-Id: I7f6ba3bf40061e23a7c8c48264137023e4a4ba12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483948Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#818708}

Currently, on-focus logic (like select-all, unelide) is distributed
between LocationBarView and OmniboxViewViews.

Having it exist in LocationBarView is undesirable for two reasons:
 1. All of the calls call into omnibox_view_->FooBar(), so the parent
    class is containing logic that wholly should belong in the child
    view.
 2. The logic cannot be unit tested within OmniboxViewViewsTest unit
    test. This forces us to put it in a browser test, which is slower
    and flakier.

This CL moves this logic into the child OmniboxViewViews class.

This CL also moves the browser test into the unit test.

Bug: 1138113, 45260, 751031
Change-Id: Ib5d15ae849f6cd42b27f08dbfbca2c8c7d3367d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485561
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818707}

This CL adds a simple version of the find_bad_builds.py script. It finds
builds which may contain a given CL which was landed and then reverted.

Future CLs add more features to this script. See https://crrev.com/c/2464165
for a fuller description.

Bug: 1137072
Change-Id: I3b4469b74d2be69af7655c20082900bbe0b5377f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469226
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818706}

BUG=1140143
TEST=none

Change-Id: If89a59ce8992c13ef269b24dbe0a1458c72718fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485842Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818705}