- 05 Sep, 2018 40 commits
-
-
Matthew Jones authored
This is a reland of f7f910d0 with the changes from https://chromium-review.googlesource.com/c/chromium/src/+/1208293 applied. Original change's description: > Add ActivityTabProvider to ChromeActivity > > This patch adds ActivityTabProvider to ChromeActivity. This class > provides an easy mechanism for classes that care about the tab > that is currently in the foreground (i.e. not in the tab > switcher/toolbar swipe/animation layout). > > The observer provides either the activity's tab or null depending > on the state of the browser. The null event can be ignored depending > on the listener. > > The ActivityTabObserver interface only has a single method: > onActivityTabChanged(Tab t) > > When an observer is attached to the provider, onActivityTabChanged is > called on only that observer with the current tab (giving it access > without requiring a handle to a larger object). > > Bug: 871279 > Change-Id: Ice961224c6690dc79c38f5d6cb255fed4730c8ce > Reviewed-on: https://chromium-review.googlesource.com/1165489 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588872} TBR: tedchoc Bug: 871279 Change-Id: I9c17590de19db025110cda2171cd1f8d9c1ffa57 Reviewed-on: https://chromium-review.googlesource.com/1208714Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#589018}
-
Dominic Mazzoni authored
In a few places in the code we call AXTreeSerializer::Reset when there's a tricky reparenting issue or when we really want the accessibility tree to be re-serialized from scratch (like when the mode changes). However, this can lead to a corner case where the next update from the serializer can't be unserialized, because the client tries to unserialize it as an incremental update, but it contains some reparenting. The trick is to just ensure that we always set node_id_to_clear on the next update after a reset. That also requires us to relax the previous requirement that node_id_to_clear must be valid. Now the serializer sets node_id_to_clear to be equal to the root after a reset, to guarantee that the client ends up with a fresh start. Bug: 878325 Change-Id: Iff255a3f62e47363be0b3d9c2f6809c229a6a00f Reviewed-on: https://chromium-review.googlesource.com/1198009Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589017}
-
Christian Biesinger authored
In the hope that this is faster. This also matches the style we use elsewhere in the code. Additionally, this makes a small change to NGLayoutResult to avoid an unnecessary adddref (PhysicalFragment() constructs a new scoped_refptr) Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9d59180ca0f6c95401ae2d7e36616244d66c59d6 Reviewed-on: https://chromium-review.googlesource.com/1208251Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589016}
-
David Grogan authored
It's no longer in *active* development but it's a good feature and we hope to get back to it. Marked all the tests as Failure. Bug: 174167 Change-Id: I9ec257a2ac644ccc8588043c63c796aa8185094b Reviewed-on: https://chromium-review.googlesource.com/1208432 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589015}
-
Mathieu Perreault authored
A wrong value of GetDetectedValues was used (after addresses were elided). This change stores the value of GetDetectedValues so it's not re-computed. Bug: 878416 Change-Id: Ifd8190148a0bf8dd3643da4016fb41dea3cc1ae3 Reviewed-on: https://chromium-review.googlesource.com/1208194 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#589014}
-
John Z Wu authored
@protocols do not create symbols so there's no need to export them. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1cc08845aa95a478805838dce476a15f4b57ec50 Reviewed-on: https://chromium-review.googlesource.com/1205492Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#589013}
-
Filip Gorski authored
Bug: 714109 Change-Id: Icc18f9cf5d338e3c9ae213a2bd8697d4c11674a1 Reviewed-on: https://chromium-review.googlesource.com/1207711Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#589012}
-
Scott Chen authored
Bug: 832933 Change-Id: I36e6ccf6b8d47a9386df5a34feb3d12d15fe7880 Reviewed-on: https://chromium-review.googlesource.com/1204971Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589011}
-
Ted Choc authored
The initial version focuses on the layouts and initial styles. This specifically does not bring over the images yet. BUG=876372 Change-Id: Ie3b25e2eddcba5c061d8f649874f2d9dd796abc2 Reviewed-on: https://chromium-review.googlesource.com/1194563 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589010}
-
Matt Wolenetz authored
Due to prevalence of MSE support in other browsers for legacy incorrectly muxed content where AVC keyframeness is incorrectly marked in the MP4 container, this change expands the previous chrome://media-internals logging when such mismatch is detected, to trust the keyframe-ness of the AVC coded frame for buffering and decoding. Otherwise, such streams, especially those with frames incorrectly marked as keyframes in the MP4, would be buffered as out-of-order GOPS rather than out-of-order nonkeyframes, corrupting the buffering and decode sequence on playback in the new, compliant, MseBufferByPts logic. Seek preroll from actual AVC nonkeyframes in legacy MseBufferByDts logic should also be fixed by this change. BUG=879734,844799,229412,760264 Change-Id: I90f53ec333e1aeeeaf39e96e176438cb13b4a195 Reviewed-on: https://chromium-review.googlesource.com/1205640 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#589009}
-
Michael Spang authored
Using the VK_LAYER_GOOGLE_image_pipe_swapchain layer we can create a swapchain for an image pipe and assign it as the texture of a scenic window. This does not work from the viz process yet as we would need to plumb the image pipe handle over from the browser using FIDL or mojo. Rendering needs to be done from the UI thread via VulkanBrowserCompositorOutputSurface or a test app such as ozone_demo. This also will not work until vulkan synchronization is fixed, see https://crbug.com/877684 Bug: 861853 Test: content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu Change-Id: I79ac045c6d6deb20f49023c8e8e9492631700703 Reviewed-on: https://chromium-review.googlesource.com/1188974 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#589008}
-
Ben Pastene authored
The following two dirs can accumulate cruft over a VM's life time: - /var/log/chrome/ - /var/spool/crash/ This clears them before each test. Should become unnecessary when crbug.com/878526 is closed out. Bug: 880878 Change-Id: I5414cb65016294938e9e68db495946bbb05cad48 Reviewed-on: https://chromium-review.googlesource.com/1208254Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#589007}
-
Theresa authored
BUG=875541,875542 Change-Id: Ifbf0803605b049a1639a4a609c5fc668c8257658 Reviewed-on: https://chromium-review.googlesource.com/1205791 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#589006}
-
Tatiana Buldina authored
Change-Id: I9c6f935e3ce9b55297151dd8eabc57c15754081b Reviewed-on: https://chromium-review.googlesource.com/1204850 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589005}
-
David Tseng authored
The Tts engine component extension was converted to an event page in: https://chromium-review.googlesource.com/c/chromiumos/platform/assets/+/447000/5/speech_synthesis/patts/manifest.json This means the extension is aggressively unloaded. In particular, on startup, it is not loaded until the extension receives a request. In code paths that require the engine to be awake, explicitly wake the event page. Bug: 880556 Change-Id: If49f3b59440bd64a9a0af7382f25e054285a26bf Reviewed-on: https://chromium-review.googlesource.com/1205092 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#589004}
-
Samuel Huang authored
This reverts commit 0060319d. Reason for revert: http://crbug.com/881042 : exo_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1) : Speculative revert to see if it fixes the memory leak (also in other tests). Original change's description: > Disable lock screen notification by default > > The feature is not launched on M70. This CL should be merged to M70 branch as well. > > R: yamaguchi@chromium.org > TBR: oshima@chromium.org > Bug: 880227 > Change-Id: I2d8f3dbe97bcd0c8d28cfe775e2c86dd1e169d11 > Reviewed-on: https://chromium-review.googlesource.com/1206551 > Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588815} TBR=yoshiki@chromium.org,oshima@chromium.org,yamaguchi@chromium.org Change-Id: I8fe6b9ca4fbf195e229e44d5a85e1c5589733e8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880227 Reviewed-on: https://chromium-review.googlesource.com/1208136Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#589003}
-
Sean Topping authored
In some cases, the main gesture handler might permanently have priority, and lower priority handlers (such as the root UI) will never receive a gesture until that handler is removed. This change ensures that if a user attempts multiple gestures in quick succession, that the root UI will receive the gesture instead. This mitigates buggy gesture handling logic and prevents the UI from being permanently stuck. then try to swipe several times in succession. Eventually the root UI should handle the swipe. Bug: internal b/112338841 Test: Run an app which is permanently able to handle gesture events, Change-Id: I741e041feba56b5e87ad8cb3ca5e1f564f48518b Reviewed-on: https://chromium-review.googlesource.com/1199967 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#589002}
-
Reilly Grant authored
This change adds support for handling the |to_be_removed_request_headers| and |modified_request_headers| parameters to FollowRedirect(). The changes are reflected in the stored request object and passed on to the underlying URLLoader. Bug: 880069 Change-Id: I5c79b358537c741467bd5e2d3a71d19cfa5dec42 Reviewed-on: https://chromium-review.googlesource.com/1207712Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589001}
-
Michael Nye authored
This missing default can cause some audio streams to be muted by default. Bug: b/113075348 Test: Ran changes on developer device Change-Id: Icaa75cf3d78a85f978b91dfa1de44d21b9266328 Reviewed-on: https://chromium-review.googlesource.com/1192114 Commit-Queue: Michael Nye <michaelnye@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#589000}
-
Scott Violet authored
The EventInjectorDelegate implementation for mus has a special EventTarget. The base class of EventInjectorDelegateMus assumes it can cast EventTargets to Window. The casting doesn't work for the special EventTarget (it isn't a Window). This patch adds the necessary overrides to special case the non-Window EventTarget. BUG=814675 TEST=covered by tests Change-Id: Icf2de31115e54630043c162ae45acdde2904877d Reviewed-on: https://chromium-review.googlesource.com/1208459Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#588999}
-
Jordy Greenblatt authored
The new mocks switch the Settings UI page order near the MultiDevice (a.k.a. Connected Devices) sections from Network Connected devices Bluetooth to Network Bluetooth Connected devices See the new order in this screenshot of this CL deployed: https://screenshot.googleplex.com/TJuzLmqHNsL Bug: 871351 Change-Id: Iba4016a6ad9b0954f2d5b467aab17a293bd0102e Reviewed-on: https://chromium-review.googlesource.com/1205501Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#588998}
-
Filip Gorski authored
Bug: 881000 Change-Id: Icfe8def8af1abce2e36bc9400d43ef27b5a1f678 Reviewed-on: https://chromium-review.googlesource.com/1208460Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#588997}
-
Daniel Erat authored
Add a getHistogram function to the chrome.autotestPrivate that Chrome OS integration tests can call to get data about a given histogram. This will hopefully be more reliable than the current approach of parsing chrome://histograms. Bug: 878641, 844755 Change-Id: I9077c297a69742b9e225eefed52fe4b012d796fa Reviewed-on: https://chromium-review.googlesource.com/1200840 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#588996}
-
Daniel Zhang authored
Fix bug where AppList bounds were 28 px too tall in peeking and closed states. Bug: 874200 Change-Id: I9b449c9310d946b405bb3b8f0610e5e1018c6872 Reviewed-on: https://chromium-review.googlesource.com/1205497Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Daniel Zhang <oxyflush@google.com> Cr-Commit-Position: refs/heads/master@{#588995}
-
Chris Sharp authored
Change-Id: I4eb83bb32f60323b990a8066ab3a72df7e38359f TBR=grt@chromium.org Change-Id: I4eb83bb32f60323b990a8066ab3a72df7e38359f Reviewed-on: https://chromium-review.googlesource.com/1193746 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#588994}
-
Jialiu Lin authored
If user stays in advanced protection, ::OnGetIDToken(..) will not trigger scheduling next refresh. This CL fixes this issue. This CL also enables most unit tests on Chrome OS. Bug: 880931 Change-Id: I59d2c30b7a87bb59b755bea0b31b32081d21ef11 Reviewed-on: https://chromium-review.googlesource.com/1207577Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#588993}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/750e508722a9..79ec21c5d4cf git log 750e508722a9..79ec21c5d4cf --date=short --no-merges --format='%ad %ae %s' 2018-09-05 jmadill@chromium.org Small style guide amendments. Created with: gclient setdep -r src/third_party/angle@79ec21c5d4cf The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ic628b0b3c1840cd4ff801728a5b764ebe52b23ab Reviewed-on: https://chromium-review.googlesource.com/1208071Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588992}
-
Daniel Erat authored
Add a switch that can be used to supply an alternate interval (in seconds) between the ExternalMetrics class reading UMA events and histograms reported by Chrome OS system daemons from /var/lib/metrics/uma-events. I intend to use this in a test that will verify this reporting path (without needing to wait the current default of 30 seconds). Bug: 878641 Change-Id: I83f3ba70b7c32ddd598e1793a71900ef5b72b667 Reviewed-on: https://chromium-review.googlesource.com/1202023 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#588991}
-
Samuel Huang authored
This reverts commit f7f910d0. Reason for revert: https://crbug.com/881012 : chrome_public_test_apk failing on chromium.memory/Android CFI with new failure in org.chromium.chrome.browser.firstrun.FirstRunIntegrationTest#testRedirectChromeTabbedActivityToFirstRun Original change's description: > Add ActivityTabProvider to ChromeActivity > > This patch adds ActivityTabProvider to ChromeActivity. This class > provides an easy mechanism for classes that care about the tab > that is currently in the foreground (i.e. not in the tab > switcher/toolbar swipe/animation layout). > > The observer provides either the activity's tab or null depending > on the state of the browser. The null event can be ignored depending > on the listener. > > The ActivityTabObserver interface only has a single method: > onActivityTabChanged(Tab t) > > When an observer is attached to the provider, onActivityTabChanged is > called on only that observer with the current tab (giving it access > without requiring a handle to a larger object). > > Bug: 871279 > Change-Id: Ice961224c6690dc79c38f5d6cb255fed4730c8ce > Reviewed-on: https://chromium-review.googlesource.com/1165489 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588872} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org Change-Id: I2e1a6991f0478632a95b53969394a2314392a5dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871279 Reviewed-on: https://chromium-review.googlesource.com/1208361Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#588990}
-
Christian Biesinger authored
I'm trying to figure out why NGLink made things slower, and while I don't expect these changes to make the difference, they shouldn't hurt. R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7dd6f5130f3ebcd07dfb44d0af801ab28516bcc9 Reviewed-on: https://chromium-review.googlesource.com/1207650 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#588989}
-
Zach Helfinstein authored
Refining the isActionable method to not include elements that are disabled. Bug: None Change-Id: I05f85282904af5025615cf8efde6945f219bad20 Reviewed-on: https://chromium-review.googlesource.com/1206030Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#588988}
-
Kenneth Russell authored
After the update to the 24.20.100.6286 driver, these tests should be passing. Re-enable: webgl_conformance_d3d9_tests webgl_conformance_d3d9_passthrough_tests conformance2/glsl3/short-circuiting-in-loop-condition.html Tbr: zmo@chromium.org Bug: 841789, 843369 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1ec732be8a283c2fdb68bf316943ee2d7d0b65b1 Reviewed-on: https://chromium-review.googlesource.com/1207652Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588987}
-
Ben Pastene authored
The pak file gets generated when building chrome for HiDPI: https://codesearch.chromium.org/chromium/src/chrome/chrome_paks.gni?rcl=9a8cfdf0edde3f7d61d08b5890a94c038a15f3fb&l=220 But it doesn't show up in the target's data. Consequently, it's missing from tests' isolate. This should fix that. Bug: 878730 Change-Id: I1e95c41a18cfe88a83235b42605c53829f9a344f Reviewed-on: https://chromium-review.googlesource.com/1197826Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#588986}
-
chcunningham authored
Tracking down crash in static mime parsing code. Hopefully all we need is the input string. Bug: 809912 Change-Id: Iacc44a26f981bf84a49eeeac24001f205b1f2a52 Reviewed-on: https://chromium-review.googlesource.com/1205994 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#588985}
-
James Cook authored
Pressing Ctrl-F creates a widget for DropdownBarHost and a textfield for the text entry view. The view requests focus, which calls into DesktopNativeWidgetAura::ClearNativeFocus() to return focus to the active widget's contents aura::Window. There's a special code path in FocusController for this case. However, the existing window service code in //services/ws was always using FocusController::FocusWindow() to maintain its version of focus. That code path blocks focusing a parent when a child is focused, see https://codereview.chromium.org/11519040 Instead, allow the window service to ResetFocusWithinActiveWindow() in this case, similar to what the client is doing. This fixes both Mash and SingleProcessMash. It also fixes a similar issue with Ctrl-L and omnibox focus. Bug: 880533 Change-Id: Iaa3132d7e32b96bf2ad33f781f6696ec9c88218d Reviewed-on: https://chromium-review.googlesource.com/1205498Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#588984}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/58e53ea82f25..b27d084b0112 git log 58e53ea82f25..b27d084b0112 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 dj2@everburning.com Revert "BUILD.gn: Make a better interface with dependents. (#1875)" (#1876) 2018-09-05 corentin@wallez.net BUILD.gn: Make a better interface with dependents. (#1875) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b27d084b0112 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I75d27e2add9990ccd3c6fc80fe40b28cf6297e8a Reviewed-on: https://chromium-review.googlesource.com/1208070Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588983}
-
Xida Chen authored
This CL adds temporary fix in TouchActionFilter to prevent crash. We'd likely need to merge this back to 70 for the next Android dev release. Bug: 869375, 880018 Change-Id: I087f39f64ba31dc4b5f8edfd2f6b0b0ae28da76d Reviewed-on: https://chromium-review.googlesource.com/1207094Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#588982}
-
Alex Leung authored
Bug=b:111935545 Change-Id: I991b5161d14aadae59576dbab231631364b47f8b Reviewed-on: https://chromium-review.googlesource.com/1187681 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#588981}
-
Robert Phillips authored
This change lets Chrome see the bug fix from the Skia CL: https://skia-review.googlesource.com/c/skia/+/12733 (Fix srcBounds computation in SkMatrixConvolutionImageFilter) which fixed some matrix image filter problems when tiling (i.e., the edges would become darker bc some input pixels needed for filtering were being discard) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9fca093a223104b85847b0b3a3c0a6a29871d5ba Reviewed-on: https://chromium-review.googlesource.com/1131554Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#588980}
-
James Wallace-Lee authored
Fixes a crash from HitTestSync caused by writing to nullptr. Bug: 880801 Change-Id: Icc01027f6aa2fb60956bdc1ecafb96048680e895 Reviewed-on: https://chromium-review.googlesource.com/1208190 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#588979}
-