- 02 May, 2018 40 commits
-
-
Alexander Alekseev authored
Not yet suported service "usm" needs to be behind flag CrOSEnableUSMUserService. Bug: 837107 Change-Id: If3bfc4d58d1894074fb7b50c94b8fe91ee459e5a Reviewed-on: https://chromium-review.googlesource.com/1038813Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#555488}
-
Avi Drissman authored
BUG=838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8df9263f159af6a1152b46882a80bec0c52a822d Reviewed-on: https://chromium-review.googlesource.com/1036566Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555487}
-
Charlie Harrison authored
This is a pre-req to a refactoring effort splitting off logic from main.cc and adding new tests. This CL also changes rule_stream_test.cc -> rule_stream_unittest.cc Bug: 833419 Change-Id: I9c73a336c2bae2fdbdbe7db68346c8c9a64be325 Reviewed-on: https://chromium-review.googlesource.com/1040045 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555486}
-
Dmitry Gozman authored
This is a reland of c07726e1 Original change's description: > Move manifest.mojom and content::Manifest to blink > > ... as a part of Onion Soup project. > > This also required moving WebDisplayMode from public/platform > to public/common since it's referenced both in manifest itself > and, more generally, browser code. > > mojom::blink::Manifest is typemapped to blink::Manifest, which uses > stl types and should be used by blink's embedder, not blink > implementation. > > Bug: 704441 > Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae > Reviewed-on: https://chromium-review.googlesource.com/1006188 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554953} TBR=dgozman Bug: 704441 No-Presubmit: true Change-Id: Ie4f16da0aa695e6eecef72574f263cbbb4b3254f Reviewed-on: https://chromium-review.googlesource.com/1036507 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555485}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2050565fe116..f9ab22385ead $ git log 2050565fe..f9ab22385 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 robertphillips Modify SkGpuBlurUtils::GaussianBlur's reexpand method and allow more approx fit intermediates 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms 33bdf05..513d372 (1 commits) 2018-05-01 herb Reland "Remove devKerning" 2018-05-01 herb Take sk_sp<SkDevice> instead of SkDevice* 2018-05-02 skcms-skia-autoroll Roll skia/third_party/skcms a1c0fe6..33bdf05 (1 commits) 2018-05-02 kjlubick Add public repro instructions for repoducing fuzzers 2018-05-02 mtklein Revert "fonts: Set up remote glyph caching to push fonts." 2018-05-02 mtklein Revert "Remove devKerning" 2018-05-02 mtklein Revert "fonts: Dont memcpy with nullptr in SkRemoteGlyphCache" 2018-05-02 mtklein Revert "fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache." 2018-05-02 mtklein Revert "Add padding back to make msan happy" Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ic58c56833d60fbd583fbf671a31cfb3fb94eb975 Reviewed-on: https://chromium-review.googlesource.com/1039772Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555484}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1eb58e1f8892..1037c743e338 $ git log 1eb58e1f8..1037c743e --date=short --no-merges --format='%ad %ae %s' 2018-05-01 ehmaldonado presubmit: Don't overwrite cwd when running tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:829084 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iba54fff4eeb01ec9698dab0338cb391054c1874a Reviewed-on: https://chromium-review.googlesource.com/1040106Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555483}
-
Dave Schuyler authored
This CL passes the correct available width to ComputeMatchMaxWidths so that the text get an ellipsis if needed. Also, the description view will not be shown if there is no space for it. Bug: 836740, 838592 Change-Id: I096fddd1191dfb61f1cd008e4b81a79bd718d1f2 Reviewed-on: https://chromium-review.googlesource.com/1038618Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555482}
-
Olivier Robin authored
RationalizeCreditCardFieldPredictions run twice - Once after getting the heuristics type - Once after getting the server types. The second time, the local type used to rationalize is the result of the first run. This means that if the type is remove on the first run, the server data wont restore it. Change implementation to always use the heuristics result during this rationalization. Also introduce overall_type. overall_type will give the result of local computation, after heuristics and rationalization. heuristics_type will keep the result of the heuristics type inference. Change-Id: I90dd108f92f3cbcf06cbe1ed41c033bf51ccbd3e Reviewed-on: https://chromium-review.googlesource.com/1016913 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#555481}
-
Peter Kasting authored
This method was used in the following places: (1) TabScrubber, where the code did nothing. (2) BrowserNonClientFrameViewMus, to handle the tabstrip being deleted before the frame. (3) GlassBrowserFrameView, to NOTREACHED() because the tabstrip should never be deleted before the frame. (4) A test that the call was fired. Because of (3), I assume (2) is actually dead code. Since that's the only functional use, it seems like this whole method can disappear. BUG=none TEST=none Change-Id: I5945ccd019741eff09df286bf5ae1bfa82337761 Reviewed-on: https://chromium-review.googlesource.com/1039004 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555480}
-
Peter Kasting authored
There were basically two callers of this function: * GlassBrowserFrameView, which only cares about the new tab button position anyway, and thus can ask for it directly. * BrowserNonClientFrameViewMus, which wants to know where the tabstrip's "client area" is. Fix this by explicitly handling the "tab" and "new tab button" areas separately, so it won't matter if there's a "non-client" gap between them. In theory, this frame should never be used with TRAILING mode, but with this change the TabStrip API can't be misused. BUG=822063 TEST=none Change-Id: Iaad98ce2485b2897ecffb6c5ec0a6bea5c218f7d Reviewed-on: https://chromium-review.googlesource.com/1038789Reviewed-by:
-
Brian White authored
Bug: 836875 Change-Id: I633a00c07f52093c12a49723fd213dfc03192eba Reviewed-on: https://chromium-review.googlesource.com/1039346 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#555478}
-
https://webrtc.googlesource.com/src.git/+log/878a3df8a25d..2a35c43779f6 $ git log 878a3df8a..2a35c4377 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:836790,chromium:none,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2d9ffa08d725ed51ad90bd7df30e4c98c9296796 Reviewed-on: https://chromium-review.googlesource.com/1039779Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555477}
-
Nicolas Pena authored
This CL uses the OriginalURLViaServiceWorker() in the timing allow check algorithm if the response WasFetchedViaServiceWorker(). This way, if a service worker changes a same origin request to become cross origin, then the timing allow check algorithm will still fail. resource-timing-worker.js is changed so it avoids an empty Response, which is an odd case in terms of same origin checks. Bug: 837275 Change-Id: I7e497a6fcc2ee14244121b915ca5f5cceded417a Reviewed-on: https://chromium-review.googlesource.com/1038229 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#555476}
-
https://pdfium.googlesource.com/pdfium.git/+log/5f3e4f1605a5..d3b0f7cc78e6 $ git log 5f3e4f160..d3b0f7cc7 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 hnakashima Remove int out params from reference to pointer in CXFA_Node. 2018-05-02 thestig Make several Huffman decoders consistently check for integer overflows. 2018-05-02 tsepez Remove unused cpdfxfa_context.h includes from unittests Created with: roll-dep src/third_party/pdfium BUG=chromium:837972 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id94199a352df2125f5afc40d50475f73fd7b6aa6 Reviewed-on: https://chromium-review.googlesource.com/1039776Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555475}
-
Min Qin authored
There is no need to use a RepeatingClosure. Change-Id: Iac2a26754cb93fff720085ec955ef455dc2e8e2b Reviewed-on: https://chromium-review.googlesource.com/1038363Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555474}
-
https://chromium.googlesource.com/catapult.git/+log/86d3e79d8882..5b2cfb7fa5f1 $ git log 86d3e79d8..5b2cfb7fa --date=short --no-merges --format='%ad %ae %s' 2018-05-02 simonhatch Dashboard - Remove /new_points Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I5ff1277533bc31e6883da7c5c5dab97c56d067c2 Reviewed-on: https://chromium-review.googlesource.com/1040112Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555473}
-
Zach Helfinstein authored
When experimental-accessibility-features is enabled, a button appears as a status area widget. Its highlighted appearance is tied to dictation being active, giving a visual indication of dictation listening in addition to another way to activate the feature. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie2eedb8b5aa6a2252754b10da1ebc5ab052b3938 Reviewed-on: https://chromium-review.googlesource.com/1014391 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 4/30 - 5/9) <oshima@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
TBR=jlebel@chromium.org NOTRY=true NOPRESUBMIT=true Bug: 839001 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic423f2970b8f129b2155cbfcdfa71681f791d0e3 Reviewed-on: https://chromium-review.googlesource.com/1040346 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#555471}
-
Devlin Cronin authored
New mocks use a bubble with title only (as opposed to title and body), different strings, and no cancel button. Update the bubble accordingly, and allow ToolbarActionsBarBubble* to accept a null body. Bug: 834494 Change-Id: Iea23483d894e001e23b14e4e7450120c21d6c87a Reviewed-on: https://chromium-review.googlesource.com/1033320Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555470}
-
Daniel Kurtz authored
Currently the Microarchitecture table in cpu_identity only supports Intel Microarchitectures. Add an entry for the AMD Excavator microarchitecture. BUG=b:69376360 TEST=unit_tests --gtest_filter="CpuIdentityTest.*" R=chongjiang@chromium.org,sque@chromium.org Change-Id: I255596e330e0353ab4bec2d51ea25d2420cbcb30 Reviewed-on: https://chromium-review.googlesource.com/1033457Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Daniel Kurtz <djkurtz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555469}
-
Vadym Doroshenko authored
This CL contains: 1.Making NewPasswordFormManager (NPFM) to be FormFetcher::Consumer and creating FormFetcher in it. 2.Implementing processing of matches from FormFetcher and sending fill message to the renderer. Bug: 831123 Change-Id: I58181afdd7c096ecd2a7392cfd7eb08dc43299f1 Reviewed-on: https://chromium-review.googlesource.com/1039808 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555468}
-
David Black authored
Currently non-functional. See bug for demo. Bug: b:79108829 Change-Id: Ifc267b6629c1c831d8085952fc4f5f7c67ecd848 Reviewed-on: https://chromium-review.googlesource.com/1038726Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Charlie Harrison authored
Extensions (like the Great Suspender) want to be able to navigate tabs in the background. Often these tabs will have opened a popup since their last user gesture, classifying them as tab-unders. This CL allows tab-under navigations to and from chrome-extension schemes, allowing extensions arbitrary redirection as long as they can round trip through some extension resource. Bug: 822791 Change-Id: I33b160f0204e2485582432c8ccf2a6722f9721bd Reviewed-on: https://chromium-review.googlesource.com/1039647Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab5340be. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16697 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: I95fdabbc0290f5bd4df40908cd392b8a203293f3 Reviewed-on: https://chromium-review.googlesource.com/1040048 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555465}
-
Tom Sepez authored
This reverts commit 11ab394e. TBR=dcheng@chromium.org Bug: 835778 Change-Id: Iffac66c75702b353625aff03873ff89a993a731b Reviewed-on: https://chromium-review.googlesource.com/1040110Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Chris Nardi authored
In https://github.com/w3c/fxtf-drafts/issues/233, [NoInterfaceObject] was removed from DOMRectList. Remove it from our implementation to match the spec. Bug: 837926 Change-Id: I0bc89c841c7b1eb64ddf498f0c31b02554d6a74b Reviewed-on: https://chromium-review.googlesource.com/1034206Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555463}
-
Conley Owens authored
This change removes the Physical Web UrlManager and the native hooks associated with UrlManager. BUG=826540 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie0215e48c8ab1a0fac8a852c338c7f87955b603d Reviewed-on: https://chromium-review.googlesource.com/1038062Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#555462}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I06ced286b0eeb8289e40f668577b08e35b282600 Reviewed-on: https://chromium-review.googlesource.com/1038223 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555461}
-
Sammie Quon authored
By default the back button will tell focus to go on the tray associated with the detail view. This is usually the view that activated the detail view, except in the case of the volume view whos child headphone button activates the detail view. Add functionality for a tray item to choose which item to restore focus too. The default will be the tray item itself. The first and only user will be the volume tray. Test: manual Bug: 803013 Change-Id: If053cd6f152679b79a98b85570a3cf3f97ed5e8f Reviewed-on: https://chromium-review.googlesource.com/1038884Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#555460}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e3401a0..d48a883d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I655bbe96a1819e901cb16c2ffbe53efba1271740 Reviewed-on: https://chromium-review.googlesource.com/1040046Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555459}
-
Charlie Harrison authored
These metrics are not being used. Bug: None Change-Id: I4007b8dd3b19666965a61f059f78aaccc4854628 Reviewed-on: https://chromium-review.googlesource.com/1038905Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Peter E Conn authored
Save successful verification results as an Android Preference. If verification attempts fail because of network conditions, fall back to these results. Bug: 814755 Change-Id: I7617340a40908d4b08972efda096a5636e7e07f6 Reviewed-on: https://chromium-review.googlesource.com/1019149 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555457}
-
Dmitry Skiba authored
StartupTimeBomb does nothing on Android (see crrev.com/672973002), and ShutdownWatcherHelper is useless because on Android Chrome never shuts down cleanly (it's killed by the OS). This CL ifdefs out usages of StartupTimeBomb and ShutdownWatcherHelper on Android. Bug: 366699 Change-Id: I192bb86c794ef2423a7c32ef70c4a4eea35a64c0 Reviewed-on: https://chromium-review.googlesource.com/1028480 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Updating the font on paint required mutable access to the ComputedStyle member of LayoutObject. Instead, update the font when style is computed or when the text is modified. Note that we still need a mutable style from the parent, but that is trivial to fix once all other mutable access to LayoutObject's ComputedStyle is gone. Bug: 813068 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9bb1eb3a89cf20a36d91a5182323d8f450e9f55 Reviewed-on: https://chromium-review.googlesource.com/1033748Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555455}
-
Amirhossein Simjour authored
Now that VR supports html <select>, we should send scroll events to dialogs. Bug: 836292 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I45d44af2069e21bedd0662d3f26ab6c89ff82288 Reviewed-on: https://chromium-review.googlesource.com/1028584 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555454}
-
glevin authored
As per crbug.com/788022 Comments 1,6: - Consolidate 2 paragraphs into one - Fix padding between content area and buttons - Update "Don't show" checkbox text - Move "Don't show" checkbox from button to content area - Remove X (Close) button from upper right Bug: 788022 Test: Try to open second (multi) profile, view Multiprofile warning dialog, marvel at the unbearable Harmoniousness of it all. Change-Id: I1bb57e06b11c66e9b3cb3f3f4149ec8edcd35af5 Reviewed-on: https://chromium-review.googlesource.com/1015786Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555453}
-
Daniel Nicoara authored
Need to have the GL context current before deleting the buffers. Since the context was destoryed before the buffers due to declaration ordering in the class definition, the context was lost before the buffers were destroyed. Also rename the overlay array to signify that it is an array. Fixed presubmit warning to use base::size over arraysize. BUG=NONE TEST=Ran ozone_demo and verified no GL errors are seen on console. Change-Id: I8e8da2918fe7c1f2cb5cf16bcebddfd453b315b3 Reviewed-on: https://chromium-review.googlesource.com/1039988Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#555452}
-
Katie D authored
This will allow a button in the shelf to request Select-to-Speak state changes and to be updated when Select-to-Speak updates its own state. This builds off of https://chromium-review.googlesource.com/c/chromium/src/+/1030901 and the full working proof of concept can be seen at https://chromium-review.googlesource.com/c/chromium/src/+/1031550. Still TODO: Add the button, and update the SelectToSpeakEventHandler to start processing touch events or mouse when the button was clicked rather than just when the search key was held down. This change also adds tests for toggling Select-to-Speak on and off in accessibility_manager, as those tests were missing. Bug: 753018 Change-Id: I93bb77dc23bdfa855e991e31d67dc4e3b8271036 Reviewed-on: https://chromium-review.googlesource.com/1036198 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Also add a web-platform-test for this change, which is already supported by Firefox. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/-2AyrUFwXvY/Q_wCUmKSAgAJ Spec change PR: https://github.com/whatwg/html/pull/3659 Bug: 836401 Change-Id: Ia710190857211684ce5ce7d4ff835b874f658b29 Reviewed-on: https://chromium-review.googlesource.com/1039265Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#555450}
-
Michael Lippautz authored
Includes incremental garbage collection infrastructure in regular builds. Does not enable incremental marking at runtime! This CL may cause throughput regressions and is an attempt to collect a broad range of potential performance issues. Bug: chromium:757440 Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed Reviewed-on: https://chromium-review.googlesource.com/980753 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555449}
-
