- 18 Feb, 2020 40 commits
-
-
Hidehiko Abe authored
atomic cannot be used on chromeos platform. BUG=1043804 TEST=Build locally. Change-Id: I0c9ab4682f2bdf25cf966d4a581ee666a588bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057504 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#742043}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4d1700125c33..9dbb98007b7b git log 4d1700125c33..9dbb98007b7b --date=short --first-parent --format='%ad %ae %s' 2020-02-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5d89b446..0f78b586 (234 commits) Created with: gclient setdep -r src/third_party/skia@9dbb98007b7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ic921622ce096d79ab4883d2f68124cd1c7f71647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742042}
-
Keishi Hattori authored
Some classes are using ExecutionContextLifecycleObservers just to do GetExecutionContext(), and not using ContextDestroyed() notifications. Convert those cases to use ContextClient. Bug: 1052319 Change-Id: I4b048ca9a2997d1676ccd8fa37546959a9e9f9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060361Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742041}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/215b5370bc4f..d353ca088149 git log 215b5370bc4f..d353ca088149 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cwallez@chromium.org CMake: Add support for the Vulkan backend Created with: gclient setdep -r src/third_party/dawn@d353ca088149 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I98d63ff690c37629040fed0b702c675319c1aa4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061095Reviewed-by:
-
Eugene Zemtsov authored
HTMLVideoElement used to have 2 intersection observers, and this function would activate one of them. Now there is only one observer and it's always active. Bug: 696211 Change-Id: Ib17343059c39201e60838a1d3fddb54df9bd703e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048416Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#742039}
-
Eric Willigers authored
WebAppNavigationBrowserTest replaces BookmarkAppNavigationBrowserTest. InstallTestWebApp() replaces InstallTestBookmarkApp() Tests using the class no longer have any references to extensions, and continue to pass if the DesktopPWAsWithoutExtensions flag is enabled. To avoid a name class, the existing class WebAppNavigationBrowserTest is renamed to WebAppNavigateBrowserTest. It tests the Navigate() function. Bug: 1052722 TBR=jamescook@chromium.org TBR=pbos@chromium.org Change-Id: I8a09bb8f5c4bf563645ae5bca940015a05fbbe56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060213Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#742038}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b861a4a4a354..720d39c018b9 Created with: gclient setdep -r src-internal@720d39c018b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5ff14051bd6ba4601767f93086688c5319c52045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061097Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742037}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/54cfb999..f78c3a6a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I027725eb8611865f87ebe4911dd6ea1b3a5baa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060774Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742036}
-
Isabella Scalzi authored
Use the mimeType property that was sent from piex_loader.js to prevent lossy JPEG encoding of images that are of type BMP. Bug: 1039141 Change-Id: I1ee989bb8c2627cd5fba282dd7bb0b7214b48f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060358 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742035}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2bc3be29bec4..c7be4c1bdab3 git log 2bc3be29bec4..c7be4c1bdab3 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c7be4c1bdab3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf47a73f0152149b59cb5fba22db62d2f0fe6098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061098Reviewed-by:
-
John Z Wu authored
Assuming the flaky test was because the real CWVPasswordController was executing javascript in a free floating WKWebView with CGRectZero, using this fake CWVPasswordController may deflake it. Also added another test for fetching password suggestions. Bug: 1048256 Change-Id: I4a2898ddcd4edb5135835f81fa6b59435a59ddb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057119Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#742033}
-
Keishi Hattori authored
Adds Blink mojo Remote/Receiver wrappers HeapMojo{Receiver,Remote} Also uses them in the speech module as an example Design doc: https://docs.google.com/document/d/1mYKbNgVzQUbc0zKLjiBcO5Ue_VTh3sIwj8glHU-azQ8/edit Bug: 1049056 Change-Id: Ia14f455736197f25d1fdbfe78473d3681fd02e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000268 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: -
Hiroki Nakagawa authored
Module dedicated workers was enabled by default in M80. This flag is no longer necessary. Bug: 1043565 Change-Id: Ia0fa3227aa57eb472dcb5260afe1a71bd5bbab63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060435Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742031}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/192da9d76fef..015cb80815b8 git log 192da9d76fef..015cb80815b8 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 jmadill@chromium.org Revert "Use newer OSX SDK for iOS" Created with: gclient setdep -r src/third_party/angle@015cb80815b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052887 Tbr: cwallez@google.com Change-Id: Ie5a2ddee6732622854afbe78c12b6e06a9dfe1b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061092Reviewed-by:
-
Adam Rice authored
Initially WebSocketStream used a hwm of 0 for the ReadableStream that is returned from the `connected` promise, but that resulted in poor throughput when the application wasn't continuously reading. Change the hwm of 1 so that up to one message will still be transferred to the render process even when it is not inside a read() call. Backpressure will still be applied if more than 1 message is in transit. BUG=983030 Change-Id: I883d9e62b8465d45bc9b383db8f639fbf791c78d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054605Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#742029}
-
Jiewei Qian authored
This CL add support for Native File System API to consider the read content setting when determining permissions. Also whitelists chrome:// scheme for this permission. Fixed: 1048467,1034873 Change-Id: I97815505fc288f27d5fad9264bf58028561ed102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032659 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#742028}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I7f893ae22a975a6b4823ada624c0fd4b2029f70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061528Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742027}
-
Yuki Shiino authored
DataView is also an ArrayBufferView as well as Int32Array, etc. NotShared/AllowShared should be applied to DataView, too. Bug: 839389 Change-Id: I0d4848fb4a1e2046ac447bb002b7963c011fa602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060349Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#742026}
-
Yuki Shiino authored
Bug: 839389, 501866, 529941 Change-Id: I458fef8d9aa7e96777498cdd1161ba1ab5d6e090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059030Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie006c64f2686fff268e649e79b1c89f28af04368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061099Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ae59435606fc..113d07a6ebda git log ae59435606fc..113d07a6ebda --date=short --first-parent --format='%ad %ae %s' 2020-02-18 johnkslang@users.noreply.github.com Merge pull request #2084 from durswd/enable_rtti Created with: gclient setdep -r src/third_party/glslang/src@113d07a6ebda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ie19a6284505c958117e55082e510f5a7b4efef91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061096Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/b0a41e52137a..d8d0c66b9c07 $ git log b0a41e521..d8d0c66b9 --date=short --no-merges --format='%ad %ae %s' 2020-02-14 junyer Fix the check for Apple platforms. Mea culpa. 2020-02-14 junyer Provide hooks::context iff thread_local is supported. 2020-02-14 junyer Update doc/syntax.html. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: If0e8f0224379fd2f9cd9441d05f6b4f8d0e552dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061170Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742022}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c4f3c178ade..4d1700125c33 git log 3c4f3c178ade..4d1700125c33 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 reed@google.com move SkDeque.h into private Created with: gclient setdep -r src/third_party/skia@4d1700125c33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: Ib35023377fde81ed25415f92585476aee20bd0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061094Reviewed-by:
-
Matt Falkenhagen authored
This reverts commit a8a9ff46. Reason for revert: Suspected cause of https://crbug.com/1052853. Original change's description: > Run v8 in proxy resolver in jitless mode. > > This allows MITIGATION_DYNAMIC_CODE_DISABLE to be enabled for the > process on Windows, and moves PAC resolver from the Renderer helper > variant to the Default helper variant on macOS. > > BUG=961831,961592 > > Change-Id: I90f9dc69fa5ebf43f71b0395d7d2217fc24181b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051153 > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741531} TBR=yangguo@chromium.org,rsesek@chromium.org,wfh@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 961831, 961592, 1052853 Change-Id: I11fb9137107b7e391add16b8fac2bef247576bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060434Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742020}
-
Alan Cutter authored
System web apps handle updating at start up via SystemWebAppManager::NeedsUpdate(). This CL disables the WebAppTabHelper update logic for system web apps to avoid colliding update logic with SystemWebAppManager. This CL merges the common_browser_tests target into web_applications_browser_tests. This is due to the new dependency on web_applications_on_extensions_test_support via TestSystemWebAppInstallation. We have decided that browser_tests should be able to depend on anything and don't need to match the deps rules we enforce on production code. Bug: 1035242 Change-Id: Ib376d668d6c1bc8edeb677038efb49a5af838d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014216 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
VdaVideoDecoder holds PictureBuffer and its underlying buffer until VdaVideoDecoder's destruction, or DismissPictureBuffer() with the picture buffer id is called. VaapiVideoDecodeAccelerator only calls DismissPictureBuffer() upon a resolution event, but not on its destruction. It doesn't matter if VdaVideoDecoder destroys immediately. Although this is generally true, the exception is a profile change video. VdaVideoDecoder destroys VaapiVDA and re-create VaapiVDA when the profile in the video is changed at middle. Therefore, there may be picture buffers that are unreleased because DissmissPictureBuffer() is not called. This fixes the memory leakage problem by calling DismissPictureBuffer() in VaapiVDA's destruction. VaapiVDA::Cleanup() is originally called in both Destroy() and NotifyError(). This removes the call on NotifyError() to simplify the code. Bug: chromium:1051107 Test: No leakage in playing https://crosvideo.appspot.com/?codec=h264&loop=true&mute=true&cycle=true on atlas Change-Id: Idb7f903a32747917dccf0d6c968f43a66678b0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050417 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#742018}
-
Kent Tamura authored
We should not modify underlying_event. This CL has no behavior changes. Change-Id: I3eae72cec99ef44e1b91c48d8d50605f217ee90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060397Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#742017}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 1052232 Change-Id: Icb76de7ead3dc4f6e453aaee2af06703d43721ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060394Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b60fa4128af2..b861a4a4a354 Created with: gclient setdep -r src-internal@b861a4a4a354 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I400ee38f2334c80f9e6813844aa144635492f6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061090Reviewed-by:
-
Kinuko Yasuda authored
Remove WebURLRequestToResourceType as now that all the references in content/renderer are gone (after crrev.com/c/2041982 and crrev.com/c/2043265) Also: move some code that needs to use RequestContextType from WebURLLoaderImpl into blink/renderer/platform/loader/fetch/url_loader. Additional context: - I expect that deprecating ResourceType would take more time than RequestContextType at least in //content, so this CL tries to focus on RequestContextType deprecation - While, RequestContextType usage in Blink may also last a bit longer than the deprecation of network::ResourceRequest::fetch_request_context_type. Bug: 1045925 Change-Id: Ie43812962000a93cf0fb51bfc042292ecf271fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056007 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4c73c6d70e7..2bc3be29bec4 git log d4c73c6d70e7..2bc3be29bec4 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 cjamcl@chromium.org Reland "[Lighthouse] Rename Audits panel to Lighthouse" Created with: gclient setdep -r src/third_party/devtools-frontend/src@2bc3be29bec4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:10521119 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1a085d6d5ac1a3b3cec192097ecc3636db279c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061093Reviewed-by:
-
Keishi Hattori authored
Adds ContextLifecycleObserver as the base class for ContextLifecycleObserver. This allows us to create ExecutionContext ContextDestroyed observers in platform/. ContextLifecycleNotifier is the bare minimum interface required to implement ContextLifecycleObserver in platform/ Prerequisite for crrev.com/c/2000268 Bug: 1049056 Change-Id: I64c067ce9179b7075ac9d0a8171965c74ce04405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046626 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
This reverts commit a37b994a. Reason for revert: Suspected cause of crashes at https://crbug.com/1052665. Original change's description: > Crash fix: notify browser nodes when extra mac nodes change > > When a table is updated, it clears the extra mac nodes. This means the > cached _children in BrowserAccessibilityCocoa need to be invalidated. > > By adding a call to OnAtomicUpdateFinished(), the correct > invalidation code path is now executed. It calls OnDataChanged() on > each node, which calls childrenChanged() on BrowserAccessibilityCocoa. > > Bug: 1050598 > Change-Id: I4d401aaf8ce768d171160ce232a2b1d118f37a90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048030 > Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741346} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org,iapres@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1050598, 1052665 Change-Id: I660e0d01abeabfe64f5791bdc33bbd0b4e7e4e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060432 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Ryan Sturm authored
Adds a launch entry for PreconnectToSearch. Bug: 1036489 Change-Id: Ie0aa87c78eefe50e78f50772be75f3a590b45f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061111Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#742010}
-
Luciano Pacheco authored
Fix integration tests that interacted with folders that weren't visible in the directory tree. A follow up CL will stop populating some of these folders until the parent folder is expanded. Bug: 1039820, 996626 Change-Id: Id226f985e55c9cae13548f837c14406a5af9a8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059624 Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#742009}
-
Alex Danilo authored
The action bar buttons were changed from 'button' to 'cr-button'. During startup, Polymer elements are loaded lazily so the style for box-sizing isn't set until load completes. Adds an explicit box-sizing property to the CSS to make the buttons size correctly before the cr-button elements are initialized. Tbr: noel Bug: 1051828 Change-Id: Ie3ecc8722fa6d644ac96ec8ff8e8c223d0afe347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060212 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#742008}
-
Jinsuk Kim authored
Repeated preview tab open requests attach the WebContents twice. This caused a problem not allowing the scroll on the contents. This CL adds a check to avoid repeated WebContents attachment. Bug: 1049967 Change-Id: I8589b7e1215be71de185506381fa946677d3aafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054688Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#742007}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0503911de1fc..539ac2af50bd git log 0503911de1fc..539ac2af50bd --date=short --first-parent --format='%ad %ae %s' 2020-02-17 dberris@chromium.org Pinpoint: Parse all known formats Created with: gclient setdep -r src/third_party/catapult@539ac2af50bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041818 Tbr: wenbinzhang@google.com Change-Id: Ieb6f7f1d90f3eb5f9e8b978b43c71ab4f6aa538a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061089Reviewed-by:
-
Isabella Scalzi authored
On the bots, |openQuickViewDeleteEntireCheckSelection| is still failing occasionally. Check that the first file in the test has loaded completely before attempting to delete it. Bug: 803259 Change-Id: I8cdc38352356cbe6d6dfee29efe14a81021269d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060396 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8ff754ea. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5884731f3fdd3bb8f9f9820bab08960ed432b661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060773Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742004}
-
