- 10 Apr, 2018 40 commits
-
-
Takashi Toyoshima authored
Since these files are not used by Blink, we can put them in services/network/cors. This will make it easier for CORSURLLoader to depend on cors::PreflightController. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibebe686a54e70872b33db06bf7ed72d653d4d1f6 Reviewed-on: https://chromium-review.googlesource.com/999692 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#549444}
-
Greg Thompson authored
With this change, alternate_version_generator now also updates occurrences of the version number found in the .rdata section of PE images. As a result, Chrome runs and thinks it is the altered version. While at it, I also switched from using a custom MappedFile to the one in base, which now supports r/w mappings. BUG=461856 R=huangs@chromium.org Change-Id: I4e5c3bbc71e73a05b541d12693e512a7ac1b3ecb Reviewed-on: https://chromium-review.googlesource.com/1001896 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549443}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: Ifb724d96099e6324cfdb7fbf50a6a87cc69449f2 Reviewed-on: https://chromium-review.googlesource.com/989457Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#549442}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c366fc9e..86b145e5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I858c7a08a20d2fa0853507c1da20f75100e231a5 Reviewed-on: https://chromium-review.googlesource.com/1004193Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549441}
-
Yuta Kitamura authored
Scheduler classes are being renamed as part of scheduler architecture refactoring. Bug: 826203 Change-Id: Ic9a74dd8ef8238c0d83dda03d3c9e5a6f505d85b Reviewed-on: https://chromium-review.googlesource.com/994853 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549440}
-
Matt Falkenhagen authored
For ServiceWorkerProviderHost: * Remove IsHostToRunningServiceWorker(). This was a subtle function since it was used mainly as !IsProviderForClient(), but it was also false when the service worker was still starting up. * Add IsProviderForServiceWorker() as an analogue to IsProviderForClient(). * Improve documentation/terminology throughout for consistency with ServiceWorkerProviderContext. Change-Id: I69a0449aeda41f23f41bee767524aebf5ff9b1d2 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/1002216 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549439}
-
https://chromium.googlesource.com/catapult.git/+log/b5c70ce2580e..1bae362e7789 $ git log b5c70ce25..1bae362e7 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 simonhatch HistogramSet - Merge by only a subset of tags. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic0d3e1eaaedd22c46eade2ea5c780e496a214453 Reviewed-on: https://chromium-review.googlesource.com/1004007Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549438}
-
JunHo Seo authored
'type' doesn't give much information. Use more informative name. Bug: 770147 Change-Id: Iad53dfc11347c149f1d076cc5c326437df2f28c4 Reviewed-on: https://chromium-review.googlesource.com/989387 Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#549437}
-
Yuta Kitamura authored
These files were renamed in crrev.com/c/986112, but they should have "_impl" in the back. This patch corrects those names. Bug: 826203 Change-Id: Ib4cf5e51f1e5cd8d517486a0e1fb177bb30d8f78 Reviewed-on: https://chromium-review.googlesource.com/994504 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Peter Kasting authored
Bug: none Test: none Change-Id: Iefdc0ad2f75590e077b5599b4f6e2984f89747d3 Reviewed-on: https://chromium-review.googlesource.com/940769 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#549435}
-
Chong Zhang authored
'loading.desktop.network_service' fails randomly when uploading json results, e.g. https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/5265 It seems that we might miss some charts in certain conditions. e.g. We don't have 'timeToInteractive_std' when all values are None. This CL handled the case by only doing diff on common charts / points between control and enabled chartjson result. Bug: 827442 Change-Id: Ibb1b9004d48bdfc2fa017c4acf57c989ae15c17f Reviewed-on: https://chromium-review.googlesource.com/1003520Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549434}
-
Matt Giuca authored
Moves browser-window-specific functionality from AppMenuButton into new subclass BrowserAppMenuButton, and made AppMenuButton a base class of HostedAppButtonContainer::AppMenuButton. BrowserViewButtonProvider now provides an AppMenuButton, rather than a generic MenuButton, allowing code that is common to browser and hosted app windows to interact with the app menu (e.g., detecting whether it is open, and closing it). This will be used in a future CL to fix the code that hides the zoom bubble if the menu is open so that it works in hosted app windows. Tbr: nyquist@chromium.org Bug: 791399 Change-Id: I2bce579b2c220cd70c0a02e95f270e0f3d13ba8d Reviewed-on: https://chromium-review.googlesource.com/983252 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#549433}
-
Karan Bhatia authored
A chrome extension has implicit host permissions to its own origin (chrome- extension://extension_id/). This allows the extension to monitor and modify requests to any of its own resources using the WebRequest API. However, this allows an extension with DNR to also possibly/mistakenly block or redirect its own background page. This is not a problem for the WebRequest API since it is (generally) the background page which does the blocking in case of the WebRequest API. To fix, simply whitelist all resources on the chrome-extension scheme as far as DNR is concerned. BUG=829225 Change-Id: I022f137f1fde20276de22f0f8529aa4f1c9a53db Reviewed-on: https://chromium-review.googlesource.com/1000770Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549432}
-
Alexey Baskakov authored
In the Files App Settings menu, the storage indicator should be clickable and link to the Settings -> Device -> "Storage management" UI. Bug: 680347 Test: Manually tested Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3703b2d94852a3011e7e6d91b2afe010400795b5 Reviewed-on: https://chromium-review.googlesource.com/999240 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#549431}
-
Xianzhu Wang authored
This optimize especially for the following simple case: <div style="overflow: hidden"> ABC </div> which seems quite common in real web pages. This CL saves OverflowClip node and Save/ClipRect/Restore operations when the contents don't overflow. Performance results: CT: (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180409001618/html/index.html) record_time: -2.7% paint_op_count: -2% painter_memory_usage: -0.7% rasterize_and_record_micro.top_25 (https://pinpoint-dot-chromeperf.appspot.com/job/113ce7b4c40000): record_time: -4.5% paint_op_count: -2.4% painter_memory_usage: -1.8% Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia12e0182cb2b712013dca3e2cb9805d2d65cd7df Reviewed-on: https://chromium-review.googlesource.com/1001752 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549430}
-
Xianzhu Wang authored
For: <div style="transform: translateX(10px)"> <div>A</div> <div style="overflow: hidden">B</div> <div>C</div> </div> previously we emitted the following paint operations: Save Transform Draw A Restore Save Transform ClipRect Draw B Restore Save Transform Draw C Restore With this CL, we emit the following paint operations: Save Transform Draw A Save ClipRect Draw B Restore Draw C Restore by reusing transform state across clip state which has the same transform. CT result: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180406052047/html/index.html This CL reduces paint_op_count by 2.6%. Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id0d41b98ffd35440f4a608856650f7109362d425 Reviewed-on: https://chromium-review.googlesource.com/999095 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This CL: - Changes the AdDelayThrottle lifetime so it is always created, in an enabled or dryrun state - Adds an enum histogram for the product of {isAd, isSecure} in the destructor. - Fixes a bug where syncXHRs were breaking due to us not properly handling DetachFromCurrentSequence(). Added a browser test for that case. Bug: 829042 Change-Id: Ib4bc572f1edce2c975b72f4a6d128c65b6acd2bc Reviewed-on: https://chromium-review.googlesource.com/998537 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549428}
-
Esmael El-Moslimany authored
Bug: 829722 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I372a6f71ff768fdcc5b113b86617db5b92b10e1c Reviewed-on: https://chromium-review.googlesource.com/998979Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#549427}
-
Alan Cutter authored
This CL updates the minor text color to increase the contrast ratio to 4.5 where previously it was only 2.4. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=333305&signed_aid=nJkKAfQZwVySGN2WxDNekw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=333570&signed_aid=czXiHkbVYr98gGQf_RowuQ==&inline=1 Bug: 823197 Change-Id: I45a52eb1cf3782202d348a7617557ffc1ba6b139 Reviewed-on: https://chromium-review.googlesource.com/999275 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#549426}
-
John Abd-El-Malek authored
With this change, the code now only lives on the UI thread. Bug: 825242, 777915 Change-Id: I3330347910559bb464a693a412182930415cb639 Reviewed-on: https://chromium-review.googlesource.com/998526 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549425}
-
Blake O'Hare authored
When you use multiple fingers to drag the keyboard around, the events for these get sent to the event filter sequentially. Check for a pointer ID (which is unique per touch point) and include it in the active drag descriptor. Ignore non-matching pointer events. Bug: 802992 Change-Id: I5a3948719e5c103ee1aa618afc3fe36939567326 Reviewed-on: https://chromium-review.googlesource.com/979739Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#549424}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/02ef76b018ac..871e7778ef8b $ git log 02ef76b01..871e7778e --date=short --no-merges --format='%ad %ae %s' 2018-03-28 pprabhu gerrit: Add 'private' subcommand. 2018-04-09 dgarrett cros tryjob: Remove --waterfall option. 2018-04-09 cmtice [clang-tidy builder] Change board from 'kahlee' to 'grunt'. 2018-04-05 mxt Revert "remove whirlwind-no-vmtest-pre-cq from default set" 2018-04-06 xzhou Update tss group test to add bootlockboxd to tss. 2018-04-06 dgarrett cbuildbot_launch: RunCbuildbot -> Cbuildbot. Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:752342,chromium:830691,chromium:829055,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iad8d29ecd5f47e06ce4867453d3ba4a4606d835c Reviewed-on: https://chromium-review.googlesource.com/1004003 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549423}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6bd23308..c366fc9e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I18185cfb20c8da9a084b7f372baeb35e0af764dd Reviewed-on: https://chromium-review.googlesource.com/1003652Reviewed-by:
-
Christopher Cameron authored
Split the RWHVCocoa showLookUpDictionaryOverlayInternal, showLookUpDictionaryOverlayFromRange, and showLookUpDictionaryOverlayAtPoint into browser-side and AppShim-side components. Remove RenderWidgetHostViewMacDictionaryHelper, because it ends up having no effect. It is used to specify a target NSView on which to draw the dictionary overlay, but it is only used for the PDF plugin, which is incapable of drawing the dictionary overlay (because it can't look up the point in the view at which it is supposed to be drawn). This should be a cut-and-paste with no functional effects. Bug: 821651 Change-Id: Ie443bdc76a5e0b28d2f6595fcff0601f8ce4a228 Reviewed-on: https://chromium-review.googlesource.com/1000765 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549421}
-
Alan Cutter authored
This CL refactors browsertests in browser_non_client_frame_view_ash_browsertest.cc. The HostedAppNonClientFrameViewAshTest test is split up into smaller tests for theme color, content setting icons and browser action icons. The BrowserNonClientFrameViewAshTest tests reduce their boiler plate code with a GetFrameViewAsh() helper function. Bug: 822146 Change-Id: I2fc50086f50d719873cf8b18fb044c2d63f1e8c8 Reviewed-on: https://chromium-review.googlesource.com/994912 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#549420}
-
Stephen Lanham authored
Add BluetoothTestCast, a test fixture which allows the general Bluetooth tests to be run against the Cast implementations. Fix the necessary pieces to make the tests pass, including: * Handle service and manufacturer data properly. * Stub power management properly. * Handle discovery sessions properly. * Add TODOs for future work. This by no means is all the test coverage we need for this code, this just allows us to run device_unittests upstream. BUG=827672 Bug: b/75967216 Test: test page Change-Id: Ibf1acb524d1644a78a5510af09d354736bbb3a67 Reviewed-on: https://chromium-review.googlesource.com/998839 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Bailey Forrest <bcf@chromium.org> Cr-Commit-Position: refs/heads/master@{#549419}
-
Ken Rockot authored
mojo::ScopedHandleBase::operator-> is imminently changing to DCHECK that it's only called on valid handles. Blink's MojoHandle wrapper is explicitly intended to be able to represent invalid handle values and forward them to underlying system API calls. This changes Blink's MojoHandle to use get() instead of operator-> to get the underlying value of its wrapped handle, as get() makes no assertions or guarantees about the validity of the handle value. Bug: 830907 Change-Id: If0b5b9e929e78aafef868330a537ec20c3ac1deb Reviewed-on: https://chromium-review.googlesource.com/1003287Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#549418}
-
John Z Wu authored
This will stub out breakpad so there won't be duplicate symbols between //ios/web_view and the client app. Saves about 300KB total. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idac0f3671f6321b37749531f5a2e18a99c63bd69 Reviewed-on: https://chromium-review.googlesource.com/1004034 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#549417}
-
Hirokazu Honda authored
The original limitation, 48, is too small to pass following two CTS tests. * android.media.cts.ResourceManagerTest#testReclaimResourceSecureVsSecure * android.media.cts.MediaCodecCapabilitiesTest#testGetMaxSupportedInstances Extend the limitation to 64 to pass thos tests. TBR=posciak@chromium.org BUG=b:72354215 BUG=chromium:804687 TEST=android.media.cts.ResourceManagerTest#testReclaimResourceSecureVsSecure TEST=android.media.cts.MediaCodecCapabilitiesTest#testGetMaxSupportedInstances Change-Id: Ia0805d3248103b8205505ce56056c0fa6e951cb6 Reviewed-on: https://chromium-review.googlesource.com/1000994Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#549416}
-
Sunny Sachanandani authored
When Commit hangs we'll know what caused the commit in the first place. R=zmo BUG=823498 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0f382b7c8f64dbc80b89a9a610ef735f7fd1916c Reviewed-on: https://chromium-review.googlesource.com/1003753Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#549415}
-
Kent Tamura authored
LifecycleObserver.h was renamed to lifecycle_observer.h. TBR=thakis@chromium.org Bug: 768828, 830210 Change-Id: I26008bacc5ebb8446ec0a95e03ad1bd2f34cb102 Reviewed-on: https://chromium-review.googlesource.com/1004076Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549414}
-
Alan Cutter authored
This reverts commit 705d7330. Reason for revert: Broke WinMSVC64 (dbg) compile. https://ci.chromium.org/buildbot/chromium.win/WinMSVC64%20%28dbg%29/4682 indexed_db_backing_store_unittest.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) class leveldb::Status __cdecl content::indexed_db::GetInt<class content::LevelDBTransaction>(class content::LevelDBTransaction *,class base::BasicStringPiece<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > const &,__int64 *,bool *)" (__imp_??$GetInt@VLevelDBTransaction@content@@@indexed_db@content@@YA?AVStatus@leveldb@@PEAVLevelDBTransaction@1@AEBV?$BasicStringPiece@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@base@@PEA_JPEA_N@Z) referenced in function "public: void __cdecl <lambda_395e582d16a7cd048cd3868c3a9ede8f>::operator()(class content::IndexedDBBackingStore *,class content::IndexedDBKey,struct content::IndexedDBValue,struct `private: virtual void __cdecl content::indexed_db_backing_store_unittest::IndexedDBBackingStoreTest_SchemaUpgradeWithoutBlobsSurvives_Test::TestBody(void)'::`2'::TestState *)const " (??R<lambda_395e582d16a7cd048cd3868c3a9ede8f>@@QEBAXPEAVIndexedDBBackingStore@content@@VIndexedDBKey@2@UIndexedDBValue@2@PEAUTestState@?1??TestBody@IndexedDBBackingStoreTest_SchemaUpgradeWithoutBlobsSurvives_Test@indexed_db_backing_store_unittest@2@EEAAXXZ@@Z) Original change's description: > [IndexedDB] Schema upgrade fix, fail for corrupt blobs, fix enums.xml > > For the last 4 years we 'saved' the new schema version number, so any v2 > databases are never marked as v3. The 'migration' always deleted all > blob files. To correctly upgrade to v3, all v2 databases that have blob > entries are considered corrupt and are wiped. > > This also fixes the enums.xml values for IDB setup errors, which have > been missing 'DeleteIndex' and 'ClearObjectStore' (and subsequently have > had incorrect reporting on values > 23) since 2014: > https://crrev.com/b05831ee > > Bug: 756447, 829125, 829141 > Change-Id: I1d711b5ed4bfb4e7240da56a2fc78e6ebe561ca1 > Reviewed-on: https://chromium-review.googlesource.com/1000138 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549395} TBR=mpearson@chromium.org,jsbell@chromium.org,dmurph@chromium.org,pwnall@chromium.org Change-Id: I563e3f3b77f0ff72025d3d398a6e8f5e36a818bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756447, 829125, 829141 Reviewed-on: https://chromium-review.googlesource.com/1004133Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#549413}
-
James Wallace-Lee authored
Fix bug where not drawing caused animations to not tick. UpdateAnimationState is usually called in ProxyImpl::DrawInternal, so call it in WillBeginImplFrame if the frame is aborted. Bug: 826665 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic15f53dc26f822f090bd0a84dd774cad8ba22ae7 Reviewed-on: https://chromium-review.googlesource.com/1000013 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#549412}
-
Xiaoqian Dai authored
When splitview and overview are both active at the same time, new a window should not end overview mode if the window is in the same root window with the current snapped window. Otherwise the end of the overview mode might cause the expected end of the splitview mode. Bug: 827712 Change-Id: I627f99f8c5d4d7c01a038f453be855c2a1193196 Reviewed-on: https://chromium-review.googlesource.com/994455Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#549411}
-
Jialiu Lin authored
Move "settings:security" icon from chrome/browser/resources/settings/icon.html to ui/webui/resources/cr_elements/icons.html, such that it can be used outside of settings WebUI. Bug: 830013 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I430227fb442597a2d1faf2d9ccf0723c1d3eac3c Reviewed-on: https://chromium-review.googlesource.com/1003600 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#549410}
-
Yuly Novikov authored
conformance2/rendering/attrib-type-match.html on Linux Nvidia GL passthrough BUG=814905 TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib00f331d732ce881f5169366ec4140bbf1284c7b Reviewed-on: https://chromium-review.googlesource.com/1001502 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#549409}
-
Ria Jiang authored
When the target we found is not in the tree of the client |root_view|, send the event to the |root_view| instead. Bug: 750755 Test: content_unittests content_browsertests https: //ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/38690 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8957c94fe543cc9f659497f781b723ad25e2fa51 Reviewed-on: https://chromium-review.googlesource.com/963857Reviewed-by:
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b59810f75793..8aa3eac3b786 $ git log b59810f75..8aa3eac3b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:826393 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6911983835ac44c4ce52574d0485dad38cc75ac3 Reviewed-on: https://chromium-review.googlesource.com/1003757 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549407}
-
Istiaque Ahmed authored
AsyncExtensionFunction is deprecated and will soon be deleted. Turn these guest functions into UIThreadExtensionFunction. This CL does not introduce any behavior changes. Bug: 829174 Change-Id: I275fe31ca3d33a87e137ee9c562aa6002e5ab6f1 Reviewed-on: https://chromium-review.googlesource.com/997109 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#549406}
-
John Z Wu authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3b82817163196ff5ff127008028f0ef4f5338654 Reviewed-on: https://chromium-review.googlesource.com/1004033Reviewed-by:
-
