- 06 Oct, 2020 40 commits
-
-
Anna Malova authored
Change-Id: Ic3a97e5da2203d52d20de5f0a72f28675c2c8333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398543Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#814176}
-
Dave Tapuska authored
With RenderWidgetFullscreenPepper gone we can remove the IPC to show that widget. Remove the privileged attribute on RequestMouseLock as well since it was only set by that widget. BUG=1134674 Change-Id: Ib72b94179f0f63aa53e0014e968f736a7fef94fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450730 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814175}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08142700a841..f6e983b87ff4 2020-10-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 78d150eb to edbb6564 (486 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I4fb13c56c2130a2bfbc42c98a6f1379ecd3dacef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814174}
-
Kent Tamura authored
Move the main logic of |LayoutTextControl::ComputeLogicalHeight()| to TextAreaIntrinsicBlockSize() and TextFieldIntrinsicBlockSize() in layout_box.cc like other form controls' intrinsic sizes in order to share the code with LayoutNG. * ClampIntrinsicBlockSize() and LayoutBox::ComputeLogicalHeight() <textarea>'s intrinsic size should not depend on scrollbar existence. So we need to subtract the scrollbar thickness if a scrollbar exists. This CL has no behavior changes. Bug: 1040826 Change-Id: I1abdf34617364c7c30398d9dc20be43e3eae7da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452069 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814173}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f79f298cc9cb..3fe3c2199cc3 2020-10-06 sigurds@chromium.org Refactor selection logic in console (part 1) 2020-10-06 aerotwist@chromium.org TypeScriptify /webaudio 2020-10-06 alexrudenko@chromium.org Escape parts of the selector in simpleSelector() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I925363b1fd11fb7802f6ba5e421991cba23eeb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452216Reviewed-by:
-
Ramin Halavati authored
Session startup pref is updated to support ephemeral Guest profiles. Ephemeral Guest profiles are not off-the-record and will deprecate OTR Guest profiles. This change is behind disabled EnableEphemeralGuestProfilesOnDesktop flag. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: I786a4f9a3ecccab625936948a6dec798d657ca20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450277 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#814171}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba1e9298..a95acb3a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d220966f2024a3a498443936a9143529fe54ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451536Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1fe3df3c28abdf808535d7836ae9b0c64028cb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452217Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iee48e0190dfb454e592c3709977c4979c4af924d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451951Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#814168}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: If9e6ec1dc94c9b8d1c5ca7b83f4f4e8368f6c71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442796 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#814167}
-
Kelvin Jiang authored
This CL implements a global rules tracker which tracks the total # of rules in the global pool, and per extension. The CL also checks against the global limit and surfaces a warning to the UI if an extension's rule count exceeds this limit. Bug: 983299 Change-Id: I98e620bb6565ed18ded8cbb3885b2a611f6a33cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376686 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#814166}
-
Takashi Sakamoto authored
Change-Id: I2b048b5daad0454609026ccea1497daa19a056bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444632Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#814165}
-
Jacobo Aragunde Pérez authored
When tests are grouped in batches, the AtSpiReady state of the single- -instance class AtkUtilAuraLinux may already have been changed and affect the next test expectations. For that reason, we must change it back to its default state when test ends. This was making the TestAtkPopupWindowActive work some times, when it should have been failing after a13d2391. Now, we explicitly set AtSpiReady to true as part of the test body and we can re-enable the test. Bug: 1131867 Change-Id: I617914611ab7509b6bc3e1928baa61fb33b643ca AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429023 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#814164}
-
Yuta Hijikata authored
Background: Currently lacros-chrome is built with target_os="linux" but we plan to build lacros-chrome with target_os="chromeos" going forward. To achieve this goal, we have to replace defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) so not to include code specific to ash-chrome in lacros-chrome. What this does: We are replacing existing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) with an exception where is is accompanied with `|| defined(OS_LINUX)` since that will evaluate to true for both ash-chrome and lacros-chrome. The buildflag was introduced in http://crrev.com/c/2426071. For more detail please read the design doc go/lacros-build-config. Test: printing_unittests Bug: 1052397 Change-Id: I51902ef0e963c509662576885be5602895685908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437079Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#814163}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Icfb9b5aa57f7a5232fbf41534f25c4ea1d54034c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445473Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814162}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6aa084d. With Chromium commits locally applied on WPT: dd98a6ff "[layout] Introduce the NGLayoutOverflowCalculator." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I33d0070a78d1848091c4f6e7744ab5430815c656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451535Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814161}
-
Jan Krcal authored
This is a reland of b8368dd1 Original change's description: > [Profile creation] Show sync confirmation and finish the flow > > This CL proceeds with the happy path of the signed-in profile creation > flow: > 1) After a successful sign-in, the current WebUI for sync confirmation > gets displayed; > 2) After choosing whether to sync, the flow is finished by opening a > browser window for the new profile. > > Error handling and restyling the confirmation page is left for follow-up > CLs. > > Bug: 1126913 > Change-Id: I17b43fe4ec0c0e0f2f9725b1df8e8e59d2c35f3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421592 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811140} Bug: 1126913 Change-Id: I4b3b6d974214c4be16f207111007887b433b04dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437373 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#814160}
-
Hitoshi Yoshida authored
SanitierConfig is a construction options for Sanitizer. Its members are defined to have non-null types in spec[1], and this CL makes its Blink implementation to follow the spec. [1] https://wicg.github.io/sanitizer-api/#sanitizer-api Bug: 839389, 116418 Change-Id: I86302fe6f36894bf102d23844bb9353ba5bdb1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444770Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#814159}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I924615894dbd75baf38ad389b160834d5868ac7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446209Reviewed-by:
-
Viktor Semeniuk authored
This change shows proper string when user is signed out and there are no weak passwords. Bug: 1135155 Change-Id: I46da38d75f48bc230058cf9f6f36b3effd0cd45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448373 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814157}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I475d54b703c2cea4ca5f6a816a200511571901e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445933Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814156}
-
Anastasiia N authored
Update width of management status label in settings, so it can fit the default "Primary account" text. Screenshots: http://screen/3QzuPjQMPCUpr8e, http://screen/9FRoEbupQUdSZ8e, http://screen/9vrUQp9LczfghoW Bug: 1099332 Change-Id: I22a92c993bc7ed960da0cf85b8455559794cb450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442016 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814155}
-
Gabriel Marin authored
Updated the microarchitecture based unit tests for default commands to check that the first two commands are sampling CPU cycles. BUG=b:170056137 Change-Id: I6a1a91e4f1b35cb0c3e6ef77dc6aa8a297f831ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450841Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#814154}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/326e14f34bb5..db2c2dd9b9a2 2020-10-06 enrico.galli@intel.com Add support for depthBias, depthBiasSlope, and depthBiasClamp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: If65aac1dcb0371a906ce334920b630071fc0ec7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452109Reviewed-by:
-
Callum May authored
Edge has been receiving reports of null pointer crashes similar to the linked bug. We believe they are caused by AuthenticatorCommon::IsUserVerifyingPlatformAuthenticatorAvailable passing in a null delegate since ContentBrowserClient::GetWebAuthenticationRequestDelegate may return a nullptr if the embedder can't service the request. To fix this we can check the pointer before calling the delegate Bug: 1110081 Change-Id: I007a8815fb23e86e025e2ccafb2bcc74d40aebfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423049 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#814152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idd7a25c5d7b92eb7595bdc00b4482f8344de231a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451906Reviewed-by:
-
Paula Vidas authored
The class is moved to a helper file so it can be reused in tests for sync invalidations. Bug: 1135167 Change-Id: I30cbc76cd5ed032666c5827b007c94128a65ebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450269 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#814150}
-
Aya ElAttar authored
- Changed ClipboardNonBacked::ReadImage to run ReadImageCallback with empty SKBitmap as a crash happens when it returns without running the callback. Bug: 1133717 Test: New unit test added. Change-Id: I6a7264b8b0d0c56e78852ed1822883cdd9c4efc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440656 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814149}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d0b4e1976ca1..9929780af36a 2020-10-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ib134880d8033303df6322748be8a16e60e2e9fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451899Reviewed-by:
-
Monica Basta authored
The code assumes if no browser exists for the profile where the signin is happening then the sign in error is related to the user manager. The previous assumption is not valid if the user decides to close the profile while the user manager or another profile is open. This CL compares the profile path with |UserManager::GetSigninProfilePath| and only in case of equality uses |UserManagerProfileDialog::DisplayErrorMessage| to show the sign in error. Bug: 1132175 Change-Id: Icccdc44d3927d8750bea9957120d7fef6677c4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435309 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814147}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/32decd42e68a..f79f298cc9cb 2020-10-06 sigurds@chromium.org Fix CSS priority for generated dark-mode themes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135123 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a720b9d513b66ed48d67eeeef26cdf3fac4134a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451907Reviewed-by:
-
Mikel Astiz authored
The metric has collected sufficient data and the team considers it sufficient to rely on Sync.PostedClientToServerMessageLatency. Change-Id: I5e53d623c058999a6bc5c7adb7b623141abe92f4 Fixed: 1105063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445151 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814145}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601899131-c43b6187adc90e2cb7e0fb0be3a8513091bf4fd9.profdata to chrome-win32-master-1601942192-fa539b08a521491a2633981acf18458f1a2ef415.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie4653559492a162b60d116d3be8f0a22ee3abbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451750Reviewed-by:
-
Nohemi Fernandez authored
This reverts commit 4f68ef3f. Reason for revert: Failing bot MAC Asan 64 tests https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/65394 Original change's description: > Desktop PWAs: Browser tests wait for registry > > The browser test helper methods in web_app_browsertest_util.cc > that install PWAs (InstallWebApp, InstallWebAppFromManifest, > PendingAppManagerInstall) now wait for on_registry_ready(). > > Bug: 1119807 > Change-Id: I60c16e04b75603a8d0979fd09e9f6746335cd788 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450133 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814065} TBR=dmurph@chromium.org,ericwilligers@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I23471abd515c34d6262def80bc83613420f90622 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119807,1135469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450319 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#814143}
-
Nohemi Fernandez authored
This reverts commit 430b7621. Reason for revert: Failing builder https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel Original change's description: > [LayoutNG] Don't truncate margins after spanners. > > A column spanner forcefully breaks a column, so any leading margins on > content right after the spanner shouldn't be discarded. > > Bug: 829028 > Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482 > Reviewed-by: Alison Maher <almaher@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813892} TBR=ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com Change-Id: I535ec21071aacd85f22968286e0f920fd2870324 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450062Reviewed-by:
-
Alexander Bolodurin authored
Split fileManagerPrivate.getThumbnail() into getDriveThumbnail() and getPdfThumbnail() to allow implementation-specific arguments: PDF thumbnailer supports size arguments, Drive thumbnailer only supports crop and, in future, others that may have their own (and different) argument needs. For getPdfThumbnail(), pass through size arguments from the image loader request to the PDF thumbnailer and pull up default values from C++ to the image loader JS code, to make them usable in other thumbnailers that take explicit dimension arguments. Bug: 1049966 Change-Id: Ia17a32028a7fb510c1755c9fa0283f9a37978331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434013 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814141}
-
Boris Sazonov authored
PrimaryAccountManager.IsAuthenticated was only checking sync account and wasn't fitting into the new consent-aware API for the primary account. This CL introduces HasPrimaryAccount(ConsentLevel) and replaces existing calls to IsAuthenticated with HasPrimaryAccount(kSync). Subsequent CLs will replace HasUnconsentedPrimaryAccount with HasPrimaryAccount(kNotRequired) and so on. Bug: 1046746 Change-Id: I2118ecbfc2295b9c437de304fd8617e1d13665aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440621 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=True Bug: 1134724 Change-Id: I8b3bf9d6e9c204854d16a082ff3a2c7987a36755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452090Reviewed-by:
-
Patrick Brosset authored
When initiator objects are created for parser and script type requests a line number is passed, so that clients can possibly link http requests to locations in source files. For some reasons, only the line number is passed and not the column. This means that for minified files (where all content is on one line) it is impossible to link to the exact location. Furthermore, clients like DevTools which know how to re-format minified files won't be able to link to the right line once a file is re-formatted. The column number is already available in the TextPosition object that is set in FetchInitiatorInfo, so in this change, we just return it to the client too. Corresponding frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2444236/ Bug: 1134064 Change-Id: I297924c3a22176309bd0fe4b613f7f1a42163ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442367Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814138}
-
Kenichi Ishibashi authored
This CL removes AppCacheResponseReader dependency from ServiceWorkerResourceWriter by re-implementing resource writing logic. See [1] for the reasoning of the rewrite. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit?usp=sharing This CL should not have behavior changes, and existing tests like ServiceWorkerResourceStorageTest cover this change. Bug: 1117369 Change-Id: I2fe4075ddff1c185768e0dd245e49f1ac5c26962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430687 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814137}
-
