GitLab

There are some repeated code in these functions and the only diff amongest
them is whether it gives "texImage2D" or "texSubImage2D" or "texSubImage3D".

This CL packs the repeated part into helper function. After this, when
we make changes to these functions in the future, we would only need to
change one place instead of 3 places. Also, this will reduce potential
bugs in the code. For example, at this moment, line 4131 in
WebGLRenderingContextBase.cpp (texImage2D) does this:
if (imageForRender && imageForRender->isSVGImage())

while line 1095 in WebGL2RenderingContextBase.cpp (texSubImage3D) does:
if (imageForRender->isSVGImage())
which doesn't do a null check on imageForRender.

This change can certainly prevent bugs like this.

For this change, we just need to make sure that all bots are green.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2025703002
Cr-Commit-Position: refs/heads/master@{#398286}

Review-Url: https://codereview.chromium.org/2041323002
Cr-Commit-Position: refs/heads/master@{#398285}

MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=shess@chromium.org

Review-Url: https://codereview.chromium.org/2033693004
Cr-Commit-Position: refs/heads/master@{#398284}

This lets Resources do the size calculations, and also fixes an issue where the
font scaling factor would be applied twice for >600dp screens
(chrome/android/java/res/values-sw600dp/dimens.xml already specifies the size
in sp).

Review-Url: https://codereview.chromium.org/2033683002
Cr-Commit-Position: refs/heads/master@{#398283}

This CL replaces MessageLoop::current()->DeleteSoon with
ThreadTaskRunnerHandle::Get()->DeleteSoon in ios. These
calls are equivalent on threads that run a MessageLoop.

BUG=616447
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2035953002
Cr-Commit-Position: refs/heads/master@{#398282}

Revert of Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness (patchset #3 id:60001 of https://codereview.chromium.org/2033953002/ )

Reason for revert:
looks like this broke the Android Tests (dbg) bot
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)

also see crbug.com/617935

Original issue's description:
> Fix DexLoaderTest#testLoadAfterDeleteCachedDexes() flakiness
>
> There seems to be data cached by the OS which is not deleted by
> DexLoader#deleteCachedDexes() which is causing the test to be flaky.
> This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test
> DexLoader#deleteCachedDexes() in a scenario which is closer to how the function
> is used in production.
>
> The test used to test that calling DexLoader#deleteCachedDexes() would make
> DexLoader#load() load a dex file from scratch.
>
> The CL changes the test to test that:
> - DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local
> data directory
> - It is possible to use reuse a data directory to load several dexes
>
> BUG=616923
>
> Committed: https://crrev.com/c59b7de12ab8878ddfe4df4fe5cd91b0d526b8c2
> Cr-Commit-Position: refs/heads/master@{#398198}

TBR=hanxi@chromium.org,pkotwicz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616923

Review-Url: https://codereview.chromium.org/2041333003
Cr-Commit-Position: refs/heads/master@{#398281}

BUG=skia:5398
# For minor change to ct_skps.isolate
TBR=maruel
NOTRY=true

Review-Url: https://codereview.chromium.org/2048623002
Cr-Commit-Position: refs/heads/master@{#398280}

Revert of Use /LTCG:Incremental to speed up the non-clobber official builds. (patchset #2 id:20001 of https://codereview.chromium.org/2045683002/ )

Reason for revert:
I'm seeing some compiler issue on the Win perf builders (https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Builder/builds/9316/steps/compile/logs/stdio) :

fatal error C1001: An internal error has occurred in the compiler

BUG=616946

Original issue's description:
> Use /LTCG:Incremental to speed up the non-clobber official builds.
>
> /LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.
>
> Committed: https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800
> Cr-Commit-Position: refs/heads/master@{#398153}

TBR=brucedawson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2035313007
Cr-Commit-Position: refs/heads/master@{#398279}

This reduces code duplication and makes the world a happier place.

BUG=611802
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2039853004
Cr-Commit-Position: refs/heads/master@{#398278}

Fix rounding issue:
int(x + 0.5) does not round up correctly.
This should be round(x+0.5) or math.ceil(x).

Fix formatting issue: the timeout is a float, and should be printed
using %f instead of %i.

Review-Url: https://codereview.chromium.org/2037373003
Cr-Commit-Position: refs/heads/master@{#398277}

During layout tests when preferences were being overriden they were not
being properly being used as the cached WebPreferences on the
RenderViewHost was not updated. This change fixes that and changes the way
spatial navigation is enabled in layout tests to adapt to this change.

This is an initial change to support the moving of mixed content checks to
the browser.

BUG=576270

Review-Url: https://codereview.chromium.org/2042763002
Cr-Commit-Position: refs/heads/master@{#398276}

Simplify transferring a counted element entry from one set to another.

To do so, add generalized version of add() over HashCountedSet that lets
the caller specify a count.

R=
BUG=

Review-Url: https://codereview.chromium.org/2045883002
Cr-Commit-Position: refs/heads/master@{#398275}

Ported from google3 with minor changes.

R=aizatsky@chromium.org, kcc@chromium.org, ochang@chromium.org, rouslan@chromium.org, phajdan.jr@chromium.org

BUG=539572

Review-Url: https://codereview.chromium.org/2012443002
Cr-Commit-Position: refs/heads/master@{#398274}

This cl uses updated V8 api which will be easier to work with incrementally
(althrough it is not used incrementally at the moment). For that
ScriptWrappableVisitor now has to maintain his marking deque.

LOG=no
BUG=468240

Review-Url: https://codereview.chromium.org/2044023002
Cr-Commit-Position: refs/heads/master@{#398273}

Chrome on iOS now requires mojo for WebUI which has an optional dependency
on third_party/WebKit. Chrome on iOS cannot depends on third_party/WebKit,
so only enable those optional dependencies if target OS is not iOS.

Fixes the following build failures when building with clang Xcode (which
is only done by downstream release bots as we do not have capacity to run
it on each commit):
  error: unable to load plugin 'third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib': 'dlopen(third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib, 9): Symbol not found: __ZN4llvm8RegistryIN5clang15PluginASTActionEE4HeadE
    Referenced from: third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.dylib

To prevent further dependencies on third_party/WebKit to creep in change
third_party/WebKit/Source/{config.gyp,wtf/wtf.gyp} to not define any
target when target OS is iOS (in order to generate errors when running
"gclient runhooks").

This is similar to corresponding GN changes in issue
https://codereview.chromium.org/2004743002/.

BUG=616750

Review-Url: https://codereview.chromium.org/2036683002
Cr-Commit-Position: refs/heads/master@{#398272}

The following tests were marked flaky in https://crbug.com/616100 and
https://crbug.com/616155:
- IndexedDBBrowserTest.GetAllMaxMessageSize
- IndexedDBBrowserTest.CanDeleteWhenOverQuotaTest
- IndexedDBBrowserTest.DeleteCompactsBackingStore

But they're not so much flaky, as genuinely broken since
https://codereview.chromium.org/2018663002 landed. That patch will soon
be fixed or reverted now that it has been identified as the root cause.

BUG=616155,616100
TBR=jsbell@chromium.org

Review-Url: https://codereview.chromium.org/2044533002
Cr-Commit-Position: refs/heads/master@{#398271}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/412fea1c..cba1fdd4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2047653002
Cr-Commit-Position: refs/heads/master@{#398270}

  In order to roll GN a8e5d2e3..c0f67c55 (r396969:r398260) and pick up
  the following changes:

  40451c50 Add support for user defined "pool" to GN.
  0e85587e Fix doc on "Multiple outputs" for runtime_deps.
  57979207 [Mac/iOS/GN] Document the new rules for create_bundle and runtime_deps.
  4feb71fc [GN] Adding missing source type for extension .appex.
  3dbb1f62 Migrate WaitableEvent to enum-based constructor in tools/

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg

Review-Url: https://codereview.chromium.org/2045913002
Cr-Commit-Position: refs/heads/master@{#398269}

Fix typo in TryToSetupDecodeOnSeparateThread method to set
decode_client_ properly in V4L2VideoDecodeAccelerator and
V4L2SliceVideoDecodeAccelerator classes.

BUG=

Review-Url: https://codereview.chromium.org/2044033002
Cr-Commit-Position: refs/heads/master@{#398268}

Backup and restore the sync settings. Also enable restore to an
older version of Chrome than the backed up version.

BUG=616477
BUG=613205

Review-Url: https://codereview.chromium.org/2047473003
Cr-Commit-Position: refs/heads/master@{#398267}

The workaround is no longer necessary.

BUG=617504

Review-Url: https://codereview.chromium.org/2048583003
Cr-Commit-Position: refs/heads/master@{#398266}

BUG=587663

Review-Url: https://codereview.chromium.org/2031973002
Cr-Commit-Position: refs/heads/master@{#398265}

This allows TransformValues to be inserted into the
InlineStylePropertyMap. It does not yet allow them to be retrieved from
any of the StylePropertyMaps. I'm working on that in
https://codereview.chromium.org/2039093003.

BUG=545318

Review-Url: https://codereview.chromium.org/2048483002
Cr-Commit-Position: refs/heads/master@{#398264}

BUG=524114
TEST=manually

Review-Url: https://codereview.chromium.org/2027553006
Cr-Commit-Position: refs/heads/master@{#398263}

Also restrict the categories in Sandwich to reduce the size of traces by 2x.

BUG=582080

Review-Url: https://codereview.chromium.org/2047463002
Cr-Commit-Position: refs/heads/master@{#398262}

Review-Url: https://codereview.chromium.org/2042213002
Cr-Commit-Position: refs/heads/master@{#398261}

Disallow cross-origin wrapper creation from them

BUG=616225
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2042743002
Cr-Commit-Position: refs/heads/master@{#398260}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/80d06aa4..412fea1c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2047643002
Cr-Commit-Position: refs/heads/master@{#398259}

Fixed by a revert in V8:
https://chromium.googlesource.com/v8/v8/+/9b606523b5e210f60c4260ee5f50a54e8f07adbd

BUG=617137
TBR=jbroman
NOTRY=true

Review-Url: https://codereview.chromium.org/2040153002
Cr-Commit-Position: refs/heads/master@{#398258}

Revert of Flip more Win bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2030823002/ )

Reason for revert:
Suspected to break Chrome Win builder. (Will revert this revert if it was a false alarm)

Error log:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/7879/steps/compile/logs/stdio

C:\b\build\scripts\slave\.recipe_deps\depot_tools\ninja.exe -w dupbuild=err -C C:\b\build\slave\google-chrome-rel-win\build\src\out\Release chrome chrome_official_builder_no_unittests -j200
ninja: Entering directory `C:\b\build\slave\google-chrome-rel-win\build\src\out\Release'
ninja: error: unknown target 'chrome_official_builder_no_unittests'

Original issue's description:
> Flip more Win bots to GN.
>
> This flips the remaining Win builders on the chromium, chromium.chrome,
> and chromium.perf waterfalls, as well as the matching trybots. The
> remaining GYP win builders are FYI bots, memory bots, and the official
> builders; the latter should be flipped ASAP after this lands to avoid
> any skew.
>
> R=brucedawson@chromium.org
> BUG=605319
>
> Committed: https://crrev.com/85eb563218e8b7af05360745aae05a2c79f80824
> Cr-Commit-Position: refs/heads/master@{#398033}

TBR=brucedawson@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605319

Review-Url: https://codereview.chromium.org/2046913002
Cr-Commit-Position: refs/heads/master@{#398257}

Review-Url: https://codereview.chromium.org/2046493003
Cr-Commit-Position: refs/heads/master@{#398256}

These friend declarations were added because MSVC had a bug around the
visibility of nested classes. They are no longer necessary.

BUG=617504

Review-Url: https://codereview.chromium.org/2041273002
Cr-Commit-Position: refs/heads/master@{#398255}

WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*),
but I think the issue had existed only in the transition period.
This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose().

(*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912625b89ba97bb

BUG=

Review-Url: https://codereview.chromium.org/2024033002
Cr-Commit-Position: refs/heads/master@{#398254}

BUG=none
R=pfeldman

Review-Url: https://codereview.chromium.org/2019143002
Cr-Commit-Position: refs/heads/master@{#398253}

This CL implements a simple search that matches the functionality of the
original history page.

This CL also fixes a bug related to window separators in the synced view
that could cause excess window separators to appear.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2022003002
Cr-Commit-Position: refs/heads/master@{#398252}

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2045723002
Cr-Commit-Position: refs/heads/master@{#398251}

This is a simple refactoring CL, and does not involve any
functionality change.

BUG=616302

Review-Url: https://codereview.chromium.org/2024813003
Cr-Commit-Position: refs/heads/master@{#398250}

If the object is not window, info.This() == info.Holder(). Hence, we can just replace
info.This() with info.Holder().

If the object is window, info.Holder() is the inner window and info.This() is the outer window.
However, all accesses to the outer window are redirected to the inner window.
Hence, the replacement doesn't change any behavior.

BUG=

Review-Url: https://codereview.chromium.org/2042943002
Cr-Commit-Position: refs/heads/master@{#398249}

This matches the most recent update of the spec:
https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318

Review-Url: https://codereview.chromium.org/2036893003
Cr-Commit-Position: refs/heads/master@{#398248}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a4540654..80d06aa4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2046893002
Cr-Commit-Position: refs/heads/master@{#398247}