GitLab

Required for crash server to de-obfuscate java stack traces.

BUG=620323

Review-Url: https://codereview.chromium.org/2556523002
Cr-Commit-Position: refs/heads/master@{#443305}

Since TaskManagerImpl is destructed after ~ArcServiceManager is called,
we need to check the return value from the getter.

BUG=680301
TEST=1) try, 2) sign in, wait for ARC boot, press Search+ESC,
 press Ctrl+Shift+QQ to sign out, confirm the browser does not crash

Review-Url: https://codereview.chromium.org/2625823005
Cr-Commit-Position: refs/heads/master@{#443304}

In order to support Client-side Lo-Fi and other Previews optimizations
which can be enabled in parallel, change the Lo-Fi bool to a Previews
bitmask.

TBR=mek@chromium.org
BUG=657997
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2484633004
Cr-Commit-Position: refs/heads/master@{#443303}

Prior to enabling PointerEvents, OOPIFs with TouchEvent handlers worked.
But with PointerEvents turned on, they fail. This happens because the
InputRouterImpl sending the touch events to the OOPIF never gets
notified of the current TouchAction, in turn because ChromeClientImpl
sends the TouchAction notification via RenderView and not the
RenderWidget serving the OOPIF.

Prior to PointerEvents this was not an issue, as the touch events
would continue to flow regardlesss. But with PointerEvents, touch
events are blocked after a TouchScrollStart is issued.

This CL plumbs a LocalFrame* parameter into ChromeClient::setTouchAction
so the notification can be sent via the correct channel.

BUG=680158

Review-Url: https://codereview.chromium.org/2626133002
Cr-Commit-Position: refs/heads/master@{#443302}

Suppress lint warnings for translations of the
data_reduction_promo_summary string in
values-pt-rBR/android_chrome_strings.xml and
values-cs/android_chrome_strings.xml

BUG=680246

Review-Url: https://codereview.chromium.org/2624183003
Cr-Commit-Position: refs/heads/master@{#443301}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7f52163a4f80..ed0540fbc6ef

$ git log 7f52163a4..ed0540fbc --date=short --no-merges --format='%ad %ae %s'
2017-01-12 simonhatch Dashboard - Append a link to the doc on memory regressions for memory benchmarks.
2017-01-12 simonhatch Dashboard - Fix bisect output when no values are produced.

BUG=680226

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2633503002
Cr-Commit-Position: refs/heads/master@{#443300}

Revert r440390's debug instrumentation of ExtendableMessageEvent.

R=
BUG=655926

Review-Url: https://codereview.chromium.org/2623273004
Cr-Commit-Position: refs/heads/master@{#443299}

BUG=649427
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628773004
Cr-Commit-Position: refs/heads/master@{#443298}

This variant of the test runs on Site Isolation Win in addition to the
regular test, hence it also needs to be disabled.

BUG=672570
NOTRY=true
TBR=lukasza@chromium.org

Review-Url: https://codereview.chromium.org/2633513002
Cr-Commit-Position: refs/heads/master@{#443297}

Neighbours can clip to the same infinity. Using two of the same
vertex in a polygon can cause the computed normal to be (0,0,0),
which causes badness and failures.

BUG=626095
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2551263002
Cr-Commit-Position: refs/heads/master@{#443296}

https://boringssl.googlesource.com/boringssl/+log/a81967b47c5eba78aedccd2bc3cb3fb95fe80bd0..8b8d22c961413c1ae465719d8252bea50587ed3f

BUG=none

Review-Url: https://codereview.chromium.org/2626273002
Cr-Commit-Position: refs/heads/master@{#443295}

https://skia.googlesource.com/skia.git/+log/d32303e7276b..693fdbd6b81a

$ git log d32303e72..693fdbd6b --date=short --no-merges --format='%ad %ae %s'
2017-01-12 reed refFoo variant for getters that naturally have a sk_sp
2017-01-12 mtklein skia_android_serial = "auto"
2017-01-12 brianosman Cleanup GrPixelConfig helper functions
2017-01-12 jvanverth Fix perf regression with SDF paths

BUG=677889

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2627953004
Cr-Commit-Position: refs/heads/master@{#443294}

The crash happens in a incognito page when a A2HS banner shows for a
WebApp. It is caused since WebApkInstallServiceFactory didn't implemtent
GetBrowserContextToUse() which returns a nullptr as default. In this CL,
the same pointer of the original browser context is returned for the
incognito page, so calling of WebApkInstallerService::Get() can return an
null-empty instance of WebApkInstallerService.

Crash Stacktrace:

Thread 0 CRASHED [SIGSEGV @ 0x0000000c ] MAGIC SIGNATURE THREAD
Stack Quality20%Show frame trust levels
0xd1af55a0	(libmonochrome.so -__tree:878 )	WebApkInstallService::IsInstallInProgress(GURL const&)
0xd1aefe43	(libmonochrome.so -shortcut_helper.cc:273 )	ShortcutHelper::IsWebApkInstalled(content::BrowserContext*, GURL const&, GURL const&)
0xd1a24ea3	(libmonochrome.so -app_banner_manager.cc:244 )	banners::AppBannerManager::PerformInstallableCheck()
0xd1abafd7	(libmonochrome.so -app_banner_manager_android.cc:180 )	banners::AppBannerManagerAndroid::PerformInstallableCheck()
0xd1a25c91	(libmonochrome.so -app_banner_manager.cc:239 )	banners::AppBannerManager::OnDidGetManifest(InstallableData const&)
0xd1a548d5	(libmonochrome.so -callback.h:85 )	InstallableManager::RunCallback(std::__ndk1::pair<InstallableParams, base::Callback<void (InstallableData const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> > const&, InstallableStatusCode)
0xd1a54a4d	(libmonochrome.so -installable_manager.cc:246 )	InstallableManager::WorkOnTask()
0xd1a54d55	(libmonochrome.so -installable_manager.cc:288 )	InstallableManager::OnDidGetManifest(GURL const&, content::Manifest const&)

BUG=679826

Review-Url: https://codereview.chromium.org/2620403002
Cr-Commit-Position: refs/heads/master@{#443293}

This should have been removed when the 'top' omnibox was hidden on the NTP.
Since there is only one omnibox visible on iPhone, we don't need the fakebox flag.

BUG=666081

Review-Url: https://codereview.chromium.org/2601943002
Cr-Commit-Position: refs/heads/master@{#443292}

BUG=

Review-Url: https://codereview.chromium.org/2592983003
Cr-Commit-Position: refs/heads/master@{#443291}

Revert of Part two of fallback crash handler for Crashpad handler process. (patchset #11 id:220001 of https://codereview.chromium.org/2611393002/ )

Reason for revert:
Breaks components_unittests on Win10.

Original issue's description:
> Part two of fallback crash handler for Crashpad handler process.
>
> This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it.
> After this, the dump is dropped into the Crashpad database for eventual upload.
>
> BUG=678959
>
> Review-Url: https://codereview.chromium.org/2611393002
> Cr-Commit-Position: refs/heads/master@{#443249}
> Committed: https://chromium.googlesource.com/chromium/src/+/92651104e939dbe94378a607e7acd381ca394fd3

TBR=scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678959

Review-Url: https://codereview.chromium.org/2628863005
Cr-Commit-Position: refs/heads/master@{#443290}

BUG=v8:4203
R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2625823006
Cr-Commit-Position: refs/heads/master@{#443289}

BUG=629305

Review-Url: https://codereview.chromium.org/2620373003
Cr-Commit-Position: refs/heads/master@{#443288}

If a user has a distilled entry in the Reading List and is on a poor network, the
distilled entry will be loaded and the user cannot access the online page.
To avoid blocking the user from the up to date page, reloading a page from the
offline page will not start the offline triggering timer.
Reloading again from the pending loading will load back the online version.

BUG=680481

Review-Url: https://codereview.chromium.org/2616093002
Cr-Commit-Position: refs/heads/master@{#443287}

This is the most Chrome-dependent part of //apps, and is only used for the app
list in Chrome, so why not move it to chrome/browser/ui/app_list?

This enables us to make the rest of the //apps code independent of Chrome so it
can be used for app_shell.

Alternatively, we could make custom_launcher_page_contents.cc not depend on
Chrome (it's mostly for extensions::ChromeExtensionWebContentsObserver), but
that's probably better off being lumped into a larger task to move app_list out
of chrome if that should become a goal.

BUG=679971
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2628883002
Cr-Commit-Position: refs/heads/master@{#443286}

- Push notifications are no longer grouped with all other Chrome
  notifications

- However, this patch makes them standalone, rather than grouped by
  origin, as we aren't yet setting a summary notification.

BUG=674015,674335

Review-Url: https://codereview.chromium.org/2628723003
Cr-Commit-Position: refs/heads/master@{#443285}

Use early returns and variables to avoid unwanted line breaks in statements.

Review-Url: https://codereview.chromium.org/2631513002
Cr-Commit-Position: refs/heads/master@{#443284}

From observer_list_threadsafe.h:
  // If the observer to be removed is in the list, RemoveObserver MUST
  // be called from the same thread which called AddObserver.

This rule is currently not respected by DomainReliabilityMonitor, which
prevents the addition of a DCHECK.

With this CL, the rule is respected and |last_network_change_time_|
is read/written from the same thread (no data race).

BUG=

Review-Url: https://codereview.chromium.org/2627523003
Cr-Commit-Position: refs/heads/master@{#443283}

Review-Url: https://codereview.chromium.org/2628973004
Cr-Commit-Position: refs/heads/master@{#443282}

Revert of Fix RGBA alpha parsing and serialization to adhere to W3 standard. (patchset #15 id:280001 of https://codereview.chromium.org/2608423002/ )

Reason for revert:
This CL causes Mac Retina to fail webkit tests fast/forms/select/menulist-appearance-basic.html
: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/10963

Original issue's description:
> Fix RGBA alpha parsing and serialization to adhere to W3 standard.
>
> Specifically, a 2.55 multiplication factor should be used, and
> serialization should be to two or three digits according to section
> <alphavalue> in https://drafts.csswg.org/cssom/#serializing-css-values
>
> This fixes test case "background-color: rgba(5, 7, 10, 0.5)" in
> https://w3c-test.org/cssom/serialize-values.html and also that the
> implementation is now same as Firefox as noted in the bug.
>
> Note a large number of tests need to be fixed, many of them because:
> - *-expected.txt specifically had bad alpha values such as 0.501961 or
> - an alpha value of 0.5 was previously 127 but should have been 128.
> The latter applies to the updated expected images too where the only
> difference was tiny bit of alpha (and rgb when alpha blended) change.
>
> BUG=453414
>
> Review-Url: https://codereview.chromium.org/2608423002
> Cr-Commit-Position: refs/heads/master@{#443157}
> Committed: https://chromium.googlesource.com/chromium/src/+/13a86c2faeebcbc12dd4a7e8dea54318da635c19

TBR=sashab@chromium.org,eae@chromium.org,ktyliu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453414

Review-Url: https://codereview.chromium.org/2629163002
Cr-Commit-Position: refs/heads/master@{#443281}

BUG=666666
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2629483002
Cr-Commit-Position: refs/heads/master@{#443280}

Review-Url: https://codereview.chromium.org/2623423003
Cr-Commit-Position: refs/heads/master@{#443279}

Increase ninja concurrency from 50 to 1000. Load templates from script
directory. No visible changes except some whitespace differences.

BUG=680217

Review-Url: https://codereview.chromium.org/2621413002
Cr-Commit-Position: refs/heads/master@{#443278}

This is a ~100mb file that isn't actaully used by anything, and that can
be created after-the-fact by a class-dumping tool

BUG=none

Review-Url: https://codereview.chromium.org/2619273002
Cr-Commit-Position: refs/heads/master@{#443277}

When creating a tab in foreground, the TabModel loads it before
marking it active to avoid visual blinking.
But loading require getting the header height of the new tab and not
of the current tab.

BUG=676153

Review-Url: https://codereview.chromium.org/2599313002
Cr-Commit-Position: refs/heads/master@{#443276}

- Move and rename the find bar buttons (since they're used beyond just
  the find bar these days).
- Fix VectorIconButton's disabled state.

BUG=626786

Review-Url: https://codereview.chromium.org/2625273002
Cr-Commit-Position: refs/heads/master@{#443275}

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2109293005
Cr-Commit-Position: refs/heads/master@{#443274}

The first memory system-health story ran in a set has been reporting
memory use differently all subsequent runs. This is due to how we
flush the system caches.

Just before we measure memory we flush the system caches unfortunately
this doesn't immediately take effect, instead the next story run is
effected. Due to this the first story run has anomalous results.
This option causes us to flush caches each time before Chrome starts
so we effect even the first story - avoiding the bug.

*************** Note to Perf Sheriff ****************

Regressions across several memory metrics are
expected for system_health.memory_mobile,
system_health.memory_desktop and memory.top10_mobile
as we stop under counting memory use.

*****************************************************

BUG=chromium:671156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2589173004
Cr-Commit-Position: refs/heads/master@{#443273}

This CL enables configuring which trigger types result in a background
fetch. The default configuration can be overridden by a variation
parameter. It also reports the trigger type of each fetch to UMA.

Additionally, this CL enables two additional trigger types that were
previously inactive (Chrome cold start / Chrome foregrounding).

BUG=672479

Review-Url: https://codereview.chromium.org/2626433005
Cr-Commit-Position: refs/heads/master@{#443272}

Chrome OS audio server is going to report more types of microphones,
implement the UI side corresponding code to parse these types from
node info.

BUG=672537

Review-Url: https://codereview.chromium.org/2609863007
Cr-Commit-Position: refs/heads/master@{#443271}

Change the note-taking app setting's "Waiting for Android
apps..." string to a simpler "Initializing...".

BUG=633596,633243

Review-Url: https://codereview.chromium.org/2628673004
Cr-Commit-Position: refs/heads/master@{#443270}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0e201cdd06ed..7f52163a4f80

$ git log 0e201cdd0..7f52163a4 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 simonhatch Bisect - Average list_of_scalars in compare_samples.

BUG=669608

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2628203002
Cr-Commit-Position: refs/heads/master@{#443269}

TBR=zmo@chromium.org

BUG=668223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2620133005
Cr-Commit-Position: refs/heads/master@{#443268}

Rather than have an extra copy of the data hanging off the
SSLClientSocketImpl, we can extract it out of BoringSSL on demand.

BUG=none

Review-Url: https://codereview.chromium.org/2601493002
Cr-Commit-Position: refs/heads/master@{#443267}

BUG=679369

Review-Url: https://codereview.chromium.org/2618333005
Cr-Commit-Position: refs/heads/master@{#443266}