GitLab

This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call.  Ouch.

BUG=none
TEST=new unittests


Review URL: http://codereview.chromium.org/8738001

TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8914022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114495 0039d316-1c4b-4281-b951-d872f2087c98

This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call.  Ouch.

BUG=none
TEST=new unittests


Review URL: http://codereview.chromium.org/8738001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114494 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8907049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114493 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a straightforward crash from the clock menu, and also includes some code cleanup done while investigating (see inline comments).

BUG=chromium-os:issue_106947
TEST=Test the clock display and menu in the status area, including changing 24 hour and timezone preferences. Also, see issue.


Review URL: http://codereview.chromium.org/8930001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114492 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 84af7c82.

BUG=none
TEST=none
TBR=apatrick@chromium.org

Review URL: http://codereview.chromium.org/8914016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114491 0039d316-1c4b-4281-b951-d872f2087c98

TBR=God
NOTRY=true
BUG=chromium:107599
TEST=None

Review URL: http://codereview.chromium.org/8818013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97848
TEST=manual. Check chrome:plugins, run gtalk if plugins available


Review URL: http://codereview.chromium.org/8899014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114487 0039d316-1c4b-4281-b951-d872f2087c98

This prevents the translators from accidentally translating or removing
these from the translations.

Review URL: http://codereview.chromium.org/8930022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114486 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114090

Review URL: http://codereview.chromium.org/8822017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114485 0039d316-1c4b-4281-b951-d872f2087c98

mac-release/sizes: http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=50&header=ChromiumFramework&graph=ChromiumFramework&rev=114468

mac-release/sizes: http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=50&header=ChromiumFramework&graph=Chromium.app&rev=114468

TBR=cmp
Review URL: http://codereview.chromium.org/8916012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114484 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/8921025 added logic to take care of the
case where changing the gaia passphrase caused a sync client that was
already signed in to request a reauth, and if it was unavailable, go to
one of the OFFLINE states.

This patch adds a sync integration test to verify that a client does
indeed go to the OFFLINE state when the gaia password has been changed
elsewhere.

BUG=none
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/8931013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114483 0039d316-1c4b-4281-b951-d872f2087c98

Use the unique_id to determine the process instead of the selected index. 

BUG=chromium-os:23739
TEST=manual on chromium-os(aura) on Linux 

Review URL: http://codereview.chromium.org/8932003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114479 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org,mirandac@chromium.org
BUG=107397
TEST=ExtensionsLoadMultipleTest

Review URL: http://codereview.chromium.org/8898025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114478 0039d316-1c4b-4281-b951-d872f2087c98

OmniboxViewTest.PopupAccelerators had to be disabled for Aura so that we can enable the intyeractive_ui_tests in the main Waterfall

TBR=oshima@chromium.org
BUG=107588
TEST=none

Review URL: http://codereview.chromium.org/8915011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114477 0039d316-1c4b-4281-b951-d872f2087c98

Revert 114133 - Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only initialize the number of
levels requirested. Also ClearLevel now uses glTexSubImage2D to clear the level if the
texture is immutable.  Finally, rearranged the code in doTexSubImage2D to correctly
bypass clearing a level if the bitmaps supplied matches the dimensions of the texture level.
BUG=106894
Review URL: http://codereview.chromium.org/8872061

Reverting as it may be causing a failure in the XP perf bots:
http://build.chromium.org/p/chromium.perf/builders/XP%20Perf%20%28dbg%29/builds/6854

Un-reverting original change.  It doesn't seem to have been the cause for the regression.


TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/8905027

TBR=vangelis@chromium.org
Review URL: http://codereview.chromium.org/8913011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114476 0039d316-1c4b-4281-b951-d872f2087c98

We appear to need to mark classes AURA_SHELL_EXPORT in order to use them in unit tests.

TBR=sky@chromium.org
BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/8911010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114475 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8898029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114474 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves all command line processing out of the coordinator.  Key other features required by this change:
1) object and nexe are now passed by ppapi temporary files
2) native library and .o loading is done purely on demand
3) the command lines baked into llc and ld are used exclusively

One minor change that fit with the CL is that the coordinator now creates only one helper thread that runs both llc and ld.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2440
TEST=none
Review URL: http://codereview.chromium.org/8786005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114473 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/8933010/ caused a regression in interactive_ui_tests on Linux+Aura+ChromeOS

http://codereview.chromium.org/8873036/
was rebased on the above and had to be reverted

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8916010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114472 0039d316-1c4b-4281-b951-d872f2087c98

Databases are deleted before starting tests, to ensure nothing remains
from previous runs. Test results are communicated back via document.title
to avoid trying to read back a value by injecting script into a process
that's busy-looping. Test phases are explicitly triggered by the caller
in all cases, rather than relying on previous test state.

BUG=103456
TEST=

Review URL: http://codereview.chromium.org/8892021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=csilv

Review URL: http://codereview.chromium.org/8910015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114470 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=107567
TEST=drmemory bots go greener

Review URL: http://codereview.chromium.org/8916009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114469 0039d316-1c4b-4281-b951-d872f2087c98

This is intended to make it easier to test Breakpad crash dumping on
the buildbots.  Crash dumping will be disabled in Chromium by default
at run time unless CHROME_HEADLESS is set.

The bots set CHROME_HEADLESS, but we don't really want the bots to be
uploading crash dumps that are useless without symbols, so uploading
is disabled except for official builds and when building with
mac_breakpad_uploads=1.

This should not affect stack backtraces that occur in tests (such as
browser_tests) via StackDumpSignalHandler().  Although Breakpad would
normally take priority over this signal handler, Breakpad does not get
enabled in these test suites because is_browser is false inside
InitCrashReporter().

This change leaves the Gyp option "mac_breakpad" for enabling the
creation of Breakpad files.  This remains off by default for Chromium
builds, because the symbol dumping is slow and because it has problems
in the makefile-based Mac builds.

BUG=105778
TEST=run Chromium with --crash-test and CHROME_HEADLESS=1; a *.dmp file
  should appear in ~/Library/Application Support/Chromium/Crash Reports


Review URL: http://codereview.chromium.org/8824003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114468 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8916005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114467 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mpcomplete@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8910012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114466 0039d316-1c4b-4281-b951-d872f2087c98

    The Chrome Frame test flakyness has been resolved by
    http://src.chromium.org/viewvc/chrome?view=rev&revision=114046

TBR=dmazzoni@chromium.org
TEST=try bots.
BUG=99629


Review URL: http://codereview.chromium.org/8914009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114465 0039d316-1c4b-4281-b951-d872f2087c98

At least we got rid of the button!

BUG=105582
TEST=Go to https://latest.foo.appspot.com and get an interstitial with no "Proceed" button. Type "proceed" in the page and expect it to continue to load.


Review URL: http://codereview.chromium.org/8919007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114464 0039d316-1c4b-4281-b951-d872f2087c98

Options2 is a copy of the resources for and implementation of chrome://settings that will be pared down significantly for UberPage (see bug).

BUG=100885
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8895023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114462 0039d316-1c4b-4281-b951-d872f2087c98

Also fix a typo in es_419 data.

BUG=chromium-os:23036
TEST=Manual


Review URL: http://codereview.chromium.org/8932013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114461 0039d316-1c4b-4281-b951-d872f2087c98

DownloadQuery will be used first by the DownloadsSearchFunction in download_extension_api.h/cc to implement the chrome.experimental.downloads.search() function outlined in http://goo.gl/6hO1n

BUG=12133
TEST=content_unittests DownloadQueryTest

Review URL: http://codereview.chromium.org/8601012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106432
TEST=None

Review URL: http://codereview.chromium.org/8873036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114459 0039d316-1c4b-4281-b951-d872f2087c98

This is so that the sync performance tests don't need to wait for each
URL delete to hit the disk before moving on to the next one.

This is a speculative fix to stabilize the delete_typed_urls sync perf
test.  It also cuts down the runtime of the typed urls test from >20s to <10s or so.

BUG=107040
TEST=

Review URL: http://codereview.chromium.org/8890089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114458 0039d316-1c4b-4281-b951-d872f2087c98

Make NotificationService handle the process of instantiating NotificationServiceImpl instead.

BUG=98716
R=jam@chromium.org
TBR=akalin@chromium.org

Review URL: http://codereview.chromium.org/8913009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114454 0039d316-1c4b-4281-b951-d872f2087c98

xp-release/sizes: http://build.chromium.org/f/chromium/perf/xp-release/sizes/report.html?history=150&rev=114424

TBR=cmp
Review URL: http://codereview.chromium.org/8910010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114453 0039d316-1c4b-4281-b951-d872f2087c98

Adding tests + minor code cleanup.

BUG=NONE
TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart)


Review URL: http://codereview.chromium.org/8929027

TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8916006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114452 0039d316-1c4b-4281-b951-d872f2087c98

vista-release-dual-core/dom_perf: http://build.chromium.org/f/chromium/perf/vista-release-dual-core/dom_perf/report.html?history=250&rev=114297

mac-release-10.6/dom_perf: http://build.chromium.org/f/chromium/perf/mac-release-10.6/dom_perf/report.html?history=250&rev=114297

TBR=cmp
Review URL: http://codereview.chromium.org/8933024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114450 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8918005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114448 0039d316-1c4b-4281-b951-d872f2087c98

through HTTPS Proxies. This also changes the mechanism used 
to restart HttpProxyClientSocket requests with auth. Previously
the transport socket would be Disconnected, and then re-Connected
(which was not implemented for SSLClientSockets). However, the 
approach was problematic in the face of, for example, ipv6. The
new approach is to close the HttpProxyClientSocket, and request
a new socket from the pool.

Review URL: http://codereview.chromium.org/8912010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114447 0039d316-1c4b-4281-b951-d872f2087c98

Because
- chrome.webRequest.*.addListener can be called multiple times with the same callback function, and
- chrome.webRequest.*.removeListener does not consider the filters and extraInfoSpec for removing a listener,
calling removeListener should remove all listeners that are registered for one callback.

BUG=107368
TEST=no


Review URL: http://codereview.chromium.org/8934008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114446 0039d316-1c4b-4281-b951-d872f2087c98

The mac bots do have audio hardware so we should be able to safely run these tests.

TEST=This runs more tests as part of media_unittests on the mac bots.

Review URL: http://codereview.chromium.org/8909005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114445 0039d316-1c4b-4281-b951-d872f2087c98