- 25 Jul, 2016 40 commits
-
-
mikecase authored
BUG=522043 Review-Url: https://codereview.chromium.org/2051913002 Cr-Commit-Position: refs/heads/master@{#407620}
-
sque authored
The build ID reading code is based on: src/native_client/src/untrusted/minidump_generator/build_id.cc BUG=chromium:627873 TEST=build successfully Review-Url: https://codereview.chromium.org/2159013002 Cr-Commit-Position: refs/heads/master@{#407619}
-
rsleevi authored
Symantec originally indicated NTT DoCoMo was indepedently operated, but subsequent investigation revealed it was part of Symantec's MPKI. Apple's G3 is only audited to WebTrust for CAs, not SSL BRs, so removing it from the exclusion set. This adds Apple's CA 8 to the set, after communicating with Apple's PKI team to receive confirmation that it was created pursuant to the audited CP/CPS and is part of the same infrastructure. BUG=620178 Review-Url: https://codereview.chromium.org/2177943004 Cr-Commit-Position: refs/heads/master@{#407618}
-
qyearsley authored
BUG=508725,627008 Review-Url: https://codereview.chromium.org/2175383002 Cr-Commit-Position: refs/heads/master@{#407617}
-
yoav authored
According to https://github.com/ResponsiveImagesCG/picture-element/issues/223#issuecomment-69772765 we seem to be the only browser that loads data URIs immediately (as if they were cached). It was introduced as part of the move to async image loading: https://codereview.chromium.org/200923002 This is now causing issues: https://code.google.com/p/chromium/issues/detail?id=469131 This CL changes this behavior to be spec compliant and load data URIs asynchronously, like other resources. This is relanding https://codereview.chromium.org/1492303003 BUG=514206 Review-Url: https://codereview.chromium.org/2173003002 Cr-Commit-Position: refs/heads/master@{#407616}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61e64edd..f5146b9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2181763002 Cr-Commit-Position: refs/heads/master@{#407615}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=vabr@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2169263002 Cr-Commit-Position: refs/heads/master@{#407614}
-
rouslan authored
When PaymentRequest UI is closing, any open editor UI should also be closed. Closing editor UI fires callbacks that should be ignored in this case. BUG=631130 Review-Url: https://codereview.chromium.org/2176273002 Cr-Commit-Position: refs/heads/master@{#407613}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=dtrainor@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2175503002 Cr-Commit-Position: refs/heads/master@{#407612}
-
mpearson authored
Revert of Revert disabled test for crbug/419370 (patchset #2 id:20001 of https://codereview.chromium.org/2174743002/ ) Reason for revert: Newly re-enabled tests crash consistently on Linux ChromiumOS Tests (dbg)(1) bot. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 StartupPageListWebUITest.testDropFromOutsideSource (run #1): [ RUN ] StartupPageListWebUITest.testDropFromOutsideSource [28436:28436:0725/125631:WARNING:chrome_browser_main_chromeos.cc(332)] Running as stub user with profile dir: test-user [28436:28436:0725/125631:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [28436:28436:0725/125631:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [28436:28436:0725/125631:ERROR:logging_chrome.cc(173)] Unable to create symlink /tmp/.org.chromium.Chromium.2OfPzc/dVYVbTE/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.2OfPzc/dVYVbTE/test-user/chrome_debug_20160725-125631.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [28436:28474:0725/125631:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.2OfPzc/dVYVbTE/stub_device_local_extension_cache/.initialized exists. [28436:28436:0725/125632:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [28436:28459:0725/125632:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [28470:28497:0725/125633:ERROR:node_controller.cc(1099)] Could not be introduced to peer 92B1CCD4AD67F70B.12EAFA42C6B0A7E0 [28436:28436:0725/125635:WARNING:CONSOLE(1084)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://resources/js/cr/ui/list.js (1084) [28436:28436:0725/125636:ERROR:device_event_log_impl.cc(140)] [12:56:37.003] Network: ui_proxy_config_service.cc:91 No configured NetworkState for guid: [28436:28436:0725/125637:WARNING:user_image_source.cc(39)] Failed to deserialize account_id. [28436:28436:0725/125639:INFO:CONSOLE(1206)] "Running TestCase StartupPageListWebUITest.testDropFromOutsideSource", source: test_api.js (1206) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f8ac44f2c0e base::debug::StackTrace::StackTrace() #1 0x0000042772fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f8aab0c00b0 <unknown> #3 0x7f8aab171993 __poll #4 0x7f8aaef36ff6 <unknown> #5 0x7f8aaef37124 g_main_context_iteration #6 0x7f8ac45857df base::MessagePumpGlib::Run() #7 0x7f8ac456fb8a base::MessageLoop::RunHandler() #8 0x7f8ac460bd94 base::RunLoop::Run() #9 0x0000042fc3b6 content::RunThisRunLoop() #10 0x0000042fc34a content::RunMessageLoop() #11 0x0000012ed456 WebUITestHandler::WaitForResult() #12 0x0000012ed129 WebUITestHandler::RunJavaScriptTestWithResult() #13 0x0000013d62b7 WebUIBrowserTest::RunJavascriptUsingHandler() #14 0x0000013d67f2 WebUIBrowserTest::RunJavascriptTest() #15 0x0000013d6741 WebUIBrowserTest::RunJavascriptTestF() #16 0x0000018b53eb StartupPageListWebUITest_testDropFromOutsideSource_Test::RunTestOnMainThread() #17 0x000003558718 InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x0000042770c1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x0000009d3b02 _ZN4base8internal13FunctorTraitsIM24DevToolsBeforeUnloadTestFvvEvE6InvokeIRK13scoped_refptrI53DevToolsBeforeUnloadTest_TestDockedDevToolsClose_TestEJEEEvS4_OT_DpOT0_ #20 0x000004278221 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content15BrowserTestBaseEFvvEJRK13scoped_refptrIS5_EEEEvOT_DpOT0_ #21 0x0000042781c2 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #22 0x000004277fec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x000000879aae base::Callback<>::Run() #24 0x0000035f7089 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x0000035f5e00 ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x000001a0d245 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #27 0x7f8abc36e591 content::BrowserMainLoop::PreMainMessageLoopRun() #28 0x7f8abbae46ed _ZN4base8internal13FunctorTraitsIMN4mojo10BindingSetIN7content5mojom14ProcessControlEE7ElementEFvvEvE6InvokeIPS8_JEEEvSA_OT_DpOT0_ #29 0x7f8abc3762f1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #30 0x7f8abc376297 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #31 0x7f8abc3761fc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #32 0x7f8abbae479e base::Callback<>::Run() #33 0x7f8abcd6669b content::StartupTaskRunner::RunAllTasksNow() #34 0x7f8abc36c613 content::BrowserMainLoop::CreateStartupTasks() #35 0x7f8abc37876d content::BrowserMainRunnerImpl::Initialize() #36 0x7f8abc368cdd content::BrowserMain() #37 0x7f8abdc24c06 content::RunNamedProcessTypeMain() #38 0x7f8abdc26ca5 content::ContentMainRunnerImpl::Run() #39 0x7f8abdc23e42 content::ContentMain() #40 0x000004276e1d content::BrowserTestBase::SetUp() #41 0x000003557244 InProcessBrowserTest::SetUp() #42 0x00000081d27a _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_ #43 0x00000440ad0e testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x000004400023 testing::Test::Run() #45 0x000004400798 testing::TestInfo::Run() #46 0x000004400d3a testing::TestCase::Run() #47 0x00000440608c testing::internal::UnitTestImpl::RunAllTests() #48 0x00000441acca testing::internal::HandleSehExceptionsInMethodIfSupported<>() #49 0x00000440c31e testing::internal::HandleExceptionsInMethodIfSupported<>() #50 0x000004405d2f testing::UnitTest::Run() #51 0x000003568e61 RUN_ALL_TESTS() #52 0x000003567dd2 base::TestSuite::Run() #53 0x00000351cb32 ChromeTestSuiteRunner::RunTestSuite() #54 0x00000351cc19 ChromeTestLauncherDelegate::RunTestSuite() #55 0x0000042f0145 content::LaunchTests() #56 0x00000351cf39 LaunchChromeTests() #57 0x0000007f8f74 main #58 0x7f8aab0ab7ed __libc_start_main #59 0x0000007f8e05 <unknown> StartupPageListWebUITest.testDropToReorder (run #1): [ RUN ] StartupPageListWebUITest.testDropToReorder [28506:28506:0725/125636:WARNING:chrome_browser_main_chromeos.cc(332)] Running as stub user with profile dir: test-user [28506:28506:0725/125636:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [28506:28506:0725/125636:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected [28506:28506:0725/125636:ERROR:logging_chrome.cc(173)] Unable to create symlink /tmp/.org.chromium.Chromium.2OfPzc/dEqao8B/test-user/chrome_debug.log pointing at /tmp/.org.chromium.Chromium.2OfPzc/dEqao8B/test-user/chrome_debug_20160725-125636.log: No such file or directory Xlib: extension "RANDR" missing on display ":9". [28506:28528:0725/125637:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.2OfPzc/dEqao8B/stub_device_local_extension_cache/.initialized exists. [28506:28506:0725/125637:WARNING:child_account_service.cc(302)] User instance wasn't found while setting child account flag. [28506:28531:0725/125637:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. [28544:28566:0725/125639:ERROR:node_controller.cc(1099)] Could not be introduced to peer 72E0750553B9F697.FCC163B203A2E18 [28506:28506:0725/125641:WARNING:CONSOLE(1084)] "/deep/ combinator is deprecated. See https://www.chromestatus.com/features/6750456638341120 for more details.", source: chrome://resources/js/cr/ui/list.js (1084) [28506:28506:0725/125643:ERROR:device_event_log_impl.cc(140)] [12:56:43.459] Network: ui_proxy_config_service.cc:91 No configured NetworkState for guid: [28506:28506:0725/125643:WARNING:user_image_source.cc(39)] Failed to deserialize account_id. [28506:28506:0725/125646:INFO:CONSOLE(1206)] "Running TestCase StartupPageListWebUITest.testDropToReorder", source: test_api.js (1206) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7fe75e022c0e base::debug::StackTrace::StackTrace() #1 0x0000042772fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fe744bf00b0 <unknown> #3 0x7fe744ca1993 __poll #4 0x7fe748a66ff6 <unknown> #5 0x7fe748a67124 g_main_context_iteration #6 0x7fe75e0b57df base::MessagePumpGlib::Run() #7 0x7fe75e09fb8a base::MessageLoop::RunHandler() #8 0x7fe75e13bd94 base::RunLoop::Run() #9 0x0000042fc3b6 content::RunThisRunLoop() #10 0x0000042fc34a content::RunMessageLoop() #11 0x0000012ed456 WebUITestHandler::WaitForResult() #12 0x0000012ed129 WebUITestHandler::RunJavaScriptTestWithResult() #13 0x0000013d62b7 WebUIBrowserTest::RunJavascriptUsingHandler() #14 0x0000013d67f2 WebUIBrowserTest::RunJavascriptTest() #15 0x0000013d6741 WebUIBrowserTest::RunJavascriptTestF() #16 0x0000018b570b StartupPageListWebUITest_testDropToReorder_Test::RunTestOnMainThread() #17 0x000003558718 InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x0000042770c1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x0000009d3b02 _ZN4base8internal13FunctorTraitsIM24DevToolsBeforeUnloadTestFvvEvE6InvokeIRK13scoped_refptrI53DevToolsBeforeUnloadTest_TestDockedDevToolsClose_TestEJEEEvS4_OT_DpOT0_ #20 0x000004278221 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content15BrowserTestBaseEFvvEJRK13scoped_refptrIS5_EEEEvOT_DpOT0_ #21 0x0000042781c2 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #22 0x000004277fec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJ13scoped_refptrIS4_EEEEFvvEE3RunEPNS0_13BindStateBaseE #23 0x000000879aae base::Callback<>::Run() #24 0x0000035f7089 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #25 0x0000035f5e00 ChromeBrowserMainParts::PreMainMessageLoopRun() #26 0x000001a0d245 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #27 0x7fe755e9e591 content::BrowserMainLoop::PreMainMessageLoopRun() #28 0x7fe7556146ed _ZN4base8internal13FunctorTraitsIMN4mojo10BindingSetIN7content5mojom14ProcessControlEE7ElementEFvvEvE6InvokeIPS8_JEEEvSA_OT_DpOT0_ #29 0x7fe755ea62f1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ #30 0x7fe755ea6297 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #31 0x7fe755ea61fc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #32 0x7fe75561479e base::Callback<>::Run() #33 0x7fe75689669b content::StartupTaskRunner::RunAllTasksNow() #34 0x7fe755e9c613 content::BrowserMainLoop::CreateStartupTasks() #35 0x7fe755ea876d content::BrowserMainRunnerImpl::Initialize() #36 0x7fe755e98cdd content::BrowserMain() #37 0x7fe757754c06 content::RunNamedProcessTypeMain() #38 0x7fe757756ca5 content::ContentMainRunnerImpl::Run() #39 0x7fe757753e42 content::ContentMain() #40 0x000004276e1d content::BrowserTestBase::SetUp() #41 0x000003557244 InProcessBrowserTest::SetUp() #42 0x00000081d27a _ZN7testing8internal12InvokeHelperIRKNSt7__debug6vectorIPN12user_manager4UserESaIS6_EEESt5tupleIJEEE12InvokeMethodIN8chromeos15MockUserManagerEMSG_KFSA_vEEESA_PT_T0_RKSC_ #43 0x00000440ad0e testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x000004400023 testing::Test::Run() #45 0x000004400798 testing::TestInfo::Run() #46 0x000004400d3a testing::TestCase::Run() #47 0x00000440608c testing::internal::UnitTestImpl::RunAllTests() #48 0x00000441acca testing::internal::HandleSehExceptionsInMethodIfSupported<>() #49 0x00000440c31e testing::internal::HandleExceptionsInMethodIfSupported<>() #50 0x000004405d2f testing::UnitTest::Run() #51 0x000003568e61 RUN_ALL_TESTS() #52 0x000003567dd2 base::TestSuite::Run() #53 0x00000351cb32 ChromeTestSuiteRunner::RunTestSuite() #54 0x00000351cc19 ChromeTestLauncherDelegate::RunTestSuite() #55 0x0000042f0145 content::LaunchTests() #56 0x00000351cf39 LaunchChromeTests() #57 0x0000007f8f74 main #58 0x7fe744bdb7ed __libc_start_main #59 0x0000007f8e05 <unknown> Original issue's description: > Revert disabled test for crbug/419370 > > The disabled test seems to have hit assertion in the old code, > which does not exist today. > Removing 'DISABLED_' prefix to revive those tests. > > BUG=419370 > > Committed: https://crrev.com/73e67742737ad7cdfaeabf162d97857ee321278a > Cr-Commit-Position: refs/heads/master@{#407414} TBR=dbeam@chromium.org,kochi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=419370 Review-Url: https://codereview.chromium.org/2177373002 Cr-Commit-Position: refs/heads/master@{#407611}
-
dpranke authored
R=mbarbella@chromium.org, inferno@chromium.org BUG=630905 Review-Url: https://codereview.chromium.org/2178033003 Cr-Commit-Position: refs/heads/master@{#407610}
-
mikecase authored
Running "run_chrome_browser_tests.py PopularUrlsTest" will run a page cycler that loops through a list of popular urls. This test is to replace the old PopularUrls test which was deleted because it relied on some flaky build/android/test_runner.py code. BUG=604882 Review-Url: https://codereview.chromium.org/2140803003 Cr-Commit-Position: refs/heads/master@{#407609}
-
danakj authored
This changes half the LayerTreeHostCommon tests to just set things on layers instead of calling SetLayerPropertiesForTesting with a bunch of default values that are just noise. Once the others are done we can remove those methods. R=ajuma@chromium.org, jaydasika@chromium.org BUG=630754 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2178073003 Cr-Commit-Position: refs/heads/master@{#407608}
-
nick authored
(ascending -> descending -> no sort) if the column is initially ascending, or (descending -> ascending -> no sort) if the column is initially descending. Expose a set_sort_descriptors() method so that TaskManagerTableModel can apply its saved user preference directly. Previously that worked by calling ToggleSortOrder the right number of times, which was weird, since ToggleSortOrder is basically a click event handler. Expand unittests to verify the implementation. BUG=616897,54909 Review-Url: https://codereview.chromium.org/2146033003 Cr-Commit-Position: refs/heads/master@{#407607}
-
mpearson authored
Revert of Enable Expect-Staple in SSLClientSocket. (patchset #3 id:40001 of https://codereview.chromium.org/2155753002/ ) Reason for revert: The newly added test HTTPSOCSPTest.ExpectStapleReportNotSentOnValid fails on the Android bot: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/2675 C 165.045s Main Detailed Logs C 165.045s Main ******************************************************************************** C 165.063s Main [FAIL] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid: C 165.063s Main [ RUN ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid C 165.063s Main [WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: / C 165.063s Main ../../net/url_request/url_request_unittest.cc:9342: Failure C 165.063s Main Value of: mock_report_sender.latest_report().empty() C 165.063s Main Actual: false C 165.064s Main Expected: true C 165.064s Main ../../net/url_request/url_request_unittest.cc:9343: Failure C 165.064s Main Value of: mock_report_sender.latest_report_uri() C 165.064s Main Actual: https://report.badssl.com/expect-staple C 165.064s Main Expected: GURL() C 165.064s Main Which is: C 165.064s Main [ FAILED ] HTTPSOCSPTest.ExpectStapleReportNotSentOnValid (65 ms) Original issue's description: > Enable Expect-Staple in SSLClientSocket. > > In TransportSecurityState, set |enable_static_expect_staple_| > to true by default. Update SSLClientSocket to call > TransportSecurityState::ProcessExpectStaple. > > In ssl_client_socket_impl.cc, this also removes the if > (|signed_certificate_timestamps_enabled_) check around > extracting the OCSP response and setting the > UMA_HISTOGRAM_BOOLEAN("Net.OCSPResponseStapled"). Since > SCTs are always enabled, this if statement was a noop. > > This does not enable Expect-Staple for QUIC. See > https://crbug.com/631101 > > BUG=598021 > > Committed: https://crrev.com/3c0e49240847ea54265e17c7a8a1ecf73daeaeee > Cr-Commit-Position: refs/heads/master@{#407575} TBR=svaldez@chromium.org,rsleevi@chromium.org,estark@chromium.org,dadrian@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598021 Review-Url: https://codereview.chromium.org/2176183003 Cr-Commit-Position: refs/heads/master@{#407606}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=oshima@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2172023002 Cr-Commit-Position: refs/heads/master@{#407605}
-
sungmann.cho authored
Currently, the official build always disable "Report an Issue" menu item through -[AppController validateUserInterfaceItem:], when Task Manager is opened and focused. This code was added at https://codereview.chromium.org/7635017. I can't find any discussion of this behaviour, but I think users should be able to report their problems at any time without any difficulties. BUG=526531 Review-Url: https://codereview.chromium.org/2177563002 Cr-Commit-Position: refs/heads/master@{#407604}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=reillyg@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2172043002 Cr-Commit-Position: refs/heads/master@{#407603}
-
dgozman authored
BUG=631162 Review-Url: https://codereview.chromium.org/2179683002 Cr-Commit-Position: refs/heads/master@{#407602}
-
dbeam authored
They were never on to begin with and now that we've reached a new enough version of Polymer that this flag actually has an effect, it's breaking things. TBR=michaelpg@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Review-Url: https://codereview.chromium.org/2181073002 Cr-Commit-Position: refs/heads/master@{#407601}
-
ulan authored
system_health.memory_desktop.browse:news:nytimes. Mac 10.9 does not run these tests after https://codereview.chromium.org/2175293002 BUG=630686,630765 Review-Url: https://codereview.chromium.org/2178933002 Cr-Commit-Position: refs/heads/master@{#407600}
-
krasin authored
According to the C++ standard, the three arguments overload of std::string::assign accepts an std::basic_string: http://en.cppreference.com/w/cpp/string/basic_string/assign Fixing the usage, where char* instead of std::string was passed. This popped up after libc++ became more standard compliant, and now it throws a compiler error. BUG=630681 Review-Url: https://codereview.chromium.org/2177863003 Cr-Commit-Position: refs/heads/master@{#407599}
-
rnephew authored
BUG=630627,615157 Review-Url: https://codereview.chromium.org/2175313003 Cr-Commit-Position: refs/heads/master@{#407598}
-
w.shackleton authored
I stopped UpdateDeviceList being called every time XISlaveSwitch events occur. BUG=609748 Review-Url: https://codereview.chromium.org/2077163003 Cr-Commit-Position: refs/heads/master@{#407597}
-
glebl authored
This changes WebFormControlElement::directionForFormData so it takes into account text-align: left|right while returning the text direction used in autofill dropdown component. BUG=482339 Review-Url: https://codereview.chromium.org/2161963003 Cr-Commit-Position: refs/heads/master@{#407596}
-
yzshen authored
Mojo C++ bindings: add a presubmit check to disallow adding new mojom targets with use_new_wrapper_types set to false. BUG=624136 Review-Url: https://codereview.chromium.org/2179113002 Cr-Commit-Position: refs/heads/master@{#407595}
-
jbudorick authored
Requires https://codereview.chromium.org/2144103002/ BUG=627939 Review-Url: https://codereview.chromium.org/2144823003 Cr-Commit-Position: refs/heads/master@{#407594}
-
krasin authored
https://chromium.googlesource.com/webm/libvpx.git/+log/4b073bc39a39..82070ae9393b $ git log 4b073bc39..82070ae93 --date=short --no-merges --format='%ad %ae %s' 2016-07-25 krasin Fix compilation error under Clang 4.0. 2016-07-22 jzern configure: test for -Wfloat-conversion 2016-07-23 jzern vp8/decodeframe: fix signed/unsigned comparison 2016-07-23 jzern vp9: fix frame-level threaded decode shutdown 2016-07-23 noreply vp8/postproc.c: disable clang-format for RGB_TO_YUV 2016-07-21 jimbankoski vp8:fix threading issues 2016-07-22 jzern vp8/postproc: fix implicit float conversion 2016-07-15 yuryg Add VPX_SWAP macro 2016-07-22 jzern blockiness_test: fix implicit float conversion 2016-07-22 aconverse Minor skip segment simplification. 2016-07-22 jzern resize_test: fix implicit float->int conversion 2016-07-22 marpan vp9 1pass-vbr: Adjust gf setting for nonzero-lag case. 2016-07-21 noreply vpx/: apply clang-format 2016-07-21 slavarnway VP9: get_pred_context_switchable_interp() -- encoder side 2016-07-11 paulwilkins Sample points to reduce encode overhead. 2016-06-10 paulwilkins Noise energy Experiment in first pass. R=johannkoenig@chromium.org BUG=631144 Review-Url: https://codereview.chromium.org/2178123002 Cr-Commit-Position: refs/heads/master@{#407593}
-
malaykeshav authored
BUG=611781 COMPONENT=Chrome OS, HaTS, Unittest Review-Url: https://codereview.chromium.org/2169223002 Cr-Commit-Position: refs/heads/master@{#407592}
-
vmpstr authored
This patch updates the code to prevent auto deducing to a raw pointer. R=chrisha@chromium.org BUG=554600 Review-Url: https://codereview.chromium.org/2171123002 Cr-Commit-Position: refs/heads/master@{#407591}
-
puthik authored
There is no reason to unset bluetooth_adapter_. If the adapter is not present, making calls to it will simply invoke the error callback. Just removing this should fix the crash. BUG=630069 TEST=build Review-Url: https://codereview.chromium.org/2172063002 Cr-Commit-Position: refs/heads/master@{#407590}
-
yuweih authored
Currently EglThreadContext only creates OpenGL ES 2 context. OpenGL ES 3 is backward compatible with ES 2 and has new interfaces (e.g. GL_PACK_ROW_LENGTH) that can improve the performance of the client OpenGL renderer. This CL makes EglThreadContext create OpenGL ES context of the highest version supported by the software or hardward of the device. BUG=385924 Review-Url: https://codereview.chromium.org/2175913002 Cr-Commit-Position: refs/heads/master@{#407589}
-
mpearson authored
Revert of Auto-rebaseline for r407494 (patchset #1 id:1 of https://codereview.chromium.org/2179893002/ ) Reason for revert: Caused webkit testing failures on Win 10 bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/12825 unexpected_failures: virtual/gpu-rasterization/fast/images/color-profile-reflection.html virtual/gpu-rasterization/fast/images/png-with-color-profile.html details: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win10/12825/layout-test-results/results.html If the bot tries to land the change again and again causes failures, the channel recommends changing the "NeedsRebaseline" entry in TestExpectations to "NeedsManualRebaseline". Original issue's description: > Auto-rebaseline for r407494 > > https://chromium.googlesource.com/chromium/src/+/9ff8991aa > > BUG=627844 > TBR=bsalomon@google.com > > Committed: https://crrev.com/b7a7ce4683ce455f1624cdd4b3a8bc6aff64d654 > Cr-Commit-Position: refs/heads/master@{#407527} TBR=bsalomon@google.com,blink-rebaseline-bot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=627844 Review-Url: https://codereview.chromium.org/2182653004 Cr-Commit-Position: refs/heads/master@{#407588}
-
puthik authored
Implement the following functionality - Request to read/write Gatt characteristic/descriptor. - Send response message back for the request read/write. - Send reply back that response message is sent. BUG=629210 TEST=manual test using step below 1. Create custom Gatt server in nrF connect app. 2. Connect minnie to ryu via chrome interface. 3. Ryu can correctly see minnie's Gatt server object. 4. Ryu can correctly read / write Gatt server object. Review-Url: https://codereview.chromium.org/2101283003 Cr-Commit-Position: refs/heads/master@{#407587}
-
lukasza authored
BUG=101395 Review-Url: https://codereview.chromium.org/2165133003 Cr-Commit-Position: refs/heads/master@{#407586}
-
qinmin authored
CancelOnFailureAndDeleteSelf() should be the last call DownloadTargetDeterminer can make. After that, it is deleted. Reporting the UMA first, then call CancelOnFailureAndDeleteSelf(). BUG=630370 Review-Url: https://codereview.chromium.org/2166163003 Cr-Commit-Position: refs/heads/master@{#407585}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/189c4816b033..139402a9056e $ git log 189c4816b..139402a90 --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2178113002 Cr-Commit-Position: refs/heads/master@{#407584}
-
stevenjb authored
Minor fixes to the networkingPrivate IDL. This produces a non-fatal but confusing error in the Settings UI. ManagedDOMString[] is invalid, ManagedDOMStringList should be used instead. (The managed property should be an objetc with each entry, e.g. 'Active', 'DevicePolicy', etc, as a separate array of strings, instead of an array of objects). BUG=none Review-Url: https://codereview.chromium.org/2182633002 Cr-Commit-Position: refs/heads/master@{#407583}
-
yangguo authored
Jinja2 and markupsafe will be pulled into v8/third_party/ via DEPS, while the protocol handler generator will be pulled into v8/platform/inspector_protocol/. In order for the protocol handler generator to work when building standalone V8, it needs to include them correctly. R=pfeldman@chromium.org BUG=580337 Review-Url: https://codereview.chromium.org/2174773002 Cr-Commit-Position: refs/heads/master@{#407582}
-
dschuyler authored
This CL adds (somewhat) dynamic padding to the end of the MD settings so that the last item may scroll to the top of the page when selected in the side nav menu. BUG=593989 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2090753002 Cr-Commit-Position: refs/heads/master@{#407581}
-
