- 02 Oct, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bbb8c722..f98bdc1d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib222e8f40034e5347ea74850a95b2dca3f349348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836392Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702236}
-
danakj authored
This splits apart the computation of each emulated field and makes more clear the intended outcome for desktop vs mobile cases. We remove the applied_widget_rect_ state, which can be computed from other inputs, and the scale_ state which is already stored in the emulation_params_. When the scale is not used, it used to store it as 0 and multiply the context menu coordinates by 0. Now we store a 1 when the scale is not used. R=avi@chromium.org TBR=caseq Bug: 1006052 Change-Id: I9c9aabca73d7d73f946e5889444004e00e181bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834080 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#702235}
-
Aaron Colwell authored
This fixes renderer kills caused by creating an iframe whose src is a blob URL created by an opaque origin. Bug: 1010120 Change-Id: I16b5f148522aa390d2d01c2e08353e834c6a48fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836533Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#702234}
-
Thanh Nguyen authored
1. Add |hits| to FuzzyTokenizedStringMatch. 2. Use FuzzyTokenizedStringMatch in AppSearchProvider under a new flag. Bug: 990684 Change-Id: I2da004456ca341d70f0d3398ec3e81095bebeb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833199 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702233}
-
Peter K. Lee authored
New assets from http://crbug/999939 with a slightly lighter grey background. Before: https://screenshot.googleplex.com/Y1AYLsWsZr0 After: https://screenshot.googleplex.com/H6W5xi65gMB Bug: 999939 Change-Id: I831f3bc6df5fc06316f05b097b64a45d9cae53aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835280 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702232}
-
Nick Burris authored
Create a new type of document marker for text fragments to avoid interfering with find-in-page usage of TextMatch markers. The TextFragment marker is a sub-type of the TextMatch marker, equivalent to an inactive text match marker. This also makes text fragments not get painted as tick marks on the scrollbar. Bug: 995381, 924970 Change-Id: I8c6169adfcd5deebc39a40171d61e70113b19bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814937Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#702231}
-
Adithya Srinivasan authored
Test fails flakily on all aura platforms. Bug: 1010675 Change-Id: Ic1906b0421dab41ddc14f36462aff459867afc33 Tbr: lfg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836007Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#702230}
-
Jüri Valdmann authored
CheckOpResult is used via CHECK macros in a number of constexpr functions, for example base::time_internal::SaturatedAdd. This is not legal C++, says GCC. Bug: 819294 Change-Id: Ic56a623af61a5c00daa8920136015cfa100ebe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827370Reviewed-by:
-
Peter Boström authored
This is replaced with views::GetHighlightPath() which is used by the other InkDrop and FocusRing. Bug: chromium:931964, chromium:1007546 Change-Id: Id34c89f3a81edffc72d4ff7460882ebbda346368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836372 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#702228}
-
Xianzhu Wang authored
This is a preparation of CompositeAfterPaint composited scrollbar implementation. Previously we create many display items for a scrollbar. This was unnecessary because we always invalidate all display items of a scrollbar (as a DisplayItemClient). Too many display items for one client also increases cost when searching for cached display items. As scrollbar's whole track (including track background, buttons and tickmarks) and thumb are still painted separately for cc painted scrollbars, we still need separate display items for them. Bug: 931486 Change-Id: I4a63797ba1e823810364689b975d065bba0841ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830401 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#702227}
-
Jeffrey Yasskin authored
This reverts commit 267f7f3a. Reason for revert: The new tests seem to be flaky. See crbug.com/1010658 for error messages. Original change's description: > [bfcache] Add tests for outstanding network requests > > It turns out that fetch() and XMLHttpRequests are now tracked > as network requests. > > This patch adds tests to verify this behaviour. > > This patch also slightly improves tracing for active feature > detection. > > R=kouhei@chromium.org,arthursonzogni@chromium.org > > Change-Id: I368f3b52ba8930269bef284f98bd1831944633f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825419 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701708} TBR=kouhei@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org BUG=1010658 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I62b5cb17c4afc5fac114c9b634d4696404f72e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836155Reviewed-by:
Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702226}
-
Moe Ahmadi authored
Deleting suggestions with Shift+Del (as opposed to right click and choosing delete from the dropdown menu) does not invoke Start() on the provider. Therefore, the list of autocomplete matches were not being updated. This fixes that bug by immediately deleting the match from the list of matches. Bug: 996516 Change-Id: If37a59d80b68a9f64a66140328a49549ef8ae53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832983 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702225}
-
Peter Boström authored
This replaces SetToolbarButtonHighlightPath and removes the OnBoundsChanged calls required to keep it up to date. Bug: chromium:1007546 Change-Id: I942ed7f0e8b9d748ad617af87d3241c1500d35b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836147 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#702224}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0a784e03b0f0..73fb657586a5 git log 0a784e03b0f0..73fb657586a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 saklein@chromium.org PackagesService: Add BuildsChrome endpoint. Created with: gclient setdep -r src/third_party/chromite@73fb657586a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1924dc7752bc6bfe08c63c49040660f126379ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702223}
-
Wez authored
TBR=alexmos Bug: 1010256, fuchsia:36774, b/140763277 Change-Id: I9fd94a2435a35c22945100e054caae6ab0e5052b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836434Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#702222}
-
Miyoung Shin authored
This CL converts XRSessionClient{Ptr, Request} in chrome and blink to the new Mojo type, and uses pending_receiver<XRSessionClient> in vr_service.mojom. Bug: 955171, 978694 Change-Id: Ia226a135173cd3e38c3b52a60beaae562ac63d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828760Reviewed-by:Kent Tamura <tkent@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#702221}
-
Trevor Perrier authored
This CL hides the Lite mode summary text on the settings menu when the data used history chart is not shown in the Lite mode settings. Currently both show when 100KB has been received regardless of how much data has been saved. Bug: 944977 Change-Id: Ic2f70deb770f120adf12070ae2c00d69e6822d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835176Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#702220}
-
Tommy Li authored
No one is looking at these anymore. They expired once already in June, but got extended. Bug: 969931 Change-Id: I345ad00364f5cd39b8b228e6a43419a880d7ab5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829491 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#702219}
-
Sanket Joshi authored
The up-down arrow is currently slight off vertical center. This CL fixes that and updates all affected test baselines. Bug: 1010330 Change-Id: Id1965a6243046816207bf521e25bb06413e6c77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832720Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Patrick Noland authored
In the linked bug, retaining the site instance causes he whole entry to be discarded and replaced when returning. This prevents the stored scroll state from being restored properly. Resetting the SiteInstance means the existing entry can be reused for future visits, preserving the state. Bug: 992198 Change-Id: Ib0f3e2b4f259846f02ee3e5e78c7341d2b98e148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825791 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6c43f42ce94be9551b741855cfe8ef3bad6bd5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835220Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#702216}
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: I488fc6578141f596979a4729afe02e9cdbe97786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833904Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#702215}
-
John Chen authored
Enable ChromeDriver tests on Win10 bot, as win7-rel bot is no longer included by default in Chromium CQ. Change-Id: Ie8d42abe069ccbcd4313d5067a2c474913c36204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835068Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702214}
-
Travis Skare authored
QR Code generation itself is being added as a mojo service in a follow-on change. Launch with a feature flag: chrome --enable-features=SharingQRCodeGenerator Bug: 993908 Change-Id: Iba2772227ec2d494524e90e45bd0e4726047f66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769685 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#702213}
-
Brian Norris authored
They should also use the cros-network-metrics group. Bug: chromium:975070, chromium:975825 Test: validate_format.py, pretty_print.py, presubmits Change-Id: Id2afb8fed98206268d93a7f2d1f10a379badcf21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834654Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Norris <briannorris@chromium.org> Cr-Commit-Position: refs/heads/master@{#702212}
-
Chris Lu authored
Made a mistake in the final patchset of crrev.com/c/1832157. Modified a unittest to cover this mistake. Bug: 976901 Change-Id: I21b06444ca31ba174d217051266c8edaba97aca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835097 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Alison Maher authored
Forced colors is currently being sent to the render process over two pipelines. This change cleans up the repeated code to use the new pipeline introduced in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1728056 Similar to how system colors are accessed in https://chromium-review.googlesource.com/c/chromium/src/+/1793742, ForcedColors have been removed from WebPreferences/WebSettings and can now accessed through WebThemeEngine. A similar change for PreferredColorScheme will follow. Bug: 970285 Change-Id: Id552d8f77c1fe01027b76f0bae5adeae972aaf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802392 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chrome://sandboxAlex Gough authored
This collects all chrome://sandbox webui plumbing files into a single subdirectory. No functional changes. Bug: 997273 Change-Id: Idf78f2423d96986e487fa2a383e5af3dce7b74c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835679 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#702209}
-
Matt Mueller authored
Bug: 1008994 Change-Id: I10a52af910605852786ffcf888276764d6660c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835158Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702208}
-
John Lee authored
When the webview for the tab strip first loads, it thinks it's visible even when the container View for it is hidden. Forcing its WebContents to be hidden allows `document.hidden`, `document.visibilityState` and `visibilitychange` events on the document to all be correct even at load. Bug: 1005554 Change-Id: I5926b03bf86218574b6e644e2710efe8f475efbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834425 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702207}
-
Sergey Ulanov authored
This will make it easier to test CDM support as it'll be possible to play protected video in Shaka player in WebRunner. Change-Id: Ib1ef1b41b21cfbb837e0babdefaa0281458abcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836379 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Arthur Hemery authored
Mistake about junit tests. Since we do not work with any native code and do pure java, we do not need to run these. Bug: 976218 Change-Id: I7bc24b2ddadf8ff3ffc9d740d556e9725054c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835620Reviewed-by:
-
Eric Karl authored
PooledSharedImageVideoProvider::GpuHelperImpl currently registers a stub destruction observer in its constructor. It does not remove this observer in its destructor, which can lead to a crash when CommandBufferStub attempts to notify it of destruction. I was going to unregister in destruction, but then noticed that this observer isn't needed: - CommandBufferHelper already registers its own observer internally - GpuHelperImpl just used this notification to clear |command_buffer_helper_|, which is already taken care of internally in that class. So instead this CL just removes the observer from GpuHelperImpl. Bug: 1010612 Change-Id: I47d1982d6ccaf8624650a4274e8cb1500aba4f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835168Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702204}
-
Ahmed Mehfooz authored
With this change each notification that is in the message center but not visible will have an icon representing it in the stacking bar. The icons are removed as we scroll up through the message center. If there is not enough space to show all icons there will be a "+ x" appended after the icons to signify remaining notifications. Bug: 1002714 Change-Id: I2e7737a4cf0dd145e0868e7fbf11a15be897d51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803731 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702203}
-
Tommy Li authored
We're proceeding with a button-based remove interface instead of the context menu. We may add this back later for some other reason, but we don't need it currently, so this CL rips it out. Bug: 1205, 929477 Change-Id: I87a6b9b283e6d16656fe263c5271f51192d74adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834895Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#702202}
-
Xianzhu Wang authored
- Remove unused cc/layers/scrollbar_theme_painter.h - Add comments in cc::Scrollbar - Remove rect parameter from cc::Scrollbar::PaintPart() because the rect can be easily calculated by blink, given that the coordinate space of the canvas is clearly defined - Improve performance of blink::ScrollbarLayerDelegate::HasTickMarks (implementation of cc::Scrollbar::HasTickMarks()). The old implementation queried all tick marks and see if it was empty, which may be slow when there are a lot of tick marks (e.g. when searching in a huge document). - Add blink::ScrollbarTheme::PaintTrackAndButtonsForCompositor() to avoid exposing too much details of ScrollbarTheme to outside. This is a preparation for CompositeAfterPaint composited scrollbar implementation. Change-Id: Ibf8c7a90d80ddf972f215495d0fd89470fa2deb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834286Reviewed-by:
-
Jamie Madill authored
This will unblock supporting a build variant in ANGLE where we don't have Chromium supporting folders. This will enable us to port to the Skia standalone build. Bug: angleproject:3943 Change-Id: Ieb88f18b34d330458071c047f03a1c1d420b3d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834909Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#702200}
-
Toby Huang authored
For supervised users, if an extension is disabled due to requiring additional permissions, remove the code that sends a remote approval request to the custodian. The supervised user should be able to re-enable the extension themselves once local as opposed to remote parental approval is enabled. Bug: 1004851 Change-Id: I4fbb463332c50a354afde6d801f8e8f6a4445817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825173Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702199}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6b4c2a88f36e..6154fb127e5c git log 6b4c2a88f36e..6154fb127e5c --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6154fb127e5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Id6e6eb6c352f2b6f9eedfe569fc05d6eda7897c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836352Reviewed-by:
-
Theresa Wellington authored
- ClipDrawableProgressBar - ContextMenuDialog - MaterialProgressBar - PaddedFrameLayout - PromoDialog - PromoDialogLayout - PromoDialogTest - RadioButtonLayout - RadioButtonLayoutTest - RadioButtonWithDescription - DragReorderableListAdapter - DragStateDelegate - ViewResourceFrameLayout BUG=951455 Change-Id: Ic5232c262edae50150ff0f3160a65ed8bd00e1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829676Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#702197}
-
