GitLab

Some autofill browser_tests on linux_chromeos are failing:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/11359

> [autofill] Hook the sign-in button up to required actions.
> 
> - Actually use the info we're getting from wallet to tell whether a user needs
>   to authenticate further (in this case only in a non-passive way).
> 
> - Add a DialogSignedInState to autofill_dialog_types.h.
> 
> - Add a DialogSignedInState SignedInState() to AutofillDialogController interface
>   and implements AutofillDialogControllerImpl.
> 
> - Adds a UpdateAccountChooser() to AutofillDialogView and implements in
>   AutofillDialogViews.
> 
> - Use SignedInState() from AutofillDialogViews.
> 
> BUG=157270,163508,171528
> R=isherman@chromium.org,sky@chromium.org
> 
> Review URL: https://chromiumcodereview.appspot.com/12094069

TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/12091104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180111 0039d316-1c4b-4281-b951-d872f2087c98

Revert 180103 - Only permit plug-in loads in the browser if the plug-in isn't blocked or the
user has authorized it with a browser-mediated interaction.

BUG=172573
Review URL: https://codereview.chromium.org/12086077

TBR=cevans@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12114045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180110 0039d316-1c4b-4281-b951-d872f2087c98

Links to first failures after my CL: https://src.chromium.org/viewvc/chrome?view=rev&revision=180067
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/20475
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/builds/24259

I'm planning to suppress the errors in an impending CL.

BUG=173597
TEST=No unsuppressed RenderTextLinux leaks.
TBR=asvitkine@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/12153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180106 0039d316-1c4b-4281-b951-d872f2087c98

> PPAPI: Fix WebSocket Var ref leak receiving binary
> 
> BUG=173503
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12096099

This seems to have broken WebSocket tests on the mac bots
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/35419
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/7829

TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/12096107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180105 0039d316-1c4b-4281-b951-d872f2087c98

user has authorized it with a browser-mediated interaction.

BUG=172573
Review URL: https://codereview.chromium.org/12086077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180103 0039d316-1c4b-4281-b951-d872f2087c98

Reverts a buffer size increase added in http://crrev.com/168111
and hacks added in http://crrev.com/169553

BUG=161307
TEST=Flash, HTML5 playback smoothly -- even in the background.

Review URL: https://chromiumcodereview.appspot.com/12155003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180102 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166584

Review URL: https://chromiumcodereview.appspot.com/12151002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180101 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180100 0039d316-1c4b-4281-b951-d872f2087c98

Bubbling isn't enabled in <webview> currently. There's no reason why it's
not and this is even more useful once we support window.open and the Permission
API.

BUG=140316


Review URL: https://chromiumcodereview.appspot.com/12146002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180099 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173019
TST=visual


Review URL: https://chromiumcodereview.appspot.com/12143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/12139002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180097 0039d316-1c4b-4281-b951-d872f2087c98

Words will be broken and wrapped if they don't fit horizontally
and ellipsis added if 2 lines are not enough.

BUG=170625


Review URL: https://chromiumcodereview.appspot.com/12131002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180096 0039d316-1c4b-4281-b951-d872f2087c98

Some of these are trivial; some others will potentially require more thinking for the feature to be right (e.g., we might want "Continue where I left off" to be per-desktop, etc.), but at least they now work (i.e., do something) on multi-desktop environments.

Clear candidates for separate desktop-specific iteration were left out in this CL as well as non-trivial swaps which I'll put in their own CL.

This CL is making progress towards getting rid of BrowserList::const_iterator (non-multi-desktop aware) and removes BrowserList::iterator which was already no longer used.

BUG=129187, 170753

Review URL: https://chromiumcodereview.appspot.com/12114034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180095 0039d316-1c4b-4281-b951-d872f2087c98

As chrome on android starts to use deferred image decoding, images decoding may not be captured by InspectorTimelineAgent.
In such case, we cannot rely on telemetry to get the decoding time.
Disable this test for now while we working on a fix.
Since this test is android only, just disable it

BUG=173184


Review URL: https://chromiumcodereview.appspot.com/12100007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173503


Review URL: https://chromiumcodereview.appspot.com/12096099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180093 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
CC=tomhudson,vmpstr
BUG=173426

Review URL: https://chromiumcodereview.appspot.com/12096098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180092 0039d316-1c4b-4281-b951-d872f2087c98

This was added for CrOS support for touch event tracking, currently causes
us to misinterpret the acks we are receiving.

BUG=168350
NOTRY=True

Review URL: https://codereview.chromium.org/12114040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180091 0039d316-1c4b-4281-b951-d872f2087c98

Pass custom color to BubbleBorder ctor (or SK_ColorWHITE default).
Call BubbleFrameView::SetBubbleBorder instead and remove border ctor arg.
Misc refactoring and cleanup.

TODO(followup): Update bubbles to use BubbleDelegateView where possible.
TODO(followup): Use theme colors for misc borders instead of SK_ColorWHITE.

BUG=166075
TEST=No observable changes.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12096084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180090 0039d316-1c4b-4281-b951-d872f2087c98

Previously, scroll offset was based on screen pixels, but now
is based on screen density independent pixels.  This converts
the top controls manager to deal in DIP instead of PX.

BUG=161303


Review URL: https://chromiumcodereview.appspot.com/12095071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180089 0039d316-1c4b-4281-b951-d872f2087c98

The Chrome OS builds already use -fstack-protector-strong. Adding
additional -fstack-protector arguments means that the last one seen on the
commandline is used. This has caused a regression in the stack-protector
features, so avoid stack-protector on Chrome OS.

BUG=chromium-os:38354
TEST=link build


Review URL: https://chromiumcodereview.appspot.com/12095046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163760,169151


Review URL: https://chromiumcodereview.appspot.com/12082081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180087 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds webstore as a new source for Chrome signin. It also grabs password as soon as password form is submitted rather than at the end of navigation. The reason is webstore runs in its own context, redirect from gaia to webstore results in context swap during which password data is discarded, thus password must be sent to the oneclick signin helper before redirect occurs.

PM mock at https://docs.google.com/a/google.com/presentation/d/1zCvdhBXKL8RDQwuRauSZdgCbiRexJRZ564z9Uw0wS6U/edit?disco=AAAAAFg3OEI#slide=id.g996e03e1_00. This CL implements the transition from slide 7 to 8.

BUG=173433

Review URL: https://codereview.chromium.org/12086069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180086 0039d316-1c4b-4281-b951-d872f2087c98

When impl painting is enabled, we always did a full tree sync from
the main thread to the pending tree because it was always recreated.
Since we recycle the tree now, it maintains its structure from one
commit to the next, so we don't need to do a full tree sync unless
its structure changed, the same decision as for non-impl-painting
mode.

On the impl side, the pending tree maintains the same structure as the
active tree unless the main thread commits a structure change. This is
the case when the main thread does a full tree sync into the pending
tree. So we propagate the flag to the LayerTreeHostImpl and use it when
activating the pending tree.

Causing a commit every layout() with the 10_10_layer_tree, the win is clear:
Before: *RESULT 10_10_layer_tree: frames= 2657.12 runs/s
After: *RESULT 10_10_layer_tree: frames= 3256.78 runs/s

R=jamesr,enne
BUG=173526


Review URL: https://chromiumcodereview.appspot.com/12094094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180085 0039d316-1c4b-4281-b951-d872f2087c98

BUG=171863
TEST=unit_tests.exe
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/12094073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180084 0039d316-1c4b-4281-b951-d872f2087c98

- Actually use the info we're getting from wallet to tell whether a user needs
  to authenticate further (in this case only in a non-passive way).

- Add a DialogSignedInState to autofill_dialog_types.h.

- Add a DialogSignedInState SignedInState() to AutofillDialogController interface
  and implements AutofillDialogControllerImpl.

- Adds a UpdateAccountChooser() to AutofillDialogView and implements in
  AutofillDialogViews.

- Use SignedInState() from AutofillDialogViews.

BUG=157270,163508,171528
R=isherman@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12094069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180083 0039d316-1c4b-4281-b951-d872f2087c98

First pass on tool to bisect across range of revisions to help narrow down where a regression in a performance metric occurred. The tool will also attempt to track down regressions caused by WebKit, Skia, and V8 by bisecting those depots as well. At the moment, the tool only works on linux based machines using the git workflow.

An example usage:

./tools/bisect-perf-regression.py -c\
"out/Release/performance_ui_tests --gtest_filter=ShutdownTest.SimpleUserQuit"\
-g 1f6e6786\
-b b732f23b4f81c382db0b23b9035f3dadc7d925bb\
-m shutdown/simple-user-quit

BUG=


Review URL: https://chromiumcodereview.appspot.com/12092033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180082 0039d316-1c4b-4281-b951-d872f2087c98

> [Sync] Add timestamp to TrafficRecorder records
> 
> All client server traffic records have a timestamp field to
> indicate creation time of each record. Timestamps are
> dumped with the traffic serializations.
> 
> BUG=161922
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12088080

This broke the compile for Linux Builder (dbg)
http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/42048/steps/compile/logs/stdio

TBR=mgist@chromium.org
Review URL: https://codereview.chromium.org/12090113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180081 0039d316-1c4b-4281-b951-d872f2087c98

 * Change the LauncherDelegate::ItemClicked's argument from
   int flag to const ui::Event&
 * temporarily set the view's event target to RV. Sadrul
   is working on real solution in crbug.com/173235.

I tried to add interactive_ui_tests for chrome, but turns
out it's require more work as there is no interactive ui tests for
extensions. I'd rather refactor launcher code so that we can test
the same behavior in ash_unittests. I'll work on it and add more tests
once @skuhne finished new launcher (could be 26 or 27)

BUG=166195
TEST=covered by tests. Also tested on device (clicking panel icon on other display should move the panel to that display)

Review URL: https://chromiumcodereview.appspot.com/12093075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180080 0039d316-1c4b-4281-b951-d872f2087c98

It appears that the native event is synthesized correctly now, so reenable this code path and tests.

R=ben@chromium.org
BUG=112222


Review URL: https://chromiumcodereview.appspot.com/12092051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180079 0039d316-1c4b-4281-b951-d872f2087c98

MMX intrinsics aren't supported on x64 until MSVC 2012.

BUG=166496
TBR=scottmg

Review URL: https://chromiumcodereview.appspot.com/12088098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180078 0039d316-1c4b-4281-b951-d872f2087c98

scan the entire public class hierarchy for ref-counting
problems. This is to detect situations where a RefCounted type
implements some Delegate-type class and the Delegate may be
directly deleted, even if the RefCounted type may not be.

Also removed unused flag -skip-refcounted-dtors while here

BUG=123295
TEST=tools/clang/plugins/tests/test.sh

Review URL: https://chromiumcodereview.appspot.com/10407057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180077 0039d316-1c4b-4281-b951-d872f2087c98

Looks like this wasn't deleted when the mac webintents UI went
away in r173274.

BUG=173194

Review URL: https://codereview.chromium.org/12094096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=166447


Review URL: https://chromiumcodereview.appspot.com/12090098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180075 0039d316-1c4b-4281-b951-d872f2087c98

When the new enable_user_alternate_protocol_ports flag is present
then Alternate-Protocol requests to user controlled ports (>1024)
from restricted ports (<1024) will be honored.

Review URL: https://chromiumcodereview.appspot.com/12089060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180074 0039d316-1c4b-4281-b951-d872f2087c98

All client server traffic records have a timestamp field to
indicate creation time of each record. Timestamps are
dumped with the traffic serializations.

BUG=161922


Review URL: https://chromiumcodereview.appspot.com/12088080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180073 0039d316-1c4b-4281-b951-d872f2087c98

Not used.  If we do enable browser side mixing in the future it'll
be based on AudioConverter.  With renderer side mixing and
AudioOutputProxy, there's not a pressing need for this function.

BUG=none
TEST=compile


Review URL: https://chromiumcodereview.appspot.com/12082111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180072 0039d316-1c4b-4281-b951-d872f2087c98

Move tracing code in content\browser to content\browser\tracing now that there's a separate directory.

BUG=169170
Review URL: https://codereview.chromium.org/12149003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162530
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12088096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159265
TEST=browser_tests --gtest_filter=GetAuthTokenFunctionTest.*
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11882025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180069 0039d316-1c4b-4281-b951-d872f2087c98

As discussed, this creates a media::AudioHardwareConfig class lazily created,
owned, and filled by RenderThreadImpl via a single synchronous IPC and updated
via AudioMessageFilter.

This change does not plumb part 2 where AudioRendererMixer recreates itself based
on these device change updates.

BUG=157216
TEST=New unittest. Device changes on Windows/Mac continue to work.

Review URL: https://chromiumcodereview.appspot.com/11880009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180068 0039d316-1c4b-4281-b951-d872f2087c98