GitLab

This cl de-couples fling boosting logic from input handler proxy.
The FlingBooster class will be used for browserside fling boosting.

The boosting logic remains unchanged for the most part. The only change
is handling a gesture_scroll_begin while fling cancellation is deferred:
The code used to filter the GSB only when its target node is the same as
the node that is currently scrolling and cancel the deferred fling
otherwise. With this cl a GSB will always get filtered when a fling
cancellation is deferred.

This change is necessary for using boosting logic in the browser and is
more similar to mac where wheel events with momentum phase are recieved
after a swipe.

The following tests from InputHandlerProxyTest are related to fling
boosting and they all pass after applying this cl:
FlingBoost, NoFlingBoostIfScrollDelayed, NoFlingBoostIfNotAnimated
NoFlingBoostIfFlingInDifferentDirection,
NoFlingBoostIfScrollInDifferentDirection,
FlingBoostTerminatedDuringScrollSequence


Bug: 249063
Change-Id: I873e91c1de386c3e253e0744c682b0fc3a7456ae
Reviewed-on: https://chromium-review.googlesource.com/744901Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516372}

Currently, RenderWidgetHostImpl::SubmitCompositorFrame synchronously
inspects the frame token in the CompositorFrame and matches it up with
the frame token of the FrameSwapMessages. Once the frame token in the
CompositorFrame catches up with the frame swap messages, then we start
handling the IPCs. However, this architecture cannot work with an
out-of-process display compositor. In this patch, I check the validation
of frame token in Viz/Service/CompositorFrameSinkSupport and use it
to call RenderWidgetHostImpl to handle the IPCs.

Bug: 771331
Change-Id: I40fe5d0a4bba05e0bc635199c5fe03e5fe641c23
Reviewed-on: https://chromium-review.googlesource.com/748771
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516371}

download_nacl_toolchains.py became flaky after switching to vpython
and causing build breakages. Switch it back to python.

TBR=dpranke@chromium.org

Bug: 784251
Change-Id: I449bb25ff83254edabed249df0564cd0de3c8ec1
No-Try: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/769327Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516370}

Bug: 726520
Change-Id: I41220f1ff9ebd0f9bee8546eff4cb721a3aba732
Reviewed-on: https://chromium-review.googlesource.com/766907Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516369}

Now use_case, rail_mode and expensive_task_policy are easier to read.

Bug: 784438
Change-Id: Ie07aaa06c3ad7c6dd7c37cc097d087e26050a34b
Reviewed-on: https://chromium-review.googlesource.com/768809
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516368}

History page override example that uses the History API with
vanilla JavaScript and CSS.
Still has basic history page functions, but now organizes history in Google
colored blocks.
Can search through previous week history by key words and delete single entry
or delete in bulk.

Bug: 41212
Change-Id: Ib2e7c9e7465c08be856991899abeeaef77eceb22
Reviewed-on: https://chromium-review.googlesource.com/731660Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516367}

Moved URL variables closer to the usage place.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I37e86cb69a3eb33e4be0a93551146490adb6acb7
Reviewed-on: https://chromium-review.googlesource.com/757825Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516366}

Add MediaStoppedReason as an argument to MediaStoppedPlaying on
WebContentsObserver. This will contain information as to
whether the media was stopped because it reached the end.
It is needed for Media Engagement.

BUG=781726

Change-Id: I84eee732269cb6859d42ac5a5d34185bbd1d6e2d
Reviewed-on: https://chromium-review.googlesource.com/758583
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516365}

download.py became flaky after switching to vpython
and causing build breakages. Switch it back to
python.

TBR=dpranke@chromium.org

Bug: 784243
Change-Id: Ie0ca441bc0c9485c4052251a8e4c757697cbc7e7
No-Try: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/769230
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516364}

Bug: 780378
Change-Id: Iaa3c4760231696205d08b9558aa62f476ab57ce2
Reviewed-on: https://chromium-review.googlesource.com/768774Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516363}

This patch removes a few obsolete options from the grit tool,
that were not even documented through -h:

  -d and -c <client>, which were allegedly used to handle
   communication with Perforce in the past, and no longer
   needed (or used by the code).

  --psyco, since this project is now dead and unmaintained
   and the flag was never used by the Chromium build.

  '-g <param>' and '-q' are no longer accepted and ignored.

'grit unit' was invoked to run the unit-test suite
and was succesful on Linux.

BUG=None
R=thakis@chromium.org,joi@chromium.org

Change-Id: I97de9a7d3b32bdbe0a050df7719635ddec0cb663
Reviewed-on: https://chromium-review.googlesource.com/631938
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516362}

Bug: 782083, 782080, 775334, 755429, 753204
Bug: 753200, 745187, 719792, 689320, 656857
Bug: 784721
Change-Id: I5e1c231d1a286891d61349454b1dc6c13cfda295
Reviewed-on: https://chromium-review.googlesource.com/766955
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516361}

https://pdfium.googlesource.com/pdfium.git/+log/f2d490650cef..ccf206a7731e

$ git log f2d490650..ccf206a77 --date=short --no-merges --format='%ad %ae %s'
2017-11-14 rharrison Move CXFA_FileRead out of XFA and rename

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I71a298ef96d7c3260c2e6dd7889556ac58d74af8
Reviewed-on: https://chromium-review.googlesource.com/768619
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516360}

This switches MusDemoExternal implementation to make use of
newly added WindowTreeClient::ConnectViaWindowTreeHostFactory API.

It allows us to remove some class parameters of WindowTreeDataExternal

BUG=666958

Change-Id: I12cb8e63d5bcd0c9484811b7cb09e0e546f866cb
Reviewed-on: https://chromium-review.googlesource.com/768987Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#516359}

NotificationDisplayService.

Bug: 783018
Change-Id: I8fbf77513867bf091aafc0404128fe230f07eebf
Reviewed-on: https://chromium-review.googlesource.com/759680Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516358}

After removing web/, SpellCheckerClient is just an extra indirection
layer to talk from core/ to core/ through WebViewImpl.
This patch replaces it with a single page-wide SpellCheckState field.

We can make a page supplement to avoid even mentioning spell checking
in Page, but that's probably too much trouble for little benefit.

Bug: none
Change-Id: Ia8778941ce066a17a5a4fe8e34cd69971053d407
Reviewed-on: https://chromium-review.googlesource.com/764977
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516357}

BUG=784849

TBR=zmo@chromium.org
NOTRY=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic6316db156c1b68daf84ec804094a510ed6bab46
Reviewed-on: https://chromium-review.googlesource.com/769227
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516356}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9b3020fa..414f4942

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I6670f473846ecc871e442a66ce43e0bd3e4af9ae
Reviewed-on: https://chromium-review.googlesource.com/768212Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516355}

Bug: 642281
Change-Id: Ie61b86046e7691bc049a36a5ed2a5d46392919fc
Reviewed-on: https://chromium-review.googlesource.com/767017Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Albert Bodenhamer <abodenha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516354}

This is a follow up of crrev.com/c/735324.

Bug: 784868
Change-Id: I9ca1cb3d892a74bd08b36b8883f4b30eefd6b7e5
Reviewed-on: https://chromium-review.googlesource.com/768690
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516353}

These tests were all passing according to:
http://wince.sfo.corp.google.com:8766/rls

This test was recently rebaselined in
https://chromium-review.googlesource.com/c/chromium/src/+/742238
but was missing a windows expectation:
invalidation-rect-includes-newline-for-vertical-lr.html

These tests match the non-RLS expectations except they have additional
Scrolling Layer and Scrolling Contents Layers:
paint/invalidation/selection-clear-after-move.html
paint/invalidation/compositing/should-not-repaint-move-backface-hidden.html

Bug: 781419

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: Ic70afc049f2095b92b5cf8179736dc552d06534b
Reviewed-on: https://chromium-review.googlesource.com/765015
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516352}

Scrolling with trackpad on Chrome devices generates GFC when the user
touches the touchpad and GFS when the user lifts their fingers even when
fling velocity is zero. This cl uses these events for scroll latching
instead of the timer. Scrolling with a real mouse wheel is unchanged.

       TouchpadFlingStartResetsWheelPhaseState

Bug: 526463
Test: RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest.
Change-Id: Ie3bb30c57fc8fd50f543d2856e570e401f5a2caf
Reviewed-on: https://chromium-review.googlesource.com/757577
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516351}

Bug: 767356
Change-Id: I2f8df4e507c4de83ac4c5166870cf673d1bd8465
Reviewed-on: https://chromium-review.googlesource.com/755376
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516350}

TBR: alexclarke
Bug: 784909
Change-Id: I2439160310386e88d2b91555bb605e5b8329f1c6
Reviewed-on: https://chromium-review.googlesource.com/768850Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516349}

* Do not trim trailing whitespace from MIME parameter names.
* Do not trim leading whitespace from MIME parameter values.
* Except keep trimming leading whitespace from "charset" value.

Bug: 772834
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie7f5bc493ea0c8fece9a6a8159b27c85bb58ac2b
Reviewed-on: https://chromium-review.googlesource.com/763667Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516348}

There were two bugs:
1. The next or previous on line might be an anonymous block object that is ignored in the accessibility tree.
Fixed by assigning the same next and previous on line object to any child, if the child doesn't have its own next or previous on line object.
2. The object returned by next on line is not the same as the one returned from previous on line on the other object and vice versa.
Fixed by always descending and returning a leaf object for next and previous on line.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 646785
Change-Id: Ibe6f1fd6b682b9b7345af22f9cbd3ca66f9db801
Tested: Gmail compose window with a link, NVDA and Jaws with an anonymous block created by background-color: red, layout tests
Reviewed-on: https://chromium-review.googlesource.com/766908Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516347}

This bad cast error was already being suppressed on Linux because it
occurred in a reinterpret_cast_ptr (which became a reinterpret_cast
via a macro) in Vector.h, and was therefore being suppressed by a
blacklist entry for Vector.h. But on ARM32, reinterpret_cast_ptr is not
a macro but rather a function in StdLibExtras.h that wraps a
reinterpret_cast, and therefore was not covered by the blacklist entry.

Fix the bad cast error by introducing a function named
unsafe_reinterpret_cast_ptr which is meant to be used to CFI-unsafely
cast between pointer types, and start using it in Vector.h. We
should now no longer need to blacklist Vector.h (the last attempt
to remove it from the blacklist was reverted due to a test failure
in HeapTest.VectorDestructorsWithVtable, which is exactly the test
that this change fixes on ARM32).

Bug: 469376
Change-Id: I83906d8f5fbd19069f82bfc18f608d9a1532b3be
Reviewed-on: https://chromium-review.googlesource.com/768268Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516346}

Bug: 781413
Change-Id: I6560282e0d0e228da9a1bb48f04977408d7635a0
Reviewed-on: https://chromium-review.googlesource.com/767292Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516345}

Changes the callback return value of the API to be a pointer to
the profile instead of being the validity state of the profile.

The concept of a validity state for the whole profile was removed since
validity depends on the context (Autofill != Payment Request).

Using a pointer to the validated profile is more useful for the called,
which can now start the validation of all profiles at the same time and
handle the result from the callback.

Another modification was to put all of the validation utils in the same
file.

Also make the validator keep a weakptr to an AutofillProfile in case
it gets deleted while loading the rules.

Bug: 
Change-Id: I9d41a0cea577351d8a1618bc9f771af1524e38c6
Reviewed-on: https://chromium-review.googlesource.com/709779
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516344}

Makes failures due to a timeout waiting for a JavaScript step
also print out testharness.js's result string. This is because tests
with multiple steps could fail at an earlier step, but end up reporting
the failure as a timeout in a later step.

Bug: 
Change-Id: Ic4f8ab96b9bf6f404414431a5ee4141761829e0f
Reviewed-on: https://chromium-review.googlesource.com/767616Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516343}

This reverts commit bf228a61.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reuse kArcIntentHelperPackageName in c/b/
> 
> Reusing kArcIntentHelperPackageName where needed. Also adding a method
> to reuse such package name + a custom string appended to it, this is
> AppendStringToIntentHelperPackageName.
> 
> Bug: None
> Test: Build.
> Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3
> Reviewed-on: https://chromium-review.googlesource.com/764396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Commit-Queue: David Jacobo <djacobo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516326}

TBR=yusukes@chromium.org,sky@chromium.org,djacobo@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None

Revert because it is breaking the build https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/79362

Change-Id: I2cd3a0c2b526d542242e14eeb9ed363b784f7795
Reviewed-on: https://chromium-review.googlesource.com/769047Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516342}

This reverts commit bf228a61.

Reason for revert: Didn't compile properly on CrOS (which we missed due to a bad CQ configuration).

Original change's description:
> Reuse kArcIntentHelperPackageName in c/b/
> 
> Reusing kArcIntentHelperPackageName where needed. Also adding a method
> to reuse such package name + a custom string appended to it, this is
> AppendStringToIntentHelperPackageName.
> 
> Bug: None
> Test: Build.
> Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3
> Reviewed-on: https://chromium-review.googlesource.com/764396
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Commit-Queue: David Jacobo <djacobo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516326}

TBR=yusukes@chromium.org,sky@chromium.org,djacobo@chromium.org

Change-Id: Idfef3e2b248c5a1339bb97c47be0f3a6cdf84ba3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/769187Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516341}

Tool is no longer used.

Bug: 632021
Change-Id: Ib3fc75c0fdfa0d60ae9187e3009572ba694a7f3c
Reviewed-on: https://chromium-review.googlesource.com/768733Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516340}

This CL adds a test with a frame having a child iframe that renders an
image. the parent should only get a first-paint entry even after the
child has rendered the image.

An upstream spec issue had been filed to clarify:
https://github.com/w3c/paint-timing/issues/22

Bug: 736114
Change-Id: Idc0910a7acc8f8af3bf9634a7e6827805fe8d370
Reviewed-on: https://chromium-review.googlesource.com/766393
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516339}

According to the flakiness dashboard, layout test virtual/gpu/fast/canvas/
canvas-imageSmoothingQuality.html is now passing on Linux and Win, but still
failing on Mac trybots:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-imageSmoothingQuality.html

This CL updates the fail tag to reflect this behavior.

Bug: 693568
Change-Id: Ibd2974c9c02706d0ad5d6b0c342e2dc1112ead34
TBR: junov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/768948Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516338}

Bug: 721395
Change-Id: I06b833910c11c345b0995c0ff3f7de5f64c56b82
Reviewed-on: https://chromium-review.googlesource.com/760037Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516337}

Add a new vector to keep track of all newly inserted events.  This
vector is processed once in the audio thread to clamp the start time
of the event if needed.  Once processed, this vector is cleared.

Previously, the clamp check would process the entire event list to see
if any event needed to be clamped.  Most of the time, this is wasted
because there are no events to be clamped because they're all in the
future or because they've already been clamped.

Also removed unneeded member functions and variables.

Bug: 780125
Test: 
Change-Id: I73b871d8fa87a68e482cb98d48af33e05d1f0cfb
Reviewed-on: https://chromium-review.googlesource.com/747071Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516336}

The SignedInAccounts modal has a button to show the
Settings screen, in which case the modal should be
dismissed before presenting the Settings screen.

This CL makes presentation happen inside the completion
block of the dismissal. Otherwise, the presentation
will fail because |self.presentingViewController| is
still busy presenting another screen. Also,
|self.presentingViewController| must be set to another
variable to be used for presentation, otherwise, it will
be nil after dismissal.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia67e19816a4010a630f9679bae709b4f7307a3be
Reviewed-on: https://chromium-review.googlesource.com/767587Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516335}

If no fieldset element is found the first time
UpdateAncestorDisabledState is run, future traversals to search for
fieldset elements are skipped.

This reduces time spent in HTMLInputElement::InsertedInto and
HTMLInputElement::RemovedFrom by about 3% each.

Bug: 
Change-Id: Id70b60f4d815dd2fa2067ea2971e57f6d9bb2922
Reviewed-on: https://chromium-review.googlesource.com/739182Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516334}

This change makes worker use results of GetLocalChanges when preparing commit
contribution. EnqueueForCommit is not used and therefore removed.

With this change the expectation is that ModelTypeWorker::entities_ only
accumulate entities in two scenarios:
- Between calls to ProcessGetUpdatesResponse and ApplyUpdates remote updates are
  accumulated
- Between calls to GetContribution and OnCommit response local changes are
  maintained

Encryption is still done at ModelTypeWorker. There are a couple of important
scenarios related to encryption:
- After processor nudges worker about local changes worker should remember about
  that nudge in case cryptographer is not ready. When cryptographer becomes
  ready worker should nudge a NudgeHandler, processor is not going to reissue
  the nudge.
- When worker receives corrupt encrypted update it should skip the update and
  continue with the rest of entities in the batch. It shouldn't block datatype.

Another important scenario concerns commit failures. When commit fails on the
server NonBlockingTypeCommitContribution would not include corresponding
CommitResponseData in the response_list. Wth this change worker is not
retaining/recommitting entities so processor should do that.

This CL includes bunch of random small cleanups I stumbled upon while reviewing
implementation.

BUG=740757
R=skym@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/729520
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#511258}
Change-Id: I753173b6638d802c2057472f7a612e1b8f876d4c
Reviewed-on: https://chromium-review.googlesource.com/753983
Cr-Commit-Position: refs/heads/master@{#516333}