GitLab

SpdyTrial_npn_http/npn_spdy: compare them for https traffic.
xxx_AlternateProtocol_spdy/http: compare them for http traffic.

BUG=46689
TEST=none
Review URL: http://codereview.chromium.org/3023022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53916 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, add some sanity check code in language_options_list.js
to filter bad language codes, just in case.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3051013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50484
TBR=timurrrr

Review URL: http://codereview.chromium.org/2868074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53914 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5169
TEST=unit tests

Review URL: http://codereview.chromium.org/2847080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53913 0039d316-1c4b-4281-b951-d872f2087c98

pulse the topmost parent that is visible (e.g. "Other Bookmarks").

BUG=http://crbug.com/42028

TEST=\
Repeat this test with the following themes:
1) None, 2) Maria Carey, 3) Ocean Pacific, 4) American Apparel:
.
New profile.  Click star to 'mark something.  See bookmark pulse in bar.  Cancel.
Do that again, but set parent to "Other Bookmarks" and hit OK.
New page; click star.  Default parent is Other Bookmarks; see Other Bookmarks folder pulse.
Add enough bookmarks on bar so something falls in overflow menu (chevron appears).
Go to one of them, then click star.  (You can't see chevron pulse.. it's hidden.)
Create a folder.  Add a bookmark to the folder.  Go that page.
Click on star; see folder pulse.


Review URL: http://codereview.chromium.org/2805099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53912 0039d316-1c4b-4281-b951-d872f2087c98

It's already enabled on windows by default. This of course applies only to the branded builds.

Also, make the path to imported pyauto binaries prettier by applying os.path.normpath

Change to chrome_switches.cc is to put a comment at the place where it belongs

Review URL: http://codereview.chromium.org/2873073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3018023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53910 0039d316-1c4b-4281-b951-d872f2087c98

This change is unit tests for <http://codereview.chromium.org/2805065/show>.

BUG=43011,40340
TEST=unit_test --gtest_filter=SpellCheckTest*
Review URL: http://codereview.chromium.org/2807035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53909 0039d316-1c4b-4281-b951-d872f2087c98

Revert 53903 - Revert 52613 - Revert 52608 - Add and alternative GetAppOutput() to process_util that takes a timeout.

[For those keeping track, this removes it again. The failure wasn't a flake. :(]

[Undoing the revert to see if the failure wasn't a flake.... Revert if the
original failure, below, occurs again.]

["base_unittests" didn't exit cleanly on "Chromium Linux x64" but was killed due
to timeout.]

Contributed by tessamac@chromium.org

TEST=none
BUG=47356

Review URL: http://codereview.chromium.org/2810014
Patch from Tessa MacDuff <tessamac@chromium.org>.

TBR=viettrungluu@chromium.org, tessamac@chromium.org
Review URL: http://codereview.chromium.org/3012004

TBR=viettrungluu@chromium.org, tessamac@chromium.org
Review URL: http://codereview.chromium.org/3036023

TBR=viettrungluu@chromium.org, tessamac@chromium.org
Review URL: http://codereview.chromium.org/3045018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53908 0039d316-1c4b-4281-b951-d872f2087c98

handled

The cause of the bug is that the document is not in printing mode when the page
size is checked.

BUG=50340
TEST=manual

Review URL: http://codereview.chromium.org/2868071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53907 0039d316-1c4b-4281-b951-d872f2087c98

Revert 52613 - Revert 52608 - Add and alternative GetAppOutput() to process_util that takes a timeout.

[Undoing the revert to see if the failure wasn't a flake.... Revert if the
original failure, below, occurs again.]

["base_unittests" didn't exit cleanly on "Chromium Linux x64" but was killed due
to timeout.]

Contributed by tessamac@chromium.org

TEST=none
BUG=47356

Review URL: http://codereview.chromium.org/2810014
Patch from Tessa MacDuff <tessamac@chromium.org>.

TBR=viettrungluu@chromium.org, tessamac@chromium.org
Review URL: http://codereview.chromium.org/3012004

TBR=viettrungluu@chromium.org, tessamac@chromium.org
Review URL: http://codereview.chromium.org/3036023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53903 0039d316-1c4b-4281-b951-d872f2087c98

BUG = 2821005
TEST = Manually navigate.

Review URL: http://codereview.chromium.org/3009005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53902 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53900 0039d316-1c4b-4281-b951-d872f2087c98

This should allow easier invocation of the chromoting plugin. The javascript
will parse window.location.href, so the plugin should be invocable via the
commandline for easier debugging.

Note, this isn't tested yet, but should it should be close to right.

BUG=50248
TEST=none

TBR: hclam@chromium.org, garykac@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53899 0039d316-1c4b-4281-b951-d872f2087c98

OpenGL ES 2.0 GLSL and for the new texImage2D

TBR=petersont@google.com

Review URL: http://codereview.chromium.org/3035012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53898 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53897 0039d316-1c4b-4281-b951-d872f2087c98

No code change.

BUG=49709,50457
TEST=none
TBR=hclam

Review URL: http://codereview.chromium.org/3077004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=35164

Review URL: http://codereview.chromium.org/2832087
Patch from Evan Martin <evan@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53895 0039d316-1c4b-4281-b951-d872f2087c98

Rearranged the declaration order for probability groups contained in 2 A/B
tests in a way that preserves the remaining probability space to the default
value, after the other groups receive an equal share of the sample space.

BUG=50451
r=jar


Review URL: http://codereview.chromium.org/3080004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3033035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50248
TEST=write javascript to manually setup connection.

Review URL: http://codereview.chromium.org/3064009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53892 0039d316-1c4b-4281-b951-d872f2087c98

The ChromeFrame persistent cookie test creates persistent cookies and reloads the current page via the gcf: protocol to load
it in chrome. The page when loaded in Chrome validates whether the cookies were set. This does not work correctly on IE8 in Vista
and windows 7 as the cookie stores are partitioned.

Fix is redirect the page to a target page which validates the cookies.

Review URL: http://codereview.chromium.org/3053018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53891 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/3076005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/2832086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3063011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=Reload should be left of home
Review URL: http://codereview.chromium.org/3056023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53887 0039d316-1c4b-4281-b951-d872f2087c98

Rename some resource files for clarity, or to fit better with upcoming theme resources.  Does not rename the identifiers yet, so as to minimize code change.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53886 0039d316-1c4b-4281-b951-d872f2087c98

BUG=48037
TEST=layout tests should still pass for media

Review URL: http://codereview.chromium.org/3005034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:50332
TEST=git try -b linux_chromeos_valgrind.

Review URL: http://codereview.chromium.org/2868070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53884 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50447
TEST=none

Review URL: http://codereview.chromium.org/3033034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53883 0039d316-1c4b-4281-b951-d872f2087c98

Added error code check in DoDataConnectComplete, which falls back
to PASV if the connection with EPSV has timed out, and stops the transaction
in case of any other error.

BUG=48285
TEST=navigate to ftp.apc.com, it should succeed and display a directory listing

Review URL: http://codereview.chromium.org/3033028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53882 0039d316-1c4b-4281-b951-d872f2087c98

This only includes boolean settings in the dialog.
I will fill in other stuff in later CLs.

BUG=chromium-os:4809
TEST=manually check on the netbook by uncommenting TODO lines.

Review URL: http://codereview.chromium.org/3067006
Patch from Takayoshi Kochi <kochi@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53881 0039d316-1c4b-4281-b951-d872f2087c98

Changes unique id matching that happens between browser and renderer.  Unique ids sent between processes are now combined in the case where credit card and address combination suggestions are supplied to popup.

BUG=50264
TEST=AutoFillManagerTest.FillCreditCardForm, AutoFillManagerTest.FillNonBillingFormSemicolon, AutoFillManagerTest.FillBillFormSemicolon

Review URL: http://codereview.chromium.org/3039031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50080
TEST=none

Review URL: http://codereview.chromium.org/3033033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53878 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2857018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53877 0039d316-1c4b-4281-b951-d872f2087c98

The comment for ReadRawData reads:
  // If returning true, data was read from the job.  buf will contain
  // the data, and bytes_read will receive the number of bytes read.
...
  // If returning false, an error occurred or an async IO is now pending.
  // If async IO is pending, the status of the request will be
  // URLRequestStatus::IO_PENDING, and buf must remain available until the
  // operation is completed.  See comments on URLRequest::Read for more info.

I interpret this to mean that an implementer should never set status to IO_PENDING and return true, but that's what the slow download job does:
...
    SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
    DCHECK(!is_done());
    return true;
...

Unfortunately this class is part of the Download UI tests which are already flaky/broken so it's not possible to verify that this change doesn't further break those tests. But the current implementation is clearly broken and should be fixed.

BUG=50399
TEST=ran ui_tests, verified no additional breakage

Review URL: http://codereview.chromium.org/3052016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53876 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3007014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53875 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53874 0039d316-1c4b-4281-b951-d872f2087c98

DOMUIThumbnailSource objects are deleted on the IO thread, while they are used
on the UI thread. The DataSource documentation says that they should not live
on the IO thread, but for almost all DataSources, the only reference held is
the one by ChromeURLDataManager, which lives on the IO thread. Since I had a racy
stack where the object was being used on the UI thread while its destructor was
running on the IO thread, forcing destruction on the UI thread should fix
the crash.

Pretty much everything but changing the templated base class of DataSource to
always DeleteOnUIThread is my usual cleanup.

BUG=34115
TEST=none

Review URL: http://codereview.chromium.org/3061009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53873 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a host of seeking, synchronization and layout test issues but does incur a CPU performance hit while seeking.  In the worst case a seek could take quite some time if the content was high resolution H.264 and we attempted to seek to right before a keyframe.

We'll see how people like the new behaviour and back this change out if needed.

BUG=48984
TEST=layout tests, media_unittests

Review URL: http://codereview.chromium.org/3032030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53872 0039d316-1c4b-4281-b951-d872f2087c98